Home » Mailing list archives » linux-kernel » 2008 » April » 22

Re: [PATCH 05/15] drivers/char: minor irq handler cleanups

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Benjamin Herrenschmidt
Subject: Re: [PATCH 05/15] drivers/char: minor irq handler cleanups
Date: Tuesday, April 22, 2008 - 3:46 am

On Tue, 2008-04-22 at 12:13 +0200, Rogier Wolff wrote:

But free_irq at interrupt time has great chances of crashing the machine
or currupting data structures in subtle ways. You should -not- do that.

Either let the kernel handle the runaway interrupt, or eventually if you
want to be brutal, call disable_irq_nosync yourself, but not free_irq.


It would be if you used something like disable_irq_nosync. Not free_irq.
The later is just bogus.


Well, if you know how to trigger the bug, it would be useful to verify
that the kernel generic code properly detects and masks the runaway
interrupt. If that works, then remove your code completely. If not, it
would be useful to figure out why :-) But either way, just replace it
with disable_irq_nosync.

Cheers,
Ben.


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 01/15] ARM minor irq handler cleanups, Jeff Garzik, (Fri Apr 18, 4:22 pm)
[PATCH 02/15] [SPARC] minor irq handler cleanups, Jeff Garzik, (Fri Apr 18, 4:22 pm)
[PATCH 03/15] [BLACKFIN] minor irq handler cleanups, Jeff Garzik, (Fri Apr 18, 4:22 pm)
[PATCH 04/15] [PPC] minor irq handler cleanups, Jeff Garzik, (Fri Apr 18, 4:22 pm)
[PATCH 05/15] drivers/char: minor irq handler cleanups, Jeff Garzik, (Fri Apr 18, 4:22 pm)
[PATCH 06/15] [SCSI] minor irq handler cleanups, Jeff Garzik, (Fri Apr 18, 4:22 pm)
[PATCH 07/15] [SCSI] aha1542: minor irq handler cleanups, Jeff Garzik, (Fri Apr 18, 4:22 pm)
[PATCH 08/15] [ISDN] minor irq handler cleanups, Jeff Garzik, (Fri Apr 18, 4:22 pm)
[PATCH 09/15] [AVR32] remove unused 'irq' argument from lo ..., Jeff Garzik, (Fri Apr 18, 4:22 pm)
[PATCH 10/15] [IA64] minor irq handler cleanups, Jeff Garzik, (Fri Apr 18, 4:22 pm)
[PATCH 11/15] [RTC] minor irq handler cleanups, Jeff Garzik, (Fri Apr 18, 4:23 pm)
[PATCH 12/15] [MIPS] pmc-sierra/msp71xx/msp_hwbutton.c: mi ..., Jeff Garzik, (Fri Apr 18, 4:23 pm)
[PATCH 13/15] [X86] standard vm86 irq handler, Jeff Garzik, (Fri Apr 18, 4:23 pm)
[PATCH 14/15] Canonicalize several irq handlers., Jeff Garzik, (Fri Apr 18, 4:23 pm)
[PATCH 15/15] [INPUT, PCMCIA] avoid use of 'irq' function arg, Jeff Garzik, (Fri Apr 18, 4:23 pm)
Re: [PATCH 01/15] ARM minor irq handler cleanups, Lennert Buytenhek, (Fri Apr 18, 4:29 pm)
Re: [PATCH 02/15] [SPARC] minor irq handler cleanups, David Miller, (Fri Apr 18, 4:33 pm)
Re: [PATCH 01/15] ARM minor irq handler cleanups, Andrew Morton, (Fri Apr 18, 4:44 pm)
Re: [PATCH 01/15] ARM minor irq handler cleanups, Jeff Garzik, (Fri Apr 18, 5:21 pm)
Re: [PATCH 01/15] ARM minor irq handler cleanups, Jeff Garzik, (Fri Apr 18, 5:25 pm)
Re: [PATCH 01/15] ARM minor irq handler cleanups, Andrew Morton, (Fri Apr 18, 6:17 pm)
Re: [PATCH 05/15] drivers/char: minor irq handler cleanups, Rogier Wolff, (Fri Apr 18, 11:00 pm)
Re: [PATCH 01/15] ARM minor irq handler cleanups, Russell King, (Sat Apr 19, 1:17 am)
Re: [PATCH 01/15] ARM minor irq handler cleanups, Jeff Garzik, (Sat Apr 19, 1:28 am)
Re: [PATCH 04/15] [PPC] minor irq handler cleanups, Kumar Gala, (Sat Apr 19, 7:57 am)
Re: [PATCH 01/15] ARM minor irq handler cleanups, Lennert Buytenhek, (Sat Apr 19, 9:14 am)
Re: [PATCH 05/15] drivers/char: minor irq handler cleanups, Alan Cox, (Sat Apr 19, 9:16 am)
Re: [PATCH 01/15] ARM minor irq handler cleanups, Jeff Garzik, (Sun Apr 20, 3:17 pm)
Re: [PATCH 01/15] ARM minor irq handler cleanups, Russell King, (Sun Apr 20, 3:40 pm)
Re: [PATCH 01/15] ARM minor irq handler cleanups, Jeff Garzik, (Sun Apr 20, 3:49 pm)
Re: [PATCH 05/15] drivers/char: minor irq handler cleanups, Jeff Garzik, (Sun Apr 20, 6:38 pm)
Re: [PATCH 13/15] [X86] standard vm86 irq handler, Ingo Molnar, (Mon Apr 21, 6:52 am)
Re: [PATCH 03/15] [BLACKFIN] minor irq handler cleanups, Bryan Wu, (Mon Apr 21, 8:27 pm)
Re: [PATCH 05/15] drivers/char: minor irq handler cleanups, Benjamin Herrenschmidt, (Tue Apr 22, 1:05 am)
Re: [PATCH 05/15] drivers/char: minor irq handler cleanups, Rogier Wolff, (Tue Apr 22, 3:13 am)
Re: [PATCH 05/15] drivers/char: minor irq handler cleanups, Benjamin Herrenschmidt, (Tue Apr 22, 3:46 am)
Re: [PATCH 12/15] [MIPS] pmc-sierra/msp71xx/msp_hwbutton.c ..., Ralf Baechle, (Mon Apr 28, 1:53 pm)