login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
April
»
22
Re: [PATCH 03/15] [BLACKFIN] minor irq handler cleanups
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Bryan Wu
Subject:
Re: [PATCH 03/15] [BLACKFIN] minor irq handler cleanups
Date: Monday, April 21, 2008 - 8:27 pm
On Sat, Apr 19, 2008 at 7:22 AM, Jeff Garzik <jeff@garzik.org> wrote:
quoted text
> - time_sched_init() should use standard irq_handler_t > > - sys_timer0_int_handler() should not take 'regs' third argument > > - remove pointless cast from void* > > This change's main purpose is to prepare for the patchset in > jgarzik/misc-2.6.git#irq-remove, that explores removal of the > never-used 'irq' argument in each interrupt handler. > > Signed-off-by: Jeff Garzik <jgarzik@redhat.com> > --- > arch/blackfin/kernel/time.c | 5 ++--- > arch/blackfin/oprofile/timer_int.c | 5 ++--- > 2 files changed, 4 insertions(+), 6 deletions(-) > > diff --git a/arch/blackfin/kernel/time.c b/arch/blackfin/kernel/time.c > index 9bdc8f9..715b394 100644 > --- a/arch/blackfin/kernel/time.c > +++ b/arch/blackfin/kernel/time.c > @@ -39,8 +39,7 @@ > /* This is an NTP setting */ > #define TICK_SIZE (tick_nsec / 1000) > > -static void time_sched_init(irqreturn_t(*timer_routine) > - (int, void *)); > +static void time_sched_init(irq_handler_t timer_routine); > static unsigned long gettimeoffset(void); > > static struct irqaction bfin_timer_irq = { > @@ -64,7 +63,7 @@ static struct irqaction bfin_timer_irq = { > #define TIME_SCALE 1 > > static void > -time_sched_init(irqreturn_t(*timer_routine) (int, void *)) > +time_sched_init(irq_handler_t timer_routine) > { > u32 tcount; > > diff --git a/arch/blackfin/oprofile/timer_int.c b/arch/blackfin/oprofile/timer_int.c > index 6c6f860..e2c825a 100644 > --- a/arch/blackfin/oprofile/timer_int.c > +++ b/arch/blackfin/oprofile/timer_int.c > @@ -40,10 +40,9 @@ static void disable_sys_timer0() > { > } > > -static irqreturn_t sys_timer0_int_handler(int irq, void *dev_id, > - struct pt_regs *regs) > +static irqreturn_t sys_timer0_int_handler(int irq, void *dev_id) > { > - oprofile_add_sample(regs, 0); > + oprofile_add_sample(get_irq_regs(), 0); > return IRQ_HANDLED; > } >
Sorry for the delay, it is pretty good for Blackfin. Acked-by: Bryan Wu <cooloney@kernel.org> -Bryan --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH 01/15] ARM minor irq handler cleanups
, Jeff Garzik
, (Fri Apr 18, 4:22 pm)
[PATCH 02/15] [SPARC] minor irq handler cleanups
, Jeff Garzik
, (Fri Apr 18, 4:22 pm)
[PATCH 03/15] [BLACKFIN] minor irq handler cleanups
, Jeff Garzik
, (Fri Apr 18, 4:22 pm)
[PATCH 04/15] [PPC] minor irq handler cleanups
, Jeff Garzik
, (Fri Apr 18, 4:22 pm)
[PATCH 05/15] drivers/char: minor irq handler cleanups
, Jeff Garzik
, (Fri Apr 18, 4:22 pm)
[PATCH 06/15] [SCSI] minor irq handler cleanups
, Jeff Garzik
, (Fri Apr 18, 4:22 pm)
[PATCH 07/15] [SCSI] aha1542: minor irq handler cleanups
, Jeff Garzik
, (Fri Apr 18, 4:22 pm)
[PATCH 08/15] [ISDN] minor irq handler cleanups
, Jeff Garzik
, (Fri Apr 18, 4:22 pm)
[PATCH 09/15] [AVR32] remove unused 'irq' argument from lo ...
, Jeff Garzik
, (Fri Apr 18, 4:22 pm)
[PATCH 10/15] [IA64] minor irq handler cleanups
, Jeff Garzik
, (Fri Apr 18, 4:22 pm)
[PATCH 11/15] [RTC] minor irq handler cleanups
, Jeff Garzik
, (Fri Apr 18, 4:23 pm)
[PATCH 12/15] [MIPS] pmc-sierra/msp71xx/msp_hwbutton.c: mi ...
, Jeff Garzik
, (Fri Apr 18, 4:23 pm)
[PATCH 13/15] [X86] standard vm86 irq handler
, Jeff Garzik
, (Fri Apr 18, 4:23 pm)
[PATCH 14/15] Canonicalize several irq handlers.
, Jeff Garzik
, (Fri Apr 18, 4:23 pm)
[PATCH 15/15] [INPUT, PCMCIA] avoid use of 'irq' function arg
, Jeff Garzik
, (Fri Apr 18, 4:23 pm)
Re: [PATCH 01/15] ARM minor irq handler cleanups
, Lennert Buytenhek
, (Fri Apr 18, 4:29 pm)
Re: [PATCH 02/15] [SPARC] minor irq handler cleanups
, David Miller
, (Fri Apr 18, 4:33 pm)
Re: [PATCH 01/15] ARM minor irq handler cleanups
, Andrew Morton
, (Fri Apr 18, 4:44 pm)
Re: [PATCH 01/15] ARM minor irq handler cleanups
, Jeff Garzik
, (Fri Apr 18, 5:21 pm)
Re: [PATCH 01/15] ARM minor irq handler cleanups
, Jeff Garzik
, (Fri Apr 18, 5:25 pm)
Re: [PATCH 01/15] ARM minor irq handler cleanups
, Andrew Morton
, (Fri Apr 18, 6:17 pm)
Re: [PATCH 05/15] drivers/char: minor irq handler cleanups
, Rogier Wolff
, (Fri Apr 18, 11:00 pm)
Re: [PATCH 01/15] ARM minor irq handler cleanups
, Russell King
, (Sat Apr 19, 1:17 am)
Re: [PATCH 01/15] ARM minor irq handler cleanups
, Jeff Garzik
, (Sat Apr 19, 1:28 am)
Re: [PATCH 04/15] [PPC] minor irq handler cleanups
, Kumar Gala
, (Sat Apr 19, 7:57 am)
Re: [PATCH 01/15] ARM minor irq handler cleanups
, Lennert Buytenhek
, (Sat Apr 19, 9:14 am)
Re: [PATCH 05/15] drivers/char: minor irq handler cleanups
, Alan Cox
, (Sat Apr 19, 9:16 am)
Re: [PATCH 01/15] ARM minor irq handler cleanups
, Jeff Garzik
, (Sun Apr 20, 3:17 pm)
Re: [PATCH 01/15] ARM minor irq handler cleanups
, Russell King
, (Sun Apr 20, 3:40 pm)
Re: [PATCH 01/15] ARM minor irq handler cleanups
, Jeff Garzik
, (Sun Apr 20, 3:49 pm)
Re: [PATCH 05/15] drivers/char: minor irq handler cleanups
, Jeff Garzik
, (Sun Apr 20, 6:38 pm)
Re: [PATCH 13/15] [X86] standard vm86 irq handler
, Ingo Molnar
, (Mon Apr 21, 6:52 am)
Re: [PATCH 03/15] [BLACKFIN] minor irq handler cleanups
, Bryan Wu
, (Mon Apr 21, 8:27 pm)
Re: [PATCH 05/15] drivers/char: minor irq handler cleanups
, Benjamin Herrenschmidt
, (Tue Apr 22, 1:05 am)
Re: [PATCH 05/15] drivers/char: minor irq handler cleanups
, Rogier Wolff
, (Tue Apr 22, 3:13 am)
Re: [PATCH 05/15] drivers/char: minor irq handler cleanups
, Benjamin Herrenschmidt
, (Tue Apr 22, 3:46 am)
Re: [PATCH 12/15] [MIPS] pmc-sierra/msp71xx/msp_hwbutton.c ...
, Ralf Baechle
, (Mon Apr 28, 1:53 pm)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Rusty Russell
Re: 2.6.22-rc3-mm1
Gautham R Shenoy
[PATCH 1/8] Enhance process freezer interface for usage beyond software suspend
Jeffrey V. Merkey
Re: Versioning file system
James Bottomley
Re: [PATCH -mm 1/2] scsi: remove dma_is_consistent usage in 53c700
David Miller
Re: NO_HZ: timer interrupt stuck
git
:
Oliver Kullmann
Re: how to move with history?
Junio C Hamano
Re: [PATCH 2/3] git-add--interactive: remove hunk coalescing
Miles Bader
Re: way to automatically add untracked files?
Harvey Harrison
Re: [SoC RFC] libsvn-fs-git: A git backend for the subversion filesystem
Alex Riesen
Re: git exclude patterns for directory
git-commits-head
:
Linux Kernel Mailing List
V4L/DVB: tm6000: add special usb request to quit i2c tuner transfer
Linux Kernel Mailing List
OMAP: DSS2: SDI driver
Linux Kernel Mailing List
PCI: introduce pci_pcie_cap()
Linux Kernel Mailing List
netfilter: nf_conntrack_sip: add T.38 FAX support
Linux Kernel Mailing List
drivers/acpi: use kasprintf
linux-netdev
:
Timo Teräs
ip xfrm policy semantics
David Miller
Re: [2.6.30-rc3] powerpc: compilation error of mace module
Patrick McHardy
Re: [rfc 02/13] [RFC 02/13] netfilter: nf_conntrack_sip: Add callid parser
webmaster Maintenance
&#32852;&#31995;&#31995;&#32479;&#31649;&#29702;&#21592;
Krzysztof Oledzki
Re: Error: an inet prefix is expected rather than "0/0".
openbsd-misc
:
Ted Bullock
Re: Proliant DL380 G3 cannot get on network
Úlfar M. E. Johnson
installing openbsd in xen
Eric Furman
Re: Defending OpenBSD Performance
Damien Miller
Re: Patching a SSH 'Weakness'
frantisek holop
Re: mount ffs as msdos, system hangs
Colocation donated by:
Syndicate