On Mon, 21 Apr 2008, Paul E. McKenney wrote:No, not even then. We *always* unhash the dentries before freeing them, but we very consciously use "hlist_del_rcu()" on them, not "hlist_del_init()". That, in turn, will mean that the "pprev" pointer will still be set, so the "hlist_unhashed()" thing will *not* trigger. IOW, when we do that direct-free with: if (hlist_unhashed(&dentry->d_hash)) __d_free(dentry); the "hlist_unhashed()" will literally guarantee that i has *never* been on a hash-list at all! (If you want to test whether it is currently unhashed or not, you actually have to use "d_unhashed()" on the dentry under the dentry lock, which tests the DCACHE_UNHASHED bit). Of course, there could be some bug in there, but the thing is, none of this has even changed in a long time, certainly not since 2.6.25. Which is why I think the dcache code is all fine, and the bug comes from somewhere else corrupting the data structures. Linus --
| Peter Zijlstra | [PATCH 6/6] sched: disabled rt-bandwidth by default |
| Tejun Heo | [PATCHSET] FUSE: extend FUSE to support more operations |
| Avi Kivity | [PATCH 041/104] KVM: Don't assign vcpu->cr3 if it's invalid: check first, set last |
| Vegard Nossum | [RFC][PATCH] bitfields API |
git: | |
| Rogan Dawes | Re: kernel.org mirroring (Re: [GIT PULL] MMC update) |
| David Kastrup | Terminology question about remote branches. |
| Tony Stubbs | git svn rebase - could not detach HEAD |
| Nicolas Pitre | Re: Understanding version 4 packs |
| James Hartley | scp batch mode? |
| Firas Kraiem | Possible mug in mini_sendmail-chroot. |
| Gregory Edigarov | Question on interface enumeration |
| bsd_news | LC_COLLATE and PostgreSQL |
| Jeff Garzik | Re: [PATCH] drivers/net: remove network drivers' last few uses of IRQF_SAMPLE_RANDOM |
| Jay Vosburgh | [PATCH 6/9] net/bonding: Handlle wrong assumptions that slave is always an Etherne... |
| Radu Rendec | Re: Endianness problem with u32 classifier hash masks |
| Robert Olsson | [PATCH] pktgen multiqueue etc |
