Re: [PATCH 1/2] OLPC: Add support for calling into Open Firmware

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: H. Peter Anvin
Date: Monday, April 21, 2008 - 6:09 am

Okay, stepping back a few steps, it's pretty clear that most of my 
objections aren't really an issue for Geode/OLPC; however, I *really* 
don't want others to pick it up as being "the" Open Firmware interface.

Within those constraints it makes sense to set up the PDEs in 
swapper_pg_dir and let them propagate using the normal mechanisms.

** This is assuming that your OF interface does not rely on a 1:1 
mapping of low memory being present at the time it makes a call.  If it 
*does*, then a separate page directory needs to be maintained for the OF 
class. **


Thus, I'm willing to accept this with these changes:

- Please name things specific to the interface (as opposed to Open 
Firmware in general, like the device tree) olpc_ofw or olpcfw, to denote 
that this is an OLPC-specific interface.  Thus, 
CONFIG_OLPC_OPEN_FIRMWARE or something along those lines.

- Make it explicit in Kconfig that OLPC_OPEN_FIRMWARE conflicts with 
X86_PAE, 64BIT, or X86_PAT.

- Change VMALLOC_END in include/asm-x86/pgtable_32.h so the kernel will 
know to avoid this virtual memory range.

- Add a memory region to arch/x86/mm/dump_tabletables.c.

	-hpa
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.25-mm1, Andrew Morton, (Fri Apr 18, 1:47 am)
[PATCH] 2.6.25-mm1 - Build Failure with PWRficient onchip ..., Kamalesh Babulal, (Fri Apr 18, 4:26 am)
StackProtector Oopses - Re: 2.6.25-mm1, Reuben Farrelly, (Fri Apr 18, 6:02 am)
Re: StackProtector Oopses - Re: 2.6.25-mm1, Ingo Molnar, (Fri Apr 18, 6:36 am)
Re: StackProtector Oopses - Re: 2.6.25-mm1, Arjan van de Ven, (Fri Apr 18, 6:51 am)
Re: StackProtector Oopses - Re: 2.6.25-mm1, Reuben Farrelly, (Fri Apr 18, 7:41 am)
Re: StackProtector Oopses - Re: 2.6.25-mm1, Reuben Farrelly, (Fri Apr 18, 7:49 am)
Re: 2.6.25-mm1 (build error: driver core), Randy Dunlap, (Fri Apr 18, 9:40 am)
Re: 2.6.25-mm1 (build error: trace selftest), Randy Dunlap, (Fri Apr 18, 9:45 am)
Re: 2.6.25-mm1 (build error: driver core), Greg KH, (Fri Apr 18, 9:56 am)
Re: 2.6.25-mm1 (build error: driver core), Dan Williams, (Fri Apr 18, 11:38 am)
Re: 2.6.25-mm1, Valdis.Kletnieks, (Fri Apr 18, 1:14 pm)
2.6.25-mm1: orphaned files after build, Alexey Dobriyan, (Fri Apr 18, 4:09 pm)
Re: 2.6.25-mm1, Joseph Fannin, (Fri Apr 18, 7:13 pm)
Re: 2.6.25-mm1, Joseph Fannin, (Fri Apr 18, 7:25 pm)
Re: 2.6.25-mm1, Andrew Morton, (Fri Apr 18, 8:02 pm)
Re: 2.6.25-mm1, Andrew Morton, (Fri Apr 18, 8:08 pm)
Re: 2.6.25-mm1, Joseph Fannin, (Fri Apr 18, 8:10 pm)
Re: 2.6.25-mm1, Andrew Morton, (Fri Apr 18, 8:29 pm)
Re: 2.6.25-mm1, Dmitry Torokhov, (Fri Apr 18, 9:14 pm)
Re: 2.6.25-mm1, Andrew Morton, (Fri Apr 18, 9:29 pm)
Re: 2.6.25-mm1, Joseph Fannin, (Fri Apr 18, 11:33 pm)
Re: 2.6.25-mm1, Andres Salomon, (Sat Apr 19, 6:25 am)
Re: 2.6.25-mm1, Andrew Morton, (Sat Apr 19, 10:38 am)
[PATCH 1/2] OLPC: Add support for calling into Open Firmware, Andres Salomon, (Sat Apr 19, 10:39 am)
[PATCH 2/2] OLPC: drop pre-OpenFirmware workarounds, Andres Salomon, (Sat Apr 19, 10:39 am)
Re: 2.6.25-mm1, Andres Salomon, (Sat Apr 19, 10:50 am)
Re: 2.6.25-mm1, Arjan van de Ven, (Sat Apr 19, 11:21 am)
internal compiler error: SIGSEGV [Was: 2.6.25-mm1], Jiri Slaby, (Sun Apr 20, 4:29 am)
[Was: 2.6.25-mm1], Jiri Slaby, (Mon Apr 21, 1:31 am)
Re: [Was: 2.6.25-mm1], Al Viro, (Mon Apr 21, 2:06 am)
fault in __d_lookup [Was: 2.6.25-mm1], Jiri Slaby, (Mon Apr 21, 2:37 am)
Re: fault in __d_lookup [Was: 2.6.25-mm1], Al Viro, (Mon Apr 21, 2:45 am)
Re: fault in __d_lookup [Was: 2.6.25-mm1], Jiri Slaby, (Mon Apr 21, 2:59 am)
Re: 2.6.25-mm1, Takashi Iwai, (Mon Apr 21, 4:07 am)
Re: [PATCH 1/2] OLPC: Add support for calling into Open Fi ..., H. Peter Anvin, (Mon Apr 21, 6:09 am)
Re: fault in __d_lookup [Was: 2.6.25-mm1], Rafael J. Wysocki, (Mon Apr 21, 6:42 am)
Re: 2.6.25-mm1, Takashi Iwai, (Mon Apr 21, 7:06 am)
Re: 2.6.25-mm1, Jordan Crouse, (Mon Apr 21, 7:56 am)
Re: OLPC: Add support for calling into Open Firmware, H. Peter Anvin, (Mon Apr 21, 7:58 am)
Re: 2.6.25-mm1, Andres Salomon, (Mon Apr 21, 8:05 am)
Re: OLPC: Add support for calling into Open Firmware, Jordan Crouse, (Mon Apr 21, 8:05 am)
Re: StackProtector Oopses - Re: 2.6.25-mm1, Ingo Molnar, (Mon Apr 21, 8:06 am)
Re: 2.6.25-mm1, Jordan Crouse, (Mon Apr 21, 8:12 am)
Re: fault in __d_lookup [Was: 2.6.25-mm1], Matthew Wilcox, (Mon Apr 21, 10:23 am)
Re: 2.6.25-mm1 (snd-pcsp causes driver conflict), Stas Sergeev, (Mon Apr 21, 10:44 am)
Re: 2.6.25-mm1 (snd-pcsp doesn't like DEBUG_PAGEALLOC), Stas Sergeev, (Mon Apr 21, 10:55 am)
Re: 2.6.25-mm1, Stas Sergeev, (Mon Apr 21, 12:45 pm)
Re: OLPC: only check for OFW signature on VSA-less Geodes, Jordan Crouse, (Mon Apr 21, 2:17 pm)
Re: StackProtector Oopses - Re: 2.6.25-mm1, Arjan van de Ven, (Mon Apr 21, 6:48 pm)
Re: StackProtector Oopses - Re: 2.6.25-mm1, Valdis.Kletnieks, (Mon Apr 21, 7:04 pm)
Re: StackProtector Oopses - Re: 2.6.25-mm1, Ingo Molnar, (Tue Apr 22, 1:34 am)
Re: 2.6.25-mm1 (snd-pcsp causes driver conflict), Takashi Iwai, (Tue Apr 22, 3:09 am)
Re: 2.6.25-mm1 (snd-pcsp doesn't like DEBUG_PAGEALLOC), Takashi Iwai, (Tue Apr 22, 3:13 am)
Re: 2.6.25-mm1 (snd-pcsp doesn't like DEBUG_PAGEALLOC), Dmitry Torokhov, (Tue Apr 22, 7:01 am)
Re: StackProtector Oopses - Re: 2.6.25-mm1, Arjan van de Ven, (Tue Apr 22, 7:29 am)
Re: 2.6.25-mm1 (snd-pcsp doesn't like DEBUG_PAGEALLOC), Stas Sergeev, (Tue Apr 22, 9:42 am)
Re: 2.6.25-mm1 (snd-pcsp causes driver conflict), Stas Sergeev, (Tue Apr 22, 10:54 am)
Re: 2.6.25-mm1 (snd-pcsp doesn't like DEBUG_PAGEALLOC), Stas Sergeev, (Tue Apr 22, 11:31 am)
Re: 2.6.25-mm1 (snd-pcsp doesn't like DEBUG_PAGEALLOC), Takashi Iwai, (Wed Apr 23, 1:49 am)
Re: 2.6.25-mm1 (snd-pcsp causes driver conflict), Takashi Iwai, (Wed Apr 23, 1:55 am)
Re: 2.6.25-mm1 (snd-pcsp causes driver conflict), Takashi Iwai, (Wed Apr 23, 7:14 am)
Re: 2.6.25-mm1 (snd-pcsp doesn't like DEBUG_PAGEALLOC), Takashi Iwai, (Wed Apr 23, 7:18 am)
Re: 2.6.25-mm1 (snd-pcsp doesn't like DEBUG_PAGEALLOC), Stas Sergeev, (Wed Apr 23, 1:02 pm)
Re: 2.6.25-mm1 (snd-pcsp doesn't like DEBUG_PAGEALLOC), Takashi Iwai, (Thu Apr 24, 2:40 am)
Re: 2.6.25-mm1 (snd-pcsp doesn't like DEBUG_PAGEALLOC), Stas Sergeev, (Thu Apr 24, 8:51 pm)
Re: 2.6.25-mm1 (snd-pcsp doesn't like DEBUG_PAGEALLOC), Takashi Iwai, (Thu Apr 24, 11:28 pm)
Re: 2.6.25-mm1 (snd-pcsp doesn't like DEBUG_PAGEALLOC), Stas Sergeev, (Fri Apr 25, 9:45 am)
Re: 2.6.25-mm1 (snd-pcsp doesn't like DEBUG_PAGEALLOC), Takashi Iwai, (Fri Apr 25, 9:51 am)
Re: 2.6.25-mm1 (snd-pcsp doesn't like DEBUG_PAGEALLOC), Stas Sergeev, (Fri Apr 25, 10:25 am)
Re: 2.6.25-mm1 (snd-pcsp doesn't like DEBUG_PAGEALLOC), Dmitry Torokhov, (Fri Apr 25, 11:09 am)
Re: 2.6.25-mm1 (snd-pcsp doesn't like DEBUG_PAGEALLOC), Stas Sergeev, (Fri Apr 25, 11:31 am)
Re: 2.6.25-mm1 (snd-pcsp doesn't like DEBUG_PAGEALLOC), Dmitry Torokhov, (Fri Apr 25, 11:37 am)
Re: 2.6.25-mm1 (snd-pcsp doesn't like DEBUG_PAGEALLOC), Takashi Iwai, (Fri May 2, 9:44 am)
Re: 2.6.25-mm1 (snd-pcsp doesn't like DEBUG_PAGEALLOC), Stas Sergeev, (Fri May 2, 9:57 am)
Re: 2.6.25-mm1 (snd-pcsp doesn't like DEBUG_PAGEALLOC), Takashi Iwai, (Tue May 6, 3:20 am)
Re: 2.6.25-mm1 (snd-pcsp doesn't like DEBUG_PAGEALLOC), Stas Sergeev, (Tue May 6, 9:51 am)