login
Header Space

 
 

Re: [PATCH 33/36] IB: convert struct class_device to struct device

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Greg Kroah-Hartman <gregkh@...>
Cc: <linux-kernel@...>, Tony Jones <tonyj@...>, Kay Sievers <kay.sievers@...>, Roland Dreier <rolandd@...>, Sean Hefty <sean.hefty@...>, Hal Rosenstock <hal.rosenstock@...>
Date: Sunday, April 20, 2008 - 1:23 pm

Looks like something slipped into the tree as part of my recent
merge... please apply the following patch first if it's not too late, so
this doesn't break the ipath driver build.

Otherwise we can merge this later I guess...
---
IB/ipath: Remove reference to dev->class_dev

Commit 124b4dcb ("IB/ipath: add calls to new 7220 code and enable in
build") inadvertently added core to set dev->class_dev.dev back into
ib_ipath.  This is completely redundant since commit 1912ffbb ("IB: Set
class_dev->dev in core for nice device symlink"), which removed
class_dev setting from low-level drivers, and also will break the build
when class_dev is removed completely from struct ib_device.

Signed-off-by: Roland Dreier <rolandd@cisco.com>
---
 drivers/infiniband/hw/ipath/ipath_verbs.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/infiniband/hw/ipath/ipath_verbs.c b/drivers/infiniband/hw/ipath/ipath_verbs.c
index 5734520..8af3b46 100644
--- a/drivers/infiniband/hw/ipath/ipath_verbs.c
+++ b/drivers/infiniband/hw/ipath/ipath_verbs.c
@@ -2067,7 +2067,6 @@ int ipath_register_ib_device(struct ipath_devdata *dd)
 	dev->phys_port_cnt = 1;
 	dev->num_comp_vectors = 1;
 	dev->dma_device = &dd->pcidev->dev;
-	dev->class_dev.dev = dev->dma_device;
 	dev->query_device = ipath_query_device;
 	dev->modify_device = ipath_modify_device;
 	dev->query_port = ipath_query_port;
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 36/36] SCSI: convert struct class_device to struct de..., Greg Kroah-Hartman, (Sun Apr 20, 6:46 am)
[PATCH 35/36] DRM: remove unused dev_class, Greg Kroah-Hartman, (Sun Apr 20, 6:46 am)
[PATCH 34/36] IB: rename "dev" to "srp_dev" in srp_host stru..., Greg Kroah-Hartman, (Sun Apr 20, 6:46 am)
[PATCH 33/36] IB: convert struct class_device to struct device, Greg Kroah-Hartman, (Sun Apr 20, 6:46 am)
Re: [PATCH 33/36] IB: convert struct class_device to struct ..., Roland Dreier, (Sun Apr 20, 1:23 pm)
[PATCH 32/36] memstick: convert struct class_device to struc..., Greg Kroah-Hartman, (Sun Apr 20, 6:46 am)
[PATCH 31/36] driver core: replace remaining __FUNCTION__ oc..., Greg Kroah-Hartman, (Sun Apr 20, 6:46 am)
[PATCH 30/36] sysfs: refill attribute buffer when reading fr..., Greg Kroah-Hartman, (Sun Apr 20, 6:46 am)
[PATCH 28/36] Firmware: add iSCSI iBFT Support, Greg Kroah-Hartman, (Sun Apr 20, 6:45 am)
[PATCH 29/36] PM: Remove destroy_suspended_device(), Greg Kroah-Hartman, (Sun Apr 20, 6:45 am)
[PATCH 27/36] PM: Remove legacy PM (fix), Greg Kroah-Hartman, (Sun Apr 20, 6:45 am)
[PATCH 26/36] Kobject: Replace list_for_each() with list_for..., Greg Kroah-Hartman, (Sun Apr 20, 6:45 am)
[PATCH 25/36] SYSFS: Explicitly include required header file..., Greg Kroah-Hartman, (Sun Apr 20, 6:45 am)
[PATCH 24/36] Driver core: make device_is_registered() work ..., Greg Kroah-Hartman, (Sun Apr 20, 6:45 am)
[PATCH 23/36] PM: Convert wakeup flag accessors to inline fu..., Greg Kroah-Hartman, (Sun Apr 20, 6:45 am)
[PATCH 22/36] PM: Make wakeup flags available whenever CONFI..., Greg Kroah-Hartman, (Sun Apr 20, 6:45 am)
[PATCH 21/36] PM: Fix misuse of wakeup flag accessors in ser..., Greg Kroah-Hartman, (Sun Apr 20, 6:45 am)
[PATCH 20/36] Driver core: Call device_pm_add() after bus_ad..., Greg Kroah-Hartman, (Sun Apr 20, 6:45 am)
[PATCH 19/36] PM: Handle device registrations during suspend..., Greg Kroah-Hartman, (Sun Apr 20, 6:45 am)
[PATCH 18/36] block: send disk "change" event for rescan_par..., Greg Kroah-Hartman, (Sun Apr 20, 6:45 am)
[PATCH 17/36] sysdev: detect multiple driver registrations, Greg Kroah-Hartman, (Sun Apr 20, 6:45 am)
[PATCH 16/36] driver core: cpu: fix section mismatch in cpu...., Greg Kroah-Hartman, (Sun Apr 20, 6:45 am)
[PATCH 15/36] power_state: remove it from driver core, Greg Kroah-Hartman, (Sun Apr 20, 6:45 am)
[PATCH 14/36] PNP: add all PNP card device id's as individua..., Greg Kroah-Hartman, (Sun Apr 20, 6:45 am)
[PATCH 13/36] firmware: clean up samples for coding style is..., Greg Kroah-Hartman, (Sun Apr 20, 6:45 am)
[PATCH 12/36] firmware: move firmware_class from Documentati..., Greg Kroah-Hartman, (Sun Apr 20, 6:45 am)
[PATCH 11/36] sysfs: small header file cleanup for SYSFS=n, Greg Kroah-Hartman, (Sun Apr 20, 6:45 am)
[PATCH 10/36] driver core: Convert debug functions declared ..., Greg Kroah-Hartman, (Sun Apr 20, 6:45 am)
[PATCH 09/36] driver core: register_memory/unregister_memory..., Greg Kroah-Hartman, (Sun Apr 20, 6:45 am)
[PATCH 08/36] driver core: memory: semaphore to mutex, Greg Kroah-Hartman, (Sun Apr 20, 6:45 am)
[PATCH 07/36] UIO: hold a reference to the device's owner wh..., Greg Kroah-Hartman, (Sun Apr 20, 6:45 am)
[PATCH 06/36] UIO: Implement a UIO interface for the SMX Cry..., Greg Kroah-Hartman, (Sun Apr 20, 6:45 am)
[PATCH 05/36] UIO: Remove needless PCI_DEVICE_ID definition ..., Greg Kroah-Hartman, (Sun Apr 20, 6:45 am)
[PATCH 04/36] UIO: arch/arm/Kconfig: Make UIO available on A..., Greg Kroah-Hartman, (Sun Apr 20, 6:45 am)
[PATCH 03/36] uio: mark pci_device_id hilscher_pci_ids[] __d..., Greg Kroah-Hartman, (Sun Apr 20, 6:45 am)
[PATCH 02/36] uio: Kconfig improvements, Greg Kroah-Hartman, (Sun Apr 20, 6:45 am)
[PATCH 01/36] kobject: catch kobjects that are not initialized, Greg Kroah-Hartman, (Sun Apr 20, 6:45 am)
speck-geostationary