"Andi Kleen" <andi@firstfloor.org> writes:
quoted text
> Are you talking about x86?

ARM (TI-OMAP)

quoted text
> On older x86 this effect should have been handled by the C state
> algorithm taking the bus master activity register into account (which
> should also trigger for interrupts)

Well, today we still do use the bus master hook for ARM.  In my terms it is an 'OCP bus initiator' not master.  But it is logically the same.

If some device is actively pushing data on the bus, this will limit a C-State's choice.  In our hardware if you are using the 'hw-auto' features you won't hit the state anyway even if you try as hw-activity figures into some automatic state machines. However, the cost of context savings for some of the states is high enough that it is still worth the bus-master activity check.  You want to avoid unnecessary context stacking if you are not going to hit the state.

quoted text
> But I think the register has been nop'ed on newer platforms
> so indeed we'll need some way to handle this.

The activity is still useful.  Not sure about the underlying X86 hardware implementation.  For me it's just exporting some activity for masters & slaves as seen by the interconnect.

Regards,
Richard W.

--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/