Re: x86: 4kstacks default

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Willy Tarreau <w@...>
Cc: Andi Kleen <andi@...>, Alan Cox <alan@...>, Shawn Bohrer <shawn.bohrer@...>, Ingo Molnar <mingo@...>, Andrew Morton <akpm@...>, Linux Kernel Mailing List <linux-kernel@...>, Arjan van de Ven <arjan@...>, Thomas Gleixner <tglx@...>
Date: Sunday, April 20, 2008 - 9:21 am

On Sun, Apr 20, 2008 at 02:47:17PM +0200, Willy Tarreau wrote:

I've seen many bugs in error paths in the kernel and fixed quite a 
few of them - and stack problems were not a significant part of them.

There are so many possible bugs (that also occur in practice) that 
singling out stack usage won't gain much.


What actually brings bad reputation is shipping a 4k option that is 
known to break under some circumstances.

And history has shown that as long as 8k stacks are available on i386 
some problems will not get fixed. 4k stacks are available as an option 
on i386 for more than 4 years, and at about as long we know that there 
are some setups (AFAIK all that might still be present seem to include 
XFS) that are known to not work reliably with 4k stacks.

If we go after stability and reputation, we have to make a decision 
whether we want to get 4k stacks on 32bit architectures with 4k page 
size unconditionally or not at all. That's the way that gets the maximal 
number of bugs shaken out [1] for all supported configurations before 
they would hit a stable kernel.


cu
Adrian

[1] obviously not all, but that's true for all classes of bugs

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: x86: 4kstacks default, Andrew Morton, (Fri Apr 18, 5:29 pm)
Re: x86: 4kstacks default, Ingo Molnar, (Sat Apr 19, 10:23 am)
Re: x86: 4kstacks default, Benjamin Herrenschmidt, (Wed Apr 23, 1:27 am)
Re: x86: 4kstacks default, David Chinner, (Wed Apr 23, 7:36 pm)
Re: x86: 4kstacks default, Benjamin Herrenschmidt, (Wed Apr 23, 8:56 pm)
Re: x86: 4kstacks default, Arjan van de Ven, (Wed Apr 23, 8:45 pm)
Re: x86: 4kstacks default, Christoph Hellwig, (Thu Apr 24, 5:52 am)
Re: x86: 4kstacks default, Chris Mason, (Thu Apr 24, 11:41 am)
Re: x86: 4kstacks default, Alexander van Heukelum, (Thu Apr 24, 2:30 pm)
Re: x86: 4kstacks default, Peter Zijlstra, (Thu Apr 24, 8:25 am)
Re: x86: 4kstacks default, Oliver Pinter, (Sat Apr 19, 10:35 am)
Re: x86: 4kstacks default, Adrian Bunk, (Sat Apr 19, 11:19 am)
Re: x86: 4kstacks default, Oliver Pinter, (Sat Apr 19, 11:42 am)
Re: x86: 4kstacks default, Eric Sandeen, (Sat Apr 19, 9:56 pm)
Re: x86: 4kstacks default, Adrian Bunk, (Sun Apr 20, 3:42 am)
Re: x86: 4kstacks default, Chris Wedgwood, (Sun Apr 20, 12:59 pm)
Re: x86: 4kstacks default, Eric Sandeen, (Sat Apr 19, 11:29 pm)
Re: x86: 4kstacks default, Ingo Molnar, (Mon Apr 21, 10:31 am)
Re: x86: 4kstacks default, Andi Kleen, (Sun Apr 20, 8:36 am)
Re: x86: 4kstacks default, Shawn Bohrer, (Sat Apr 19, 10:59 am)
Re: x86: 4kstacks default, Adrian Bunk, (Sun Apr 20, 4:09 am)
Re: x86: 4kstacks default, Alan Cox, (Sun Apr 20, 4:06 am)
Re: x86: 4kstacks default, Adrian Bunk, (Sun Apr 20, 4:51 am)
Re: x86: 4kstacks default, Alan Cox, (Sun Apr 20, 5:36 am)
Re: x86: 4kstacks default, Adrian Bunk, (Sun Apr 20, 6:44 am)
Re: x86: 4kstacks default, Mark Lord, (Sun Apr 20, 9:22 am)
Re: x86: 4kstacks default, Andi Kleen, (Sun Apr 20, 8:27 am)
Re: x86: 4kstacks default, Daniel Hazelton, (Sun Apr 20, 11:44 am)
Re: x86: 4kstacks default, Romano Giannetti, (Tue Apr 22, 2:20 pm)
Re: x86: 4kstacks default, Denys Vlasenko, (Wed Apr 23, 1:03 am)
Re: x86: 4kstacks default, Daniel Hazelton, (Wed Apr 23, 1:21 am)
Re: x86: 4kstacks default, , (Wed Apr 23, 1:25 am)
Re: x86: 4kstacks default, Daniel Hazelton, (Wed Apr 23, 1:41 am)
Re: x86: 4kstacks default, Romano Giannetti, (Wed Apr 23, 3:46 am)
Re: x86: 4kstacks default, Stefan Richter, (Wed Apr 23, 7:24 am)
Re: x86: 4kstacks default, Romano Giannetti, (Wed Apr 23, 8:15 am)
Re: x86: 4kstacks default, Lennart Sorensen, (Wed Apr 23, 11:59 am)
Re: x86: 4kstacks default, Andi Kleen, (Sun Apr 20, 1:26 pm)
Re: x86: 4kstacks default, Arjan van de Ven, (Sun Apr 20, 2:48 pm)
Re: x86: 4kstacks default, Andrew Morton, (Sun Apr 20, 5:45 pm)
Re: x86: 4kstacks default, Andi Kleen, (Sun Apr 20, 5:51 pm)
Re: x86: 4kstacks default, Andi Kleen, (Sun Apr 20, 4:01 pm)
Re: x86: 4kstacks default, Arjan van de Ven, (Sun Apr 20, 6:33 pm)
Re: x86: 4kstacks default, Arjan van de Ven, (Sun Apr 20, 6:33 pm)
Re: x86: 4kstacks default, Eric Sandeen, (Sun Apr 20, 11:06 pm)
Re: x86: 4kstacks default, Andi Kleen, (Sun Apr 20, 7:16 pm)
Re: x86: 4kstacks default, Arjan van de Ven, (Mon Apr 21, 1:53 am)
Re: x86: 4kstacks default, Daniel Hazelton, (Sun Apr 20, 4:43 pm)
Re: x86: 4kstacks default, Andi Kleen, (Sun Apr 20, 5:40 pm)
Re: x86: 4kstacks default, Daniel Hazelton, (Sun Apr 20, 9:45 pm)
Re: x86: 4kstacks default, Andi Kleen, (Mon Apr 21, 3:51 am)
Re: x86: 4kstacks default, Daniel Hazelton, (Mon Apr 21, 1:34 pm)
Re: x86: 4kstacks default, Bernd Eckenfels, (Sun Apr 20, 6:17 pm)
Re: x86: 4kstacks default, Avi Kivity, (Sun Apr 20, 7:48 pm)
Re: x86: 4kstacks default, Willy Tarreau, (Sun Apr 20, 8:47 am)
Re: x86: 4kstacks default, Mark Lord, (Sun Apr 20, 9:27 am)
Re: x86: 4kstacks default, Eric Sandeen, (Sun Apr 20, 10:09 am)
Re: x86: 4kstacks default, Willy Tarreau, (Sun Apr 20, 10:20 am)
Re: x86: 4kstacks default, Eric Sandeen, (Sun Apr 20, 10:40 am)
Re: x86: 4kstacks default, Willy Tarreau, (Sun Apr 20, 9:38 am)
Re: x86: 4kstacks default, Andi Kleen, (Sun Apr 20, 10:19 am)
Re: x86: 4kstacks default, Jörn, (Sun Apr 20, 12:41 pm)
Re: x86: 4kstacks default, Andi Kleen, (Sun Apr 20, 1:19 pm)
Re: x86: 4kstacks default, Jörn, (Sun Apr 20, 1:43 pm)
Re: x86: 4kstacks default, Andi Kleen, (Sun Apr 20, 2:19 pm)
Re: x86: 4kstacks default, Jörn, (Sun Apr 20, 4:35 pm)
Re: x86: 4kstacks default, Jörn, (Sun Apr 20, 4:32 pm)
Re: x86: 4kstacks default, Arjan van de Ven, (Sun Apr 20, 2:50 pm)
Re: x86: 4kstacks default, Andrew Morton, (Sun Apr 20, 5:50 pm)
Re: x86: 4kstacks default, Ingo Molnar, (Mon Apr 21, 10:29 am)
Re: x86: 4kstacks default, Andi Kleen, (Sun Apr 20, 5:55 pm)
Re: x86: 4kstacks default, Andi Kleen, (Sun Apr 20, 4:09 pm)
Re: x86: 4kstacks default, Adrian Bunk, (Sun Apr 20, 9:21 am)
Re: x86: 4kstacks default, Bill Davidsen, (Mon Apr 28, 2:38 pm)
Re: x86: 4kstacks default, Helge Hafting, (Wed Apr 23, 5:13 am)
Re: x86: 4kstacks default, Eric Sandeen, (Thu Apr 24, 11:46 am)
Re: x86: 4kstacks default, David Chinner, (Wed Apr 23, 7:29 pm)
Re: x86: 4kstacks default, Andi Kleen, (Sun Apr 20, 9:06 am)
Re: x86: 4kstacks default, Adrian Bunk, (Sun Apr 20, 9:30 am)
Re: x86: 4kstacks default, Bill Davidsen, (Mon Apr 28, 1:56 pm)
Re: x86: 4kstacks default, Willy Tarreau, (Sun Apr 20, 9:34 am)
Re: x86: 4kstacks default, Adrian Bunk, (Sun Apr 20, 10:04 am)
Re: x86: 4kstacks default, Adrian Bunk, (Sun Apr 20, 8:32 am)
Re: x86: 4kstacks default, Alan Cox, (Sun Apr 20, 7:02 am)
Re: x86: 4kstacks default, Adrian Bunk, (Sun Apr 20, 7:54 am)
Re: x86: 4kstacks default, Andi Kleen, (Sun Apr 20, 8:37 am)
Re: x86: 4kstacks default, Alan Cox, (Sun Apr 20, 7:37 am)
Re: x86: 4kstacks default, Adrian Bunk, (Sun Apr 20, 8:18 am)
Re: x86: 4kstacks default, Eric Sandeen, (Sun Apr 20, 10:05 am)
Re: x86: 4kstacks default, Denys Vlasenko, (Mon Apr 21, 3:45 am)
Re: x86: 4kstacks default, Eric Sandeen, (Mon Apr 21, 9:29 am)
Re: x86: 4kstacks default, Denys Vlasenko, (Mon Apr 21, 3:51 pm)
Re: x86: 4kstacks default, David Chinner, (Mon Apr 21, 9:28 pm)
Re: x86: 4kstacks default, Jörn, (Sun Apr 27, 3:27 pm)
Re: x86: 4kstacks default, Denys Vlasenko, (Sun Apr 27, 7:02 pm)
Re: x86: 4kstacks default, Eric Sandeen, (Sun Apr 27, 7:08 pm)
Re: x86: 4kstacks default, Denys Vlasenko, (Sun Apr 27, 8:00 pm)
Re: x86: 4kstacks default, Denys Vlasenko, (Tue Apr 22, 8:48 am)
Re: x86: 4kstacks default, Adrian Bunk, (Tue Apr 22, 9:01 am)
Re: x86: 4kstacks default, Denys Vlasenko, (Tue Apr 22, 9:51 am)
[PATCH] xfs: do not pass size into kmem_free, it's unused, Denys Vlasenko, (Mon Apr 21, 10:33 pm)
[PATCH] xfs: do not pass unused params to xfs_flush_pages, Denys Vlasenko, (Mon Apr 21, 11:03 pm)
[PATCH] xfs: remove unused parameter of xfs_qm_dqpurge, Denys Vlasenko, (Tue Apr 22, 5:42 am)
Re: [PATCH] xfs: remove unused parameter of xfs_qm_dqpurge, Christoph Hellwig, (Wed Apr 23, 4:18 am)
Re: [PATCH] xfs: #define out unused parameters , Denys Vlasenko, (Tue Apr 22, 4:46 pm)
Re: [PATCH] xfs: #define out unused parameters , Denys Vlasenko, (Tue Apr 22, 1:50 pm)
[PATCH] xfs: expose no-op xfs_put_perag(), Denys Vlasenko, (Tue Apr 22, 9:46 am)
Re: [PATCH] xfs: expose no-op xfs_put_perag(), David Chinner, (Tue Apr 22, 7:16 pm)
Re: [PATCH] xfs: expose no-op xfs_put_perag(), Eric Sandeen, (Tue Apr 22, 10:08 am)
Re: x86: 4kstacks default, Denys Vlasenko, (Mon Apr 21, 4:28 pm)
Re: x86: 4kstacks default, Andi Kleen, (Mon Apr 21, 5:55 am)
Re: x86: 4kstacks default, Arjan van de Ven, (Sun Apr 20, 11:41 am)
Re: x86: 4kstacks default, Adrian Bunk, (Sun Apr 20, 12:03 pm)
Re: x86: 4kstacks default, Alexander E. Patrakov, (Sun Apr 20, 11:30 pm)
Re: x86: 4kstacks default, Helge Hafting, (Wed Apr 23, 4:57 am)
Re: x86: 4kstacks default, Adrian Bunk, (Sun Apr 20, 10:21 am)
Re: x86: 4kstacks default, Eric Sandeen, (Sun Apr 20, 10:56 am)
Re: x86: 4kstacks default, Arjan van de Ven, (Sat Apr 19, 2:00 pm)
Re: x86: 4kstacks default, Eric Sandeen, (Sat Apr 19, 10:36 pm)
Re: x86: 4kstacks default, David Chinner, (Sun Apr 20, 6:53 pm)
Re: x86: 4kstacks default, Arjan van de Ven, (Sun Apr 20, 2:11 am)
Re: x86: 4kstacks default, Ingo Molnar, (Sat Apr 19, 2:33 pm)
Re: x86: 4kstacks default, Stefan Richter, (Sat Apr 19, 3:10 pm)
Re: x86: 4kstacks default, Andrew Morton, (Sat Apr 19, 1:49 pm)