[PATCH 01/36] kobject: catch kobjects that are not initialized

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Greg Kroah-Hartman
Date: Sunday, April 20, 2008 - 3:45 am

Add warnings to kobject_put() to catch kobjects that are cleaned up but
were never initialized to begin with.

Cc: Kay Sievers <kay.sievers@vrfy.org>
Cc: Hannes Reinecke <hare@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 lib/kobject.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/lib/kobject.c b/lib/kobject.c
index 0d03252..60ae9e8 100644
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@ -592,8 +592,15 @@ static void kobject_release(struct kref *kref)
  */
 void kobject_put(struct kobject *kobj)
 {
-	if (kobj)
+	if (kobj) {
+		if (!kobj->state_initialized) {
+			printk(KERN_WARNING "kobject: '%s' (%p): is not "
+			       "initialized, yet kobject_put() is being "
+			       "called.\n", kobject_name(kobj), kobj);
+			WARN_ON(1);
+		}
 		kref_put(&kobj->kref, kobject_release);
+	}
 }
 
 static void dynamic_kobj_release(struct kobject *kobj)
-- 
1.5.4.5

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 01/36] kobject: catch kobjects that are not initialized, Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 02/36] uio: Kconfig improvements, Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 03/36] uio: mark pci_device_id hilscher_pci_ids[] _ ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 04/36] UIO: arch/arm/Kconfig: Make UIO available on ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 05/36] UIO: Remove needless PCI_DEVICE_ID definitio ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 06/36] UIO: Implement a UIO interface for the SMX C ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 07/36] UIO: hold a reference to the device's owner ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 08/36] driver core: memory: semaphore to mutex, Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 09/36] driver core: register_memory/unregister_memo ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 10/36] driver core: Convert debug functions declare ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 11/36] sysfs: small header file cleanup for SYSFS=n, Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 12/36] firmware: move firmware_class from Documenta ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 13/36] firmware: clean up samples for coding style ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 14/36] PNP: add all PNP card device id's as individ ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 15/36] power_state: remove it from driver core, Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 16/36] driver core: cpu: fix section mismatch in cp ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 17/36] sysdev: detect multiple driver registrations, Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 19/36] PM: Handle device registrations during suspe ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 20/36] Driver core: Call device_pm_add() after bus_ ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 21/36] PM: Fix misuse of wakeup flag accessors in s ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 22/36] PM: Make wakeup flags available whenever CON ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 23/36] PM: Convert wakeup flag accessors to inline ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 24/36] Driver core: make device_is_registered() wor ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 25/36] SYSFS: Explicitly include required header fi ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 26/36] Kobject: Replace list_for_each() with list_f ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 27/36] PM: Remove legacy PM (fix), Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 28/36] Firmware: add iSCSI iBFT Support, Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 29/36] PM: Remove destroy_suspended_device(), Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 30/36] sysfs: refill attribute buffer when reading ..., Greg Kroah-Hartman, (Sun Apr 20, 3:46 am)
[PATCH 31/36] driver core: replace remaining __FUNCTION__ ..., Greg Kroah-Hartman, (Sun Apr 20, 3:46 am)
[PATCH 32/36] memstick: convert struct class_device to str ..., Greg Kroah-Hartman, (Sun Apr 20, 3:46 am)
[PATCH 33/36] IB: convert struct class_device to struct device, Greg Kroah-Hartman, (Sun Apr 20, 3:46 am)
[PATCH 35/36] DRM: remove unused dev_class, Greg Kroah-Hartman, (Sun Apr 20, 3:46 am)
[PATCH 36/36] SCSI: convert struct class_device to struct ..., Greg Kroah-Hartman, (Sun Apr 20, 3:46 am)