EMM: Fix rcu handling and spelling

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Christoph Lameter
Date: Wednesday, April 2, 2008 - 11:43 am

Subject: EMM: Fix rcu handling and spelling

Fix the way rcu_dereference is done.

Signed-off-by: Christoph Lameter <clameter@sgi.com>

---
 include/linux/rmap.h |    2 +-
 mm/rmap.c            |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

Index: linux-2.6/include/linux/rmap.h
===================================================================
--- linux-2.6.orig/include/linux/rmap.h	2008-04-02 11:41:58.737866596 -0700
+++ linux-2.6/include/linux/rmap.h	2008-04-02 11:42:08.282029661 -0700
@@ -91,7 +91,7 @@ static inline void page_dup_rmap(struct 
  * when the VM removes references to pages.
  */
 enum emm_operation {
-	emm_release,		/* Process existing, */
+	emm_release,		/* Process exiting, */
 	emm_invalidate_start,	/* Before the VM unmaps pages */
 	emm_invalidate_end,	/* After the VM unmapped pages */
  	emm_referenced		/* Check if a range was referenced */
Index: linux-2.6/mm/rmap.c
===================================================================
--- linux-2.6.orig/mm/rmap.c	2008-04-02 11:41:58.737866596 -0700
+++ linux-2.6/mm/rmap.c	2008-04-02 11:42:08.282029661 -0700
@@ -303,7 +303,7 @@ EXPORT_SYMBOL_GPL(emm_notifier_register)
 int __emm_notify(struct mm_struct *mm, enum emm_operation op,
 		unsigned long start, unsigned long end)
 {
-	struct emm_notifier *e = rcu_dereference(mm)->emm_notifier;
+	struct emm_notifier *e = rcu_dereference(mm->emm_notifier);
 	int x;
 
 	while (e) {
@@ -317,7 +317,7 @@ int __emm_notify(struct mm_struct *mm, e
 		 * emm_notifier contents (e) must be fetched after
 		 * the retrival of the pointer to the notifier.
 		 */
-		e = rcu_dereference(e)->next;
+		e = rcu_dereference(e->next);
 	}
 	return 0;
 }

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch 1/9] EMM Notifier: The notifier calls, Christoph Lameter, (Tue Apr 1, 1:55 pm)
Re: [patch 1/9] EMM Notifier: The notifier calls, Peter Zijlstra, (Tue Apr 1, 2:14 pm)
Re: [patch 1/9] EMM Notifier: The notifier calls, Paul E. McKenney, (Tue Apr 1, 2:38 pm)
Re: [patch 1/9] EMM Notifier: The notifier calls, Andrea Arcangeli, (Tue Apr 1, 11:49 pm)
Re: [patch 1/9] EMM Notifier: The notifier calls, Robin Holt, (Wed Apr 2, 3:59 am)
Re: [patch 1/9] EMM Notifier: The notifier calls, Andrea Arcangeli, (Wed Apr 2, 4:16 am)
Re: [patch 1/9] EMM Notifier: The notifier calls, Robin Holt, (Wed Apr 2, 7:26 am)
Re: [patch 1/9] EMM Notifier: The notifier calls, Christoph Lameter, (Wed Apr 2, 10:44 am)
Re: [patch 1/9] EMM Notifier: The notifier calls, Christoph Lameter, (Wed Apr 2, 10:59 am)
EMM: Fix rcu handling and spelling, Christoph Lameter, (Wed Apr 2, 11:43 am)
Re: EMM: Fix rcu handling and spelling, Paul E. McKenney, (Wed Apr 2, 12:02 pm)
EMM: Fixup return value handling of emm_notify(), Christoph Lameter, (Wed Apr 2, 12:03 pm)
EMM: Require single threadedness for registration., Christoph Lameter, (Wed Apr 2, 2:05 pm)
Re: EMM: Fixup return value handling of emm_notify(), Andrea Arcangeli, (Wed Apr 2, 2:25 pm)
Re: EMM: Fixup return value handling of emm_notify(), Christoph Lameter, (Wed Apr 2, 2:33 pm)
Re: [patch 1/9] EMM Notifier: The notifier calls, Andrea Arcangeli, (Wed Apr 2, 2:53 pm)
Re: [patch 1/9] EMM Notifier: The notifier calls, Christoph Lameter, (Wed Apr 2, 2:54 pm)
Re: EMM: Require single threadedness for registration., Andrea Arcangeli, (Wed Apr 2, 3:01 pm)
Re: EMM: Require single threadedness for registration., Christoph Lameter, (Wed Apr 2, 3:06 pm)
Re: [patch 1/9] EMM Notifier: The notifier calls, Andrea Arcangeli, (Wed Apr 2, 3:09 pm)
Re: EMM: Require single threadedness for registration., Andrea Arcangeli, (Wed Apr 2, 3:17 pm)
Re: EMM: Require single threadedness for registration., Christoph Lameter, (Wed Apr 2, 3:41 pm)
Re: [patch 1/9] EMM Notifier: The notifier calls, Christoph Lameter, (Wed Apr 2, 4:04 pm)
EMM: disable other notifiers before register and unregister, Christoph Lameter, (Wed Apr 2, 6:24 pm)
Re: EMM: Fixup return value handling of emm_notify(), Peter Zijlstra, (Thu Apr 3, 3:40 am)
Re: EMM: Fixup return value handling of emm_notify(), Andrea Arcangeli, (Thu Apr 3, 8:00 am)
Re: EMM: Fixup return value handling of emm_notify(), Christoph Lameter, (Thu Apr 3, 12:14 pm)
Re: EMM: disable other notifiers before register and unreg ..., Christoph Lameter, (Thu Apr 3, 12:20 pm)
[PATCH] mmu notifier #v11, Andrea Arcangeli, (Fri Apr 4, 1:20 pm)
Re: [PATCH] mmu notifier #v11, Christoph Lameter, (Fri Apr 4, 3:06 pm)
Re: [PATCH] mmu notifier #v11, Andrea Arcangeli, (Fri Apr 4, 5:23 pm)
Re: [PATCH] mmu notifier #v11, Christoph Lameter, (Sun Apr 6, 10:45 pm)
Re: [PATCH] mmu notifier #v11, Andrea Arcangeli, (Sun Apr 6, 11:02 pm)