Re: 2.6.25-rc8-mm1 (mips build failure)

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Christoph Lameter
Date: Wednesday, April 2, 2008 - 10:33 am

On Tue, 1 Apr 2008, Andrew Morton wrote:


This the fix that I posted a couple of days ago after Andrew noted the 
problem:




From: Christoph Lameter <clameter@sgi.com>
Subject: Allow override of definition for asm constant

MIPS has a different way of defining asm constants which causes troubles
for bounds.h generation (see also the Kbuild script).

Add a new per arch CONFIG variable

	CONFIG_ASM_SYMBOL_PREFIX

which can be set to define an alternate header for asm constant definitions.
Use this for MIPS to make bounds determination work right.

Signed-off-by: Christoph Lameter <clameter@sgi.com>

---
 arch/mips/Kconfig |    7 +++++++
 kernel/bounds.c   |   11 ++++++++++-
 2 files changed, 17 insertions(+), 1 deletion(-)

Index: linux-2.6.25-rc5-mm1/arch/mips/Kconfig
===================================================================
--- linux-2.6.25-rc5-mm1.orig/arch/mips/Kconfig	2008-03-31 13:14:26.888383587 -0700
+++ linux-2.6.25-rc5-mm1/arch/mips/Kconfig	2008-03-31 13:14:28.028403612 -0700
@@ -2019,6 +2019,13 @@ config I8253
 config ZONE_DMA32
 	bool
 
+#
+# Used to override gas symbol setup in kernel/bounds.c.
+#
+config ASM_SYMBOL_PREFIX
+	string
+	default "@@@#define "
+
 source "drivers/pcmcia/Kconfig"
 
 source "drivers/pci/hotplug/Kconfig"
Index: linux-2.6.25-rc5-mm1/kernel/bounds.c
===================================================================
--- linux-2.6.25-rc5-mm1.orig/kernel/bounds.c	2008-03-31 13:14:26.904383870 -0700
+++ linux-2.6.25-rc5-mm1/kernel/bounds.c	2008-03-31 13:14:28.028403612 -0700
@@ -9,8 +9,17 @@
 #include <linux/page-flags.h>
 #include <linux/mmzone.h>
 
+#ifdef CONFIG_ASM_SYMBOL_PREFIX
+#define PREFIX CONFIG_ASM_SYMBOL_PREFIX
+#else
+/*
+ * Standard gas way of defining an asm symbol
+ */
+#define PREFIX "->"
+#endif
+
 #define DEFINE(sym, val) \
-	asm volatile("\n->" #sym " %0 " #val : : "i" (val))
+	asm volatile("\n" PREFIX #sym " %0 " : : "i" (val))
 
 #define BLANK() asm volatile("\n->" : :)
 
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.25-rc8-mm1, Andrew Morton, (Tue Apr 1, 9:32 pm)
Re: 2.6.25-rc8-mm1, Dmitri Vorobiev, (Tue Apr 1, 10:40 pm)
Re: 2.6.25-rc8-mm1, Andrew Morton, (Tue Apr 1, 11:03 pm)
Re: 2.6.25-rc8-mm1, Valdis.Kletnieks, (Tue Apr 1, 11:04 pm)
Re: 2.6.25-rc8-mm1, Andrew Morton, (Tue Apr 1, 11:15 pm)
[BUG] 2.6.25-rc8-mm1 kernel panic while bootup on powerpc, Kamalesh Babulal, (Tue Apr 1, 11:25 pm)
Re: [BUG] 2.6.25-rc8-mm1 kernel panic while bootup on powerpc, Kamalesh Babulal, (Wed Apr 2, 12:08 am)
Re: [BUG] 2.6.25-rc8-mm1 kernel panic while bootup on powerpc, Michael Ellerman, (Wed Apr 2, 12:17 am)
Re: 2.6.25-rc8-mm1, Miles Lane, (Wed Apr 2, 3:49 am)
Re: 2.6.25-rc8-mm1, Valdis.Kletnieks, (Wed Apr 2, 4:08 am)
RE: 2.6.25-rc8-mm1, Chatre, Reinette, (Wed Apr 2, 9:58 am)
Re: [BUG] 2.6.25-rc8-mm1 kernel panic while bootup on powerpc, Kamalesh Babulal, (Wed Apr 2, 10:09 am)
Re: 2.6.25-rc8-mm1 (mips build failure), Christoph Lameter, (Wed Apr 2, 10:33 am)
Re: [BUG] 2.6.25-rc8-mm1 kernel panic while bootup on powerpc, Badari Pulavarty, (Wed Apr 2, 11:15 am)
Re: 2.6.25-rc8-mm1 (mips build failure), Andrew Morton, (Wed Apr 2, 11:29 am)
Re: 2.6.25-rc8-mm1 (mips build failure), Christoph Lameter, (Wed Apr 2, 11:33 am)
Re: 2.6.25-rc8-mm1 (mips build failure), Sam Ravnborg, (Wed Apr 2, 12:06 pm)
2.6.25-rc8-mm1 - BUG in fs/jbd/transaction.c, Valdis.Kletnieks, (Wed Apr 2, 12:12 pm)
Re: 2.6.25-rc8-mm1, Valdis.Kletnieks, (Wed Apr 2, 12:15 pm)
Re: [BUG] 2.6.25-rc8-mm1 kernel panic while bootup on powerpc, Badari Pulavarty, (Wed Apr 2, 12:22 pm)
Re: 2.6.25-rc8-mm1 - BUG in fs/jbd/transaction.c, Josef Bacik, (Wed Apr 2, 12:27 pm)
Re: 2.6.25-rc8-mm1 - BUG in fs/jbd/transaction.c, Andrew Morton, (Wed Apr 2, 12:30 pm)
Re: 2.6.25-rc8-mm1 - BUG in fs/jbd/transaction.c, Andrew Morton, (Wed Apr 2, 12:39 pm)
Re: 2.6.25-rc8-mm1 - BUG in fs/jbd/transaction.c, Josef Bacik, (Wed Apr 2, 12:41 pm)
Re: 2.6.25-rc8-mm1 - BUG in fs/jbd/transaction.c, Jan Kara, (Thu Apr 3, 1:57 am)
Re: 2.6.25-rc8-mm1, Dave Airlie, (Thu Apr 3, 5:11 am)
Re: 2.6.25-rc8-mm1 (mips build failure), Ralf Baechle, (Thu Apr 3, 9:02 am)
Re: 2.6.25-rc8-mm1, Andrew Morton, (Thu Apr 3, 9:59 am)
Re: 2.6.25-rc8-mm1 - BUG in fs/jbd/transaction.c, Stephen Smalley, (Thu Apr 3, 11:18 am)
Re: 2.6.25-rc8-mm1 - BUG in fs/jbd/transaction.c, Stephen Smalley, (Thu Apr 3, 11:25 am)
Re: 2.6.25-rc8-mm1 (mips build failure), Christoph Lameter, (Thu Apr 3, 3:17 pm)
Re: 2.6.25-rc8-mm1 - BUG in fs/jbd/transaction.c, James Morris, (Thu Apr 3, 4:02 pm)
Re: 2.6.25-rc8-mm1: Intel SATA boot failure, Tilman Schmidt, (Thu Apr 3, 4:08 pm)
Re: 2.6.25-rc8-mm1: Intel SATA boot failure, Andrew Morton, (Thu Apr 3, 4:17 pm)
Re: 2.6.25-rc8-mm1 (mips build failure), Dmitri Vorobiev, (Thu Apr 3, 4:26 pm)
Re: 2.6.25-rc8-mm1 - BUG in fs/jbd/transaction.c, Jan Kara, (Fri Apr 4, 3:15 am)
Re: 2.6.25-rc8-mm1 (mips build failure), Ralf Baechle, (Fri Apr 4, 3:24 am)
Re: 2.6.25-rc8-mm1 - BUG in fs/jbd/transaction.c, Stephen Smalley, (Fri Apr 4, 5:46 am)
Re: 2.6.25-rc8-mm1 - BUG in fs/jbd/transaction.c', Josef Bacik, (Fri Apr 4, 5:53 am)
Re: 2.6.25-rc8-mm1 (mips build failure), Christoph Lameter, (Fri Apr 4, 10:36 am)
Re: 2.6.25-rc8-mm1 (mips build failure), Christoph Lameter, (Fri Apr 4, 10:50 am)
Re: 2.6.25-rc8-mm1 - BUG in fs/jbd/transaction.c, James Morris, (Sun Apr 6, 4:54 pm)
Re: 2.6.25-rc8-mm1: Intel SATA boot failure, Tilman Schmidt, (Wed Apr 9, 7:29 am)
Re: 2.6.25-rc8-mm1: Intel SATA boot failure, Tilman Schmidt, (Sun Apr 13, 5:28 pm)
Re: 2.6.25-rc8-mm1: Intel SATA boot failure, Andrew Morton, (Sun Apr 13, 7:05 pm)
Re: 2.6.25-rc8-mm1: Intel SATA boot failure, Tilman Schmidt, (Tue Apr 15, 4:33 pm)