Re: [PATCH] usb ehci_iaa_watchdog fix

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Mark Lord <lkml@...>
Cc: David Brownell <david-b@...>, <pavel@...>, <oliver@...>, <linux-usb@...>, <linux-kernel@...>, <jikos@...>, <gregkh@...>, <akpm@...>
Date: Wednesday, April 2, 2008 - 12:48 pm

On Wed, 2 Apr 2008, Mark Lord wrote:


Okay, I'm puzzled.  How could this make any difference?  
ehci_bus_suspend() calls end_unlink_async() anyway, whenever reclaim is 
set.

Is the real problem that it does so before calling ehci_work() instead 
of after calling ehci_halt()?

Mark, if you want to experiment some more, try reverting your patch 
above and moving:

	if (ehci->reclaim)
		end_unlink_async(ehci);

in ehci-hub.c:ehci_bus_suspend() to just after the line saying:

	hcd->state = HC_STATE_SUSPENDED;

Alan Stern

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.25-rc7: Ugh. , Mark Lord, (Thu Mar 27, 11:29 am)
Re: 2.6.25-rc7: Ugh., Mark Lord, (Thu Mar 27, 10:14 pm)
Re: 2.6.25-rc7: Ugh., Pavel Machek, (Fri Mar 28, 5:24 am)
Re: 2.6.25-rc7: Ugh., Mark Lord, (Sun Mar 30, 5:04 pm)
Re: 2.6.25-rc7: Ugh., Oliver Neukum, (Mon Mar 31, 7:55 am)
Re: 2.6.25-rc7: Ugh., Mark Lord, (Mon Mar 31, 10:39 am)
Re: 2.6.25-rc7: Ugh., Oliver Neukum, (Mon Mar 31, 11:04 am)
Re: 2.6.25-rc7: Ugh., Mark Lord, (Mon Mar 31, 11:04 am)
Re: 2.6.25-rc7: Ugh., Oliver Neukum, (Mon Mar 31, 12:37 pm)
Re: 2.6.25-rc7: Ugh., Mark Lord, (Mon Mar 31, 1:03 pm)
Re: 2.6.25-rc7: Ugh., Mark Lord, (Mon Mar 31, 1:15 pm)
Re: 2.6.25-rc7: Ugh., Mark Lord, (Mon Mar 31, 1:21 pm)
Re: 2.6.25-rc7: Ugh., Mark Lord, (Mon Mar 31, 1:30 pm)
Re: 2.6.25-rc7: Ugh., Oliver Neukum, (Mon Mar 31, 2:05 pm)
Re: 2.6.25-rc7: Ugh., Pavel Machek, (Tue Apr 1, 5:59 am)
Re: 2.6.25-rc7: Ugh., Mark Lord, (Mon Mar 31, 3:21 pm)
Re: 2.6.25-rc7: Ugh., Oliver Neukum, (Wed Apr 2, 4:04 am)
Re: 2.6.25-rc7: Ugh., Mark Lord, (Wed Apr 2, 10:38 am)
Re: 2.6.25-rc7: Ugh., Mark Lord, (Wed Apr 2, 10:38 am)
Re: 2.6.25-rc7: Ugh., Alan Stern, (Wed Apr 2, 11:08 am)
Re: 2.6.25-rc7: Ugh., David Brownell, (Wed Apr 2, 12:04 pm)
[PATCH] usb ehci_iaa_watchdog fix, Mark Lord, (Wed Apr 2, 12:20 pm)
Re: [PATCH] usb ehci_iaa_watchdog fix, David Brownell, (Wed Apr 2, 12:56 pm)
Re: [PATCH] usb ehci_iaa_watchdog fix, Alan Stern, (Wed Apr 2, 12:48 pm)
Re: [PATCH] usb ehci_iaa_watchdog fix, David Brownell, (Wed Apr 2, 4:31 pm)
Re: [PATCH] usb ehci_iaa_watchdog fix, Alan Stern, (Wed Apr 2, 4:55 pm)
Re: [PATCH] usb ehci_iaa_watchdog fix, David Brownell, (Wed Apr 2, 7:07 pm)
Re: [PATCH] usb ehci_iaa_watchdog fix, Mark Lord, (Wed Apr 2, 1:34 pm)
Re: [PATCH] usb ehci_iaa_watchdog fix, Mark Lord, (Wed Apr 2, 2:08 pm)
Re: [PATCH] usb ehci_iaa_watchdog fix, Alan Stern, (Wed Apr 2, 3:20 pm)
Re: [PATCH] usb ehci_iaa_watchdog fix, David Brownell, (Wed Apr 2, 4:42 pm)
Re: [PATCH] usb ehci_iaa_watchdog fix, Alan Stern, (Wed Apr 2, 5:08 pm)
Re: [PATCH] usb ehci_iaa_watchdog fix, David Brownell, (Mon Apr 7, 7:37 pm)
Re: [PATCH] usb ehci_iaa_watchdog fix, Alan Stern, (Mon Apr 7, 10:13 pm)
Re: 2.6.25-rc7: Ugh., Mark Lord, (Wed Apr 2, 12:09 pm)
Re: 2.6.25-rc7: Ugh., David Brownell, (Wed Apr 2, 4:22 pm)
Re: 2.6.25-rc7: Ugh. ---&gt; PATCH, Mark Lord, (Wed Apr 2, 11:44 am)
Re: 2.6.25-rc7: Ugh. ---&gt; PATCH, Alan Stern, (Wed Apr 2, 4:09 pm)
Re: 2.6.25-rc7: Ugh. ---&gt; PATCH, Mark Lord, (Wed Apr 2, 11:47 am)
Re: 2.6.25-rc7: Ugh. ---&gt; PATCH, Mark Lord, (Wed Apr 2, 11:49 am)
2.6.25-rc7/rc8 USB dead on resume, Mark Lord, (Wed Apr 2, 11:05 am)
Re: 2.6.25-rc7/rc8 USB dead on resume, Oliver Neukum, (Wed Apr 2, 11:21 am)
Re: 2.6.25-rc7: Ugh., Mark Lord, (Mon Mar 31, 1:06 pm)
Re: 2.6.25-rc7: Ugh., Mark Lord, (Mon Mar 31, 11:14 am)
Re: 2.6.25-rc7: Ugh., Mark Lord, (Sun Mar 30, 5:09 pm)
Re: 2.6.25-rc7: Ugh., Rafael J. Wysocki, (Thu Mar 27, 6:00 pm)
Re: 2.6.25-rc7: Ugh., Mark Lord, (Fri Mar 28, 1:22 am)
Re: 2.6.25-rc7: Ugh., Greg KH, (Thu Mar 27, 12:07 pm)
Re: 2.6.25-rc7: Ugh., Mark Lord, (Thu Mar 27, 10:11 pm)
Re: 2.6.25-rc7: Ugh., Alan Stern, (Fri Mar 28, 10:34 am)
Re: 2.6.25-rc7: Ugh., Mark Lord, (Fri Mar 28, 10:57 am)
Re: 2.6.25-rc7: Ugh., Mark Lord, (Thu Mar 27, 10:13 pm)
Re: 2.6.25-rc7: Ugh., Mark Lord, (Thu Mar 27, 9:51 pm)
Re: 2.6.25-rc7: Ugh., Jiri Kosina, (Thu Mar 27, 8:32 pm)
Re: 2.6.25-rc7: Ugh., Mark Lord, (Thu Mar 27, 9:57 pm)
Re: 2.6.25-rc7: Ugh., David Miller, (Thu Mar 27, 11:12 pm)
Re: 2.6.25-rc7: Ugh., Mark Lord, (Fri Mar 28, 1:46 am)
Re: 2.6.25-rc7: Ugh., Mark Lord, (Fri Mar 28, 1:52 am)
Re: 2.6.25-rc7: Ugh., Mark Lord, (Fri Mar 28, 2:05 am)
Re: 2.6.25-rc7: Ugh., Mark Lord, (Fri Mar 28, 11:58 pm)
Re: 2.6.25-rc7: Ugh., David Brownell, (Fri Mar 28, 2:58 am)
Re: 2.6.25-rc7: Ugh., Ingo Molnar, (Fri Mar 28, 5:16 am)
Re: 2.6.25-rc7: Ugh., David Brownell, (Fri Mar 28, 5:49 am)
Re: 2.6.25-rc7: Ugh., Jan Engelhardt, (Fri Mar 28, 10:56 am)
Re: 2.6.25-rc7: Ugh., Adrian Bunk, (Fri Mar 28, 1:47 pm)
Re: 2.6.25-rc7: Ugh., Mark Lord, (Fri Mar 28, 9:47 am)
Re: Kconfig RTC selection (was: 2.6.25-rc7: Ugh.), David Brownell, (Fri Mar 28, 4:04 pm)
Re: Kconfig RTC selection (was: 2.6.25-rc7: Ugh.), Adrian Bunk, (Fri Mar 28, 5:06 pm)
Re: Kconfig RTC selection (was: 2.6.25-rc7: Ugh.), David Brownell, (Fri Mar 28, 5:23 pm)
Re: Kconfig RTC selection (was: 2.6.25-rc7: Ugh.), Adrian Bunk, (Fri Mar 28, 5:33 pm)
Re: Kconfig RTC selection (was: 2.6.25-rc7: Ugh.), David Brownell, (Fri Mar 28, 5:45 pm)
Re: Kconfig RTC selection (was: 2.6.25-rc7: Ugh.), Adrian Bunk, (Fri Mar 28, 5:59 pm)
Re: Kconfig RTC selection (was: 2.6.25-rc7: Ugh.), David Brownell, (Fri Mar 28, 6:18 pm)
Re: Kconfig RTC selection (was: 2.6.25-rc7: Ugh.), Adrian Bunk, (Fri Mar 28, 6:36 pm)
Kconfig RTC selection (was: 2.6.25-rc7: Ugh.), Tilman Schmidt, (Fri Mar 28, 8:51 am)
Re: Kconfig RTC selection (was: 2.6.25-rc7: Ugh.), David Brownell, (Fri Mar 28, 3:22 pm)
Re: Kconfig RTC selection, Tilman Schmidt, (Sat Mar 29, 8:55 am)
Re: Kconfig RTC selection, Mark Lord, (Fri Mar 28, 9:49 am)
Re: 2.6.25-rc7: Ugh., Ingo Molnar, (Fri Mar 28, 6:20 am)
Re: 2.6.25-rc7: Ugh., Jan Engelhardt, (Fri Mar 28, 11:03 am)
Re: 2.6.25-rc7: Ugh., David Brownell, (Fri Mar 28, 4:14 pm)
Re: 2.6.25-rc7: Ugh., Pavel Machek, (Fri Mar 28, 7:01 am)
Re: 2.6.25-rc7: Ugh., Mike Galbraith, (Fri Mar 28, 1:36 am)
Re: 2.6.25-rc7: Ugh., Bob Tracy, (Fri Mar 28, 12:42 am)
Re: 2.6.25-rc7: Ugh., David Miller, (Fri Mar 28, 12:56 am)
Re: 2.6.25-rc7: Ugh., Bill Davidsen, (Sat Apr 5, 2:23 pm)
Re: 2.6.25-rc7: Ugh., Bob Tracy, (Fri Mar 28, 12:34 pm)
Re: 2.6.25-rc7: Ugh., Mark Lord, (Fri Mar 28, 1:17 am)
Re: 2.6.25-rc7: Ugh., , (Fri Mar 28, 2:01 am)