Re: [PATCH 2/4] x86_64 boot -v2: Add linked list of struct setup_data

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: H. Peter Anvin

Subject: Re: [PATCH 2/4] x86_64 boot -v2: Add linked list of struct setup_data

Date: Wednesday, April 2, 2008 - 9:39 am

Paul Jackson wrote:
quoted text> Huang wrote:
>> On Sat, 2008-03-29 at 23:31 -0500, Paul Jackson wrote:
>>> Huang wrote:
>>>> +/* setup data types */
>>>> +#define SETUP_NONE			0
>>> This define seems unused?
>> I think this can prevent somebody to use 0 as type id.
> 
> Why is it a good idea to prevent a 0 type id?
> 

It is usually handy to have an ID to use as ignore, or not present, and 
for that to be zero.

	-hpa
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 2/4] x86_64 boot -v2: Add linked list of struct set ..., Huang, Ying, (Thu Mar 27, 7:49 pm)

Re: [PATCH 2/4] x86_64 boot -v2: Add linked list of struct ..., Paul Jackson, (Sat Mar 29, 9:25 pm)

Re: [PATCH 2/4] x86_64 boot -v2: Add linked list of struct ..., Paul Jackson, (Sat Mar 29, 9:31 pm)

Re: [PATCH 2/4] x86_64 boot -v2: Add linked list of struct ..., Yinghai Lu, (Sun Mar 30, 1:15 am)

Re: [PATCH 2/4] x86_64 boot -v2: Add linked list of struct ..., Huang, Ying, (Sun Mar 30, 5:52 pm)

Re: [PATCH 2/4] x86_64 boot -v2: Add linked list of struct ..., Huang, Ying, (Sun Mar 30, 5:54 pm)

Re: [PATCH 2/4] x86_64 boot -v2: Add linked list of struct ..., Paul Jackson, (Wed Apr 2, 12:39 am)

Re: [PATCH 2/4] x86_64 boot -v2: Add linked list of struct ..., H. Peter Anvin, (Wed Apr 2, 9:39 am)

Re: [PATCH 2/4] x86_64 boot -v2: Add linked list of struct ..., Paul Jackson, (Wed Apr 2, 10:36 am)


linux-kernel:
Greg Kroah-Hartman	[PATCH 041/196] kobject: add kobject_init_and_add function
Lukas Hejtmanek	Re: Another libata error related to OCZ SSD
Greg Kroah-Hartman	[PATCH 023/196] MCP_UCB1200: Convert from class_device to device
Florian Fainelli	Re: System clock runs too fast after 2.6.27 -> 2.6.28.1 upgrade
Christoph Lameter	[patch 1/4] mmu_notifier: Core code
git:
Johannes Schindelin	Re: [PATCH 1/2] Add strbuf_initf()
John Bito	[EGIT] Push to GitHub caused corruption
Jakub Narebski	Re: [PATCH 0/2] gitweb: patch view
Junio C Hamano	Re: [PATCH] When a remote is added but not fetched, tell the user.
Andy Parkins	Re: [RFC] Submodules in GIT
git-commits-head:
Linux Kernel Mailing List	ahci: Workaround HW bug for SB600/700 SATA controller PMP support
Linux Kernel Mailing List	V4L/DVB (11086): au0828: rename macro for currently non-function VBI support
Linux Kernel Mailing List	ceph: client types
Linux Kernel Mailing List	ceph: on-wire types
Linux Kernel Mailing List	crypto: chainiv - Use kcrypto_wq instead of keventd_wq
linux-netdev:
Andrew Morton	Re: [Bugme-new] [Bug 14969] New: b44: WOL does not work in suspended state
Giuseppe CAVALLARO	Re: [PATCH 03/13] stmmac: add the new Header file for stmmac platform data
Taku Izumi	[PATCH 3/3] ixgbe: add registers etc. printout code just before resetting adapters
Eric Dumazet	rps: some comments
Thomas Gleixner	Re: [RFC PATCH 02/12] On Tue, 23 Sep 2008, David Miller wrote:
openbsd-misc:
Stephan Andreas	problems with login after xlock in OpenBSD release 4.7
pmc	Make A Change. Alcoholism and Drug Addiction Treatment
ropers	Re: what exactly is enc0?
Fuad NAHDI	Re: What does your environment look like?
Matthew Szudzik	Typo on OpenBSD 4.4 CD Set