login
Login
/
Register
Search
Header Space
Forums
News
Jobs
Blogs
Features
Man Pages
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
April
»
2
Re: [PATCH 1/2] sysfs: allow the group is_visible() method to return a mode and add an update API
view
thread
Score:
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From:
Greg KH <greg@...>
To: Kay Sievers <kay.sievers@...>
Cc: James Bottomley <James.Bottomley@...>, Hannes Reinecke <hare@...>, linux-scsi <linux-scsi@...>, linux-kernel <linux-kernel@...>
Subject:
Re: [PATCH 1/2] sysfs: allow the group is_visible() method to return a mode and add an update API
Date: Wednesday, April 2, 2008 - 2:30 am
On Mon, Mar 31, 2008 at 03:42:09PM +0200, Kay Sievers wrote:
quoted text
> On Sun, 2008-03-30 at 11:54 -0500, James Bottomley wrote: > > On Sat, 2008-03-22 at 13:02 -0500, James Bottomley wrote: > > > On Fri, 2008-03-21 at 15:26 -0700, Greg KH wrote: > > > > On Fri, Mar 21, 2008 at 04:27:12PM -0500, James Bottomley wrote: > > > > > We have a problem in scsi_transport_spi in that we need to customise > > > > > not only the visibility of the attributes, but also their mode. Fix > > > > > this by making the is_visible() callback return a mode, with 0 > > > > > indicating is not visible. > > > > > > > > > > Also add a sysfs_update_group() API to allow us to change either the > > > > > visibility or mode of the files at any time on the fly. > > > > > > > > > > Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com> > > > > > --- > > > > > > > > > > Greg, can I take this through SCSI, please ... assuming it's OK? We > > > > > need this to fix up the SPI transport class. > > > > > > > > Sure. But can you document that "update" field a bit more so we can > > > > remember what it means in the future? > > > > > > How about this? I also added docbook for create and update attribute > > > group. > > Looks good to me. > > I think with the "visible" stuff for attribute groups, will be able to > fix the USB event timing problem, by moving the creation of the device > attributes to default attributes. So I'm looking forward to have this in > the tree.
Me too.
quoted text
> > Can I get an ACK from someone from sysfs for this, please? > > > > --- > > > > > > From: James Bottomley <James.Bottomley@HansenPartnership.com> > > > Date: Thu, 20 Mar 2008 20:47:52 -0500 > > > Subject: [SCSI] sysfs: make group is_valid return a mode_t > > > > > > We have a problem in scsi_transport_spi in that we need to customise > > > not only the visibility of the attributes, but also their mode. Fix > > > this by making the is_visible() callback return a mode, with 0 > > > indicating is not visible. > > > > > > Also add a sysfs_update_group() API to allow us to change either the > > > visibility or mode of the files at any time on the fly. > > Acked-by: Kay Sievers <kay.sievers@vrfy.org>
Acked-by: Greg Kroah-Hartman <gregkh@suse.de> --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[PATCH 1/2] sysfs: allow the group is_visible() method to re...
, James Bottomley
, (Fri Mar 21, 5:27 pm)
Re: [PATCH 1/2] sysfs: allow the group is_visible() method t...
, Greg KH
, (Fri Mar 21, 6:26 pm)
Re: [PATCH 1/2] sysfs: allow the group is_visible() method t...
, James Bottomley
, (Sat Mar 22, 2:02 pm)
Re: [PATCH 1/2] sysfs: allow the group is_visible() method t...
, James Bottomley
, (Sun Mar 30, 12:54 pm)
Re: [PATCH 1/2] sysfs: allow the group is_visible() method t...
, Kay Sievers
, (Mon Mar 31, 9:42 am)
Re: [PATCH 1/2] sysfs: allow the group is_visible() method t...
, Greg KH
, (Wed Apr 2, 2:30 am)
Navigation
Create content
Mailing list archives
Recent posts
Mail archive search
Enter your search terms.
all mailing lists
alsa-devel
dragonflybsd-bugs
dragonflybsd-commit
dragonflybsd-docs
dragonflybsd-kernel
dragonflybsd-submit
dragonflybsd-user
freebsd-announce
freebsd-bugs
freebsd-chat
freebsd-cluster
freebsd-current
freebsd-drivers
freebsd-embeded
freebsd-fs
freebsd-hackers
freebsd-hardware
freebsd-mobile
freebsd-net
freebsd-performance
freebsd-pf
freebsd-security
freebsd-security-notifications
freebsd-threads
git
git-commits-head
linux-activists
linux-arm
linux-ath5k-devel
linux-btrfs
linux-c-programming
linux-driver-devel
linux-ext4
linux-fsdevel
linux-ia64
linux-input
linux-kernel
linux-kernel-janitors
linux-kernel-mentors
linux-kernel-newbies
linux-kvm
linux-net
linux-netdev
linux-newbie
linux-nfs
linux-raid
linux-scsi
linux-security-module
linux-sparse
linux-usb
linux-usb-devel
madwifi-devel
netbsd-announce
netbsd-tech-kern
openbsd-announce
openbsd-bugs
openbsd-ipv6
openbsd-misc
openbsd-security-announce
openbsd-smp
openbsd-source-changes
openbsd-tech
openfabrics-general
openmoko-community
openmoko-devel
openmoko-kernel
reiserfs-devel
tux3
ucarp
Optionally limit your search to a specific mailing list.
advanced
Popular discussions
linux-kernel
:
Ryan Hope
reiser4 for 2.6.27-rc1
Ingo Molnar
Re: 2.6.24-rc6-mm1
Tim Tassonis
reiser4 for 2.6.27-rc1
Ingo Molnar
Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error
git
:
Petko Manolov
git and binary files
Wink Saville
Resolving conflicts
Ken Pratt
pack operation is thrashing my server
Junio C Hamano
What's cooking in git.git (Aug 2008, #07; Sat, 23)
openbsd-misc
:
Richard Stallman
Real men don't attack straw men
Julien TOUCHE
setting up ssh tunnel/vpn
Jeffrey 'jf' Lim
Re: SSHJail patch for OpenBSD
Daniel Ouellet
identifying sparse files and get ride of them trick available?
linux-activists
:
Jim Winstead Jr.
Re: Root Disk/Book Disk Compatibility
Peter MacDonald
demand paging: proposal
Stephen Pierce
SLS
Drew Eckhardt
Re: 20MB drive & wdxt-gen2 controller on 386?
Latest forum posts
trouble with my Asus Mainboard
1 hour ago
Linux kernel
what is "callback function"?.can anyone explain me please..
21 hours ago
Linux general
unable to remove block device driver module
1 day ago
Linux kernel
Is there anything like Real-time drivers?
2 days ago
Linux general
I can't allocate more than 4 MB with pci_alloc_consistent
2 days ago
Linux kernel
Resetting the bios password for Toshiba Laptop
2 days ago
Hardware
Kernel panic while installing fedora core 5 or ubuntu
3 days ago
Hardware
Interactive Linux kernel map
3 days ago
Linux kernel
unable to add a variable in buffer_head struct
3 days ago
Linux kernel
Linux Input driver - setting scaling/resolution on USB mouse
4 days ago
Linux kernel
Show all forums...
Recent Tags
AXFS
squashfs
release
git 1.6.0
performance
2.6.27
git 1.6
Andrew Morton
quote
Linus Torvalds
Ingo Molnar
Linux
git
cramfs
Rik van Riel
-rc
Jared Hulbert
Junio Hamano
GCC
filesystem
more tags
Colocation donated by:
Who's online
There are currently
5 users
and
746 guests
online.
Online users
Jeremy
Raynus
Mr_Z
strcmp
mmessano
Syndicate
speck-geostationary