Re: [git pull] scheduler changes for v2.6.26

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Guillaume Chazarain
Date: Saturday, April 19, 2008 - 11:47 am

On 4/19/08, Ingo Molnar <mingo@elte.hu> wrote:

This one should have been dropped (per http://lkml.org/lkml/2008/1/25/413)
I don't like rq->clock relying on jiffies, and you already fixed the
original manifestation of the problem in:

commit 2997c8c4a0b179e8b834a7f30ba4323f2c60ccf4
Author: Ingo Molnar <mingo@elte.hu>
Date:   Fri Jan 11 13:35:54 2008 +0100

    block: fix blktrace timestamps

    David Dillow reported broken blktrace timestamps. The reason
    is cpu_clock() which is not a global time source.

    Fix bkltrace timestamps by using ktime_get() like the networking
    code does for packet timestamps. This also removes a whole lot
    of complexity from bkltrace.c and shrinks the code by 500 bytes:

       text    data     bss     dec     hex filename
       2888     124      44    3056     bf0 blktrace.o.before
       2390     116      44    2550     9f6 blktrace.o.after

    Signed-off-by: Ingo Molnar <mingo@elte.hu>
    Signed-off-by: Jens Axboe <jens.axboe@oracle.com>


-- 
Guillaume
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[git pull] scheduler changes for v2.6.26, Ingo Molnar, (Sat Apr 19, 11:13 am)
Re: [git pull] scheduler changes for v2.6.26, Guillaume Chazarain, (Sat Apr 19, 11:47 am)
Re: [git pull] scheduler changes for v2.6.26, Ingo Molnar, (Sat Apr 19, 11:49 am)
Re: [git pull] scheduler changes for v2.6.26, Peter Zijlstra, (Sat Apr 19, 11:54 am)
Re: [git pull] scheduler changes for v2.6.26, Frans Pop, (Sat Apr 19, 12:47 pm)
Re: [git pull] scheduler changes for v2.6.26, Ingo Molnar, (Mon Apr 21, 5:39 am)
Re: [git pull] scheduler changes for v2.6.26, Frans Pop, (Mon Apr 21, 9:31 am)
Re: [git pull] scheduler changes for v2.6.26, Ingo Molnar, (Mon Apr 21, 12:43 pm)
Re: [git pull] scheduler changes for v2.6.26, Mike Galbraith, (Tue Apr 22, 1:51 am)
Re: [git pull] scheduler changes for v2.6.26, Ingo Molnar, (Tue Apr 22, 1:59 am)
Re: [git pull] scheduler changes for v2.6.26, Kevin Winchester, (Tue Apr 22, 2:41 am)
Re: [git pull] scheduler changes for v2.6.26, Peter Zijlstra, (Tue Apr 22, 2:59 am)
Re: [git pull] scheduler changes for v2.6.26, David Miller, (Tue Apr 22, 3:49 am)
Re: [git pull] scheduler changes for v2.6.26, Peter Zijlstra, (Tue Apr 22, 4:10 am)
Re: [git pull] scheduler changes for v2.6.26, Mike Galbraith, (Tue Apr 22, 5:25 am)
Re: [git pull] scheduler changes for v2.6.26, Mike Galbraith, (Wed Apr 23, 1:11 am)
Re: [git pull] scheduler changes for v2.6.26, Frans Pop, (Wed Apr 23, 2:36 am)
Re: [git pull] scheduler changes for v2.6.26, Peter Zijlstra, (Wed Apr 23, 2:42 am)
Re: [git pull] scheduler changes for v2.6.26, Ingo Molnar, (Wed Apr 23, 2:46 am)
Re: [git pull] scheduler changes for v2.6.26, Mike Galbraith, (Wed Apr 23, 3:30 am)
Re: [git pull] scheduler changes for v2.6.26, Peter Zijlstra, (Wed Apr 23, 4:21 am)
Re: [git pull] scheduler changes for v2.6.26, Mike Galbraith, (Wed Apr 23, 6:27 am)
Re: [git pull] scheduler changes for v2.6.26, Frans Pop, (Wed Apr 23, 6:36 am)
Re: [git pull] scheduler changes for v2.6.26, Frans Pop, (Wed Apr 23, 9:23 am)
Re: [git pull] scheduler changes for v2.6.26, Ingo Molnar, (Tue Apr 29, 5:29 am)
Re: [git pull] scheduler changes for v2.6.26, Steven Rostedt, (Tue Apr 29, 8:28 am)