On Fri, 18 Apr 2008, Alex Dubov wrote: First off, can you please use a mail client which does line breaks at around 78 chars ?That's all fine. Nobody asked for the backend to know about smartmedia on FLASH format details. The MTD NAND FLASH layer does not care about on FLASH data format at all. It provides merily access on the hardware level. I agree that your approach of making the SM/XD layer capable of handling clever and dumb hardware adapters is a good one. The point where I stringly disagree is that your implementation is forcing people with dumb hardware (see drivers/mtd/nand/*) to reimplement the (maybe already) existing drivers in order to make use of the ssfdc format, which will not work with the following real world example: ------------------ | NAND controller |----------| On board NAND | with HW ECC | | |----------| SmartMedia Card ------------------ Having a separate driver infrastructure for clever controllers, which provide only semi raw access to the FLASH chip is fine simply because such controllers do not fit into the MTD layer. Well, you probably do this with an iotctl anyway. So what's preventing you to modify the mtd block layer to handle client private ioctls. Also there is no real requirement to use the mtd block layer at all for that. Putting your layer on top of the raw MTD device is fine IMO. That's the best excuse I ever heard for not improving code which has shortcomings. Thanks, tglx --
| Greg KH | [GIT PATCH] driver core patches against 2.6.24 |
| Bart Van Assche | Integration of SCST in the mainstream Linux kernel |
| Rafael J. Wysocki | 2.6.27-rc4-git1: Reported regressions from 2.6.26 |
| tvrtko.ursulin | Re: [ANNOUNCE] Ramback: faster than a speeding bullet |
git: | |
| Jon Smirl | Huge win, compressing a window of delta runs as a unit |
| David Woodhouse | Re: [kernel.org users] [RFD] On deprecating "git-foo" for builtins |
| Adam Mercer | problem pushing repository |
| Johannes Sixt | [PATCH 01/40] Add compat/regex.[ch] and compat/fnmatch.[ch]. |
| Richard Stallman | Real men don't attack straw men |
| GVG GVG | ssh_exchange_identification: Connection closed by remote host |
| Can E. Acar | Re: Wasting our Freedom |
| Nuno Magalhães | Can't scp, ssh is slow to authenticate. |
| Jim Winstead Jr. | Re: Root Disk/Book Disk Compatibility |
| Peter MacDonald | mounting files (loop patches for 98pl4, alpha) |
| Maurizio Codogno | SLS 0.99.2 mount problems |
| Doug Evans | Re: Stabilizing Linux |
