| From | Subject | Date |
|---|---|---|
| Peter Zijlstra | [PATCH 37/37] Input: mac_hid - add lockdep annotation to ...
The mouse button emulation calls input device methods from an input
device. This causes funny lock nesting which is harmless as each
device has its own locks.
Give the nesting device its own lock classes so that lockdep will not
consider them the same.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
---
drivers/macintosh/mac_hid.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/macintosh/mac_hid.c ...
| Apr 17, 9:25 pm 2008 |
| Michael Hennerich | [PATCH 35/37] Input: bf54x-keys - add infrastructure for ...
Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Bryan Wu <cooloney@kernel.org>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
---
drivers/input/keyboard/bf54x-keys.c | 35 ++++++++++++++++++++++++++++++++---
1 files changed, 32 insertions(+), 3 deletions(-)
diff --git a/drivers/input/keyboard/bf54x-keys.c b/drivers/input/keyboard/bf54x-keys.c
index d87ac33..54ed8e2 100644
--- a/drivers/input/keyboard/bf54x-keys.c
+++ b/drivers/input/keyboard/bf54x-keys.c
@@ ...
| Apr 17, 9:25 pm 2008 |
| Kay Sievers | [PATCH 34/37] Input: add MODULE_ALIAS() to hotpluggable ...
Since 43cc71eed1250755986da4c0f9898f9a635cb3bf, the platform modalias
is prefixed with "platform:". Add MODULE_ALIAS() to the hotpluggable
"input" platform drivers, to re-enable auto loading.
[dbrownell@users.sourceforge.net: more drivers, registration fixes]
Signed-off-by: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
---
drivers/input/keyboard/aaed2000_kbd.c | 4 ++++
...
| Apr 17, 9:24 pm 2008 |
| Roel Kluin | [PATCH 36/37] Input: i8042 - fix incorrect usage of strn ...
Fix incorrect length argument for strncpy and strncat by replacing them with
strlcpy and strlcat
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
---
drivers/input/serio/i8042-x86ia64io.h | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h
index 60931ac..5ece9f5 100644
--- a/drivers/input/serio/i8042-x86ia64io.h
+++ ...
| Apr 17, 9:25 pm 2008 |
| Edward Shishkin | New location of Namesys software
Hi everyone.
I would like to inform that kernel.org administration
kindly provided us space for the following projects:
. reiserfsprogs
. reiser4 patches against vanilla kernels
. reiser4progs
The mentioned projects can be found here:
http://www.kernel.org/pub/linux/kernel/people/edward/
All updates will be announced at reiserfs-devel mailing list.
Thanks,
Edward.
--
| Apr 18, 4:38 pm 2008 |
| Jeff Garzik | [PATCH 05/15] drivers/char: minor irq handler cleanups
- remove always-false tests
- don't overload 'irq' argument, pass data properly via dev_id
- remove pointless casts from void*
- make polled uses of irq handling (where code calls irq handler
directly) more plain, by splitting polled and non-polled irq handling
work. This quite often results in a more-efficient irq handler.
This change's main purpose is to prepare for the patchset in
jgarzik/misc-2.6.git#irq-remove, that explores removal of the
never-used 'irq' argument in each ...
| Apr 18, 4:22 pm 2008 |
| Andrew Morton | Re: [PATCH 01/15] ARM minor irq handler cleanups
On Fri, 18 Apr 2008 19:22:45 -0400 (EDT)
#irq-remove doesn't seem to be included in the #ALL branch which
I'm grabbing?
--
| Apr 18, 4:44 pm 2008 |
| Jeff Garzik | [PATCH 07/15] [SCSI] aha1542: minor irq handler cleanups
- where the 'irq' function argument is known never to be used, rename
it to 'dummy' to make this more obvious
- replace per-irq lookup functions and tables with a direct reference
to data object obtained via 'dev_id' function argument, passed from
request_irq()
This change's main purpose is to prepare for the patchset in
jgarzik/misc-2.6.git#irq-remove, that explores removal of the
never-used 'irq' argument in each interrupt handler.
Signed-off-by: Jeff Garzik ...
| Apr 18, 4:22 pm 2008 |
| David Miller | Re: [PATCH 02/15] [SPARC] minor irq handler cleanups
From: Jeff Garzik <jeff@garzik.org>
Acked-by: David S. Miller <davem@davemloft.net>
--
| Apr 18, 4:33 pm 2008 |
| Jeff Garzik | [PATCH 09/15] [AVR32] remove unused 'irq' argument from ...
This change's main purpose is to prepare for the patchset in
jgarzik/misc-2.6.git#irq-remove, that explores removal of the
never-used 'irq' argument in each interrupt handler.
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
---
arch/avr32/kernel/time.c | 4 ++--
arch/avr32/mach-at32ap/time-tc.c | 2 +-
include/asm-avr32/arch-at32ap/time.h | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/avr32/kernel/time.c b/arch/avr32/kernel/time.c
index ...
| Apr 18, 4:22 pm 2008 |
| Jeff Garzik | [PATCH 13/15] [X86] standard vm86 irq handler
Prefer 'void *dev_id' argument for passing data from request_irq() to
each per-irq handler invocation.
This change's main purpose is to prepare for the patchset in
jgarzik/misc-2.6.git#irq-remove, that explores removal of the
never-used 'irq' argument in each interrupt handler.
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
---
arch/x86/kernel/vm86_32.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kernel/vm86_32.c ...
| Apr 18, 4:23 pm 2008 |
| Jeff Garzik | [PATCH 15/15] [INPUT, PCMCIA] avoid use of 'irq' function arg
NOTE: NOT FOR MERGE, NOT FOR UPSTREAM
Not-signed-off-by: ...
This change's main purpose is to prepare for the patchset in
jgarzik/misc-2.6.git#irq-remove, that explores removal of the
never-used 'irq' argument in each interrupt handler.
---
drivers/input/serio/i8042.c | 23 +++++++++++++----------
drivers/pcmcia/i82365.c | 15 ++++++++++-----
2 files changed, 23 insertions(+), 15 deletions(-)
diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c
index ...
| Apr 18, 4:23 pm 2008 |
| Lennert Buytenhek | Re: [PATCH 01/15] ARM minor irq handler cleanups
What do you mean? I know at least one of two interrupt handlers
in-tree that use their 'irq' arguments.
--
| Apr 18, 4:29 pm 2008 |
| Jeff Garzik | [PATCH 11/15] [RTC] minor irq handler cleanups
- pass rtc_int_flag to rtc_interrupt() via the standard method, dev_id
- where irq handler has been analyzed and shown never to use its
'irq' argument, rename it to 'dummy'
- remove pointless casts from void*
- remove uses of 'irq' function arg where it duplicates information
already stored in driver-private struct
This change's main purpose is to prepare for the patchset in
jgarzik/misc-2.6.git#irq-remove, that explores removal of the
never-used 'irq' argument in each interrupt ...
| Apr 18, 4:23 pm 2008 |
| Jeff Garzik | [PATCH 01/15] ARM minor irq handler cleanups
Avoid confusion by /not/ passing an unused pointer to
arm_rtc_interrupt()
This change's main purpose is to prepare for the patchset in
jgarzik/misc-2.6.git#irq-remove, that explores removal of the
never-used 'irq' argument in each interrupt handler.
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
---
arch/arm/mach-integrator/time.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-integrator/time.c b/arch/arm/mach-integrator/time.c
index ...
| Apr 18, 4:22 pm 2008 |
| Jeff Garzik | [PATCH 03/15] [BLACKFIN] minor irq handler cleanups
- time_sched_init() should use standard irq_handler_t
- sys_timer0_int_handler() should not take 'regs' third argument
- remove pointless cast from void*
This change's main purpose is to prepare for the patchset in
jgarzik/misc-2.6.git#irq-remove, that explores removal of the
never-used 'irq' argument in each interrupt handler.
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
---
arch/blackfin/kernel/time.c | 5 ++---
arch/blackfin/oprofile/timer_int.c | 5 ++---
2 files ...
| Apr 18, 4:22 pm 2008 |
| Jeff Garzik | [PATCH 10/15] [IA64] minor irq handler cleanups
- remove unused 'irq' argument from pfm_do_interrupt_handler()
- remove pointless cast to void*
- add KERN_xxx prefix to printk()
- remove braces around singleton C statement
- in tioce_provider.c, start tioce_dma_consistent() and
tioce_error_intr_handler() function declarations in column 0
This change's main purpose is to prepare for the patchset in
jgarzik/misc-2.6.git#irq-remove, that explores removal of the
never-used 'irq' argument in each interrupt handler.
Signed-off-by: ...
| Apr 18, 4:22 pm 2008 |
| Jeff Garzik | [PATCH 04/15] [PPC] minor irq handler cleanups
- whitespace cleanups
- remove pointless prototype (uses always follow func implementation)
- 'irq' argument is often used purely as a local variable. rename
argument to 'dummy' and define 'irq' as local to make this plain.
- remove pointless casts from void*
This change's main purpose is to prepare for the patchset in
jgarzik/misc-2.6.git#irq-remove, that explores removal of the
never-used 'irq' argument in each interrupt handler.
Signed-off-by: Jeff Garzik ...
| Apr 18, 4:22 pm 2008 |
| Jeff Garzik | [PATCH 06/15] [SCSI] minor irq handler cleanups
- remove pointless casts from void*
- remove needless references to 'irq' function argument, when that
information is already stored somewhere in a driver-private struct.
- where the 'irq' function argument is known never to be used, rename
it to 'dummy' to make this more obvious
- remove always-false tests for dev_id==NULL
- remove always-true tests for 'irq == host_struct->irq'
- replace per-irq lookup functions and tables with a direct reference
to data object obtained via ...
| Apr 18, 4:22 pm 2008 |
| Jeff Garzik | [PATCH 02/15] [SPARC] minor irq handler cleanups
- mark timer_interrupt() static
- sparc_floppy_request_irq() prototype should use irq_handler_t
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
---
arch/sparc/kernel/time.c | 2 +-
include/asm-sparc/floppy.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/sparc/kernel/time.c b/arch/sparc/kernel/time.c
index cfaf22c..53caacb 100644
--- a/arch/sparc/kernel/time.c
+++ b/arch/sparc/kernel/time.c
@@ -105,7 +105,7 @@ __volatile__ unsigned int ...
| Apr 18, 4:22 pm 2008 |
| Jeff Garzik | [PATCH 12/15] [MIPS] pmc-sierra/msp71xx/msp_hwbutton.c: ...
- remove always-true test
- neaten request_irq() indentation
This change's main purpose is to prepare for the patchset in
jgarzik/misc-2.6.git#irq-remove, that explores removal of the
never-used 'irq' argument in each interrupt handler.
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
---
arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c ...
| Apr 18, 4:23 pm 2008 |
| Jeff Garzik | [PATCH 08/15] [ISDN] minor irq handler cleanups
- remove pointless casts from void*
- remove braces around singleton C statements
- remove unused 'intno' argument from rs_interrupt_elsa()
- cs->irq_func() should be defined using standard irq_handler_t
This change's main purpose is to prepare for the patchset in
jgarzik/misc-2.6.git#irq-remove, that explores removal of the
never-used 'irq' argument in each interrupt handler.
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
---
drivers/isdn/hisax/elsa.c | 4 ++--
...
| Apr 18, 4:22 pm 2008 |
| Jeff Garzik | [PATCH 14/15] Canonicalize several irq handlers.
* prefer passing data to irq handler using 'void *dev_id' argument
* remove references to 'irq' function arg that either duplicate
a member of our private struct, or are always [true|false].
* add linux/interrupt.h include where needed
This change's main purpose is to prepare for the patchset in
jgarzik/misc-2.6.git#irq-remove, that explores removal of the
never-used 'irq' argument in each interrupt handler.
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
---
drivers/atm/ambassador.c ...
| Apr 18, 4:23 pm 2008 |
| Andrew Morton | Re: x86: add mp_bus_not_pci bitmap to mpparse_32.c
On Fri, 18 Apr 2008 17:11:28 GMT
Where are all these patches coming from?!?!? Google does (or at least
did) index discuss@x86-64.org so I am out of ideas.
--
| Apr 18, 4:00 pm 2008 |
| Andrew Morton | Re: [for 2.6.26] ISDN cleanups, ok for upstream?
On Fri, 18 Apr 2008 18:53:55 -0400
oops. It seems that I disabled it quite a long time ago. I'll resurrect
That merges cleanly against the small number of isdn patches which are
pending in -mm, so we're OK from that POV.
--
| Apr 18, 4:41 pm 2008 |
| Jeff Garzik | [for 2.6.26] ISDN cleanups, ok for upstream?
OK to send this upstream to Linus?
It's been in various -mm's, though I don't know the current state of
akpm's pull of jgarzik/misc-2.6.git#ALL.
The changes should produce equivalent results, and are strictly internal
cleanups in preparation for the PCI hotplug API conversion patchset,
which exists in branch #isdn-pci.
The 'isdn-cleanups' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git isdn-cleanups
contains the following updates:
...
| Apr 18, 3:53 pm 2008 |
| Andrew Morton | Re: kgdb: fix optional arch functions and probe_kernel_*
On Fri, 18 Apr 2008 17:42:54 GMT
Oh. Well that rather invalidates my earlier comments. It looks like this
change could have been folded, but I understand that this sometimes gets
wearisome and isn't terribly important if
a) the fix doesn't repair build breakage and
b) the fix doesn't fix runtime breakage and
c) the fix fixes code which the git-bisect user won't have enabled in
config anyway.
Still. Do we need the set_fs() in there? __copy_from_user_inatomic() is a
"__" ...
| Apr 18, 3:48 pm 2008 |
| Andrew Morton | Re: x86: improve default idle
On Fri, 18 Apr 2008 17:37:02 GMT
Ingo, what's going on? There is no way that this patch is so obvious that
it doesn't even need a changelog.
Was this ever sent to a mailing list for review? I can't find it, so my
last remaining means of understanding the change does not work.
(And if it _did_ have a changelog, I could at least google for the
changelog's text, but even that tool is frustrated here).
--
| Apr 18, 3:43 pm 2008 |
| Andrew Morton | Re: Introduce down_killable()
On Fri, 18 Apr 2008 17:05:06 GMT
What is the reason for all the noinlines in this file?
Something to do with getting proper wchan output? I guess it doesn't hurt
from a documentation POV, but did you find that it was actually necessary?
IOW: is gcc now capable of secretly inlining functions which are defined
further ahead in the compilation unit?
(did you actually "test" the wchan stuff, btw?)
--
| Apr 18, 3:34 pm 2008 |
| Matthew Wilcox | Re: Introduce down_killable()
Copied from kernel/mutex.c ;-)
The reason is to make sure that __down_interruptible (et al) are
out-of-line from down_interruptible, and that __down_common is inlined
I tested that wchan still produces the right output, yes.
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
--
| Apr 18, 3:55 pm 2008 |
| Andrew Morton | Re: kgdb: allow static kgdbts boot configuration
On Fri, 18 Apr 2008 19:00:57 GMT
I expect that CONFIG_KGDB_TESTS_BOOT_STRING is always defined here. Or if
not, that it is possible to arrange for that with sufficient Kconfig
I dunno. Do we *really* need this feature? I mean, if you want to run the
tests, you provide the boot parameter and that's it. Adding this
Kconfig-time stuff on top seems excessive.
--
| Apr 18, 3:26 pm 2008 |
| Andrew Morton | Re: kgdb: add kgdb internal test suite
On Fri, 18 Apr 2008 19:00:48 GMT
Why 1.5 seconds? Seems like a pointless wats of time - can we use just 1
btw, is the selftest code known to work on any other architectures?
afacit pretty much all of this code could/should be __init, but isn't?
--
| Apr 18, 3:20 pm 2008 |
| Andrew Morton | Re: kgdb: core
On Fri, 18 Apr 2008 17:41:29 GMT
Please just nuke all the interface comments in the header files. They
duplicate the kernedoc comments at the definition site and we don't want to
Well, these are trickier because there is an implementation of this
function within each architecture. So I think that in this case it _does_
make sense to document the function in a common place, and the only common
place is this header file.
So please
a) make this a kerneldoc comment and
b) remove the ...
| Apr 18, 3:09 pm 2008 |
| Christoph Lameter | Re: [PATCH 3/3] slub: add hooks for kmemcheck
It maybe easier to just avoid the #ifdef. The other debug flags also only
The second flags parameter is always 0?
--
| Apr 18, 3:12 pm 2008 |
| Pekka Enberg | Re: [PATCH 3/3] slub: add hooks for kmemcheck
Hi,
Well, I've tried to push for "generic" kmemcheck hooks so that they can
be used by SLAB/SLOB too but Vegard has always talked me out of it. Of
course, I have long forgotten the rationale.
But anyway, slub_kmemcheck.h sounds okay and I wonder if we should put
it in mm/ instead of include/linux/ as it's not supposed to be included
by anyone except SLUB?
And merged by Linus now.
Pekka
--
| Apr 18, 4:21 pm 2008 |
| Vegard Nossum | [PATCH 3/3] slub: add hooks for kmemcheck
From 2948f14a6e869d678429cfd818ca8078907d8092 Mon Sep 17 00:00:00 2001
From: Vegard Nossum <vegard.nossum@gmail.com>
Date: Fri, 4 Apr 2008 00:54:48 +0200
Subject: [PATCH] slub: add hooks for kmemcheck
With kmemcheck enabled, SLUB needs to do this:
1. Request twice as much memory as would normally be needed. The bottom half
of the memory is what the user actually sees and uses; the upper half
contains the so-called shadow memory, which stores the status of each byte
in the bottom ...
| Apr 18, 3:03 pm 2008 |
| Vegard Nossum | Re: [PATCH 3/3] slub: add hooks for kmemcheck
Thank you for your comments.
We set it to zero to allow the compiler to optimize out code if
CONFIG_KMEMCHECK=n. For instance
if (kmemcheck_page_is_tracked(page) && !(s->flags & SLAB_NOTRACK)) {
Will be turned into if(0 && !(s->flags & 0)), which can be completely
optimized away. On the other hand, if SLAB_NOTRACK is non-zero, this
The implementations of these prototypes are in mm/slub_kmemcheck.c.
They are only ever called from slub.c since they represent the
interface between ...
| Apr 18, 3:27 pm 2008 |
| Christoph Lameter | Re: [PATCH 3/3] slub: add hooks for kmemcheck
The compiler will optize it again regardless of SLAB_NOTRACK. if (0 &&
Hmmmm.. Okay that is already dealt with by a patch in Pekka's tree.
--
| Apr 18, 4:06 pm 2008 |
| Vegard Nossum | [PATCH] x86: add hooks for kmemcheck
From e508eccb7a1dd8f4b0fd6056cdeff9ce93dad47c Mon Sep 17 00:00:00 2001
From: Vegard Nossum <vegard.nossum@gmail.com>
Date: Fri, 4 Apr 2008 00:53:23 +0200
Subject: [PATCH] x86: add hooks for kmemcheck
The hooks that we modify are:
- Page fault handler (to handle kmemcheck faults)
- Debug exception handler (to hide pages after single-stepping
the instruction that caused the page fault)
Also redefine memset() to use the optimized version if kmemcheck
is enabled.
Signed-off-by: Vegard ...
| Apr 18, 3:02 pm 2008 |
| Vegard Nossum | [PATCH 1/3] kmemcheck: add the kmemcheck core
Hi,
This is kmemcheck against 2.6.25 as of today. This should be more or less
what's in x86.git, the most notable exception being that x86.git contains the
development history of kmemcheck since v4 or so, while this is the condensed
three-patch set.
This version also contains the removal of the "tracked" page flag.
I post it now for a final review, as requested by Andrew.
Vegard
From 485443a0273edd97b138c01d5fdc4f83ab725969 Mon Sep 17 00:00:00 2001
From: Vegard Nossum ...
| Apr 18, 2:58 pm 2008 |
| Jonathan Lim | Re: [PATCH] Provide u64 version of jiffies_to_usecs() in ...
It's possible that the values used in and returned from jiffies_to_usecs() are
incorrect because of truncation when variables of type u64 are involved. So a
function specific to that type is used instead.
This version implements a correction to jiffies_64_to_usecs() based on feedback
from Randy Dunlap and Roman Zippel.
Diff'd against: linux/kernel/git/torvalds/linux-2.6.git
Signed-off-by: Jonathan Lim <jlim@sgi.com>
--- a/include/linux/jiffies.h Thu Feb 14 18:04:14 PST 2008
+++ ...
| Apr 18, 2:54 pm 2008 |
| Andrew Morton | Re: x86: memtest bootparam
On Fri, 18 Apr 2008 17:17:44 GMT
OK. Did the new memtest feature get documented anywhere, btw? I'm only
These seem pointless. Why not just unconditionally implement memtest=?
All the code for that should be __init anyway so we're hardly saving
anything here.
--
| Apr 18, 2:52 pm 2008 |
| Andrew Morton | Re: x86: memtest bootparam
On Fri, 18 Apr 2008 15:07:46 -0700
Well if there was a single CONFIG_MEMTEST then it would probably be
sufficent to document it all within the Kconfig help for that option.
But there isn't a CONFIG_MEMTEST. It appears that the presence or absence
of the memtest feature is controlled by CONFIG_MEMTEST_BOOTPARAM which
So... such users shouldn't add the memtest= boot parameter?
I'd suggest the following:
- Add a CONFIG_MEMTEST. No other config variable needed.
- Put all the memtest ...
| Apr 18, 4:32 pm 2008 |
| Yinghai Lu | Re: x86: memtest bootparam
On Fri, Apr 18, 2008 at 2:52 PM, Andrew Morton
also
for big box, like 64g above, that will take a while.
YH
--
| Apr 18, 3:07 pm 2008 |
| Alexey Dobriyan | 2.6.25-$SHA1: WARNING: at arch/x86/kernel/genapic_64.c:8 ...
WARNING: at arch/x86/kernel/genapic_64.c:86 read_apic_id+0x78/0x80()
Modules linked in:
Pid: 1, comm: swapper Not tainted 2.6.25-2cca775baecbfede2fec20c99add709232311fe7 #3
Call Trace:
[<ffffffff8023150f>] warn_on_slowpath+0x5f/0x80
[<ffffffff80299e9e>] ? open_namei+0x4e/0x6b0
[<ffffffff804594e5>] ? _spin_unlock_irqrestore+0x65/0x80
[<ffffffff80254105>] ? trace_hardirqs_on+0xd5/0x160
[<ffffffff804594c2>] ? _spin_unlock_irqrestore+0x42/0x80
[<ffffffff8021ed28>] read_apic_id+0x78/0x80
...
| Apr 18, 3:39 pm 2008 |
| Andrew Morton | Re: uaccess: add probe_kernel_write()
On Fri, 18 Apr 2008 18:58:59 GMT
The above comments appear to be kerneldoc but actually aren't. I don't
think there's much point in duplicating the kerneldoc comments in the .h
file as well - people should know by now to go to the definition site to
I think the documentation should point out that this function can probe both
a user address and a kernel address (if that's right, which I think it is).
And just looking at it, I think the set_fs() in probe_kernel_address() was
always ...
| Apr 18, 2:42 pm 2008 |
| Andrew Morton | Re: x86: spinlock ops are always-inlined
On Fri, 18 Apr 2008 18:47:21 GMT
What was the reason for making this change?
--
| Apr 18, 2:31 pm 2008 |
| Andrew Morton | Re: x86: 4kstacks default
On Fri, 18 Apr 2008 17:37:36 GMT
This patch will cause kernels to crash.
It has no changelog which explains or justifies the alteration.
afaict the patch was not posted to the mailing list and was not
discussed or reviewed.
--
| Apr 18, 2:29 pm 2008 |
| David Miller | Re: Make CONFIG_ARP=m under x86_64
Subject typo.
Please fix so people don't think this is a networking patch :-)
--
| Apr 18, 3:05 pm 2008 |
| Jan Engelhardt | Make CONFIG_ARP=m under x86_64
The way it is written, CONFIG_AGP is always y for x86_64 - not so nice
when you want to use nvagp instead which requries agpgart to be
unloadable.
Signed-off-by: Jan Engelhardt <jengelh@computergmbh.de>
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 6c70fed..1b2ce6c 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -429,12 +429,17 @@ config HPET_EMULATE_RTC
def_bool y
depends on HPET_TIMER && (RTC=y || RTC=m || RTC_DRV_CMOS=m || RTC_DRV_CMOS=y)
+config ...
| Apr 18, 2:21 pm 2008 |
| Kay Sievers | Re: [RFC PATCH try2] sysfs: add /sys/dev/{char,block} to ...
Lots of stuff in that file is pretty damn wrong, and at it should
probably just be deleted. Care to put this new documentation into:
If you do:
struct class block_class = {
.name = "block",
.dev_kobj = block_kobj,
}
in:
block/genhd.c
and put:
if (!class->dev_kobj)
class->dev_kobj = char_kobj;
in:
class_register()
we can get rid of all this logic and the BLOCK #ifdef, right?
Also:
class_create(THIS_MODULE, "usb_device");
in:
...
| Apr 18, 1:53 pm 2008 |
| Bjorn Helgaas | [patch 39/53] PNP: make generic pnp_add_irq_resource()
Add a pnp_add_irq_resource() that can be used by all the PNP
backends. This consolidates a little more pnp_resource_table
knowledge into one place.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
---
drivers/pnp/base.h | 3 +++
drivers/pnp/resource.c | 24 ++++++++++++++++++++++++
drivers/pnp/interface.c | 14 ++++++--------
drivers/pnp/isapnp/core.c | 8 +++-----
drivers/pnp/pnpacpi/rsparser.c | 31 +++++++------------------------
...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 53/53] PNP: dont sort by type in /sys/.../resources
Rather than stepping through all IO resources, then stepping through
all MMIO resources, etc. (and traversing the list every time), we
can just iterate over the resource list once directly.
This can change the order in /sys, e.g.,
# cat /sys/devices/pnp0/00:07/resources # OLD
state = active
io 0x3f8-0x3ff
irq 4
# cat /sys/devices/pnp0/00:07/resources # NEW
state = active
irq 4
io 0x3f8-0x3ff
The old code artificially sorted resources by type; ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 52/53] PNP: fill in generic pnp_dev fields earlier
This makes dev_printk() work better because we have a default driver.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Index: work8/drivers/pnp/core.c
===================================================================
--- work8.orig/drivers/pnp/core.c 2008-04-17 15:05:18.000000000 -0600
+++ work8/drivers/pnp/core.c 2008-04-17 17:13:12.000000000 -0600
@@ -132,8 +132,13 @@
INIT_LIST_HEAD(&dev->resources);
dev->protocol = protocol;
dev->number = id;
+ dev->dma_mask = ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 51/53] PNPBIOS: remove include/linux/pnpbios.h
The contents of include/linux/pnpbios.h are used only inside the PNPBIOS
backend, so this file doesn't need to be visible outside PNP.
This patch moves the contents into an existing PNPBIOS-specific file,
drivers/pnp/pnpbios/pnpbios.h.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
---
drivers/pnp/pnpbios/bioscalls.c | 1
drivers/pnp/pnpbios/core.c | 1
drivers/pnp/pnpbios/pnpbios.h | 136 ++++++++++++++++++++++++++++++++++++
drivers/pnp/pnpbios/proc.c | 2
...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 50/53] ISAPNP: remove unused pnp_dev->regs field
The "regs" field in struct pnp_dev is set but never read, so remove it.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Index: work8/drivers/pnp/isapnp/core.c
===================================================================
--- work8.orig/drivers/pnp/isapnp/core.c 2008-04-18 11:15:16.000000000 -0600
+++ work8/drivers/pnp/isapnp/core.c 2008-04-18 11:19:49.000000000 -0600
@@ -416,10 +416,7 @@
if (!dev)
return NULL;
- dev->regs = tmp[4];
dev->card = card;
- if (size > ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 49/53] PNP: make interfaces private to the PNP core
The interfaces for registering protocols, devices, cards,
and resource options should only be used inside the PNP core.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Acked-By: Rene Herman <rene.herman@gmail.com>
---
drivers/pnp/base.h | 24 +++++++++++++++++++++++-
include/linux/pnp.h | 34 ----------------------------------
2 files changed, 23 insertions(+), 35 deletions(-)
Index: ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 40/53] PNP: make generic pnp_add_dma_resource()
Add a pnp_add_dma_resource() that can be used by all the PNP
backends. This consolidates a little more pnp_resource_table
knowledge into one place.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
---
drivers/pnp/base.h | 2 +
drivers/pnp/resource.c | 24 +++++++++++++++++++++++
drivers/pnp/interface.c | 12 +++--------
drivers/pnp/isapnp/core.c | 8 ++-----
drivers/pnp/pnpacpi/rsparser.c | 42 +++++++----------------------------------
...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 47/53] PNPACPI: move _CRS/_PRS warnings closer to ...
Move warnings about _CRS and _PRS problems to the place where we
actually make the ACPI calls. Then we don't have to pass around
acpi_status values any more than necessary.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Index: work8/drivers/pnp/pnpacpi/pnpacpi.h
===================================================================
--- work8.orig/drivers/pnp/pnpacpi/pnpacpi.h 2008-04-17 15:58:17.000000000 -0600
+++ work8/drivers/pnp/pnpacpi/pnpacpi.h 2008-04-17 15:58:22.000000000 -0600
@@ ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 48/53] PNPACPI: remove some pnp_dbg calls
These are turned off by default and don't print much useful information
anyway. Anybody debugging this area will likely need to add his or her
own printks anyway.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Acked-By: Rene Herman <rene.herman@gmail.com>
Index: work8/drivers/pnp/pnpacpi/rsparser.c
===================================================================
--- work8.orig/drivers/pnp/pnpacpi/rsparser.c 2008-04-17 16:13:37.000000000 -0600
+++ ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 45/53] PNP: replace pnp_resource_table with dynam ...
PNP used to have a fixed-size pnp_resource_table for tracking the
resources used by a device. This table often overflowed, so we've
had to increase the table size, which wastes memory because most
devices have very few resources.
This patch replaces the table with a linked list of resources where
the entries are allocated on demand.
This removes messages like these:
pnpacpi: exceeded the max number of IO resources
00:01: too many PORTs (max 40)
References:
...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 46/53] PNP: remove ratelimit on add resource failures
We used to have a fixed-size resource table. If a device had
twenty resources when the table only had space for ten, we didn't
need ten warnings, so we added the ratelimit.
Now that we can dynamically allocate new resources, we should
only get failures if the allocation fails. That should be
rare enough that we don't need to ratelimit the messages.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Index: ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 44/53] PNP: add pnp_resource_type() internal interface
Given a struct resource, this returns the type (IO, MEM, IRQ, DMA).
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Index: work8/drivers/pnp/base.h
===================================================================
--- work8.orig/drivers/pnp/base.h 2008-04-17 14:07:25.000000000 -0600
+++ work8/drivers/pnp/base.h 2008-04-17 14:07:37.000000000 -0600
@@ -18,6 +18,7 @@
int pnp_check_dma(struct pnp_dev * dev, int idx);
void pnp_init_resource(struct resource *res);
+int ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 43/53] ISAPNP: fold isapnp_read_resources() back ...
isapnp_get_resources() does very little besides call
isapnp_read_resources(), so just fold them back together.
Based on a patch by Rene Herman <rene.herman@gmail.com>
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Index: work8/drivers/pnp/isapnp/core.c
===================================================================
--- work8.orig/drivers/pnp/isapnp/core.c 2008-04-18 12:27:43.000000000 -0600
+++ work8/drivers/pnp/isapnp/core.c 2008-04-18 12:32:37.000000000 -0600
@@ -921,61 +921,53 ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 42/53] PNP: make generic pnp_add_mem_resource()
Add a pnp_add_mem_resource() that can be used by all the PNP
backends. This consolidates a little more pnp_resource_table
knowledge into one place.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
---
drivers/pnp/base.h | 3 +++
drivers/pnp/resource.c | 26 ++++++++++++++++++++++++++
drivers/pnp/interface.c | 17 +++++++----------
drivers/pnp/isapnp/core.c | 9 +++------
drivers/pnp/pnpacpi/rsparser.c | 32 ++++++++------------------------
...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 41/53] PNP: make generic pnp_add_io_resource()
Add a pnp_add_io_resource() that can be used by all the PNP
backends. This consolidates a little more pnp_resource_table
knowledge into one place.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
---
drivers/pnp/base.h | 3 +++
drivers/pnp/resource.c | 26 ++++++++++++++++++++++++++
drivers/pnp/interface.c | 18 ++++++++----------
drivers/pnp/isapnp/core.c | 8 +++-----
drivers/pnp/pnpacpi/rsparser.c | 35 ++++++++++-------------------------
...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 38/53] PNP: add pnp_new_resource() to find a new ...
This encapsulates the code to locate a new pnp_resource of the
desired type. Currently this uses the pnp_resource_table, but
it will soon change to find a resource in a linked list.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Index: work8/drivers/pnp/resource.c
===================================================================
--- work8.orig/drivers/pnp/resource.c 2008-04-17 15:04:41.000000000 -0600
+++ work8/drivers/pnp/resource.c 2008-04-18 11:08:33.000000000 -0600
@@ -516,6 ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 25/53] PNP: convert resource accessors to use pnp ...
This removes more direct references to pnp_resource_table.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
---
include/linux/pnp.h | 148 +++++++++++++++++++++++++++++++++++++---------------
1 file changed, 108 insertions(+), 40 deletions(-)
Index: work7/include/linux/pnp.h
===================================================================
--- work7.orig/include/linux/pnp.h 2008-04-02 11:08:02.000000000 -0600
+++ work7/include/linux/pnp.h 2008-04-02 13:02:29.000000000 -0600
@@ ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 30/53] PNP: convert resource initializers to use ...
This removes more direct references to pnp_resource_table.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Index: work8/drivers/pnp/manager.c
===================================================================
--- work8.orig/drivers/pnp/manager.c 2008-04-10 16:50:03.000000000 -0600
+++ work8/drivers/pnp/manager.c 2008-04-10 16:59:08.000000000 -0600
@@ -232,17 +232,17 @@
*/
void pnp_init_resources(struct pnp_dev *dev)
{
- struct pnp_resource_table *table = &dev->res;
- int ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 31/53] PNP: convert encoders to use pnp_get_resou ...
This removes more direct references to pnp_resource_table. This
path is used when telling a device what resources it should use.
This doesn't convert ISAPNP because ISA needs to know the config
register index in addition to the resource itself.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Index: work8/drivers/pnp/pnpacpi/rsparser.c
===================================================================
--- work8.orig/drivers/pnp/pnpacpi/rsparser.c 2008-04-17 14:51:52.000000000 ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 32/53] PNP: remove PNP_MAX_* uses
Remove some PNP_MAX_* uses. The pnp_resource_table isn't
dynamic yet, but with pnp_get_resource(), we can start moving
away from the table size constants.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Acked-By: Rene Herman <rene.herman@gmail.com>
---
drivers/pnp/interface.c | 43 ++++++++++++++++++------------------
drivers/pnp/quirks.c | 13 ++++++-----
drivers/pnp/resource.c | 56 +++++++++++++++++++++++++++---------------------
drivers/pnp/system.c | 21 ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 37/53] PNP: add pnp_resource index for ISAPNP
Save the ISAPNP config register index in the struct pnp_resource.
We need this because it is important to write ISAPNP configuration
back to the same registers we read it from. For example, if we
read valid regions from memory descriptors 0, 1, and 3, we'd
better write them back to the same registers, without compressing
them to descriptors 0, 1, and 2.
This was previously guaranteed by using the index into the
pnp_resource_table array as the ISAPNP config register index.
However, I am ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 35/53] PNP: remove pnp_resource_table references ...
This removes a few more references to the pnp_resource_table.
No functional change.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
---
drivers/pnp/isapnp/core.c | 87 ++++++++++++++++++++--------------------
drivers/pnp/pnpacpi/rsparser.c | 88 ++++++++++++++++++++++-------------------
drivers/pnp/pnpbios/rsparser.c | 82 +++++++++++++++++++++-----------------
3 files changed, 138 insertions(+), 119 deletions(-)
Index: ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 36/53] PNP: add struct pnp_resource
This struct currently contains only a struct resource, but we will
soon need additional PNP-specific information.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
---
drivers/pnp/base.h | 12 ++++++++----
drivers/pnp/isapnp/core.c | 26 ++++++++++++++++++--------
drivers/pnp/pnpacpi/rsparser.c | 8 ++++----
drivers/pnp/pnpbios/rsparser.c | 8 ++++----
drivers/pnp/resource.c | 8 ++++----
5 files changed, 38 insertions(+), 24 deletions(-)
Index: ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 34/53] PNP: make pnp_resource_table private to PNP core
There are no remaining references to the PNP_MAX_* constants or
the pnp_resource_table structure outside of the PNP core. Make
them private to the PNP core.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
---
include/linux/pnp.h | 14 ++------------
drivers/pnp/base.h | 12 ++++++++++++
drivers/pnp/core.c | 8 ++++++++
drivers/pnp/isapnp/core.c | 4 ++--
drivers/pnp/pnpacpi/rsparser.c | 10 ++++++----
drivers/pnp/pnpbios/rsparser.c ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 33/53] rtc: dont reference pnp_resource_table directly
pnp_resource_table is going away soon, so use the more
generic public interfaces instead.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Acked-By: Rene Herman <rene.herman@gmail.com>
Index: work9/drivers/rtc/rtc-cmos.c
===================================================================
--- work9.orig/drivers/rtc/rtc-cmos.c 2008-04-18 12:47:21.000000000 -0600
+++ work9/drivers/rtc/rtc-cmos.c 2008-04-18 12:52:19.000000000 -0600
@@ -854,11 +854,12 @@
* don't define the IRQ. It should ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 29/53] PNP: convert sysfs interface to use pnp_ge ...
This removes more direct references to pnp_resource_table.
Note that this does not allow adding new resources beyond the
preallocated ones, so even though it does not reference
pnp_resource_table directly, it is still limited to the
fixed size of that table. When the preallocation is removed,
we'll have to change this so it can add new resources.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Index: ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 28/53] PNP: convert resource assign functions to ...
This removes more direct references to pnp_resource_table.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Acked-By: Rene Herman <rene.herman@gmail.com>
Index: work8/drivers/pnp/manager.c
===================================================================
--- work8.orig/drivers/pnp/manager.c 2008-04-10 15:20:30.000000000 -0600
+++ work8/drivers/pnp/manager.c 2008-04-10 15:36:06.000000000 -0600
@@ -19,22 +19,24 @@
static int pnp_assign_port(struct pnp_dev *dev, struct pnp_port *rule, ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 21/53] PNP: use dev_printk when possible
Use dev_printk() when possible for more informative error messages.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Acked-By: Rene Herman <rene.herman@gmail.com>
---
drivers/pnp/isapnp/core.c | 38 ++++++++++++++++++--------------------
drivers/pnp/pnpacpi/rsparser.c | 20 ++++++++++++--------
drivers/pnp/pnpbios/rsparser.c | 36 ++++++++++++++----------------------
3 files changed, 44 insertions(+), 50 deletions(-)
Index: ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 22/53] PNP: factor pnp_init_resource_table() and ...
Move the common part of pnp_init_resource_table() and
pnp_clean_resource_table() into a new pnp_init_resource().
This reduces a little code duplication and will be
useful later to initialize an individual resource.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
---
drivers/pnp/base.h | 2 +
drivers/pnp/manager.c | 86 +++++++++++++++++++-------------------------------
2 files changed, 36 insertions(+), 52 deletions(-)
Index: ...
| Apr 18, 1:50 pm 2008 |
| Rene Herman | Re: [patch 22/53] PNP: factor pnp_init_resource_table() ...
... it's not being set.
Rene.
--
| Apr 18, 3:29 pm 2008 |
| Bjorn Helgaas | [patch 27/53] PNP: convert resource checks to use pnp_ge ...
This removes more direct references to pnp_resource_table.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
---
drivers/pnp/resource.c | 96 +++++++++++++++++++++++++++++--------------------
1 file changed, 58 insertions(+), 38 deletions(-)
Index: work8/drivers/pnp/resource.c
===================================================================
--- work8.orig/drivers/pnp/resource.c 2008-04-10 13:59:17.000000000 -0600
+++ work8/drivers/pnp/resource.c 2008-04-10 15:23:34.000000000 ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 20/53] PNP: remove unused interfaces using pnp_re ...
Rene Herman <rene.herman@gmail.com> recently removed the only in-tree
driver uses of:
pnp_init_resource_table()
pnp_manual_config_dev()
pnp_resource_change()
in this change:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=109c53...
These are no longer used in the PNP core either, so we can just remove
them completely.
It's possible that there are out-of-tree drivers that use these
interfaces. They should ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 26/53] PNP: use conventional "i" for loop indices
Cosmetic only: just use "i" instead of "tmp".
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Acked-By: Rene Herman <rene.herman@gmail.com>
Index: work7/drivers/pnp/resource.c
===================================================================
--- work7.orig/drivers/pnp/resource.c 2008-03-24 16:32:00.000000000 -0600
+++ work7/drivers/pnp/resource.c 2008-03-24 16:33:17.000000000 -0600
@@ -215,7 +215,7 @@
int pnp_check_port(struct pnp_dev *dev, int idx)
{
- int tmp;
+ int i;
...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 18/53] PNP: add pnp_init_resources(struct pnp_dev ...
Add pnp_init_resources(struct pnp_dev *) to replace
pnp_init_resource_table(), which takes a pointer to the
pnp_resource_table itself. Passing only the pnp_dev * reduces
the possibility for error in the caller and removes the
pnp_resource_table implementation detail from the interface.
Even though pnp_init_resource_table() is exported, I did not
export pnp_init_resources() because it is used only by the PNP
core.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Acked-By: Rene Herman ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 17/53] PNP: remove more pnp_resource_table arguments
Stop passing around struct pnp_resource_table pointers. In most cases,
the caller doesn't need to know how the resources are stored inside
the struct pnp_dev.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Acked-By: Rene Herman <rene.herman@gmail.com>
---
drivers/pnp/isapnp/core.c | 6 ++--
drivers/pnp/pnpacpi/core.c | 11 ++-----
drivers/pnp/pnpacpi/pnpacpi.h | 6 ++--
drivers/pnp/pnpacpi/rsparser.c | 55 +++++++++++++++++++++-----------------
...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 19/53] PNP: remove pnp_resource_table from intern ...
This changes pnp_clean_resource_table() to take a pnp_dev pointer
rather than a pnp_resource_table pointer. This reduces the visibility
of pnp_resource_table and removes an opportunity for error in the
caller.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Acked-By: Rene Herman <rene.herman@gmail.com>
Index: work7/drivers/pnp/manager.c
===================================================================
--- work7.orig/drivers/pnp/manager.c 2008-03-25 11:03:59.000000000 -0600
+++ ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 12/53] PNPACPI: use temporaries to reduce repetition
No functional change, just fewer words and fewer chances for
transcription errors.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Acked-By: Rene Herman <rene.herman@gmail.com>
Index: work7/drivers/pnp/pnpacpi/rsparser.c
===================================================================
--- work7.orig/drivers/pnp/pnpacpi/rsparser.c 2008-03-20 12:07:31.000000000 -0600
+++ work7/drivers/pnp/pnpacpi/rsparser.c 2008-03-20 12:14:54.000000000 -0600
@@ -278,6 +278,14 @@
void ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 24/53] PNP: remove pnp_mem_flags() as an lvalue
A future change will change pnp_mem_flags() from a "#define that
simplifies to an lvalue" to "an inline function that returns the
flags value."
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Index: work7/drivers/pnp/quirks.c
===================================================================
--- work7.orig/drivers/pnp/quirks.c 2008-04-02 13:08:09.000000000 -0600
+++ work7/drivers/pnp/quirks.c 2008-04-02 13:10:34.000000000 -0600
@@ -114,6 +114,7 @@
static void ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 13/53] PNPACPI: hoist dma_flags() out of pnpacpi_ ...
Hoist dma_flags() out of pnpacpi_parse_allocated_dmaresource() into its
caller. This makes pnpacpi_parse_allocated_dmaresource() more similar
to pnpbios_parse_allocated_dmaresource().
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Acked-By: Rene Herman <rene.herman@gmail.com>
Index: work7/drivers/pnp/pnpacpi/rsparser.c
===================================================================
--- work7.orig/drivers/pnp/pnpacpi/rsparser.c 2008-03-21 15:08:36.000000000 -0600
+++ ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 10/53] PNP: add pnp_alloc_card()
Add pnp_alloc_card() to allocate a struct pnp_card and fill in the
protocol, instance number, and initial PNP ID. Now it is always
valid to use dev_printk() on any pnp_card pointer.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Acked-By: Rene Herman <rene.herman@gmail.com>
---
drivers/pnp/base.h | 1 +
drivers/pnp/card.c | 28 +++++++++++++++++++++++++---
drivers/pnp/isapnp/core.c | 11 ++++-------
3 files changed, 30 insertions(+), 10 deletions(-)
Index: ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 23/53] PNP: add pnp_get_resource() interface
This adds a pnp_get_resource() that works the same way as
platform_get_resource(). This will enable us to consolidate
many pnp_resource_table references in one place, which will
make it easier to make the table dynamic.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Acked-By: Rene Herman <rene.herman@gmail.com>
---
drivers/pnp/resource.c | 27 +++++++++++++++++++++++++++
include/linux/pnp.h | 1 +
2 files changed, 28 insertions(+)
Index: ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 11/53] PNPACPI: pnpacpi_encode_ext_irq() wrongly ...
pnpacpi_encode_ext_irq() should set resource->data.extended_irq, not
resource->data.irq.
This has been wrong since at least 2.6.12. I haven't seen any bug
reports, but it's clearly incorrect.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Index: work8/drivers/pnp/pnpacpi/rsparser.c
===================================================================
--- work8.orig/drivers/pnp/pnpacpi/rsparser.c 2008-04-10 12:26:08.000000000 -0600
+++ work8/drivers/pnp/pnpacpi/rsparser.c 2008-04-10 ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 16/53] PNP: remove pnp_resource_table from intern ...
When we call protocol->get() and protocol->set() methods, we currently
supply pointers to both the pnp_dev and the pnp_resource_table even
though the pnp_resource_table should always be the one associated with
the pnp_dev.
This removes the pnp_resource_table arguments to make it clear that
these methods only operate on the specified pnp_dev.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Acked-By: Rene Herman <rene.herman@gmail.com>
---
include/linux/pnp.h | 4 ++--
...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 14/53] PNPACPI: extend irq_flags() to set IORESOU ...
This simplifies IRQ resource parsing slightly by computing all the
IORESOURCE_IRQ_* flags at the same time.
This also keeps track of shareability information when parsing options
from _PRS. Previously we ignored shareability in _PRS.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Acked-By: Rene Herman <rene.herman@gmail.com>
Index: work7/drivers/pnp/pnpacpi/rsparser.c
===================================================================
--- ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 15/53] PNPACPI: pass pnp_dev instead of acpi_handle
Pass the pnp_dev pointer when possible instead of the acpi_handle.
This allows better error messages and reduces the chance of error
in the caller.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Acked-By: Rene Herman <rene.herman@gmail.com>
Index: work7/drivers/pnp/pnpacpi/core.c
===================================================================
--- work7.orig/drivers/pnp/pnpacpi/core.c 2008-03-21 15:35:05.000000000 -0600
+++ work7/drivers/pnp/pnpacpi/core.c 2008-03-21 ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 04/53] PNP: change pnp_add_id() to allocate its o ...
This moves some of the pnp_id knowledge out of the backends and into
the PNP core.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Acked-By: Rene Herman <rene.herman@gmail.com>
---
drivers/pnp/base.h | 2 +-
drivers/pnp/driver.c | 28 +++++++++++++++++++++-------
drivers/pnp/isapnp/core.c | 24 +++++++++++-------------
drivers/pnp/pnpacpi/core.c | 27 +++------------------------
drivers/pnp/pnpbios/core.c | 10 +---------
...
| Apr 18, 1:49 pm 2008 |
| Bjorn Helgaas | [patch 08/53] PNP: change pnp_add_card_id() to allocate ...
This moves some of the pnp_id knowledge out of the backends and into
the PNP core.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Acked-By: Rene Herman <rene.herman@gmail.com>
Index: work7/drivers/pnp/base.h
===================================================================
--- work7.orig/drivers/pnp/base.h 2008-04-02 15:19:07.000000000 -0600
+++ work7/drivers/pnp/base.h 2008-04-02 15:19:10.000000000 -0600
@@ -4,7 +4,7 @@
void pnp_eisa_id_to_string(u32 id, char *str);
struct ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 03/53] PNP: make pnp_add_id() internal to PNP core
pnp_add_id() doesn't need to be exposed outside the PNP core, so
move the declaration to an internal header file.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Acked-By: Rene Herman <rene.herman@gmail.com>
Index: work7/include/linux/pnp.h
===================================================================
--- work7.orig/include/linux/pnp.h 2008-03-21 13:31:06.000000000 -0600
+++ work7/include/linux/pnp.h 2008-03-21 13:31:08.000000000 -0600
@@ -403,7 +403,6 @@
/* protocol helpers */
...
| Apr 18, 1:49 pm 2008 |
| Bjorn Helgaas | [patch 05/53] PNP: add pnp_eisa_id_to_string()
Converting the EISA ID to a string is messy and error-prone, and
we might as well use the same code for ISAPNP and PNPBIOS.
PNPACPI uses the conversion done by the ACPI core with
acpi_ex_eisa_id_to_string().
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
---
drivers/pnp/base.h | 2 ++
drivers/pnp/isapnp/core.c | 32 +++++++++++---------------------
drivers/pnp/pnpbios/core.c | 2 +-
drivers/pnp/pnpbios/rsparser.c | 26 +++-----------------------
...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 06/53] PNP: add pnp_alloc_dev()
Add pnp_alloc_dev() to allocate a struct pnp_dev and fill in the
protocol, instance number, and initial PNP ID. Now it is always
valid to use dev_printk() on any pnp_dev pointer.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Acked-By: Rene Herman <rene.herman@gmail.com>
---
drivers/pnp/base.h | 1 +
drivers/pnp/core.c | 28 +++++++++++++++++++++++++---
drivers/pnp/isapnp/core.c | 11 +++++------
drivers/pnp/pnpacpi/core.c | 19 +++----------------
...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 09/53] ISAPNP: pull pnp_add_card_id() out of isap ...
Split the pnp_add_card_id() part from the PNPID conversion part so we
can move the initial add_id() into the pnp_card allocation.
This makes the PNPID conversion generic so we can use the same
one for both devices and cards.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Acked-By: Rene Herman <rene.herman@gmail.com>
Index: work7/drivers/pnp/isapnp/core.c
===================================================================
--- work7.orig/drivers/pnp/isapnp/core.c 2008-04-02 ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 07/53] PNP: make pnp_add_card_id() internal to PNP core
pnp_add_card_id() doesn't need to be exposed outside the PNP core, so
move the declaration to an internal header file.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Acked-By: Rene Herman <rene.herman@gmail.com>
Index: work7/drivers/pnp/base.h
===================================================================
--- work7.orig/drivers/pnp/base.h 2008-04-02 15:17:49.000000000 -0600
+++ work7/drivers/pnp/base.h 2008-04-02 15:19:07.000000000 -0600
@@ -4,6 +4,7 @@
void ...
| Apr 18, 1:50 pm 2008 |
| Bjorn Helgaas | [patch 02/53] PNPACPI: continue after _CRS and _PRS errors
Keep going and register the device even if we have trouble parsing
_CRS or _PRS. A parsing problem might mean we ignore some resources
the device is using, or we might not be able to change its resources.
But we should still take note of anything we *could* parse correctly.
Also remove reference to dev_id because I plan to remove it soon.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Index: ...
| Apr 18, 1:49 pm 2008 |
| Bjorn Helgaas | [patch 01/53] ISAPNP: move config register addresses out ...
These are used only in drivers/pnp/isapnp/core.c, so no need to
expose them to the world.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Acked-By: Rene Herman <rene.herman@gmail.com>
Index: work7/drivers/pnp/isapnp/core.c
===================================================================
--- work7.orig/drivers/pnp/isapnp/core.c 2008-03-21 11:52:12.000000000 -0600
+++ work7/drivers/pnp/isapnp/core.c 2008-03-21 11:53:24.000000000 -0600
@@ -88,6 +88,14 @@
#define _LTAG_MEM32RANGE 0x85
...
| Apr 18, 1:49 pm 2008 |
| Bjorn Helgaas | [patch 00/53] PNP cleanup and convert to dynamic resources, v3
This finally replaces the fixed-size pnp_resource_table
with something more dynamic so we can quit worrying about
table overflows.
Most of the patches here just lead up to the dynamic
resources patch by incrementally cleaning things up
and reducing the amount of code that knows about the
pnp_resource_table.
There are a *lot* of changes from v2, mostly to fix the
ISAPNP problem Rene pointed out (we need to track the
config register index so we write things back to the
same register we read ...
| Apr 18, 1:49 pm 2008 |
| Chuck Ebbert | Huge lockdep trace then system freeze after docking laptop
https://bugzilla.redhat.com/show_bug.cgi?id=441622
... on a Thinkpad X41T when docking a running laptop.
======================================================
[ INFO: hard-safe -> hard-unsafe lock order detected ]
2.6.25-0.195.rc8.git1.fc9.i686 #1
------------------------------------------------------
kacpi_notify/64 [HC0[0]:SC0[0]:HE0:SE1] is trying to acquire:
(sequence_lock){--..}, at: [kobject_uevent_env+379/867]
kobject_uevent_env+0x17b/0x363
and this task is already holding:
...
| Apr 18, 1:22 pm 2008 |
| Steven Rostedt | [PATCH 4/5] ftrace: limit trace entries
Currently there is no protection from the root user to use up all of
memory for trace buffers. If the root user allocates too many entries,
the OOM killer might start kill off all tasks.
This patch adds an algorith to check the following condition:
pages_requested > (freeable_memory + current_trace_buffer_pages) / 4
If the above is met then the allocation fails. The above prevents more
than 1/4th of freeable memory from being used by trace buffers.
To determine the freeable_memory, I ...
| Apr 18, 1:05 pm 2008 |
| Andrew Morton | Re: [PATCH 4/5] ftrace: limit trace entries
On Fri, 18 Apr 2008 16:05:42 -0400
tpyo
--
| Apr 18, 1:19 pm 2008 |
| Steven Rostedt | [PATCH 5/5] ftrace: comment code
This is first installment of adding documentation to the ftrace.
Expect many more patches of this kind in the near future.
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
---
kernel/trace/trace.c | 135 ++++++++++++++++++++++++++++++++++++++++++++++++++-
kernel/trace/trace.h | 7 ++
2 files changed, 141 insertions(+), 1 deletion(-)
Index: linux-sched-devel.git/kernel/trace/trace.c
===================================================================
--- ...
| Apr 18, 1:05 pm 2008 |
| Steven Rostedt | [PATCH 3/5] ftrace: modulize the number of CPU buffers
Currently ftrace allocates a trace buffer for every possible CPU.
Work is being done to change it to only online CPUs and add hooks
to hotplug CPUS.
This patch lays out the infrastructer for such a change.
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
---
kernel/trace/trace.c | 38 ++++++++++++++++++++++++--------------
1 file changed, 24 insertions(+), 14 deletions(-)
Index: ...
| Apr 18, 1:05 pm 2008 |
| Steven Rostedt | [PATCH 0/5] ftrace update patches
This patch series contains various fixes, clean ups and commenting that
I've been doing today on ftrace. I need to go off and do other things
right now, but I wanted these to get out before the weekend.
-- Steve
--
| Apr 18, 1:05 pm 2008 |
| Steven Rostedt | [PATCH 2/5] ftrace: replace simple_strtoul with strict_strtoul
Andrew Morton suggested using strict_strtoul over simple_strtoul.
This patch replaces them in ftrace.
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
---
kernel/trace/trace.c | 28 ++++++++++++++++++++++------
1 file changed, 22 insertions(+), 6 deletions(-)
Index: linux-sched-devel.git/kernel/trace/trace.c
===================================================================
--- linux-sched-devel.git.orig/kernel/trace/trace.c 2008-04-18 15:47:40.000000000 -0400
+++ ...
| Apr 18, 1:05 pm 2008 |
| Andrew Morton | Re: [PATCH 1/5] ftrace: simple clean ups
On Fri, 18 Apr 2008 16:05:39 -0400
This becomes a cant-happen (I think).
--
| Apr 18, 1:15 pm 2008 |
| Steven Rostedt | [PATCH 1/5] ftrace: simple clean ups
Andrew Morton mentioned some clean ups that should be done to ftrace.
This patch does some of the simple clean ups.
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
---
kernel/trace/trace.c | 25 ++++++++++++-------------
1 file changed, 12 insertions(+), 13 deletions(-)
Index: linux-sched-devel.git/kernel/trace/trace.c
===================================================================
--- linux-sched-devel.git.orig/kernel/trace/trace.c 2008-04-18 15:47:22.000000000 -0400
+++ ...
| Apr 18, 1:05 pm 2008 |
| Chuck Ebbert | 2.6.25 booting under VMware: "WARNING: strange, CPU MTRR ...
Code was added to suppress this warning under kvm
(4147c8747eace9058c606b35e700060297edaf91) but vmware still
causes the warning.
--
| Apr 18, 1:02 pm 2008 |
| Roland McGrath | Re: [PATCH] x86: prevent unconditional writes to DebugCtl MSR
I don't think this was a good idea:
commit 5b0e508415a83989fe704b4718a1a214bc333ca7
Author: Jan Beulich <jbeulich@novell.com>
Date: Mon Mar 10 13:11:17 2008 +0000
x86: prevent unconditional writes to DebugCtl MSR
It's already a bug if there is any unconditional use of the MSR.
Silenting ignoring it is just wrong.
There was such a bug before this fix:
commit 4ba51fd75cc3789be83f0d6f878dabbb0cb19bca
Author: Roland McGrath <roland@redhat.com>
Date: Thu Apr 3 14:18:55 2008 ...
| Apr 18, 12:43 pm 2008 |
| Harvey Harrison | [PATCH] kgdb: fix signedness mixmatches, add statics, ad ...
Noticed by sparse:
arch/x86/kernel/kgdb.c:556:15: warning: symbol 'kgdb_arch_pc' was not declared. Should it be static?
kernel/kgdb.c:149:8: warning: symbol 'kgdb_do_roundup' was not declared. Should it be static?
kernel/kgdb.c:193:22: warning: symbol 'kgdb_arch_pc' was not declared. Should it be static?
kernel/kgdb.c:712:5: warning: symbol 'remove_all_break' was not declared. Should it be static?
Related to kgdb_hex2long:
arch/x86/kernel/kgdb.c:371:28: warning: incorrect type in argument 2 ...
| Apr 18, 11:51 am 2008 |
| Harvey Harrison | [PATCH] kgdb: trivial sparse fixes in kgdb test-suite
Shadowed variable and integer as NULL pointer fixes:
drivers/misc/kgdbts.c:877:6: warning: symbol 'sys_open_test' shadows an earlier one
drivers/misc/kgdbts.c:537:27: originally declared here
drivers/misc/kgdbts.c:378:22: warning: Using plain integer as NULL pointer
drivers/misc/kgdbts.c:386:22: warning: Using plain integer as NULL pointer
drivers/misc/kgdbts.c:468:30: warning: Using plain integer as NULL pointer
drivers/misc/kgdbts.c:472:15: warning: Using plain integer as NULL ...
| Apr 18, 11:31 am 2008 |
| Miles Lane | 2.6.25-mm1 -- WARNING: at fs/sysfs/dir.c:427 sysfs_add_o ...
[ 5.097022] WARNING: at fs/sysfs/dir.c:427 sysfs_add_one+0x33/0x9a()
[ 5.097026] Modules linked in: floppy ohci1394(+) ieee1394
pata_amd(+) 3c59x(+) mii libata ehci_hcd(+) ohci_hcd(+) forcedeth
usbcore ssb thermal processor fan fuse
[ 5.097051] Pid: 1112, comm: modprobe Not tainted 2.6.25-mm1 #7
[ 5.097057] [<c012883a>] warn_on_slowpath+0x41/0x67
[ 5.097354] [<c0128919>] ? test_ti_thread_flag+0xf/0x11
[ 5.097363] [<c01292c7>] ? vprintk+0x3ab/0x3c2
[ 5.097379] ...
| Apr 18, 11:24 am 2008 |
| David Teigland | [PATCH 2/6] dlm: make dlm_print_rsb() static
From: Adrian Bunk <bunk@kernel.org>
dlm_print_rsb() can now become static.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: David Teigland <teigland@redhat.com>
---
fs/dlm/lock.c | 2 +-
fs/dlm/lock.h | 1 -
2 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
index 8f250ac..1e9e8eb 100644
--- a/fs/dlm/lock.c
+++ b/fs/dlm/lock.c
@@ -165,7 +165,7 @@ void dlm_print_lkb(struct dlm_lkb *lkb)
lkb->lkb_grmode, ...
| Apr 18, 11:12 am 2008 |
| David Teigland | [PATCH 1/6] dlm: match signedness between dlm_config_inf ...
From: Harvey Harrison <harvey.harrison@gmail.com>
cluster_set is only called from the macro CLUSTER_ATTR which defines read/write
access functions. Make the signedness match to avoid sparse warnings every time
CLUSTER_ATTR is used (lines 149-159) all of the form:
fs/dlm/config.c:149:1: warning: incorrect type in argument 3 (different signedness)
fs/dlm/config.c:149:1: expected unsigned int *info_field
fs/dlm/config.c:149:1: got int extern [toplevel] *<noident>
Signed-off-by: Harvey ...
| Apr 18, 11:12 am 2008 |
| David Teigland | [PATCH 5/6] dlm: move plock code from gfs2
Move the code that handles cluster posix locks from gfs2 into the dlm
so that it can be used by both gfs2 and ocfs2.
Signed-off-by: David Teigland <teigland@redhat.com>
---
fs/dlm/Makefile | 1 +
fs/dlm/dlm_internal.h | 2 +
fs/dlm/main.c | 7 +
fs/dlm/plock.c | 439 ++++++++++++++++++++++++++++++++++++++++
fs/gfs2/locking/dlm/Makefile | 2 +-
fs/gfs2/locking/dlm/lock_dlm.h | 11 +-
fs/gfs2/locking/dlm/main.c | ...
| Apr 18, 11:12 am 2008 |
| David Teigland | [PATCH 6/6] dlm: common max length definitions
Add central definitions for max lockspace name length and max resource
name length. The lack of central definitions has resulted in scattered
private definitions which we can now clean up, including an unused one
in dlm_device.h.
Signed-off-by: David Teigland <teigland@redhat.com>
---
fs/dlm/dlm_internal.h | 2 --
include/linux/dlm.h | 4 ----
include/linux/dlm_device.h | 3 ---
include/linux/dlmconstants.h | 4 ++++
4 files changed, 4 insertions(+), 9 ...
| Apr 18, 11:12 am 2008 |
| David Teigland | [PATCH 3/6] dlm: save master info after failed no-queue ...
When a NOQUEUE request fails, the rsb res_master field is unnecessarily
reset to -1, instead of leaving the valid master setting in place. We
want to save the looked-up master values while the rsb is on the "toss
list" so that another lookup can be avoided if the rsb is soon reused.
The fix is to simply leave res_master value alone.
Signed-off-by: David Teigland <teigland@redhat.com>
---
fs/dlm/lock.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/fs/dlm/lock.c ...
| Apr 18, 11:12 am 2008 |
| David Teigland | [PATCH 0/6] dlm patches for 2.6.26
Hi,
These are the pending dlm patches for the 2.6.26 merge. They have all been
in linux-next and -mm for some time. The only really notable patch is the
one that moves gfs2's posix lock handling into the dlm so that it can be
shared by both gfs2 and ocfs2. The plock code isn't technically related to
the dlm, but it seems like a sensible common place for both gfs2 and ocfs2 to
get to it. It can also take advantage of the userspace cluster pieces
already in place for the dlm instead of ...
| Apr 18, 11:12 am 2008 |
| David Teigland | [PATCH 4/6] dlm: recover nodes that are removed and re-added
If a node is removed from a lockspace, and then added back before the
dlm is notified of the removal, the dlm will not detect the removal
and won't clear the old state from the node. This is fixed by using a
list of added nodes so the membership recovery can detect when a newly
added node is already in the member list.
Signed-off-by: David Teigland <teigland@redhat.com>
---
fs/dlm/config.c | 48 +++++++++++++++++++++++++++++++++++++++---------
fs/dlm/config.h | 3 ++-
...
| Apr 18, 11:12 am 2008 |
| James Bottomley | [GIT PATCH] SCSI updates for 2.6.25
This is the first piece of our merge for the merge window. I have a bit
of other stuff with dependent patches, and I'm sure there will be
something else crawling out of the woodwork.
It's the usual grab bag of driver updates and mid-layer changes.
There's no new stand out features in this one.
The patch is available here:
master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6.git
The short change log is:
Adrian Bunk (5):
qla1280: remove version check
...
| Apr 18, 10:41 am 2008 |
| Stefan Richter | [GIT PULL] FireWire updates post 2.6.25
Linus, please pull from the for-linus branch at
git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6.git for-linus
to receive the following IEEE 1394/ FireWire subsystem updates.
In the queue, as reported on April 2:
- raw1394, video1394, dv1394: [improvement] These drivers are no
longer bound to unit directory devices. This has always been
unnecessary and got in the way of more specialized out-of-tree
drivers.
- firewire-core: [fix] Recognize changes ...
| Apr 18, 10:40 am 2008 |
| Mark Fasheh | [git patches] Ocfs2 updates for 2.6.26-rc1
Hi Linus,
This is the Ocfs2 patchset for 2.6.26-rc1. The vast majority of
these patches were e-mailed to LKML a couple weeks ago for comment. For
convenience, I've placed my original description of these changes in this
e-mail, after the shortlog.
Please pull from 'upstream-linus' branch of
git://git.kernel.org/pub/scm/linux/kernel/git/mfasheh/ocfs2.git upstream-linus
to receive the following updates:
Documentation/ABI/obsolete/o2cb | 11 +
Documentation/ABI/stable/o2cb ...
| Apr 18, 10:04 am 2008 |
| Steven Whitehouse | [GFS2] Pull request
Hi,
Please consider pulling the following patches. The tree is almost
unchanged from the patch posting with the exception of the addition of
Roel's patch to fix a calculation in the logging code. Once these
patches go in, I'll look into creating a follow-up patch as suggested by
Christoph.
There are no changes outside of the GFS2 code in this patch set,
Steve.
The following changes since commit 4a72ef9f7ad36ea0fb3b42f31b2b0c5b9871969a:
Linus Torvalds (1):
Merge branch ...
| Apr 18, 9:53 am 2008 |
| Cyrill Gorcunov | Re: [PATCH] x86: kgdb build fix
[Harvey Harrison - Fri, Apr 18, 2008 at 09:54:38AM -0700]
| TF_MASK is no longer defined, use X86_EFLAGS_TF.
|
| Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
| ---
| In current -linus tree.
|
| arch/x86/kernel/kgdb.c | 4 ++--
| 1 files changed, 2 insertions(+), 2 deletions(-)
|
| diff --git a/arch/x86/kernel/kgdb.c b/arch/x86/kernel/kgdb.c
| index 8c7e555..24362ec 100644
| --- a/arch/x86/kernel/kgdb.c
| +++ b/arch/x86/kernel/kgdb.c
| @@ -375,12 +375,12 @@ int ...
| Apr 18, 10:57 am 2008 |
| Harvey Harrison | [PATCH] x86: kgdb build fix
TF_MASK is no longer defined, use X86_EFLAGS_TF.
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
In current -linus tree.
arch/x86/kernel/kgdb.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/kgdb.c b/arch/x86/kernel/kgdb.c
index 8c7e555..24362ec 100644
--- a/arch/x86/kernel/kgdb.c
+++ b/arch/x86/kernel/kgdb.c
@@ -375,12 +375,12 @@ int kgdb_arch_handle_exception(int e_vector, int signo, int err_code,
newPC = linux_regs->ip;
...
| Apr 18, 9:54 am 2008 |
| Cyrill Gorcunov | Re: [PATCH] x86: kgdb build fix
[Harvey Harrison - Fri, Apr 18, 2008 at 09:54:38AM -0700]
| TF_MASK is no longer defined, use X86_EFLAGS_TF.
|
| Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
| ---
| In current -linus tree.
|
| arch/x86/kernel/kgdb.c | 4 ++--
| 1 files changed, 2 insertions(+), 2 deletions(-)
|
| diff --git a/arch/x86/kernel/kgdb.c b/arch/x86/kernel/kgdb.c
| index 8c7e555..24362ec 100644
| --- a/arch/x86/kernel/kgdb.c
| +++ b/arch/x86/kernel/kgdb.c
| @@ -375,12 +375,12 @@ int ...
| Apr 18, 10:51 am 2008 |
| Ingo Molnar | Re: [PATCH] x86: kgdb build fix
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
--
| Apr 18, 2:33 pm 2008 |
| Gene Heskett | Recompiling 2.6.25 fails several ways.
Greetings; New thread.
First, my makeit script bails out at the make clean stage:
xargs: xargs.c:445: main: Assertion `bc_ctl.arg_max <= (131072-2048)' failed.
/bin/sh: line 4: 2161 Broken pipe find . \( -name SCCS -o -name BitKeeper -o -name .svn -o -name
CVS -o -name .pc -o -name .hg -o -name .git \) -prune -o \( -name '*.
[oas]' -o -name '*.ko' -o -name '.*.cmd' -o -name '.*.d' -o -name '.*.tmp' -o -name '*.mod.c' -o -name '*.symtypes' -o -name 'modules.order'
\) -type f ...
| Apr 18, 9:39 am 2008 |
| Timur Tabi | [PATCH] Add Timur Tabi to the MAINTAINERS file
Add Timur TAbi as the maintainer for the Freescale QE library, the Freescale
QE UART device driver, the Freescale SOC sound drivers, and the Crystal
Semiconductor CS4270 device driver.
Signed-off-by: Timur Tabi <timur@freescale.com>
---
This patch is for 2.6.26.
MAINTAINERS | 25 +++++++++++++++++++++++++
1 files changed, 25 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 90dcbbc..7a8bc0a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1104,6 +1104,12 @@ ...
| Apr 18, 9:33 am 2008 |
| Ben Hutchings | [PATCH][RFC] Add default CPU topology information (try #2)
Not all architectures and configurations define CPU topology information.
This can result in an empty topology directory in sysfs, and requires
in-kernel users to protect all uses with #ifdef - see
<http://marc.info/?l=linux-netdev&m=120639033904472&w=2>.
The documentation of CPU topology specifies what the defaults should be
if only partial information is available from the hardware. So we can
provide these defaults as a fallback.
This patch:
- Adds default definitions of the 4 topology ...
| Apr 18, 9:11 am 2008 |
| Michael Kerrisk | Re: [PATCH] Removal of FUTEX_FD (and related code)
Hey Rusty,
[...]
Please CC me on API changes...
Cheers,
Michael
--
| Apr 18, 11:24 am 2008 |
| Rusty Russell | [PATCH] Removal of FUTEX_FD (and related code)
From: Eric Sesterhenn <snakebyte@gmx.de>
Date: Fri, 25 Jan 2008 10:40:46 +0100
hi,
since FUTEX_FD was scheduled for removal in June 2007 lets remove it.
Google Code search found no users for it and NGPT was abandoned in 2003
according to IBM. futex.h is left untouched to make sure the id does
not get reassigned. Since queue_me() has no users left it is commented
out to avoid a warning, i didnt remove it completely since it is part
of the internal api (matching unqueue_me())
Signed-off-by: ...
| Apr 18, 9:07 am 2008 |
| Michael Kerrisk | core_pattern pipe documentation
Andi,
I wrote the following description of the core_pattern pipe feature. Does this
seem okay?
Piping core dumps to a program
Since kernel 2.6.19, Linux supports an alternate syntax
for the /proc/sys/kernel/core_pattern file. If the first
character of this file is a pipe symbol (|), then the
remainder of the line is interpreted as a program to be
executed. Instead of being written to a disk file, the
core dump is given as ...
| Apr 18, 9:53 am 2008 |
| Linus Torvalds | Re: Linux 2.6.25
Can you bisect it?
Linus
--
| Apr 18, 8:43 am 2008 |
| Gene Heskett | Re: Linux 2.6.25
Amen on that. And to add confusion here, my makeit script started dying when
I do a remake after changing a config option, cuz it can't find a System.map
file to delete, even if I copy it in from /boot. I had to delete the make
--
Cheers, Gene
"There are four boxes to be used in defense of liberty:
soap, ballot, jury, and ammo. Please use in that order."
-Ed Howdershelt (Author)
Check it out, send me comments, and dance joyously in the streets,
-- Linus Torvalds announcing ...
| Apr 18, 9:24 am 2008 |
| Cyrill Gorcunov | Re: Linux 2.6.25
[Linus Torvalds - Fri, Apr 18, 2008 at 08:43:35AM -0700]
|
|
| On Fri, 18 Apr 2008, Matthew wrote:
| >
| > I can "reproduce" this on an Intel Core 2 Duo 6600 (Conroe) with a P5W
| > DH Deluxe mainboard (by Asus) since at least 2.6.25-rc8 (or possibly
| > also rc7)
|
| Can you bisect it?
|
| Linus
it seems drivers/acpi/thermal.c has a small nit
881: /* sys I/F for generic thermal sysfs support */
882: #define KELVIN_TO_MILLICELSIUS(t) (t * 100 - 273200)
but it should multiply ...
| Apr 18, 12:38 pm 2008 |
| Cyrill Gorcunov | Re: Linux 2.6.25
[Cyrill Gorcunov - Fri, Apr 18, 2008 at 11:38:02PM +0400]
| [Linus Torvalds - Fri, Apr 18, 2008 at 08:43:35AM -0700]
| |
| |
| | On Fri, 18 Apr 2008, Matthew wrote:
| | >
| | > I can "reproduce" this on an Intel Core 2 Duo 6600 (Conroe) with a P5W
| | > DH Deluxe mainboard (by Asus) since at least 2.6.25-rc8 (or possibly
| | > also rc7)
| |
| | Can you bisect it?
| |
| | Linus
|
| it seems drivers/acpi/thermal.c has a small nit
|
| 881: /* sys I/F for generic thermal sysfs ...
| Apr 18, 1:03 pm 2008 |
| Matthew | Re: Linux 2.6.25
On Fri, Apr 18, 2008 at 5:43 PM, Linus Torvalds
sorry, unfortunately I don't have the time right now to do it (exams-time),
I hope that someone out of the gentoo-community would be willing to do
so, I'll post a link to this entry in the forums & hope that someone
can be found to do it
Regards
Mat
--
| Apr 18, 9:02 am 2008 |
| Matthew | Linux 2.6.25
Hi everyone, hi Linus,
congratulations on this new great kernel-release :)
I've another "regression" to report for 2.6.25:
it's concerning much higher temperatures being read out by the
"coretemp" kernel-module in comparison to 2.6.24* series
e.g. where temperatures were around 40-47°C they are now constantly
jumping around 55-70°C (even in idle !)
several other users/testers have reported this issue too (both on
zen-sources [heavy patched] & latest gentoo-sources) ...
| Apr 18, 8:37 am 2008 |
| Rudolf Marek | Re: Linux 2.6.25
Hi all,
I will keep the rest of the mail intact for the lm-sensors list. The temperature
is stored in hardware relative to maximum temperature. Mobile processors have
some undocumented bits that calibrate the temperature to 85 or 100C. Intel
claims that this does not work for desktops, so I changed the driver [1] and
scale for desktop CPUs is from 0 to 100.
In your case, the MAX temperature is changed from 85 to 100 for desktops But the
relative change is same, in your case -40C below ...
| Apr 18, 1:50 pm 2008 |
| Gene Heskett | Re: Linux 2.6.25
And then, after killing the make clean statement, it still dies when making a
--
Cheers, Gene
"There are four boxes to be used in defense of liberty:
soap, ballot, jury, and ammo. Please use in that order."
-Ed Howdershelt (Author)
Check it out, send me comments, and dance joyously in the streets,
-- Linus Torvalds announcing 2.0.27
--
| Apr 18, 9:27 am 2008 |
| Jiri Slaby | Re: Linux 2.6.25
I see a change on my rrd graphs on Mar 5th 11:30 AM (from 25 to 40 average
centigrades). This is when I booted 2.6.25-rc3-mm1 instead of 2.6.25-rc2-mm1,
according to logs. [I have no idea whether the values were correct before or are
correct now.]
I might bisect it, if needed.
--
| Apr 18, 1:24 pm 2008 |
| Bart Van Assche | Re: Linux 2.6.25
The coretemp kernel module reports 25°C on my PC when idle, and 34°C
after having performed some computations (lmbench2). This looks
normal. This test has been performed with a vanilla 2.6.25 kernel and
a Core 2 Duo E6750 CPU (Asus motherboard). The 2.6.22 and 2.6.24
kernels report an incorrect temperature on the same system however
(10°C). So there is either an issue with the patches that have been
applied to your kernel or the behavior of the coretemp module for the
6600 and E6750 CPU's is ...
| Apr 18, 12:18 pm 2008 |
| Ben Dooks | [PATCH] dontdiff: ignore timeconst.h
Ignore the autobuilt kernel/timeconst.h when
using diff on an built kernel tree.
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
diff -urp linux-2.6.25-dontdiff/Documentation/dontdiff linux-2.6.25-dontdiff2/Documentation/dontdiff
--- linux-2.6.25-dontdiff/Documentation/dontdiff 2008-04-18 16:16:45.000000000 +0100
+++ linux-2.6.25-dontdiff2/Documentation/dontdiff 2008-04-18 16:26:14.000000000 +0100
@@ -173,6 +173,7 @@ sm_tbl*
split-include
tags
tftpboot.img
+timeconst.h
times.h*
...
| Apr 18, 8:28 am 2008 |
| Ben Dooks | [PATCH] dontdiff: add modules.order
Add modules.order to the list of files that
shoud be ignored when using diff on a built
kernel tree.
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
diff -rup linux-2.6.25/Documentation/dontdiff linux-2.6.25-dontdiff/Documentation/dontdiff
--- linux-2.6.25/Documentation/dontdiff 2008-04-17 09:48:05.000000000 +0100
+++ linux-2.6.25-dontdiff/Documentation/dontdiff 2008-04-18 16:16:45.000000000 +0100
@@ -142,6 +142,7 @@ mkprep
mktables
mktree
modpost
+modules.order
modversions.h*
...
| Apr 18, 8:18 am 2008 |
| Alan Cox | [PATCH] cyclades: coding style & review
Signed-off-by: Alan Cox <alan@redhat.com>
--- linux-2.6.25-rc8-mm2/drivers/char/cyclades.c.old 2008-04-18 13:41:31.000000000 +0100
+++ linux-2.6.25-rc8-mm2/drivers/char/cyclades.c 2008-04-18 14:25:30.000000000 +0100
@@ -21,7 +21,6 @@
*
* This version supports shared IRQ's (only for PCI boards).
*
- * $Log: cyclades.c,v $
* Prevent users from opening non-existing Z ports.
*
* Revision 2.3.2.8 2000/07/06 18:14:16 ivan
@@ -62,7 +61,7 @@
* Driver now makes sure that the ...
| Apr 18, 7:15 am 2008 |
| Jochen Friedrich | [PATCH] [POWERPC] i2c: fix build breakage introduced by ...
Fix build breakage introduced in commit
"[POWERPC] i2c: OF helpers for the i2c API".
If i2c-core is compiled as module, the helper needs to be
compiled as module, as well. Rename i2c.c to of_i2c.c to
avoid name space conflict.
Signed-off-by: Jochen Friedrich <jochen@scram.de>
---
drivers/of/Kconfig | 2 +-
drivers/of/Makefile | 2 +-
drivers/of/{i2c.c => of_i2c.c} | 0
3 files changed, 2 insertions(+), 2 deletions(-)
rename drivers/of/{i2c.c => of_i2c.c} ...
| Apr 18, 7:23 am 2008 |
| Bill Davidsen | New comic book: Iron Man vs. Linux
I couldn't make this up, there's a new comic book coming out, and the
bad guy is "a post-national business man and kind of an open source
ideological terrorist,” who sounds a lot like our favorite leader. The
description is "Windows wants to be on every computer desktop in the
world, but Linux and Stane want to destroy the desktop. "
Stupidity factor aside, you have to wonder who thinks it would be a good
idea to push the idea of Linux as evil in books intended for children.
Let's see, ...
| Apr 18, 6:53 am 2008 |
| Hidehiro Kawai | [PATCH 2/4] jbd: ordered data integrity fix
Subject: [PATCH 2/4] jbd: ordered data integrity fix
In ordered mode, if a buffer being dirtied exists in the committing
transaction, we write the buffer to the disk, move it from the
committing transaction to the running transaction, then dirty it.
But we don't have to remove the buffer from the committing
transaction when the buffer couldn't be written out, otherwise it
breaks the ordered mode rule.
Signed-off-by: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
---
fs/jbd/transaction.c | ...
| Apr 18, 6:37 am 2008 |
| Hidehiro Kawai | [PATCH 0/4] jbd: possible filesystem corruption fixes
Subject: [PATCH 0/4] jbd: possible filesystem corruption fixes
The current JBD is not sufficient for I/O error handling. It can
cause filesystem corruption. An example scenario:
1. fail to write a metadata buffer to block B in the journal
2. succeed to write the commit record
3. the system crashes, reboots and mount the filesystem
4. in the recovery phase, succeed to read data from block B
5. write back the read data to the filesystem, but it is a stale
metadata
6. lose some files and ...
| Apr 18, 6:00 am 2008 |
| Hidehiro Kawai | [PATCH 3/4] jbd: abort when failed to log metadata buffers
Subject: [PATCH 3/4] jbd: abort when failed to log metadata buffers
If we failed to write metadata buffers to the journal space and
succeeded to write the commit record, stale data can be written
back to the filesystem as metadata in the recovery phase.
To avoid this, when we failed to write out metadata buffers,
abort the journal before writing the commit record.
Signed-off-by: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
---
fs/jbd/commit.c | 3 +++
1 file changed, 3 ...
| Apr 18, 6:38 am 2008 |
| Josef Bacik | Re: [PATCH 0/4] jbd: possible filesystem corruption fixes
There doesn't seem like much point in taking these patches as Jan is rewriting
the ordered mode path and most of these functions will be going away soon.
Those patches seem like they will be coming soon and will obsolete these.
Josef
--
| Apr 18, 7:09 am 2008 |
| Hidehiro Kawai | [PATCH 4/4] jbd/ext3: fix error handling for checkpoint io
Subject: [PATCH 4/4] jbd/ext3: fix error handling for checkpoint io
When a checkpointing IO fails, current JBD code doesn't check the
error and continue journaling. This means latest metadata can be
lost from both the journal and filesystem.
This patch leaves the failed metadata blocks in the journal space
and aborts journaling in the case of log_do_checkpoint().
To achieve this, we need to do:
1. don't remove the failed buffer from the checkpoint list where in
the case of ...
| Apr 18, 6:39 am 2008 |
| Mingming Cao | Re: [PATCH 0/4] jbd: possible filesystem corruption fixes
I hope we have a better ordered mode very soon too. Just thought it's
still valid to fix the current ordered mode for people who uses
linux-2.6.25 kernel today.
--
| Apr 18, 12:26 pm 2008 |
| Hidehiro Kawai | [PATCH 1/4] jbd: strictly check for write errors on data ...
Subject: [PATCH 1/4] jbd: strictly check for write errors on data buffers
In ordered mode, we should abort journaling when an I/O error has
occurred on a file data buffer in the committing transaction. But
there can be data buffers which are not checked for error:
(a) the buffer which has already been written out by pdflush
(b) the buffer which has been unlocked before scanned in the
t_locked_list loop
This patch adds missing error checks and aborts ...
| Apr 18, 6:36 am 2008 |
| Hidehiro Kawai | [PATCH 0/4] jbd: possible filesystem corruption fixes
Subject: [PATCH 0/4] jbd: possible filesystem corruption fixes
The current JBD is not sufficient for I/O error handling. It can
cause filesystem corruption. An example scenario:
1. fail to write a metadata buffer to block B in the journal
2. succeed to write the commit record
3. the system crashes, reboots and mount the filesystem
4. in the recovery phase, succeed to read data from block B
5. write back the read data to the filesystem, but it is a stale
metadata
6. lose some files and ...
| Apr 18, 6:29 am 2008 |
| Martin Knoblauch | 2.6.25 - Jiffies/Time jumping back and forth
Hi,
this was discussed before, but I thought the problem was solved. Apparently not...
After upgrading to 2.6.25, jiffies on my 2xdual-core IBM x3650 boxes seem to jump back and forth as can be seen on the dmesg output. Did not happen in 2.6.24. As I did not follow the rc-cycles for 2.6.25, I cannot really say when it started. Config attached.
Cheers
Martin
------------------------------------------------------
Martin Knoblauch
email: k n o b i AT knobisoft DOT de
www: ...
| Apr 18, 6:09 am 2008 |
| Ulrich Windl | /proc/mounts vs mount inconsistency in 2.6.16 (SLES10 SP1)
Hi,
I think I found a little problem in kernel 2.6.16.54-0.2.5-xen (Current SLES10
SP1):
By mistake I mounted some filesystem read-only over /.
Realizing the mistake, I did an "umount /", which seemed to work.
Then I noticed that / was mounted read-only, while the files being there were
those of the right root filesystem.
So I did a "Mount -o remount /" which enabled writes again.
As some other program had odd effects, I did "cat /proc/mounts" which still
displayed the wrong ...
| Apr 18, 5:48 am 2008 |
| Jochen Friedrich | [PATCHv3 3/7] i2c: OF helpers for the i2c API
This patch implements various helpers to support OF bindings for
the i2c API.
Signed-off-by: Jochen Friedrich <jochen@scram.de>
Acked-by: David S. Miller <davem@davemloft.net>
Acked-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
drivers/of/Kconfig | 6 +++
drivers/of/Makefile | 1 +
drivers/of/of_i2c.c | 115 ++++++++++++++++++++++++++++++++++++++++++++++++
include/linux/of_i2c.h | 24 ++++++++++
4 files changed, 146 insertions(+), 0 deletions(-)
create mode 100644 ...
| Apr 18, 5:43 am 2008 |
| NOTIFIER. | SELECTED.
Contact Dr.Carl Tucker via Email:peugeotdracarltucker@gmail.com
for your Winnings of £300,000.00 and a peugeot 607 car.
----------------------------------------------------------------
This message was sent using http://webmail.coqui.net
--
| Apr 17, 7:36 pm 2008 |
| EUROMILLION | CONGRATULATIONS ...YOUR E-MAIL WON...
CONGRATULATIONS ...YOUR E-MAIL WON...
SELECTED E-MAIL WON YOU CONTACT MR PAUL GREEN FOR MORE INFORMATION FOR
THE CLAIM OF YOUR $950,000.00 AS SOON AS POSSIBLE VIA EMAIL
(APEXTRUSTAGENCY@AIM.COM) OR CALL +34628652243
--
| Apr 18, 5:24 am 2008 |
| Thomas Gleixner | [PATCH] ftrace: simplify hex print
simplify hex to ascii conversion with a lookup table.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
kernel/trace/trace.c | 23 +++++------------------
1 file changed, 5 insertions(+), 18 deletions(-)
Index: linux/kernel/trace/trace.c
===================================================================
--- linux.orig/kernel/trace/trace.c
+++ linux/kernel/trace/trace.c
@@ -248,19 +248,18 @@ trace_seq_putmem(struct trace_seq *s, vo
}
#define HEX_CHARS 17
+static const ...
| Apr 18, 5:33 am 2008 |
| Heiko Carstens | Re: [PATCH] ftrace: simplify hex print
we have hex_asc() in include/linux/kernel.h already.
--
| Apr 18, 6:22 am 2008 |
| Ingo Molnar | Re: [PATCH] ftrace: simplify hex print
thanks Thomas, applied.
Ingo
--
| Apr 18, 5:35 am 2008 |
| Bart Van Assche | Unexport of blk_get_queue and blk_put_queue
Hello Adrian,
I noticed that blk_get_queue and blk_put_queue were unexported in the
2.6.25 kernel. Are you aware that this breaks DRBD (an out-of-tree
kernel module) ?
Bart.
--
| Apr 18, 4:43 am 2008 |
| Alan Cox | [PATCH] x25_asy: tty-the-big-operations-rework-broke-wan ...
- Coding Style
- Correct printks
- Printk levels
- Switch to ->ops
Replaces Andrews && BROKEN quick fix
Signed-off-by: Alan Cox <alan@redhat.com>
--- linux.vanilla-2.6.25-rc8-mm2/drivers/net/wan/x25_asy.c 2008-04-13 12:55:52.000000000 +0100
+++ linux-2.6.25-rc8-mm2/drivers/net/wan/x25_asy.c 2008-04-18 10:23:27.000000000 +0100
@@ -17,7 +17,7 @@
#include <linux/module.h>
#include <asm/system.h>
-#include <asm/uaccess.h>
+#include <linux/uaccess.h>
#include <linux/bitops.h>
...
| Apr 18, 3:22 am 2008 |
| Helge Hafting | Problem with delayed data from pl2303 usb serial gps
Problem:
I run car navigation software on linux, using a gps.
Getting data from the gps unit in a timely fashion is important, as
the software says thing like "turn left in 50m". That is useless however,
if the message arrives 10s after you passed the intersection!
The gps unit reports location once per second.
I frequently see delays of up to 13 seconds. I drive down a street and
make a turn or stop. Then I look at map display, and count 13 updates
before the map reflects what I did.
This ...
| Apr 18, 3:16 am 2008 |
| Greg KH | Re: Problem with delayed data from pl2303 usb serial gps
That sounds like a problem either in the device, or in the pl2303 chip,
or possibly, your userspace program.
As a test, enable debugging in the pl2303 driver:
modprobe pl2303 debug=1
or enable it after it is loaded with:
echo 1 > /sys/module/pl2303/parameters/debug
and run your program. Look at the timestamps in the kernel log for when
the pl2303 driver gets your data and compare it to when your userspace
program is getting them.
Let me know if you find anything we can help out ...
| Apr 18, 8:20 am 2008 |
| Reuben Farrelly | Re: StackProtector Oopses - Re: 2.6.25-mm1
It boots up fine with that patch below and:
tornado boot # grep STACKPROTECT /boot/config-2.6.25-mm1-wip
CONFIG_CC_STACKPROTECTOR_ALL=y
CONFIG_CC_STACKPROTECTOR=y
In fact I'm running with it applied right now and it all seems good so far, so I
guess that's confirmation that it is just the test itself which is problematic?
Reuben
--
| Apr 18, 7:49 am 2008 |
| Randy Dunlap | Re: 2.6.25-mm1 (build error: driver core)
with CONFIG_BLOCK=n:
linux-2.6.25-mm1/drivers/base/core.c: In function 'device_to_dev_kobj':
linux-2.6.25-mm1/drivers/base/core.c:768: error: 'block_class' undeclared (first use in this function)
make[3]: *** [drivers/base/core.o] Error 1
---
~Randy
--
| Apr 18, 9:40 am 2008 |
| Greg KH | Re: 2.6.25-mm1 (build error: driver core)
Ah, more fun caused by Dan's /sys/dev/... patch.
Dan, this is causing a lot of problems, I'm going to drop it for now
until the build and run-time errors get resolved.
thanks,
greg k-h
--
| Apr 18, 9:56 am 2008 |
| Randy Dunlap | Re: 2.6.25-mm1 (build error: trace selftest)
with CONFIG_RT_MUTEXES=N:
In file included from linux-2.6.25-mm1/kernel/trace/trace.c:2432:
linux-2.6.25-mm1/kernel/trace/trace_selftest.c: In function 'trace_wakeup_test_thread':
linux-2.6.25-mm1/kernel/trace/trace_selftest.c:413: error: implicit declaration of function 'rt_mutex_setprio'
make[3]: *** [kernel/trace/trace.o] Error 1
---
~Randy
--
| Apr 18, 9:45 am 2008 |
| Alexey Dobriyan | 2.6.25-mm1: orphaned files after build
At least the following files aren't removed by "make mrproper":
Module.markers
arch/x86/kernel/acpi/realmode/wakeup.lds
crypto/.tmp_aes_generic.ver
fs/.tmp_buffer.ver
kernel/time/.tmp_timekeeping.ver
Noticed by "git-ls-files -o".
*.ver , I think, remain after abruptdly terminated build.
--
| Apr 18, 4:09 pm 2008 |
| Arjan van de Ven | Re: StackProtector Oopses - Re: 2.6.25-mm1
On Fri, 18 Apr 2008 15:36:45 +0200
yes it'll be interesting to see if this is due to the test triggering or due to
something else.
Reuben:
I assume your gcc is pretty vanilla and doesn't have weird patches in this area?
Can you do a (with the test enabled in the config/code) do a
make kernel/panic.s
and send me that file? (this allows me to see what code your gcc generated for the test)
--
If you want to reach me at my work email, use arjan@linux.intel.com
For development, discussion ...
| Apr 18, 6:51 am 2008 |
| Valdis.Kletnieks | Re: 2.6.25-mm1
I may have reported this same one previously against an earlier -mm, or somebody
did, or something... ;)
x86_64 kernel, Core2 Duo T7200, Dell Latitude D820 laptop...
[ 0.060388] ACPI: Core revision 20080321
[ 0.070079] ------------[ cut here ]------------
[ 0.070082] WARNING: at arch/x86/kernel/genapic_64.c:86 read_apic_id+0x41/0x7c()
[ 0.070085] Modules linked in:
[ 0.070089] Pid: 1, comm: swapper Not tainted 2.6.25-mm1 #1
[ 0.070091]
[ 0.070092] Call Trace:
[ ...
| Apr 18, 1:14 pm 2008 |
| Andrew Morton | 2.6.25-mm1
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.25/2.6.25-mm1/
- git-xfs is undropped because I finally got around to fixing its clashes
with git-vfs.
- git-arm-master, git-sparc64 and perhaps others are dropped because they
don't generate a clean pull. They might be empty - I didn't check.
- git-kvm remains dropped due to clashes with git-s390 and perhaps git-x86.
- git-selinux is newly dropped due to memory corruption regressions.
- git-nfs is (perhaps ...
| Apr 18, 1:47 am 2008 |
| Reuben Farrelly | StackProtector Oopses - Re: 2.6.25-mm1
The GCC stackprotector option is a no-go for me, and causes 100% repeatable
fatal oopses on boot with my x86_64 box.
This is not new to 2.6.25-mm1 - but was also present in 2.6.24-rc8-mm2
(2.6.24-rc8-mm1 was good, but this option didn't exist then).
It seems that enabling the stackprotector option:
tornado boot # diff -u config-2.6.25-mm1 config-2.6.25-mm1.old
--- config-2.6.25-mm1 2008-04-18 22:40:15.000000000 +1000
+++ config-2.6.25-mm1.old 2008-04-18 20:09:38.000000000 ...
| Apr 18, 6:02 am 2008 |
| Kamalesh Babulal | [PATCH] 2.6.25-mm1 - Build Failure with PWRficient onchi ...
Hi Andrew,
The 2.6.25-mm1 kernel allyesconfig build fails on the powerpc
drivers/edac/pasemi_edac.c: In function ‘pasemi_edac_init’:
drivers/edac/pasemi_edac.c:288: error: implicit declaration of function ‘opstate_init’
drivers/edac/pasemi_edac.c: In function ‘__check_edac_op_state’:
drivers/edac/pasemi_edac.c:304: error: ‘edac_op_state’ undeclared (first use in this function)
drivers/edac/pasemi_edac.c:304: error: (Each undeclared identifier is reported only ...
| Apr 18, 4:26 am 2008 |
| Reuben Farrelly | Re: StackProtector Oopses - Re: 2.6.25-mm1
I think so. Well, put it this way... I haven't made any changes to it, this is
the standard/current gcc that has been in Gentoo Portage for the last while.
> Can you do a (with the test enabled in the config/code) do a
> make kernel/panic.s
> and send me that file? (this allows me to see what code your gcc generated
for the test)
Done - posted up in the web directory along with the other files (saves the
possible grief of MUA mangling).
I'm about to reboot to try Ingo's test ...
| Apr 18, 7:41 am 2008 |
| Dan Williams | Re: 2.6.25-mm1 (build error: driver core)
Ok, I'll have an updated version with Kay's duplicate-entry fix and a
Regards,
Dan
--
| Apr 18, 11:38 am 2008 |
| Ingo Molnar | Re: StackProtector Oopses - Re: 2.6.25-mm1
hm, does it boot up fine with the attached patch and stackprotector
enabled? It appears that your system got to the self-test so
stackprotector is working mostly - it's just that the self-test went
wrong.
Ingo
----------------->
Subject: x86: disable stackprotector selftest
From: Ingo Molnar <mingo@elte.hu>
Date: Fri Apr 18 15:21:49 CEST 2008
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
kernel/panic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: ...
| Apr 18, 6:36 am 2008 |
| Hans-Christian Egtvedt | [PATCH 1/1] Update email address in MODULE_AUTHOR
This patch updates the MODULE_AUTHOR email address for the kernel drivers I
maintain to my new, long term address.
Signed-off-by: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>
---
drivers/input/mouse/gpio_mouse.c | 2 +-
drivers/misc/atmel-ssc.c | 2 +-
drivers/rtc/rtc-at32ap700x.c | 2 +-
drivers/watchdog/at32ap700x_wdt.c | 2 +-
sound/spi/at73c213.c | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git ...
| Apr 18, 1:02 am 2008 |
| Kyle McMartin | [PATCH 2/2] kallsyms: move get_func_addr to <asm/processor.h>
While debugging something on parisc a few weeks ago, I noticed
kallsyms was all busted because print_symbol was printing the
descriptor address. Since we don't use addr[0] for the function
address, and we don't want a mess of #ifdef ARCH1 #elseif ARCH2
garbage, move the definitions to <asm/processor.h>
Signed-off-by: Kyle McMartin <kyle@mcmartin.ca>
---
include/asm-ia64/processor.h | 6 ++++++
include/asm-parisc/processor.h | 8 ++++++++
include/asm-powerpc/processor.h | 8 ...
| Apr 18, 12:48 am 2008 |
| Kyle McMartin | [PATCH 1/2] kallsyms: restructure print_fn_descriptor_symbol
Factor out the function descriptor access from the print_symbol
call.
Signed-off-by: Kyle McMartin <kyle@mcmartin.ca>
---
include/linux/kallsyms.h | 16 ++++++++++------
1 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/include/linux/kallsyms.h b/include/linux/kallsyms.h
index 82de2fb..6734a3f 100644
--- a/include/linux/kallsyms.h
+++ b/include/linux/kallsyms.h
@@ -83,17 +83,21 @@ __attribute__((format(printf,1,2)));
static inline void __check_printsym_format(const char ...
| Apr 18, 12:48 am 2008 |
| Andrew Morton | Re: [PATCH 3/3] Use __weak macro for smp_setup_processor_id
ack on all three. Please fold #3 into #1 and add both to git-powerpc.
--
| Apr 18, 12:07 am 2008 |
| Benjamin Herrenschmidt | Re: [PATCH 3/3] Use __weak macro for smp_setup_processor_id
Damn ! I took 5mn to actually split it out in order to not do two
different things in one patch :-)
Will do.
Cheers,
Ben.
--
| Apr 18, 1:19 am 2008 |
| Andrew Morton | Re: [PATCH 3/3] Use __weak macro for smp_setup_processor_id
ah, I misread it. I thought this was changing the __attribute__((weak))
which patch #1 added. But it's changing a different one. I though that
whatever ;)
--
| Apr 18, 1:38 am 2008 |
| Benjamin Herrenschmidt | [PATCH 3/3] Use __weak macro for smp_setup_processor_id
Use the __weak macro instead of the longer __attribute__ ((weak)) form
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
--
init/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-work.orig/init/main.c 2008-04-18 16:44:32.000000000 +1000
+++ linux-work/init/main.c 2008-04-18 16:44:37.000000000 +1000
@@ -500,7 +500,7 @@ static void __init boot_cpu_init(void)
cpu_set(cpu, cpu_possible_map);
}
-void __init __attribute__((weak)) ...
| Apr 17, 11:56 pm 2008 |
| Benjamin Herrenschmidt | Re: [PATCH 2/3] [POWERPC] Fix kernel stack allocation al ...
Well, I copied over from something else, looks like there's a -lot- of 0
users here...
Shouldn't there be some kind of SLAB_DEFAULT that contain those things ?
Ben.
--
| Apr 18, 1:18 am 2008 |
| Andrew Morton | Re: [PATCH 2/3] [POWERPC] Fix kernel stack allocation al ...
so... the "0" defeats all of SLAB_DEBUG_FREE, SLAB_RED_ZONE, SLAB_POISON
and SLAB_STORE_USER, if the comment in slab.h is to be believed.
Was that overkill?
--
| Apr 18, 12:06 am 2008 |
| Benjamin Herrenschmidt | [PATCH 2/3] [POWERPC] Fix kernel stack allocation alignment
The powerpc kernel stacks need to be naturally aligned, as they
contain the thread info at the bottom, which is obtained by
clearing the low bits of the stack pointer.
However, when using 64K pages (the stack is smaller than a page),
we use kmalloc to allocate it, which doesn't provide that guarantee.
It appeared to work so far... until one enables SLUB debugging
which then returns unaligned pointers. Ooops...
This patch fixes it by using a slab cache with enforced alignment
for those. It ...
| Apr 17, 11:56 pm 2008 |
| Benjamin Herrenschmidt | [PATCH 1/3] Add thread_info_cache_init() weak hook
Some architecture need to maintain a kmem cache for thread info
structures. (next patch adds that to powerpc to fix an alignment
problem).
There is no good arch callback to use to initialize that cache
that I can find, so this adds a new one in the form of a weak
function whose default is empty.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
include/linux/sched.h | 2 ++
init/main.c | 5 +++++
2 files changed, 7 insertions(+)
--- ...
| Apr 17, 11:56 pm 2008 |
| Nadia.Derbey | [PATCH 4/4] - v2 - PID: use the target ID specified in procfs
[PATCH 04/04]
This patch makes use of the target ids specified by a previous write to
/proc/self/task/<tid>/next_id as the ids to use to allocate the next upid nrs.
Upper levels upid nrs that are not specified in next_pids file are left to the
kernel choice.
Signed-off-by: Nadia Derbey <Nadia.Derbey@bull.net>
---
include/linux/pid.h | 2
kernel/fork.c | 3 -
kernel/pid.c | 141 +++++++++++++++++++++++++++++++++++++++++++++-------
3 files changed, 126 insertions(+), ...
| Apr 17, 10:45 pm 2008 |
| Nadia.Derbey | [PATCH 3/4] - v2 - IPC: use the target ID specified in procfs
[PATCH 03/04]
This patch makes use of the target id specified by a previous write into
/proc/self/task/<tid>/next_id as the id to use to allocate the next IPC
object.
Signed-off-by: Nadia Derbey <Nadia.Derbey@bull.net>
---
include/linux/sysids.h | 7 +++++++
ipc/util.c | 41 +++++++++++++++++++++++++++++++++--------
kernel/nextid.c | 2 +-
3 files changed, 41 insertions(+), 9 deletions(-)
Index: ...
| Apr 17, 10:45 pm 2008 |
| Nadia.Derbey | [PATCH 2/4] - v2 - Provide a new procfs interface to set ...
[PATCH 02/04]
This patch proposes the procfs facilities needed to feed the id(s) for the
next task to be forked.
say n is the number of pids to be provided through procfs:
if an
echo "LONG<n> X0 X1 ... X<n-1>" > /proc/self/task/<tid>/next_id
is issued, the next task to be forked will have its upid nrs set as follows
(say it is forked in a pid ns of level L):
level upid nr
L ----------> X0
..
L - i ------> Xi
..
L - n + 1 --> X<n-1>
Then, for levels L-n down to level 0, ...
| Apr 17, 10:45 pm 2008 |
| Nadia.Derbey | [PATCH 1/4] - v2 - Provide a new procfs interface to set ...
[PATCH 01/04]
This patch proposes the procfs facilities needed to feed the id for the
next object to be allocated.
if an
echo "LONG XX" > /proc/self/task/<tid>/next_id
is issued, next object to be created will have XX as its id.
This applies to objects that need a single id, such as ipc objects.
Signed-off-by: Nadia Derbey <Nadia.Derbey@bull.net>
---
fs/exec.c | 3 +
fs/proc/base.c | 76 +++++++++++++++++++++++++++++++++++++++++++
include/linux/sched.h | ...
| Apr 17, 10:45 pm 2008 |
| Dave Hansen | Re: [PATCH 0/4] - v2 - Object creation with a specified id
I still think, in its current form, this is pretty dangerous.
It might be nice to have a central place to set ids, but there's no real
safety here for when we get a mishmash of 50 of these things. We have a
queue and we fix the order in which things are inserted, but how do we
control the order in which the kernel extracts them? Can we 100%
conform to that order in the future and be consistent? Won't that also
be dictated by the way userspace behaves?
If we're going to go this route, I ...
| Apr 18, 10:07 am 2008 |
| Nadia.Derbey | [PATCH 0/4] - v2 - Object creation with a specified id
When restarting a process that has been previously checkpointed, that process
should keep on using some of its ids (such as its process id, or sysV ipc ids).
This patch provides a feature that can help ensuring this saved state reuse:
it makes it possible to create an object with a pre-defined id.
A first implementation had been proposed 2 months ago. It consisted in
changing an object's id after it had been created.
Here is a second implementation based on Oren Ladaan's idea: Oren's ...
| Apr 17, 10:44 pm 2008 |
| Lachlan McIlroy | [GIT PULL] XFS update for 2.6.26-rc1
Please pull from the for-linus branch:
git pull git://oss.sgi.com:8090/xfs/xfs-2.6.git for-linus
This will update the following files:
Documentation/filesystems/xfs.txt | 15 +-
fs/xfs/Kconfig | 12 -
fs/xfs/linux-2.6/kmem.c | 6 +-
fs/xfs/linux-2.6/xfs_aops.c | 12 +-
fs/xfs/linux-2.6/xfs_buf.c | 8 +-
fs/xfs/linux-2.6/xfs_buf.h | 8 +-
fs/xfs/linux-2.6/xfs_cred.h | 2 +-
fs/xfs/linux-2.6/xfs_export.c | 14 ...
| Apr 17, 10:05 pm 2008 |
| Rusty Russell | [PATCH 0/5] High-speed tun receive and xmit
kvm (and lguest!) want to get more speed out of the tun device. We already
have an ABI for guest<->host comms, called virtio_ring; extending tun to
understand this (with its async nature and batching) make for an efficient
network.
But moreover: the same things that make virtio a good guest<->host transport
make it appealing as a userspace<->kernel transport. So rather than do
something just for tun, we create a /dev/vring. We could do a system call,
but /dev/vring is sufficient. It ...
| Apr 17, 9:33 pm 2008 |
| Andrew Morton | Re: [PATCH 5/5] tun: vringfd xmit support.
What is the maximum numbet of pages which an unpriviliged user can
This loop is a fancy way of doing
--
| Apr 18, 4:31 am 2008 |
| pradeep singh rautela | Re: [PATCH 5/5] tun: vringfd xmit support.
I stand corrected.
Sorry for noise.
Thanks,
--
Pradeep Singh Rautela
http://eagain.wordpress.com
http://emptydomain.googlepages.com
--
| Apr 18, 11:01 am 2008 |
| Rusty Russell | [PATCH 5/5] tun: vringfd xmit support.
This patch modifies tun to allow a vringfd to specify the send
buffer. The user does a write to push out packets from the buffer.
Again we use the 'struct virtio_net_hdr' to allow userspace to send
GSO packets. In this case, it can hint how much to copy, and the
other pages will be made into skb fragments.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
---
drivers/net/tun.c | 410 +++++++++++++++++++++++++++++++++++++++++--------
include/linux/if_tun.h | 1
2 files ...
| Apr 17, 9:43 pm 2008 |
| Andrew Morton | Re: [PATCH 2/5] /dev/vring: simple userspace-kernel ring ...
hm, I don't understand the big picture here yet.
Isn't this kinda-sorta like what a relayfs file does? The oprofile
--
| Apr 18, 4:18 am 2008 |
| Rusty Russell | [PATCH 3/5] /dev/vring limit and base ioctls
It turns out the lguest (and possibly kvm) want the addresses in the
ring buffer to only cover a certain part of memory, and be offset.
It makes sense that this be an ioctl.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
---
Documentation/ioctl-number.txt | 3 +--
drivers/char/vring.c | 37 +++++++++++++++++++++++++++++++++++--
include/linux/vring.h | 9 +++++++++
3 files changed, 45 insertions(+), 4 deletions(-)
diff -r caeeb48d478a ...
| Apr 17, 9:41 pm 2008 |
| pradeep singh rautela | Re: [PATCH 5/5] tun: vringfd xmit support.
Hi Rusty,
A trivial suggestion, how about
npages = 1+(len -1)/PAGE_SIZE ?
Thanks,
--
Pradeep Singh Rautela
http://eagain.wordpress.com
http://emptydomain.googlepages.com
--
| Apr 18, 4:46 am 2008 |
| Michael Kerrisk | Re: [PATCH 2/5] /dev/vring: simple userspace-kernel ring ...
Well, it helps if he's CCed....
I'm happy to work *with someone* on the documentation (pointless to do
it on my own -- how do I know what Rusty's *intended* behavior for the
interface is), and review, and testing.
--
| Apr 18, 12:38 pm 2008 |
| Andrew Morton | Re: [PATCH 2/5] /dev/vring: simple userspace-kernel ring ...
This is may be our third high-bandwidth user/kernel interface to transport
bulk data ("hbukittbd") which was implemented because its predecessors
weren't quite right. In a year or two's time someone else will need a
hbukittbd and will find that the existing three aren't quite right and will
give us another one. One day we need to stop doing this ;)
It could be that this person will look at Rusty's hbukittbd and find that
it _could_ be tweaked to do what he wants, but it's already shipping ...
| Apr 18, 11:59 am 2008 |
| Rusty Russell | [PATCH 1/5] virtio: put last_used and last_avail index i ...
Generally, the other end of the virtio ring doesn't need to see where
you're up to in consuming the ring. However, in order for an external
entity to understand it, it must be exposed. For example, if you want
to save and restore a virtio_ring, but you're not the consumer because
the kernel is using it directly.
Fortunately, we have room to expand: the ring is always a whole number
of pages and there's hundreds of bytes of padding after the avail ring
and the used ring, whatever the number of ...
| Apr 17, 9:35 pm 2008 |
| Rusty Russell | Re: [PATCH 5/5] tun: vringfd xmit support.
I tested it when I wrote it, but just wrote a tester again:
base len npages
0 1 1
0xfff 1 1
0x1000 1 1
0 4096 1
0x1 4096 2
0xfff 4096 2
0x1000 4096 1
0xfffff000 4096 1
Since only root can open the tun device, it's currently OK. The old code
kmalloced and copied: is there some mm-fu reason why pinning userspace memory
is worse?
But I actually think it's OK even for ...
| Apr 18, 8:15 am 2008 |
| Andrew Morton | Re: [PATCH 5/5] tun: vringfd xmit support.
We generally try to avoid it - it allows users to dos the box. Although I
suspect that direct-io presently permits users to transiently pin an amount
of memory which is proportional to the number of disks upon which they can
acked-by: me.
--
| Apr 18, 12:06 pm 2008 |
| Rusty Russell | Re: [PATCH 2/5] /dev/vring: simple userspace-kernel ring ...
An excellent question, but I thought the modern kernel etiquette was to only
comment on whitespace and formatting, and call it "review"? :)
Yes, kinda-sorta in that it's a ring buffer. No, in that it's bidir and
consumption can be out-of-order (kind of important for I/O buffers).
But the reason I'm not proposing it as a syscall is that I'm not convinced
it's the One True Solution which everyone should be using. Time will tell:
it's clearly not tied to tun and it's been generically ...
| Apr 18, 7:32 am 2008 |
| Rusty Russell | [PATCH 2/5] /dev/vring: simple userspace-kernel ringbuff ...
virtio introduced a ring structure ABI for guest-host communications
(currently used by lguest and kvm). Using this same ABI, we can
create a nice fd version.
This is useful for efficiently passing packets to and from the tun,
for example.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
---
drivers/char/Kconfig | 9 +
drivers/char/Makefile | 2
drivers/char/vring.c | 400 ++++++++++++++++++++++++++++++++++++++++++++++++++
include/linux/vring.h | 58 +++++++
4 files ...
| Apr 17, 9:39 pm 2008 |
| Ray Lee | Re: [PATCH 5/5] tun: vringfd xmit support.
Picky, picky :-).
If base were always page aligned, we'd want
npages = (len + PAGE_SIZE - 1) / PAGE_SIZE;
which is simply rounding len up to the next largest page size. So when
base is not page aligned, increase len by the left-over space at the
beginning, and then do the same calculation as above. (ie, pretend
base is page aligned, and instead count the excess at the beginning as
part of len.)
npages = ( (base & PAGE_MASK) + len + PAGE_SIZE - 1) / PAGE_SIZE;
As long as len ...
| Apr 18, 9:24 am 2008 |
| Rusty Russell | [PATCH 4/5] tun: vringfd receive support.
This patch modifies tun to allow a vringfd to specify the receive
buffer. Because we can't copy to userspace in bh context, we queue
like normal then use the "pull" hook to actually do the copy.
We use struct virtio_net_hdr prepended to packets in the ring to allow
userspace to receive GSO packets in future (at the moment, the tun
driver doesn't tell the stack it can handle them, so these cases are
never taken). This will need to be something that userspace tells us
it can ...
| Apr 17, 9:42 pm 2008 |
| Ray Lee | Re: [PATCH 5/5] tun: vringfd xmit support.
On Fri, Apr 18, 2008 at 4:46 AM, pradeep singh rautela
That's not the same. In particular, his version accounts for the
fractional page at the beginning, while yours doesn't.
While it's tempting to use algebra to simplify things, it's not safe
to do so when the expression involves division over the integers. The
only care-free integer math in a computer is subtraction and ++.
--
| Apr 18, 7:25 am 2008 |
| KAMEZAWA Hiroyuki | [PATCH] fix page_reset_bad_cgroup
page->page_cgroup is unsigned long. Should be cleared by 0UL.
Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Index: linux-2.6.25/include/linux/memcontrol.h
===================================================================
--- linux-2.6.25.orig/include/linux/memcontrol.h
+++ linux-2.6.25/include/linux/memcontrol.h
@@ -30,7 +30,7 @@ struct mm_struct;
extern void mm_init_cgroup(struct mm_struct *mm, struct task_struct *p);
extern void mm_free_cgroup(struct mm_struct ...
| Apr 17, 8:10 pm 2008 |
| KAMEZAWA Hiroyuki | Re: [PATCH] fix page_reset_bad_cgroup
On Thu, 17 Apr 2008 20:22:21 -0700
Ah, sorry. I was confused...please ignore.
(I debugged an user program which clear a pointer with 0, yesterday..)
-Kame
--
| Apr 17, 8:36 pm 2008 |
| Andrew Morton | Re: [PATCH] fix page_reset_bad_cgroup
That's pretty cosmetic.
In fact it could be argued that we shouldn't do this. "0" is zero
regardless of the type of the LHS. So if we later change page_cgroup to
u32 or u16 or `struct superblock *', the old page_reset_bad_cgroup() will
happily continue to work. There's no need to make this code aware of
page_cgroup's type, to this extent?
--
| Apr 17, 8:22 pm 2008 |
| KAMEZAWA Hiroyuki | Re: [PATCH] memcgroup: check and initialize page->cgroup ...
On Thu, 17 Apr 2008 20:14:32 -0700
AFAIK, No. memmap is allocated by alloc_bootmem() and returned memory is
Hmm, I'll try his .config and see what happens.
Thanks,
-Kame
--
| Apr 17, 8:32 pm 2008 |
| Shi Weihua | Re: [PATCH] memcgroup: check and initialize page->cgroup ...
It's CONFIG_DISCONTIGMEM_MANUAL.
BTW, I attached the .config file. pls check it.
Thanks,
-Shi
| Apr 17, 8:14 pm 2008 |
| Shi Weihua | Re: [PATCH] memcgroup: check and initialize page->cgroup ...
If i use CONFIG_SPARSEMEM instead of CONFIG_DISCONTIGMEM, the kernel
boots successfully.
--
| Apr 17, 10:43 pm 2008 |
| KAMEZAWA Hiroyuki | Re: [PATCH] memcgroup: check and initialize page->cgroup ...
On Fri, 18 Apr 2008 13:43:34 +0800
Hmmm....ok. I'll check DISCONTIGMEM's boot codes.
Thanks,
-Kame
--
| Apr 17, 10:57 pm 2008 |
| KAMEZAWA Hiroyuki | [PATCH]Fix usemap for DISCONTIG/FLATMEM with not-aligned ...
On Fri, 18 Apr 2008 10:46:30 +0800
Finally, above was not guilty. patch is below. Mel, could you review below ?
This happens because this box's start_pfn == 256 and memmap_init_zone(),
called by ia64's virtual_mem_map() passed aligned pfn.
patch is against 2.6.25.
-Kame
==
This patch is quick workaround. If someone can write a clearer patch, please.
Tested under ia64/torublesome machine. works well.
****
At boot, memmap_init_zone(size, zone, start_pfn, context) is called.
In usual, ...
| Apr 18, 5:12 am 2008 |
| KAMEZAWA Hiroyuki | Re: [PATCH] memcgroup: check and initialize page->cgroup ...
On Fri, 18 Apr 2008 12:32:56 +0900
I reproduced the hang with his config and confirmed his fix works well.
But I can't find why...I'll dig a bit more.
Thanks,
-Kame
--
| Apr 17, 10:09 pm 2008 |
| KAMEZAWA Hiroyuki | Re: [PATCH] memcgroup: check and initialize page->cgroup ...
On Fri, 18 Apr 2008 13:43:34 +0800
AKAICT,
CONFIG_DISCONTIGMEM + 64KB page -> hang --------------(*)
CONFIG_SPRASEMEM_VMEMMAP + 64KB page -> works well
CONFIG_DISCONTIGMEM + 16KB page -> works well
CONFIG_SPARSEMEM_VMEMMAP + 16KB page -> works well
CONFIG_DISCONTIGMEM + 64KB page + your patch -> works well
Hmm. maybe memmap(and all possible bootmem) isn't cleared well
in case (*). still chasing it.
Thanks,
-Kame
--
| Apr 17, 11:47 pm 2008 |
| Andrew Morton | Re: [PATCH] memcgroup: check and initialize page->cgroup ...
hm, fishy. Perhaps the architecture isn't zeroing the memmap arrays?
Or perhaps that page was used and then later freed before we got to
memmap_init_zone() and was freed with a non-zero ->page_cgroup. Which is
unlikely given that page.page_cgroup was only just added and is only
present if CONFIG_CGROUP_MEM_RES_CTLR.
--
| Apr 17, 8:14 pm 2008 |
| Mel Gorman | Re: [PATCH]Fix usemap for DISCONTIG/FLATMEM with not-ali ...
Yes. All architectures can optionally pass in their own values here.
Like other aspects of mm-init, the values were trusted and as we've seen
The point of the if there was so that set_pageblock_migratetype() would
only be called once per pageblock. The impact with an unaligned zone is
that the first block is not set and will be used for UNMOVABLE pages
initially. However, this is not a major impact and there is no need to
This is a pretty large change for what seems to be a fairly basic ...
| Apr 18, 9:15 am 2008 |
| Shi Weihua | Re: [PATCH] memcgroup: check and initialize page->cgroup ...
.config is shared in previous mails.
kexec/kdump has not been used.
Thanks
-Shi
--
| Apr 17, 8:49 pm 2008 |
| Shi Weihua | [PATCH] memcgroup: check and initialize page->cgroup in ...
When we test memory controller in Fujitsu PrimeQuest(arch: ia64),
the compiled kernel boots failed, the following message occured on
the telnet terminal.
-------------------------------------
..........
ELILO boot: Uncompressing Linux... done
Loading file initrd-2.6.25-rc9-00067-gb87e81e.img...done
_ (system freezed)
-------------------------------------
We found commit 9442ec9df40d952b0de185ae5638a74970388e01
causes this boot failure by git-bisect.
And, we found the following change caused ...
| Apr 17, 7:46 pm 2008 |
| Balbir Singh | Re: [PATCH] memcgroup: check and initialize page->cgroup ...
The comment from Hugh is correct, which implies that in this case page->cgroup
The mem_map array should be cleared. I need to see the code to check where the
Please share your .config? Is this a kexec/kdump reboot by any chance?
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
--
| Apr 17, 8:37 pm 2008 |
| Dave Hansen | Re: [PATCH]Fix usemap for DISCONTIG/FLATMEM with not-ali ...
I was thinking about whether size needs to be modified in there like
this:
if (start_pfn < zone->zone_start_pfn) {
WARN_ON_ONCE(1);
+ size -= zone->zone_start_pfn - start_pfn;
start_pfn = zone->zone_start_pfn;
}
and I realized that your modification of size actually happens after its
only use in the function (to calculate end_pfn). Seems like we either
be error-checking end_pfn or delaying its calculation until after 'size'
is fixed.
-- Dave
--
| Apr 18, 10:41 am 2008 |
| kamezawa.hiroyu | Re: Re: [PATCH]Fix usemap for DISCONTIG/FLATMEM with not ...
But if ((pfn & (pageblock_nr_pages -1))) is not correct.
for calling set_pageblock_migrationtype() once in a pageblock,
ok, I'll test today if I have a chance. At least, I think I can test this
My concern here is, memmap out-of-zone is not initialized and not
marked as PG_reserved...sholdn't we initialize existing memmap even
if they are out-ot-zone ? I think all existing mem_map for memory hole
should be initialized properly.
Thanks,
-Kame
--
| Apr 18, 10:25 am 2008 |
| KAMEZAWA Hiroyuki | Re: [PATCH] memcgroup: check and initialize page->cgroup ...
On Fri, 18 Apr 2008 10:46:30 +0800
Hmm...strange. (I never see this with 2.6.25 + Primequest)
BTW, page_reset_page_cgroup, defined as this
==
#define page_reset_bad_cgroup(page) ((page)->page_cgroup = 0)
==
Should be
==
#define page_reset_bad_cgroup(page) ((page)->page_cgroup = 0UL)
==
...I'll write a patch.
Thanks,
-Kame
--
| Apr 17, 8:04 pm 2008 |
| Dan Williams | Re: [PATCH mm] sysfs: add /sys/dev/usb to handle CONFIG_ ...
Thanks! This resolves the warnings here. Now I'll take a shot at
Regards,
Dan
--
| Apr 18, 9:37 am 2008 |
| Dan Williams | Re: [PATCH mm] sysfs: add /sys/dev/usb to handle CONFIG_ ...
Hm, so how about making this an opt-in capability of the class? At
device_add() time the class is queried to see if a link should be
created in /sys/dev/block or /sys/dev/char? Although, this leads to
inconsistent coverage. But maybe that does not matter as many of
these character devices do not have interesting attributes to be
accessed? Sigh, I am beginning to wonder if the character device side
of this capability is a solution looking for a problem...
Thanks,
Dan
--
| Apr 17, 9:59 pm 2008 |
| Dan Williams | [PATCH mm] sysfs: add /sys/dev/usb to handle CONFIG_USB_ ...
The deprecated config option CONFIG_USB_DEVICE_CLASS causes class devices
with duplicate major:minor numbers to be registered. In effect they
represent a usb specific address space for major:minor numbers so add 'usb'
as a directory along side 'block' and 'char'.
Cc: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
This boots up without warning on my dev system. We end up with the
following situation:
$ ls -l /sys/dev/usb/189:0
lrwxrwxrwx 1 ...
| Apr 17, 7:11 pm 2008 |
| Kay Sievers | Re: [PATCH mm] sysfs: add /sys/dev/usb to handle CONFIG_ ...
This could work, yes. We could just set a flag in the class, that
The usual case is that one of the duplicated /sys devices is deprecated,
We will find a solution. :)
The following should work for the common case.
Best,
Kay
From: Kay Sievers <kay.sievers@vrfy.org>
Subject: sysfs: fix duplicated device number registration in /sys/dev/
If the parent device has the same dev_t, we skip the registration
for the device number at /sys/dev.
Cc: Dan Williams ...
| Apr 18, 12:54 am 2008 |
| Dan Williams | Re: [PATCH mm] sysfs: add /sys/dev/usb to handle CONFIG_ ...
On Thu, Apr 17, 2008 at 8:08 PM, Andrew Morton
I'll take a look. And Greg shares my suspicion that there might be
other duplicate devices like these USB class devices, so need to look
Thanks,
Dan
--
| Apr 17, 8:44 pm 2008 |
| Greg KH | Re: [PATCH mm] sysfs: add /sys/dev/usb to handle CONFIG_ ...
This patch is not going to work if usbcore is a module :(
thanks,
greg k-h
--
| Apr 17, 8:00 pm 2008 |
| Greg KH | Re: [PATCH mm] sysfs: add /sys/dev/usb to handle CONFIG_ ...
Hm, no they do not, they are not a new address space, we are just
reusing them as the other user wasn't using them, and the code is
deprecated and will be removed eventually. Neither of these char
devices are really hooked up to anything within the kernel, so it
doesn't matter yet.
I wonder how many other duplicates we have floating around...
thanks,
greg k-h
--
| Apr 17, 8:21 pm 2008 |
| Andrew Morton | Re: [PATCH mm] sysfs: add /sys/dev/usb to handle CONFIG_ ...
mutter. I'd have thought that with suitable fiddling most of this code
could be moved into the USB core and some of it (the
kobject_create_and_add()) can be done via USB's initcalls.
this:
--- a/drivers/base/core.c~sysfs-add-sys-dev-usb-to-handle-config_usb_device_class=y-fix
+++ a/drivers/base/core.c
@@ -31,7 +31,6 @@ static struct kobject *dev_kobj;
static struct kobject *char_kobj;
static struct kobject *block_kobj;
#ifdef CONFIG_USB_DEVICE_CLASS
-extern struct class ...
| Apr 17, 8:08 pm 2008 |
| Roland McGrath | [PATCH] ptrace_signal subroutine
This breaks out the ptrace handling from get_signal_to_deliver
into a new subroutine. The actual code there doesn't change, and
it gets inlined into nearly identical compiled code. This makes
the function substantially shorter and thus easier to read, and
it nicely isolates the ptrace magic.
Signed-off-by: Roland McGrath <roland@redhat.com>
---
kernel/signal.c | 71 ++++++++++++++++++++++++++++++++----------------------
1 files changed, 42 insertions(+), 29 deletions(-)
diff --git ...
| Apr 17, 6:44 pm 2008 |
| Kyle McMartin | Re: [PATCH] ptrace_signal subroutine
Nice clean up.
cheers, Kyle
--
| Apr 17, 7:00 pm 2008 |
| Mathieu Desnoyers | [RFC PATCH] x86 NMI-safe INT3 and Page Fault (v6)
Implements an alternative iret with popf and return so trap and exception
handlers can return to the NMI handler without issuing iret. iret would cause
NMIs to be reenabled prematurely. x86_32 uses popf and far return. x86_64 has to
copy the return instruction pointer to the top of the previous stack, issue a
popf, loads the previous esp and issue a near return (ret).
It allows placing immediate values (and therefore optimized trace_marks) in NMI
code since returning from a breakpoint would be ...
| Apr 17, 5:45 pm 2008 |
| Matt LaPlante | ipsec blocking issue in 2.6.25 (and earlier)
I'd like to call attention to an apparent bug that has been causing me some significant trouble lately. In brief, transmission of data over IPSEC (apparently the sendmsg call in particular) is blocking when the IPSEC connection becomes unavailable. This is causing various daemons such as named and squid to behave rather badly... in the case of named, it binds (no pun intended) up the entire daemon and it starts refusing queries from all interfaces.
I first noticed this somewhat earlier on in the ...
| Apr 17, 5:33 pm 2008 |
| David Miller | Re: ipsec blocking issue in 2.6.25 (and earlier)
echo "1" >/proc/sys/net/core/xfrm_larval_drop
--
| Apr 17, 6:13 pm 2008 |
| Marcus Furlong | Re: [BUG] 2.6.25-rc9 Oops (keyboard/mouse related)
On Thursday 17 April 2008 02:16 in <200804162116.14712.dtor@insightbb.com>,
Here's another one, with dmesg:
[ 0.000000] Linux version 2.6.25-rc9 (root@griffith) (gcc version 4.1.2
(Gentoo 4.1.2 p1.0.2)) #2 SMP PREEMPT Wed Apr 16 22:28:08 IST 2008
[ 0.000000] BIOS-provided physical RAM map:
[ 0.000000] BIOS-e820: 0000000000000000 - 000000000009f000 (usable)
[ 0.000000] BIOS-e820: 000000000009f000 - 00000000000a0000 (reserved)
[ 0.000000] BIOS-e820: 0000000000100000 - ...
| Apr 17, 5:08 pm 2008 |
| Michael Karcher | Re: [PATCH] usb-serial: option: Don't match Huawei drive ...
The patch is developed against 2.6.25-rc8 + some git patches, but I have
forward-ported it to current git.
I *guess* you are talking about commit aad8a278 (USB: support more
Huawei data card product IDs), as I could not find . The header of this
patch talks about three changes (declaration of unusual devices,
disabling product ID matching in driver.c and finally declaring the
product in option.c). I find only the first and the last point if this
reflected in the patch, and there are *no* ...
| Apr 17, 11:01 pm 2008 |
| Michael Karcher | Re: [PATCH] usb-serial: option: Don't match Huawei drive ...
insert "any other patches applying to usb/usb-serial that might be
involved" before the full stop.
Kernel compiled & booted. Won't work without the patch.
Relevant dmesg and lsusb -v output follows.
Regards,
Michael Karcher
dmesg:
usb 2-1: new full speed USB device using uhci_hcd and address 2
usb 2-1: configuration #1 chosen from 1 choice
usbcore: registered new interface driver usbserial
drivers/usb/serial/usb-serial.c: USB Serial support registered for generic
usbcore: registered ...
| Apr 17, 11:30 pm 2008 |
| Greg KH | Re: [PATCH] usb-serial: option: Don't match Huawei drive ...
What is this patch against? We have a change that went into 2.6.25
after 2.6.25-rc9 that should make this patch not be needed.
Can you try that release and verify this?
thanks,
greg k-h
--
| Apr 17, 8:24 pm 2008 |
| Andrew Morton | Re: 2.6.25-mm1: not looking good
Another runtime warning on the t61p:
Brought up 2 CPUs
Total of 2 processors activated (9583.80 BogoMIPS).
CPU0 attaching sched-domain:
domain 0: span 00000000,00000003
groups: 00000000,00000001 00000000,00000002
domain 1: span 00000000,00000003
groups: 00000000,00000003
CPU1 attaching sched-domain:
domain 0: span 00000000,00000003
groups: 00000000,00000002 00000000,00000001
domain 1: span 00000000,00000003
groups: 00000000,00000003
------------[ cut here ...
| Apr 18, 12:50 am 2008 |
| Jason Wessel | Re: 2.6.25-mm1: not looking good
Unless you have a qemu with the NMI patches, kgdb does not work on SMP
with qemu. The very first test is going to fail because the IPI sent by
the kernel is not handled in qemu's hardware emulation.
Jason.
--
| Apr 18, 6:27 am 2008 |
| Kay Sievers | Re: 2.6.25-mm1: not looking good
Is this with the deprecated CONFIG_USB_DEVICE_CLASS=y? They have the
same dev_t as usb_device and would be a reason for the duplicates.
Thanks,
Kay
--
| Apr 17, 5:48 pm 2008 |
| Andrew Morton | Re: 2.6.25-mm1: not looking good
On Thu, 17 Apr 2008 19:55:46 -0400
I dropped git-selinux and that crash seems to have gone away. It took about
five minutes before, but would presumably have happened earlier if I'd
reduced the cache size.
btw, wouldn't this
--- a/security/selinux/netnode.c~a
+++ a/security/selinux/netnode.c
@@ -190,7 +190,7 @@ static int sel_netnode_insert(struct sel
if (sel_netnode_hash[idx].size == SEL_NETNODE_HASH_BKT_LIMIT) {
struct sel_netnode *tail;
tail = list_entry(node->list.prev, ...
| Apr 17, 6:35 pm 2008 |
| Arjan van de Ven | Re: 2.6.25-mm1: not looking good
On Thu, 17 Apr 2008 16:03:31 -0700
do you have a stack-protector capable GCC? I guess not.
This is a catch-22. You do not have stack-protector. Should we make that
a silent failure? or do you want to know that you don't have a security
feature you thought you had.... complaining seems to be the right thing to do imo.
--
If you want to reach me at my work email, use arjan@linux.intel.com
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
--
| Apr 17, 10:49 pm 2008 |
| Ingo Molnar | Re: 2.6.25-mm1: not looking good
cool! Jason: i think that particular self-test should be repeated 1000
times before reporting success ;-)
Ingo
--
| Apr 18, 5:34 am 2008 |
| Paul Moore | Re: 2.6.25-mm1: not looking good
Yes, I believe it was testing it with slub.
--
paul moore
linux @ hp
--
| Apr 18, 7:55 am 2008 |
| Andrew Morton | Re: 2.6.25-mm1: not looking good
Not really. In the selinux case we don't know that it'll break at compile
Yeah, #error would work too.
--
| Apr 18, 12:28 am 2008 |
| Andrew Morton | Re: 2.6.25-mm1: not looking good
The mac g5 is warning us about stuff too:
io scheduler deadline registered
io scheduler cfq registered
io scheduler bfq registered
proc_dir_entry '00' already registered
Call Trace:
[c00000017a0fbb80] [c000000000012018] .show_stack+0x58/0x1dc (unreliable)
[c00000017a0fbc30] [c00000000013f68c] .proc_register+0x218/0x260
[c00000017a0fbce0] [c00000000013fab8] .proc_mkdir_mode+0x40/0x74
[c00000017a0fbd60] [c0000000001f49a8] .pci_proc_attach_device+0x90/0x134
[c00000017a0fbe00] ...
| Apr 17, 9:07 pm 2008 |
| Vegard Nossum | Re: 2.6.25-mm1: not looking good
Oops, no, and that makes sense.
I now picked up qemu 0.9.1 and applied the three NMI/SMI patches by Jan Kiszka.
So in qemu it seems to run fine now, except that I need to prod it
sometimes (it gets stuck in cpu_clock() and I have to break/continue
from gdb to make it proceed). Oh, there it made it to 1056, and gdb
can't interrupt anymore. Hmm. This is probably not a very good
But booting with nosmp on real hardware gets easily above 100,000
iterations of the loop (before I reboot), so it ...
| Apr 18, 7:47 am 2008 |
| Vegard Nossum | Re: 2.6.25-mm1: not looking good
[Empty message]
| Apr 18, 5:41 am 2008 |
| Ingo Molnar | Re: 2.6.25-mm1: not looking good
hm, there's sel_netnode_free() in the stackframe - that's from
security/selinux/netnode.c. Andrew, any recent changes in that area?
Ingo
--
| Apr 18, 12:24 am 2008 |
| Ingo Molnar | Re: 2.6.25-mm1: not looking good
that's the stackprotector self-test: you probably have a gcc that cannot
build a proper stackprotector kernel. No damage other than having no
stackprotector. Arjan Cc:-ed.
Ingo
--
| Apr 18, 12:09 am 2008 |
| Arjan van de Ven | Re: Stack protector build failure (was Re: 2.6.25-mm1: n ...
ok I found a way that works for me:
From: Arjan van de Ven <arjan@linux.intel.com>
Subject: [PATCH] stackprotector: turn not having the right gcc into an #error
If the user selects the stack-protector config option, but does not have
a gcc that has the right bits enabled (for example because it isn't build
with a glibc that supports TLS, as is common for cross-compilers, but also
because it may be too old), then the runtime test fails right now.
Andrew rightfully points out that this is a ...
| Apr 18, 9:57 am 2008 |
| Vegard Nossum | Re: 2.6.25-mm1: not looking good
With the patch below, it seems 100% reproducible to me (7 out of 7
bootups hung).
The number of loops it could do before hanging were, in order: 697,
898, 237, 55, 45, 92, 59
It seems timing-related, so I'm guessing it could be some interaction
with interrupts?
Vegard
diff --git a/drivers/misc/kgdbts.c b/drivers/misc/kgdbts.c
index 6d6286c..ee87820 100644
--- a/drivers/misc/kgdbts.c
+++ b/drivers/misc/kgdbts.c
@@ -895,7 +895,13 @@ static void kgdbts_run_tests(void)
...
| Apr 18, 4:46 am 2008 |
| Jason Wessel | Re: 2.6.25-mm1: not looking good
I assume this was SMP?
While I had not tried it yet, my guess would have been this did not
happen on a UP kernel. If it does occur on a UP kernel it means the
problem is squarely between the task scheduling after the exception is
handled and the kgdb state logic for re-entering the debug state after a
single step exception occurs.
It seems reasonable to go for 1000 iterations of this particular test to
declare success as pointed out by Ingo. Previous versions of kgdb
handled some of the ...
| Apr 18, 6:02 am 2008 |
| Andrew Morton | Re: 2.6.25-mm1: not looking good
Yes, I'd agree. All has been peachy since I dropped git-selinux.
--
| Apr 17, 11:56 pm 2008 |
| Pavel Machek | Re: 2.6.25-mm1: not looking good
Try rmmod usb / insmod usb around suspend to see if it is
usb-specific, or if something went seriously wrong in core.
Or you might just bisect it ;-).
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
| Apr 18, 2:42 am 2008 |
| Ingo Molnar | Re: 2.6.25-mm1: not looking good
you noticed it ;-) Distro maintainers will notice it too if it pops up
when something breaks StackProtector. Normal user might not notice. (but
normal user might not notice a few hundred guest roots either)
but ... the real thing that made it slip into your config was that it
was default-enabled in x86/latest - the patch below should fix that.
we need the warning: it could have caught the toplevel Makefile change
last October that broke StackProtector completely. So no, we wont be and ...
| Apr 18, 2:28 am 2008 |
| Paul Moore | Re: 2.6.25-mm1: not looking good
Looks good to me, although before I fix this let me try and figure out
why this code is causing the machine to puke all over itself.
Priorities you know :)
--
paul moore
linux @ hp
--
| Apr 18, 7:57 am 2008 |
| Andrew Morton | Re: 2.6.25-mm1: not looking good
On Thu, 17 Apr 2008 19:55:46 -0400
Perhaps it was tested only against slub? That config uses slab.
--
| Apr 17, 5:04 pm 2008 |
| Ingo Molnar | Re: 2.6.25-mm1: not looking good
that came in via the UV-APIC patchset but the warning is entirely
harmless. At that point we've got a single CPU running only so
preemption of that code to another CPU is not possible.
native_smp_prepare_cpus() should probably just disable preemption, that
way we could remove all those ugly preempt disable-enable calls from the
called functions - per the patch below. (not boot tested yet - might
provoke atomic-scheduling warnings if i forgot about some schedule point
in this rather ...
| Apr 18, 2:22 am 2008 |
| Jason Wessel | Re: 2.6.25-mm1: not looking good
So I pulled your tree and I would agree there was a problem. But it
seems unrelated to kgdb. I bisected the tree because it worked starting
with the kgdb-light merge.
It fails once with the patch below, but it is not clear as to why other
than the lock must have something to do with it.
I'll submit a patch to the kgdb test suite to increase the amount of
loops through the single step test as it is it can definitely catch
things :-)
Jason.
From ...
| Apr 18, 2:54 pm 2008 |
| Andrew Morton | Re: 2.6.25-mm1: not looking good
On Thu, 17 Apr 2008 16:40:34 -0700
Disabling CPA_DEBUG didn't help. It's still hanging. The final initcall
is init_kgdbts() and disabling KGDB prevents the hang.
--
| Apr 17, 5:14 pm 2008 |
| Andrew Morton | Re: 2.6.25-mm1: not looking good
On Fri, 18 Apr 2008 02:48:19 +0200
--
| Apr 17, 6:12 pm 2008 |
| Jason Wessel | Re: 2.6.25-mm1: not looking good
In this case you do not have to disable kgdb, but just disable the
kgdb test suite. Certainly I would be interested to know where it is
failing as it would indicate that there is a regression that is caused
by a change that occurred somewhere else in the kernel or a latent
defect in kgdb was triggered. The kgdb test suite exercises a number
of kernel fault systems as well as arch specific single stepping when
it runs and when it fails it is likely worth it to track down which
test failed and ...
| Apr 17, 8:05 pm 2008 |
| Andrew Morton | Re: 2.6.25-mm1: not looking good
A #warning sounds more appropriate.
--
| Apr 17, 11:10 pm 2008 |
| Pekka Enberg | Re: 2.6.25-mm1: not looking good
On Fri, Apr 18, 2008 at 2:03 AM, Andrew Morton
Andrew, you don't seem to have slab debugging enabled:
# CONFIG_DEBUG_SLAB is not set
And quite frankly, the oops looks unlikely to be a slab bug but rather
a plain old slab corruption cause by the callers...
Pekka
--
| Apr 17, 11:40 pm 2008 |
| Ingo Molnar | Re: 2.6.25-mm1: not looking good
this warning is telling the user that the security feature that got
enabled in the .config is completely, 100% not working due to using a
stack-protector-incapable GCC.
it's analogous as if there was a bug in gcc that made SELinux totally
ineffective in some mitigate-exploit-damage scenarios. No harm done on a
perfectly bug-free system - but once a bug happens that SELinux should
have mitigated, the breakage becomes real. Having a prominent warning is
the _minimum_.
having a build ...
| Apr 18, 12:19 am 2008 |
| Pekka Enberg | Re: 2.6.25-mm1: not looking good
Keep in mind that slab might have been corrupted by someone else much
earlier but we didn't notice due to the lack of CONFIG_SLAB_DEBUG.
--
| Apr 18, 12:25 am 2008 |
| Ingo Molnar | Re: 2.6.25-mm1: not looking good
incidentally, just today, in overnight testing i triggered a similar
hang in the KGDB self-test:
http://redhat.com/~mingo/misc/config-Thu_Apr_17_23_46_36_CEST_2008.bad
to get a similar tree to the one i tested, pick up sched-devel/latest
from:
http://people.redhat.com/mingo/sched-devel.git/README
pick up that failing .config, do 'make oldconfig' and accept all the
defaults to get a comparable kernel to mine. (kgdb is embedded in
sched-devel.git.)
the hang was at:
[ ...
| Apr 18, 12:37 am 2008 |
| Andrew Morton | Re: 2.6.25-mm1: not looking good
oop, there's more:
sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00
sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
firewire_core: created device fw0: GUID 00016c2000174bad, S400
PM: Device usb4 failed to restore: error -113
eth0: Link is Up 100 Mbps Full Duplex, Flow Control: RX/TX
eth0: 10/100 speed: disabling TSO
PM: Device usb5 failed to restore: error -113
PM: Device usb7 failed to restore: error -113
sd 0:0:0:0: [sda] Starting disk
PM: Image ...
| Apr 18, 12:53 am 2008 |
| Andrew Morton | Re: 2.6.25-mm1: not looking good
I found another machine! This one's an old 4-way Nocona (x86_64)
http://userweb.kernel.org/~akpm/config-x.txt
http://userweb.kernel.org/~akpm/dmesg-x.txt
CPU: Physical Processor ID: 0
CPU: Processor Core ID: 0
CPU0: Thermal monitoring enabled (TM1)
ACPI: Core revision 20080321
Parsing all Control Methods:
Table [DSDT](id 0001) - 461 Objects with 50 Devices 130 Methods 11 Regions
tbxface-0598 [00] tb_load_namespace : ACPI Tables successfully acquired
evxfevnt-0091 [00] enable ...
| Apr 18, 12:57 am 2008 |
| James Morris | Re: 2.6.25-mm1: not looking good
I've reverted the -mm only change to that file in
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/selinux-2.6.git#for-akpm
commit f777964ad75cf4a119d911d12e81948d2402677f
Author: James Morris <jmorris@namei.org>
Date: Fri Apr 18 20:27:24 2008 +1000
Revert "SELinux: Made netnode cache adds faster"
This reverts commit 6bf8f41d4efdf9d4eeb4f7df9c591e281f7da93e.
Possible cause of slab corruption in -mm.
--
James Morris
<jmorris@namei.org>
--
| Apr 18, 3:32 am 2008 |
| Pavel Machek | Re: 2.6.25-mm1: not looking good
I got USB messages after s2ram + suspend to disk combination, too, but
machine seems to work.
ata1.00: ACPI cmd ef/10:03:00:00:00:a0 succeeded
ata1.00: configured for UDMA/100
ata1.00: configured for UDMA/100
ata1: EH complete
sd 0:0:0:0: [sda] 117210240 512-byte hardware sectors (60012 MB)
sd 0:0:0:0: [sda] Write Protect is off
sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00
sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't
support DPO or FUA
sd 0:0:0:0: [sda] 117210240 ...
| Apr 18, 4:07 am 2008 |
| Ingo Molnar | Re: 2.6.25-mm1: not looking good
that should be the patch below.
Ingo
------------>
Subject: x86: disable preemption in native_smp_prepare_cpus
From: Ingo Molnar <mingo@elte.hu>
Date: Fri Apr 18 11:07:10 CEST 2008
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/smpboot.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
Index: linux-x86.q/arch/x86/kernel/smpboot.c
===================================================================
--- linux-x86.q.orig/arch/x86/kernel/smpboot.c
+++ ...
| Apr 18, 5:18 am 2008 |
| Vegard Nossum | Re: 2.6.25-mm1: not looking good
On Fri, Apr 18, 2008 at 3:02 PM, Jason Wessel
Yes. But now that I realize this, I tried running same kernel with
qemu, using -smp 16, and it seems to be stuck here:
[ 16.562659] kgdb: Registered I/O driver kgdbts.
[ 16.565875] kgdbts:RUN plant and detach test
and the code is at kgdb_handle_exception():
/*
* Wait for the other CPUs to be notified and be waiting for us:
*/
for_each_online_cpu(i) {
while ...
| Apr 18, 6:22 am 2008 |
| Arjan van de Ven | Stack protector build failure (was Re: 2.6.25-mm1: not l ...
On Fri, 18 Apr 2008 00:28:58 -0700
I'm totally fine with that, but I think I need Sam's help on making that happen
the right way; this is going to need makefile fu L(
Sam:
Basically what I need is that if the
scripts/gcc-x86_64-has-stack-protector.sh script fails, the build aborts with
a message/#error that says that the compiler is not capable of supporting this feature.
Right now the script is used like this:
stackp := $(CONFIG_SHELL) ...
| Apr 18, 6:58 am 2008 |
| Alan Stern | Re: 2.6.25-mm1: not looking good
There's no need to worry about them. They merely indicate that the
root hubs didn't resume along with everything else, because they were
already suspended when the system went to sleep and so they were left
suspended. The return codes in usbcore will be changed soon so that
this won't appear to be an error.
Alan Stern
--
| Apr 18, 8:22 am 2008 |
| Vegard Nossum | Re: 2.6.25-mm1: not looking good
It gets stuck in kgdb_roundup_cpus(), verified by putting a printk()
before and after this call (in kgdb_handle_exception()). Simple, but
effective :-)
Vegard
--
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
-- E. W. Dijkstra, EWD1036
--
| Apr 18, 9:02 am 2008 |
| Andi Kleen | Re: [RFC PATCH] x86 NMI-safe INT3 and Page Fault (v5)
RCU is not necessarily NMI safe. In most cases RCU needs writer locks
which you cannot do with NMIs.
-Andi
--
| Apr 18, 4:30 am 2008 |
| Mathieu Desnoyers | Re: [RFC PATCH] x86 NMI-safe INT3 and Page Fault (v5)
It uses RCU-style updates and has been designed to be lockless from the
ground up.
Mathieu
--
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
--
| Apr 17, 5:06 pm 2008 |
| Andi Kleen | Re: [RFC PATCH] x86 NMI-safe INT3 and Page Fault (v5)
Wrong. If it causes vmalloc faults it is not lockless.
-Andi
--
| Apr 18, 1:07 am 2008 |
| Takashi Iwai | Re: [PATCH] OSS: dmabuf: fix negative DMAbuf_get_buffer_ ...
At Thu, 17 Apr 2008 20:38:57 +0200,
I applied it to my git tree. Thanks.
--
| Apr 18, 3:28 am 2008 |
| Miklos Szeredi | Re: nfs: lock stuck after interrupt
Thanks for the info.
1) I pulled the devel branch of nfs-2.6.git and tested the same setup,
with exactly the same result as previously.
2) then I added your patch on top of that, which did change something
but not really for the better: now even the restarted lock request
doesn't succeed after the interrupt.
According to my suspicion, this is an issue in the server, while both
referenced patches touch only the client.
Appended little test program which I'm trying out locking ...
| Apr 18, 4:07 am 2008 |
| Aaron Wiebe | Re: nfs: lock stuck after interrupt
Note that my little patch purely resolves the situation we were seeing
on the client side. We were using Netapps for servers.
We're actually using that small patch, against 2.6.22, in production
right now and it has still solved our issue.
-Aaron
--
| Apr 18, 5:20 am 2008 |
| Jack Harvard | Re: gettimeofday() in 2.6.24
is "xtime" updated by the time tick clock timer, i.e., the timer which
generates interrupts every 1/HZ second to the kernel. Put it in
another way,
does gettimeofday get time in two parts 1) seconds from xtime.tv_sec,
updated by timer0, 2) microseconds from xtime.tv_nsec +
system_timer->offset(), updated by timer0 and timer3.
Do you mean the code here
"http://lxr.linux.no/linux+v2.6.24/kernel/time/timekeeping.c#L45"
--
| Apr 18, 1:54 am 2008 |
| Chris Friesen | Re: gettimeofday() in 2.6.24
Yes, I think xtime is updated by the tick timer.
system_timer->offset() may be updated by different mechanisms, depending
No. As I said, the function usually has "gettimeoffset" in the name and
it's specific to arm so it would be under arch/arm. For instance, on
Xscale boards it's ixp2000_gettimeoffset() in arch/arm/mach-ixp2000/core.c.
For more information you might want to look at the code in arch/arm or
else talk to the arm developers on the linux-arm-kernel mailing ...
| Apr 18, 7:35 am 2008 |
| Jeremy Fitzhardinge | Re: [RFC PATCH] x86 NMI-safe INT3 and Page Fault (v4)
I got this right first go? I must be getting good at this...
Anyway, trailing ';', and perhaps use a consistent form for mov (either
movq or mov in all three instances).
J
--
| Apr 18, 3:04 am 2008 |
| Roel Kluin | Re: [PATCH v2] mballoc: fix hot spins after err_freebudd ...
Won't this work as well?
---
In ext4_mb_init_backend() 'i' is of type ext4_group_t. Since unsigned, i >= 0 is
always true, so fix hot spins after err_freebuddy: and -meta: and prevent
decrements when zero.
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index ef97f19..054cd33 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -2572,13 +2572,13 @@ static int ext4_mb_init_backend(struct super_block *sb)
meta_group_info[j] = ...
| Apr 18, 5:13 am 2008 |
| Aneesh Kumar K.V | Re: [PATCH v2] mballoc: fix hot spins after err_freebudd ...
Won't this also have a memory corruption ? Let's say we fail in the first
loop itslef. That's with i = 0, and since we are using kmalloc.
we may find sbi->s_group_info[0] having some random values. So the
kfree can crash. Why not a simple change like below ?
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 28b5ada..c14f566 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -2223,7 +2223,7 @@ static noinline void ext4_mb_store_history(struct ext4_allocation_context *ac)
...
| Apr 17, 10:14 pm 2008 |
| Aneesh Kumar K.V | Re: [PATCH v2] mballoc: fix hot spins after err_freebudd ...
Updated one.
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 28b5ada..572d809 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -2223,7 +2223,7 @@ static noinline void ext4_mb_store_history(struct ext4_allocation_context *ac)
static int ext4_mb_init_backend(struct super_block *sb)
{
- ext4_group_t i;
+ long i; /* should be able to store group number */
int j, len, metalen;
struct ext4_sb_info *sbi = EXT4_SB(sb);
int num_meta_group_infos =
@@ -2257,6 +2257,7 ...
| Apr 17, 10:21 pm 2008 |
| Steven Whitehouse | Re: [PATCH] gfs2: fix assertion in log_refund()
Hi,
Now in the GFS2 -nmw git tree, which I'm just about to send a pull
request for,
Steve.
--
| Apr 18, 9:42 am 2008 |
| Peter Zijlstra | Re: Semphore -> mutex in the device tree
Do I interpert this correct when I envision a call-chain like this:
register_devise(A, some_parent)
lock_device(A, NESTING_PARENT)
D->probe()
register_device(B, A)
lock_device(B, NESTING_PARENT)
That would work iff register_device() sets a tree-level class on B that
Yes, associate a class with each level like this:
static struct lockdep_class_key device_tree_class[MAX_DEVICE_TREE_DEPTH];
register_device(child, parent)
{
...
child->depth = parent->depth + ...
| Apr 18, 8:32 am 2008 |
| Alan Stern | Re: Semphore -> mutex in the device tree
We must be talking at cross purposes. Are classes and subclasses all
that lockdep looks at?
Let's take a simpler example. Suppose driver D's probe routine
registers a child device. Then we have:
Subsystem: Register device A with driver core
Driver core: Lock device A with NESTING_PARENT
Call D:probe()
D:probe(): Register device B with driver core
as a child of A
Driver core: Lock device B with NESTING_PARENT
Call E:probe()
(where E is the appropriate ...
| Apr 18, 7:27 am 2008 |
| Peter Zijlstra | Re: Semphore -> mutex in the device tree
Lockdep only cares about class order; if you always lock NESTING_PARENT
-> NESTING_CHILD it won't complain; but it will not require you to hold
the parent lock (although I can provide you with an annotation to that
effect if you want; lockdep_assert_held(dev->parent->lock) - or
something like that).
As long as you're sure there aren't any actual deadlocks; and ensure you
use your annotated classes in the same order:
tree_level_n -> tree_level_n+1
and
tree_leve_n_sub_m -> ...
| Apr 17, 11:32 pm 2008 |
| Alan Stern | Re: Semphore -> mutex in the device tree
Aha. I never understood that lockdep classes worked like that.
I'm still not sure this will end up working. In the situation I have
in mind both sibling classes are locked by the same line of code;
I don't know if this ever occurs in the kernel. But it is a plausible
scenario.
In situations like this, where a private lock is acquired both before
and after a device lock (albeit on different levels), the most logical
solution is to assign each private lock to a class connected ...
| Apr 18, 2:45 pm 2008 |
| Casey Schaufler | Re: Security testing tree patch review for 2.6.26
I have done basic testing on this patchset and have not
encountered any problems from the Smack side. I have not
Casey Schaufler
casey@schaufler-ca.com
--
| Apr 18, 11:11 am 2008 |
| Thomas Gleixner | Re: Smartmedia/xd card support - request for comments
And instead of addressing the missing features and shortcomings you
add a new duplicated code layer which is only useful for a restricted
Yeah and you made this decision on your own w/o even discussing the
issues at hand with the mtd developers before implementing a separate
code stack. And now we should be impressed and merge it. That's not
Merging your code as is is a bad idea as it contains userspace visible
changes which can not be undone easily. Interim solutions burden more
problems ...
| Apr 18, 2:35 am 2008 |
| Alex Dubov | Re: Smartmedia/xd card support - request for comments
Unfortunately, I must say, Smartmedia is not supported on linux for any reasonable definition of
the word.
First, with all the respect to Jorn, alauda driver can only be considered "proof of concept". It
does not try to abstract any smartmedia functionality.
Second, ssfdc is hopelessly obsolete and requires rewrite.
Third, there's no attempt made by mtd to support advanced functionality present in many smartmedia
and all memorystick readers: adapter side copy and multi page programming (this ...
| Apr 18, 1:47 am 2008 |
| Jörn | Re: Smartmedia/xd card support - request for comments
"Proof of concept" is the wrong term. The goal of
drivers/mtd/nand/alauda.c is to get raw access to the flash. It
explicitly does not abstract anything because I don't want the
abstraction. I want a raw piece of flash, represented via mtd. And I
believe it does match those goals - modulo some bugs.
You seem to want something else. I have a rough idea what that might
When using the raw mtd, it does. After block device translation, it
Correct. Erase() is the only callback-based ...
| Apr 18, 7:00 am 2008 |
| Eric Sandeen | Re: 2.6.25 released with bug, which leads to XFS crash?
Oh, aufs was not listed in the bug report. that's an out of tree
module, right? Is it completely up to date and safe with 2.6.25?
-Eric
--
| Apr 17, 5:39 pm 2008 |
| Denys Fedoryshchenko | Re: 2.6.25 released with bug, which leads to XFS crash?
AUFS(same as COSS, UFS, NULL) is way of handling with cache storage in squid, and nothing else. It is userspace and not involved deeply with kernel things.
Since long long time i didn't had any single problem with it.
Kernel is fully vanilla.
--
------
Technical Manager
Virtual ISP S.A.L.
Lebanon
--
| Apr 18, 3:32 am 2008 |
| Christoph Hellwig | Re: 2.6.25 released with bug, which leads to XFS crash?
And it's a completely crappy one. I personally would through away every
bug report with that piece of junk involved.
--
| Apr 18, 12:40 am 2008 |
| Eric Sandeen | Re: 2.6.25 released with bug, which leads to XFS crash?
ah, ok. I had assumed kernel module too, sorry.
-Eric
--
| Apr 18, 6:40 am 2008 |
| David Chinner | Re: 2.6.25 released with bug, which leads to XFS crash?
Well, yes, and we treat shutdown bugs as such. A filesystem shutdown
is effectively a filesystem panic and is indicative of either a
corruption or a bug. The reality is that it takes time to triage
such a problem that only occurs on one workload on one set of
identical machines once every day or two. This does not make the
problem a release blocker, though.
The other side of it is that problems like this in Linux are often
the result of a bug in a lower layer and not XFS itself. Given ...
| Apr 17, 5:06 pm 2008 |
| Christoph Hellwig | Re: 2.6.25 released with bug, which leads to XFS crash?
Ah, okay. There's also a kernel filesystem driver doing unioning that's
also called aufs that I'm referring to. sorry for the noise.
--
| Apr 18, 3:37 am 2008 |
| David Miller | Re: [PATCH] NET: catch signed nla_len() retval in tcf_si ...
From: Patrick McHardy <kaber@trash.net>
Even though there have been discussions to do other things,
this patch moves things in the forward direction so I have
applied it.
Thanks.
--
| Apr 17, 11:20 pm 2008 |
| Thomas Bächler | Re: 2.6.25: Reported regressions from 2.6.24
Got another regression:
Wakeup from ACPI S3 is broken in 2.6.25, x86_64, last known version is
2.6.25-rc8git8. My Lenovo Laptop does not wake up from S3. I have no
time to analyze this further now, but I will try to find out what
happened later today, will open a bugzilla then.
--
| Apr 17, 11:50 pm 2008 |
| Chuck Lever | Re: SUNRPC: Fix a memory leak in rpc_create()
I guessed it was required for 2.6.24 based on the patch dates (and a
fuzzy recollection of which release the "bad" commit went in). The
date on the "bad" commit was before the release of 2.6.24, so I
assumed the fix should be applied in 2.6.24 as well.
Mea culpa.
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
--
| Apr 18, 7:42 am 2008 |
| Ken'ichi Ohmichi | Re: vmcoreinfo: add the symbol "phys_base"
Hi,
I'm glad if this patch is merged into stable kernel, because this
patch solves the problem of a current makedumpfile. This patch is
very simple, and it doesn't have any bad influence for the kernel
building, the kernel operating or the other.
I will release the next makedumpfile which can run on also linux
without this patch. If both linux and makedumpfile have been fixed,
the condition that the problem occurs can be decreased.
Thanks
Ken'ichi Ohmichi
--
| Apr 18, 3:17 am 2008 |
| Bjorn Helgaas | Re: pnpacpi: reduce printk severity for "pnpacpi: exceed ...
I don't object to the point of the patch (changing KERN_ERR to
KERN_WARNING), but there is a more serious bug lurking here that
corrupts memory, and if we're doing a -stable patch, we should
fix it.
The test is:
if (i >= PNP_MAX_IRQ && !warned) {
printk(...);
warned = 1;
return;
}
But it should be:
if (i >= PNP_MAX_IRQ) {
if (!warned) {
printk(...);
warned = 1;
}
return;
--
| Apr 18, 2:48 pm 2008 |
| Chris Wright | Re: [stable] [patch 00/66] 2.6.24-stable review
updated roll-up at:
kernel.org/pub/linux/kernel/v2.6/stable-review/patch-2.6.24.5-rc2.gz
--
| Apr 18, 12:50 am 2008 |
| KOSAKI Motohiro | Re: [RFC patch 15/27] Immediate Values - Documentation ( ...
Looks good to me.
Thanks!
--
| Apr 17, 7:27 pm 2008 |
| David Miller | Re: [PATCH][netlabel] Don't risk NULL ptr deref in netlb ...
From: "Jesper Juhl" <jesper.juhl@gmail.com>
I've done that, thanks everyone.
--
| Apr 17, 11:23 pm 2008 |
| Cezary Jackiewicz | Re: [PATCH -mm 1/3] misc,acpi,backlight: Compal Laptop E ...
Dnia 2008-04-17, o godz. 14:33:15
Len wanted only entry in MAINTAINERS for compal driver.
--
Cezary
--
| Apr 18, 9:29 am 2008 |
| Andrew Morton | Re: [v2.6.26] what's brewing in x86.git for v2.6.26
allmodconfig.
In file included from include/linux/mm.h:39,
from include/linux/scatterlist.h:6,
from include/asm/dma-mapping.h:4,
from include/linux/dma-mapping.h:52,
from include/asm/pci.h:6,
from include/linux/pci.h:945,
from drivers/ata/ata_generic.c:21:
include/asm/pgtable.h: In function `set_pte_at':
include/asm/pgtable.h:670: warning: `init_mm' is deprecated (declared at ...
| Apr 18, 1:00 am 2008 |
| Ingo Molnar | Re: [v2.6.26] what's brewing in x86.git for v2.6.26
we do an automatic build test (of both vmlinux and of modules) of over
80 non-x86 architecture configs, amongst them are sparc64 and sparc
configs:
http://www.tglx.de/autoqa-cgi/index?run=86&tree=1
for the latest version of our trees all the 80 non-x86 configs (and all
96 configs in total) built successfully.
if in the sparc64 row you click on the green "OK" button (which signals
that the build was successful) you can get the build log and see all 7
warnings that get triggered ...
| Apr 18, 12:47 am 2008 |
| Andrew Morton | Re: [v2.6.26] what's brewing in x86.git for v2.6.26
Why can't I find this patch on the mailing list?
It's an MM patch which touches sched.h. It should not be in git-x86.
It generates over a megabyte of warnings on sparc64.
--
| Apr 17, 11:27 pm 2008 |
| Ingo Molnar | Re: [v2.6.26] what's brewing in x86.git for v2.6.26
ok, good point, i zapped this change [it was in the x86/testing section
anyway, i.e. not to be pushed upstream as an x86 change] - and if it's
resubmitted it should be sent to -mm anyway. Arjan, what do you think?
Ingo
--
| Apr 18, 5:48 am 2008 |
| David Miller | Re: [v2.6.26] what's brewing in x86.git for v2.6.26
From: Andrew Morton <akpm@linux-foundation.org>
If you're going to touch generic code, test build on other
platforms or get it into a tree where such build testing is
done for you.
--
| Apr 17, 11:38 pm 2008 |
| Tomasz Kłoczko | Re: [v2.6.26] what's brewing in x86.git for v2.6.26
Does it meany Linux give up implementing DTrace way of
tracing/instrumntation ? In last time I observe more and more signs
inroducing parallel ways of tracing/instrumentations infrasctructures in
Linux kernel where all this can be rolled into only one .. common. Strange
but some of this tracing/instrumentations does not uses "zero cost probes"
but "near zero cost probes" (like this) and this will result only more and
more bloated kernel code with statically injected ...
| Apr 18, 2:33 am 2008 |
| David Miller | Re: [v2.6.26] what's brewing in x86.git for v2.6.26
From: Christoph Hellwig <hch@infradead.org>
set_pte_at() is done inside drivers and what-not, you're not
going to be able to get rid of this export so easily.
--
| Apr 18, 1:18 am 2008 |
| Ingo Molnar | Re: [v2.6.26] what's brewing in x86.git for v2.6.26
quite so. Your change was promising from the get go and the latest
iteration was definitely a good one and is very much mergable. That it
also helps improve other architectures is the icing on the cake.
Andi will have to prove his points by coming up with competing benchmark
results - you certainly did your fair share to back up your change with
numbers. (and Andi, if/when you do so, please Cc: Alexander too in the
future. Dont you want him to be able to reply to your complaints ...
| Apr 18, 1:38 am 2008 |
| Nick Piggin | Re: [v2.6.26] what's brewing in x86.git for v2.6.26
Obviously that one won't because it is totally unsuitable to replace
SLAB. It may be a good choice to replace SLOB (if it is found to be
technically better). Just the same as SLQB might replace SLAB if it
is found to be technically better. That's (one main criteria for) how
we merge/decide between things.
--
| Apr 18, 4:12 am 2008 |
| Ingo Molnar | Re: [v2.6.26] what's brewing in x86.git for v2.6.26
btw., several percent of TPC-C is bad... so i take back the 'SLAB is
out' observation for now :-/
Ingo
--
| Apr 18, 5:41 am 2008 |
| Andi Kleen | Re: [v2.6.26] what's brewing in x86.git for v2.6.26
My point was really: "don't merge based on bogus benchmarks" or
perhaps better put: every time you see a benchmark result turn on your
brain and make sure it is really measuring something that makes sense
and also "don't put results from bogus benchmarks into change logs"
I actually don't have a big issue with the patches themselves (they
seem reasonably clean so they don't make the code worse, although I
don't think they are a significant improvement over the previous code
The initial ...
| Apr 18, 3:51 am 2008 |
| Christoph Hellwig | Re: [v2.6.26] what's brewing in x86.git for v2.6.26
Why is is deprecated anyway? I think we all agreed that killing the
export is good, but I don't see any way how we could kill the core
useage.
--
| Apr 18, 1:11 am 2008 |
| Ingo Molnar | Re: [v2.6.26] what's brewing in x86.git for v2.6.26
the goal of having more generic markers is still possible and being
aimed for - for in-kernel utilization like SystemTap, lttng, utrace,
ftrace and similar. The latest iteration of markers looks rather
promising in terms of giving us near-zero-cost probe points.
(and last i checked dtrace was not capable of doing something like
mmiotrace - so it's a different thing.)
so dont worry :)
Ingo
--
| Apr 18, 2:42 am 2008 |
| Pavel Machek | Re: [patch 3/3] ThinkPad ACPI: fix possible NULL pointer ...
are you sure? This seems to assume machine is thinkpad if kstrdup
fails... which is very wrong.
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
| Apr 18, 5:41 am 2008 |
| Cyrill Gorcunov | Re: [patch 3/3] ThinkPad ACPI: fix possible NULL pointer ...
[Pavel Machek - Fri, Apr 18, 2008 at 02:41:12PM +0200]
| Hi!
|
| > Fix potential NULL pointer dereference if kstrdup failed
| >
| > Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
| >
| > ---
| >
| > Index: linux-2.6.git/drivers/misc/thinkpad_acpi.c
| > ===================================================================
| > --- linux-2.6.git.orig/drivers/misc/thinkpad_acpi.c 2008-04-16 20:35:34.000000000 +0400
| > +++ linux-2.6.git/drivers/misc/thinkpad_acpi.c 2008-04-16 ...
| Apr 18, 6:53 am 2008 |
| Cyrill Gorcunov | Re: [patch 3/3] ThinkPad ACPI: fix possible NULL pointer ...
[Pavel Machek - Fri, Apr 18, 2008 at 02:41:12PM +0200]
| Hi!
|
| > Fix potential NULL pointer dereference if kstrdup failed
| >
| > Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
| >
| > ---
| >
| > Index: linux-2.6.git/drivers/misc/thinkpad_acpi.c
| > ===================================================================
| > --- linux-2.6.git.orig/drivers/misc/thinkpad_acpi.c 2008-04-16 20:35:34.000000000 +0400
| > +++ linux-2.6.git/drivers/misc/thinkpad_acpi.c 2008-04-16 ...
| Apr 18, 5:55 am 2008 |
| Cyrill Gorcunov | Re: [patch 3/3] ThinkPad ACPI: fix possible NULL pointer ...
[Pavel Machek - Fri, Apr 18, 2008 at 02:41:12PM +0200]
| Hi!
|
| > Fix potential NULL pointer dereference if kstrdup failed
| >
| > Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
| >
| > ---
| >
| > Index: linux-2.6.git/drivers/misc/thinkpad_acpi.c
| > ===================================================================
| > --- linux-2.6.git.orig/drivers/misc/thinkpad_acpi.c 2008-04-16 20:35:34.000000000 +0400
| > +++ linux-2.6.git/drivers/misc/thinkpad_acpi.c 2008-04-16 ...
| Apr 18, 6:07 am 2008 |
| Yinghai Lu | Re: [PATCH] - Increase MAX_APICS for large configs
how about without acpi=off?
can you make sure acpi=off works with previous kernel in that box?
YH
--
| Apr 18, 3:01 pm 2008 |
| Jack Steiner | Re: [PATCH] - Increase MAX_APICS for large configs
Has anyone seen this failure?? (Using git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86.git
from 4/18 AM).
I tried to reproduce the above failure on a small system & was not successful.
Switched to a larger system (XE310 Intel-based 8p, 6GB). All attempts to boot fail
with the following. I backed out the MAX_APIC change, & changed NR_CPUS=8. Still fails.
...
[ 32.010000] ehci_hcd 0000:00:1d.7: port 6 high speed
[ 32.010000] ehci_hcd 0000:00:1d.7: GetStatus port 6 ...
| Apr 18, 2:14 pm 2008 |
| Yinghai Lu | Re: [RFC][patch 2/5] mm: Node-setup agnostic free_bootmem()
according to patch from Suresh in x86.git, one node still only have one bdata.
YH
--
| Apr 17, 10:06 pm 2008 |
| Alessandro Zummo | Re: [PATCH 4/6] RTC: rtc-ds1374: fix unsigned new_alarm test
On Wed, 16 Apr 2008 17:32:28 +0200
Acked-by: Alessandro Zummo <a.zummo@towertech.it>
--
Best regards,
Alessandro Zummo,
Tower Technologies - Torino, Italy
http://www.towertech.it
--
| Apr 18, 2:58 pm 2008 |
| Dmitry Torokhov | Re: WM97xx touchscreen updates
Applied the lot, thank you Mark.
--
Dmitry
--
| Apr 17, 9:48 pm 2008 |
| Andrew Morton | Re: [RFC PATCH 1/2] Marker probes in futex.c
My 2c: if we even begin to countenance merging stuff like that, it's time
for all the trace code to be removed.
<checks the email headers>
Nope, it wasn't April 1st. Guys, get a grip.
--
| Apr 18, 3:44 am 2008 |
| Frank Ch. Eigler | Re: [RFC PATCH 1/2] Marker probes in futex.c
Hi -
At least two answers apply. The markers being put in should be chosen
with the concurrence of the subsystem maintainer, who should help
identify those key quantities that are likely to be both long-lived
and good diagnostic value. So that's the discussion we're having
right now: which values should be passed. If they're long-lived, then
they can be given a long-lived name - and it doesn't have to be a
low-level C variable name. (There's no reason why we can't also have
a slew of ...
| Apr 18, 7:29 am 2008 |
| Peter Zijlstra | Re: [RFC PATCH 1/2] Marker probes in futex.c
Then what do we do when someone comes along and changes one of those
names; do we go around changing the markers and then requiring all tools
to change as well?
(And no this isn't far fetched; I'm thinking of changing fshared in the
near future).
Sounds like people will complain and generate back pressure against such
changes - something we should avoid. As soon as these markers place a
Sure, but then just make a strace like tracer and be done with it - no
need to pollute the futex code ...
| Apr 17, 11:46 pm 2008 |
| Peter Zijlstra | Re: [RFC PATCH 1/2] Marker probes in futex.c
*blink* so all this is so you don't have to put a declarion in a header
file?
How about we put these premanent markers in a header - Mathieu says
there are <200. Surely that's not too much trouble.
Then you can keep this trace_mark() (perhaps trace_printf() is a better
So instead of writing normal C code and placing a declarion in a header,
you've come up with a scheme that needs to duplicate a text string to
check integrity. Sounds like a real good way to confuse people.
--
| Apr 17, 11:56 pm 2008 |
| Andrew Morton | Re: [PATCH sched-devel] ftrace: trace_entries to change ...
Maybe we need raw_spin_lock_init(). And DEFINE_RAW_SPINLOCK()?
Although it isn't a great idea to be encouraging the use of raw
spinlocks.
--
| Apr 18, 12:14 pm 2008 |
| Andrew Morton | Re: [PATCH sched-devel] ftrace: trace_entries to change ...
static struct tracer no_tracer __read_mostly = {
We should generate an error in this case, rather than just copying in a
wrong value.
The necessity to keep the 63 and 64 in sync is fragile. sizeof() would
I guess this really should be advanced by the number of bytes which
This can be grossly inefficient. A machine can (I believe) have 1024
possible CPUs with only four present.
It should size this storage by the number of online CPUs and implement the
So I stared at the data ...
| Apr 18, 3:23 am 2008 |
| Steven Rostedt | Re: [PATCH sched-devel] ftrace: trace_entries to change ...
I was thinking the same thing. Raw spin_locks should not be used, unless
there's a really good reason to use them. Strange things like mcount is
one example, but I cant think of many more. I'd be hesitant to add such an
API, which might lead to other users of raw_spin_locks when they really
shouldn't.
Not to mention that we also have raw_spinlock_t in -rt that has a little
different meaning.
-- Steve
--
| Apr 18, 12:25 pm 2008 |
| Steven Rostedt | Re: [PATCH sched-devel] ftrace: trace_entries to change ...
Andrew, thanks for taking you time in looking through this patch.
I saw that in my checkpatch run. But the API was strange to me
(my first time I've seen strict_strtoul). I'll look more at how to use
FYI, I'm currently working on a tutorial for OLS. Yes, I'm giving a
tutorial for ftrace. I'm now writing a LaTeX document of all the features.
One thing that will come out of this is a Documentation/ftrace.txt
Last night, while writing the above mentioned document, I thought ...
| Apr 18, 5:48 am 2008 |
| Mathieu Desnoyers | Re: [RFC PATCH] x86 NMI-safe INT3 and Page Fault (v3)
oprofile hooks this in the nmi callbacks :
arch/x86/oprofile/nmi_timer_int.c: profile_timer_exceptions_notify()
calls
drivers/oprofile/oprofile_add_sample()
which calls oprofile_add_ext_sample()
where
if (log_sample(cpu_buf, pc, is_kernel, event))
oprofile_ops.backtrace(regs, backtrace_depth);
First, log_sample writes into the vmalloc'd cpu buffer. That's for one
possible page fault.
Then, is a kernel backtrace happen, then I am not sure if ...
| Apr 17, 5:05 pm 2008 |
| Jeremy Fitzhardinge | Re: [RFC PATCH] x86 NMI-safe INT3 and Page Fault (v2)
Hm, I'd need to think about it more. There's more to NMI's than just
the popf.
J
--
| Apr 18, 2:49 am 2008 |
| Andi Kleen | Re: [RFC PATCH] x86 NMI-safe INT3 and Page Fault (v3)
A red hering: The notifier setup calls vmalloc_sync_all() and oprofile
Yes, admittedly the backtrace mode was always somewhat flakey. It probably
has more problems too.
The right fix for that is to call vmalloc_sync_all() after module load
First there are no truly periodic (as in time) NMIs. The NMI watchdog
is not really periodic but is delayed arbitrarily all the time when the CPU
is in sleep states.
Then oprofile does this already what you describe. Why do we need
another ...
| Apr 18, 1:27 am 2008 |
| Mathieu Desnoyers | Re: [RFC PATCH] x86 NMI-safe INT3 and Page Fault (v2)
I wonder if we could simply paravirtualize the popf instruction, which
seems to be the only one requiring to run in ring 0.
Mathieu
--
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
--
| Apr 17, 5:48 pm 2008 |
| Mike Isely | Re: [2.6 patch] video/pvrusb2/pvrusb2-hdw.c cleanups
FYI, I've merged this change into my local repository, and expect to
push it back up for 2.6.26 as part of a pent-up pile of pvrusb2 changes.
-Mike
--
Mike Isely
isely @ pobox (dot) com
PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8
--
| Apr 17, 11:03 pm 2008 |
| Andres Salomon | [PATCH] lxfb/gxfb: fix up __init and __initdata fields f ...
On Mon, 14 Apr 2008 22:39:15 -0400
Hm, no answer on that. Might as well just remove the const. Can you
please add the patch below?
A couple things were wrong here:
- a struct in lxfb should've been static.
- 'const' and '__initdata' don't mix, so the consts have been dropped
- get_modedb() in both drivers should've been marked w/ __init
Signed-off-by: Andres Salomon <dilinger@debian.org>
---
drivers/video/geode/gxfb_core.c | 8 ++++----
...
| Apr 17, 9:07 pm 2008 |
| Andres Salomon | Re: [Linux-fbdev-devel] [PATCH] fb: Remove use of lock_k ...
On Wed, 16 Apr 2008 20:00:59 -0300
Just a minor nit; in general, I'd think you would want to completely
initialize the structure (including calling mutex_init) before
registering the structure with the rest of the system (in this case,
with registered_fb and *_call_notifier_chain). Initializing after
registration is just asking for a race conditions.
--
Need a kernel or Debian developer? Contact me, I'm looking for contracts.
--
| Apr 18, 10:41 am 2008 |
| Stephen Neuendorffer | RE: [microblaze-uclinux] Re: Microblaze Linux release
http://developer.petalogix.com/wiki/UserGuide/AdvancedTopics/EnablingUnc
It probably makes sense to grab: arch/microblaze/mm/dma-coherent.c from
git.xilinx.com and drop consistent.c. I believe this is the more
'modern' way to implement this functionality. I think it's easiest for
I'd recommend dropping anything having to do with PCI: I don't know that
there is much interest in it on microblaze.
Other comments:
memset/memmove/memcpy are broken under gcc4. There are fixed versions
of ...
| Apr 18, 10:56 am 2008 |
| Jamie Lokier | Re: [PATCH 0/7] OMFS filesystem version 3
Oh, I agree. Violent agreement, they call it :-)
-- Jamie
--
| Apr 18, 9:15 am 2008 |
| Szabolcs Szakacsits | Re: [PATCH 0/7] OMFS filesystem version 3
Swap on loopback could deadlock with whatever file system, not only FUSE.
The correct and safe way to use swap with FUSE is using the fuseblk fstype
and a swap file on the FUSE file system (so it's exactly the same as one
would do with an in-kernel file system). This completely avoids the usage
of user space during swapping. This is in use for over a year with ntfs-3g,
e.g. by Knoppix and Mr Klaus Knopper wrote only positive things to me so
far.
Szaka
--
NTFS-3G: ...
| Apr 18, 6:13 am 2008 |
| Miklos Szeredi | Re: [PATCH 0/7] OMFS filesystem version 3
Fuse has two different APIs. For the "high level", path based one,
this is true. The "low level" one is very similar to the one provided
by the VFS.
On the low level interface, when the ->lookup() method is called, it
will provide a "nodeid", which is just a per-inode unique cookie (not
the same as st_ino). It can be a pointer to the private inode data
for example, and in the ->forget() method this private data can be
And I think the VFS is great. Undoubtedly kernel programming has ...
| Apr 18, 7:23 am 2008 |
| Jamie Lokier | Re: [PATCH 0/7] OMFS filesystem version 3
Presumably if "user space isn't involved at all", it must require that
user space has granted caching rights to the kernel over a FUSE
cache coherency protocol?
Otherwise I don't see how the kernel could coherently cache file pages
for some kinds of FUSE filesystems. (E.g. sshfs, for example: every
operation must surely invoke a user space request or involve granting
a caching right to the kernel, to keep accesses coherent with other
users of the same remote files).
Ergo, either its not ...
| Apr 18, 4:52 am 2008 |
| Miklos Szeredi | Re: [PATCH 0/7] OMFS filesystem version 3
Most filesystems (ntfs-3g included) cannot be modified from the
outside, so coherency isn't an issue.
Otherwise currently fuse provides rather crude settings for caching:
- timeout for attributes (per-inode, default 1s)
- timeout for names (per-dentry, default 1s)
- page cache is bypassed completely (per-file, default off)
- invalidation of page cache on open (per-open, default on)
Writes are synchronous even in the caching case, for various reasons.
That is one of the reasons ...
| Apr 18, 5:20 am 2008 |
| Bob Copeland | Re: [PATCH 0/7] OMFS filesystem version 3
Correct me if I'm wrong, but one place where caches seem necessary is for
lookup. My file system already has an inode number; my understanding
is that the kernel inode cache and dcache are caching the FUSE inode by
filename and its hashed inode number.
In FUSE, on open, I'm passed a filename which I then have to resolve into an
inode # via my own lookup. The VFS does the path_lookup as part of sys_open,
and since I get to put private data into the struct inode, I'll generally
already have ...
| Apr 18, 6:51 am 2008 |
| Jamie Lokier | Re: [PATCH 0/7] OMFS filesystem version 3
Seems sensible. As someone who is deep in coherency protocols at the
moment (I'm writing a robust distributed database/filesystem) I don't
Great!
I suggest adding another option (as well) where the filesystem can ask
fuse to send it synchronous validation requests - some things require
that. (In my own work, the choice of A->B async invalidation and B->A
synchronous validation is heuristic: some usage patterns benefit from
Fwiw, I think NFS version 4 is coherent (it uses leases), and ...
| Apr 18, 5:57 am 2008 |
| Szabolcs Szakacsits | Re: [PATCH 0/7] OMFS filesystem version 3
Thankfully you need none, it's already there by FUSE and the kernel. The
trick is exactly that you can have the kernel performance and the left is
moved to user space with typically negligible performance overhead which is
usually well compensated with faster delivered new features and bug fixes.
The completely unoptimized ntfs-3g read/write saturates my USB disks with
25-30 MB/sec using 8% (read), 35% (write) CPU time on a 2.5 GHz Core 2 Duo
with cold caches.
If you have the free ...
| Apr 18, 3:30 am 2008 |
| Bob Copeland | Re: [PATCH 0/7] OMFS filesystem version 3
Yep, I suspect switching to the lower-level API plus switching to mmap()
and getting rid of various memcpy's in omfs.c would make a huge difference.
Cool, thanks for the tips!
--
Bob Copeland %% www.bobcopeland.com
--
| Apr 18, 10:48 am 2008 |
| Miklos Szeredi | Re: [PATCH 0/7] OMFS filesystem version 3
Yes, that makes sense. I expect this could be done by extending the
existing requests with a flag saying the result is already cached.
And then the filesystem can either reply with a special "cached data
Oh well, you can turn off caching if it bothers you :) OTOH it would
be rather hard (and probably against the point) to try to extend the
sftp protocol to handle cache coherency. Sshfs is not meant to be a
normal filesystem (although some people are trying to use it for home
directories ...
| Apr 18, 9:01 am 2008 |
| Szabolcs Szakacsits | Re: [PATCH 0/7] OMFS filesystem version 3
FUSE is more than just providing a framework for block based filesystems.
Sometimes FUSE is criticised for the extra useful features it provides.
This is about as true as claiming FUSE doesn't have any context switch
overhead. Sometimes it has none, sometimes small, sometimes it can be
significant (e.g. when not using the 50 fold context switch speed up
patch). The question is, how releavant it is? Just some short notes,
1. Using the in-kernel cached data involves no context switch ...
| Apr 18, 5:46 am 2008 |
| Bob Copeland | Re: [PATCH 0/7] OMFS filesystem version 3
Sure. I'll go on record saying that omfs_fuse was written over a weekend and
can not be considered a good example of anything. I already had a
proto-libomfs that I had made for omfsck and mkomfs, and wanted to see how
easy it would be to wire that stuff up into a FUSE fs. Pretty easily, it
turned out.
--
Bob Copeland %% www.bobcopeland.com
--
| Apr 18, 7:43 am 2008 |
| Szabolcs Szakacsits | Re: [PATCH 0/7] OMFS filesystem version 3
I also don't advocate any solution, only interested in the FUSE myth
busting and making it easier to use and develop for, i.e. having the best
possible performance with zero effort.
I checked both solutions quickly, I think they are nicely written.
The kernel driver had 30 MB/s with 10% CPU usage, the FUSE version had
6 MB/s with high I/O waiting.
The major reason seems to be that the FUSE version reads heavily from the
block device during pure write operations, while the kernel ...
| Apr 18, 10:35 am 2008 |
| Jarod Wilson | Re: [PATCH update] firewire: fw-ohci: work around genera ...
Ah, I'll have to take a closer look at these cards and see if I can figure out
what drives the link layer... But barring the discovery of another TI chip,
I'm assuming an attempt to reproduce the generation issue will be fruitless.
Well, based on the positive results we've seen thus far with TI controllers
and this patch in Fedora kernels:
Signed-off-by: Jarod Wilson <jwilson@redhat.com>
--
Jarod Wilson
jwilson@redhat.com
--
| Apr 17, 7:51 pm 2008 |
| Takashi Iwai | Re: [PATCH] make alsa use corect patch for Realtek ALC889A
At Fri, 18 Apr 2008 03:52:06 +0200,
It's a bug of alsa-lib that was already fixed in the recent version.
You can open 4, 6 or 8 channels with the device. But, the default PCM
is set up only for two channels due to soft-mixing. You can use
special PCM names such as "surround51" to open for 5.1 output
instead. Again, no kernel issue.
thanks,
Takashi
--
| Apr 18, 3:16 am 2008 |
| Kasper Sandberg | Re: [PATCH] make alsa use corect patch for Realtek ALC889A
I wasnt sure how it was evaluated, i dont really know alsa alot, so i
Yes, sorry for delay, for some reason my mail client decided not to
update the view.. weird..
You should know that this is WITH my modification..
About problems.. well.. now that you do mention it, when i play
something without a .asoundrc, i get:
ALSA lib dlmisc.c:118:(snd_dlsym_verify) unable to verify version for
symbol _snd_pcm_empty_open
ALSA lib pcm.c:2108:(snd_pcm_open_conf) symbol _snd_pcm_empty_open is
not ...
| Apr 17, 6:52 pm 2008 |
| Bart Van Assche | Re: AMD Quad Core clock problem?
That's a very good question. I don't have enough knowledge of AMD quad
cores and the motherboards they are used in to answer this question.
There should be a kernel maintainer that is able to answer this
question though.
Last year I fixed a similar issue for PPC32. See also
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=0fbbeb....
Bart.
--
| Apr 18, 4:56 am 2008 |
| Miklos Szeredi | Re: nfs: infinite loop in fcntl(F_SETLKW)
OK, but that AFAICS is a lock manager implementation issue, not an API
No gfs2, only ext3.
Thanks,
Miklos
--
| Apr 18, 5:47 am 2008 |
| Benjamin Herrenschmidt | Re: [PATCH 1/2] Add thread_info_cache_init() to all archs
Yeah, missing quilt ref :-)
I'll send the proper patches in a minute.
Cheers,
Ben.
--
| Apr 17, 11:44 pm 2008 |
| Kyle McMartin | Re: [PATCH 1/2] Add thread_info_cache_init() to all archs
This is definitely the cleanest way to do this from my pov. Although I'm
slightly concerned about the proliferation of weak symbols, I'm much
more concerned with adding more include-order-dependent arch overrides. :)
speaking with the parisc dunce-cap on,
Kyle
--
| Apr 17, 9:21 pm 2008 |
| Michael Ellerman | Re: [PATCH 1/2] Add thread_info_cache_init() to all archs
There's also a #define of this called "__weak" if you like, less typing
and less ugly.
cheers
--=20
Michael Ellerman
OzLabs, IBM Australia Development Lab
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
| Apr 17, 9:38 pm 2008 |
| Benjamin Herrenschmidt | Re: [PATCH 1/2] Add thread_info_cache_init() to all archs
Well, looking there, I saw we already used weak symbols for that so what
about the patch below ? If you're ok, I'll re-send with appropriate sob
& adapted powerpc part.
Cheers,
Ben.
Index: linux-work/init/main.c
===================================================================
--- linux-work.orig/init/main.c 2008-03-26 10:39:25.000000000 +1100
+++ linux-work/init/main.c 2008-04-18 13:10:35.000000000 +1000
@@ -504,6 +504,10 @@ void __init __attribute__((weak)) smp_se
{
}
+void ...
| Apr 17, 8:58 pm 2008 |
| Andrew Morton | Re: [PATCH 1/2] Add thread_info_cache_init() to all archs
Yes, `weak' is a nice solution. It does add a few bytes of text which we
could avoid with compile-time trickery, but only a very few.
Plus this is __init anyway, although I don't know how well the combination
s/weak)/weak))/
--
| Apr 17, 9:19 pm 2008 |
| Seewer Philippe | Re: Disk geometry from /sys
Aye. Though I prefer the term virtual geometry. But thats cosmetics.
Sorry for beeing unclear, and many thanks for untangling my post.
If anyones interested in even more Details about C/H/S adressing and so
on, there's a very good document about that to be found here:
http://www.mossywell.com/boot-sequence/
--
| Apr 18, 6:37 am 2008 |
| Mark Lord | Re: Disk geometry from /sys
..
That can sound a bit misleading. The complete story, for ATA/SATA drives,
is that the disk has two geometries: an internal physical one, with a
fixed number of heads and cylinders, but variable sectors/track
(which normally varies by cylinder zone).
Software *never* sees or knows about that geometry, so ignore it.
The second geometry, is the one that the drive reports to software
as its "native" geometry. This is what you see from "hdparm -I"
and friends, and this geometry is what ...
| Apr 18, 6:22 am 2008 |
| Nadia Derbey | Re: [RFC][PATCH 0/4] Object creation with a specified id
OK, race problem between threads is fixed. Thanks for finding the issue!
The new patch series is coming next.
Regards,
Nadia
--
| Apr 17, 10:46 pm 2008 |
| Serge E. Hallyn | Re: [TOMOYO #7 30/30] Hooks for SAKURA and TOMOYO.
This is getting silly - if you change them "everywhere" then you can
change them in your security profiles too :)
Anyway this thread has degenerated again.
Crispin, thanks for posting those use cases.
Now the next step IMO is for someone (Tetsuo?) to take one of those use
cases and run through each of the four (was it 4?) proposed methods for
handling the pathnames. One paragraph describing how the use case in
general would be handled, then a list of shortcomings for the ...
| Apr 18, 6:21 am 2008 |
| Romano Giannetti | Re: [Suspend-devel] 2.6.25-rc6 regression - hang on resu ...
Sorry to be a bit though, but _what_ I'm supposed to patch? It's in
s2ram sources? Thanks!
Romano
--
Sorry for the disclaimer --- ¡I cannot stop it!
--
La presente comunicación tiene carácter confidencial y es para el exclusivo uso del destinatario indicado en la misma. Si Ud. no es el destinatario indicado, le informamos que cualquier forma de distribución, reproducción o uso de esta comunicación y/o de la información contenida en la misma están estrictamente prohibidos por la ...
| Apr 18, 12:34 am 2008 |
| Soeren Sonnenburg | Re: [Suspend-devel] 2.6.25-rc6 regression - hang on resu ...
Patch the sources of libx86... (s2ram makes use of that lib to do the
POSTing)
Soeren
--
| Apr 18, 1:32 am 2008 |
| Stefan Richter | Re: [PATCH upate] iso transmit cycle skip patch
Thanks. Committed to linux1394-2.6.git/master.
I will submit it to upstream in a week or so.
--
Stefan Richter
-=====-==--- -=-- =--=-
http://arcgraph.de/sr/
--
| Apr 18, 11:49 am 2008 |
| Pieter Palmers | Re: [PATCH upate] iso transmit cycle skip patch
I've double-checked it, and it seems to be good. Hence:
Signed-off-by: Pieter Palmers <pieterp@joow.be>
Greets,
Pieter
--
| Apr 18, 11:07 am 2008 |
| Aaron Carroll | Re: [RESEND][RFC] BFQ I/O Scheduler
Here are some microbenchmark results. Test setup is a 2-way IA64 with a
single 15k RPM 73GiB SCSI disk with TCQ depth set to 1. Workloads are
generated with FIO: 128 processes issuing synchronous, O_DIRECT, 16KiB
block size requests.
Figures are quoted as average (stdev). CFQ (i=0) means idle window
disabled. All other tunables are default.
==================================x8=======================================
Random ...
| Apr 17, 6:26 pm 2008 |
| Alexander van Heukelum | Alternative implementation of the generic __ffs
Hello all,
I've implemented ffs (find first set bit) like it is shown
in http://www.hackersdelight.org/ (see revisions, page 21).
I would be interested to see how it compares with the generic
implementation of __ffs in the linux kernel, in particular
on architectures that do not have an obvious fast way of
determining the first set bit of a word.
I have included a simple benchmark program that should give
a reasonable estimate of the performance ratio of the two
implementations. Please ...
| Apr 18, 1:18 pm 2008 |
| dean gaudet | Re: Alternative implementation of the generic __ffs
technically you can compute x4 with the original value prior to isolating
the least-significant one-bit -- the compiler probably can't figure this
i'm never sure if it's better to use | or + here... i bet it depends on
what native operations the processor has... and depends on how ?: are
implemented.
-dean
--
| Apr 18, 4:46 pm 2008 |
| Ben Hutchings | Re: [PATCH][RFC] Add default CPU topology information
No, it isn't! But cputopology.txt does say these should be macros, not
functions.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
--
| Apr 18, 5:10 am 2008 |
| Ben Hutchings | Re: [PATCH][RFC] Add default CPU topology information
<snip>
Damn, x86 is also using functions instead of macros. Sorry about that; I'll
have another try.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
--
| Apr 18, 5:24 am 2008 |
| Andrew Morton | Re: [PATCH][RFC] Add default CPU topology information
I get a huuuuuuuge crash early in boot on the t61p dual x86_64 laptop.
Before netconsole has started and it has no serial port, so all I have is a
partially-scrolled-off jpg, sorry.
I'll drop the patch.
http://userweb.kernel.org/~akpm/p4175278.jpg
http://userweb.kernel.org/~akpm/config-t61p.txt
http://userweb.kernel.org/~akpm/dmesg-t61p.txt
If I didn't have all that wrong crap on the stack we'd have a full
trace here. I have CONFIG_FRAME_POINTER=y, but that doesn't seem to
have ...
| Apr 18, 12:10 am 2008 |
| Andrew Morton | Re: [PATCH][RFC] Add default CPU topology information
ooh, I just discovered kstack=. That should be hoisted up to core kernel
then pushed out to other architectures, not hidden in x86_64 code.
But first I guess it should be make to work - it fails miserably, because
only one of our seventy fix stack-dumping functions actually looks at it.
This:
--- a/arch/x86/kernel/traps_64.c~a
+++ a/arch/x86/kernel/traps_64.c
@@ -426,7 +426,7 @@ _show_stack(struct task_struct *tsk, str
printk(" %016lx", *stack++);
touch_nmi_watchdog();
...
| Apr 18, 12:32 am 2008 |
| Andrew Morton | Re: [PATCH][RFC] Add default CPU topology information
powerpc allmodconfig:
arch/powerpc/kernel/pci_64.c:655: error: expected identifier or '(' before 'void'
arch/powerpc/kernel/pci_64.c:655: error: expected ')' before '(' token
Because this:
#ifdef CONFIG_NUMA
int pcibus_to_node(struct pci_bus *bus)
{
struct pci_controller *phb = pci_bus_to_host(bus);
return phb->node;
}
#endif
is expanding to
int ((void)(bus), -1)(struct pci_bus *bus)
which the compiler has trouble with.
This:
+++ a/include/asm-powerpc/topology.h
@@ ...
| Apr 17, 11:45 pm 2008 |
| Thomas Gleixner | Re: [RFC PATCH] UBIFS - new flash file system
The mount time compared to JFFS2 on a 700MiB partition went down from
We did some initial stress tests and so far it looks pretty robust.
Great job !
Thanks,
tglx
--
| Apr 18, 2:05 am 2008 |
| Dmitry Torokhov | Re: [PATCH 1/1] Input/Joystick Driver: add support AD714 ...
Hi Bryan,
Why don't you use REL_X/REL_Y to report directional movement? Using
buttons for that is pretty unusual.
--
Dmitry
--
| Apr 18, 10:15 am 2008 |
| Richard MUSIL | Re: Problem with accessing stable git over http
Thanks, this seems has solved the problem. Now, I can fetch from stable
branch over http without any problems.
Richard
--
| Apr 18, 12:18 am 2008 |
| Stefan Richter | Re: [PATCH 2/2 update] firewire: insist on successive se ...
Some a-posteriori thoughts:
Situations like this happen quite regularly when camcorders are plugged
in or out or switched on or off, or when bus-powered hubs are plugged
in, and similar situations --- depending on the PHYs on the bus.
The conclusion that we have to discard the old topology data in this
situation still stands.
However, although we have to discard node data, we should not discard
_device_ data. Chances are that some devices remained on the bus. At
least the local ...
| Apr 18, 9:45 am 2008 |
| David Miller | Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC
From: Krzysztof Halasa <khc@pm.waw.pl>
I'll fix it properly because I know you won't do the work.
You don't need to keep making excuses.
--
| Apr 18, 3:32 pm 2008 |
| Krzysztof Halasa | Re: [PATCH v2] Re: WAN: new PPP code for generic HDLC
David doesn't want the new PPP, insisting that I fix existing
hdlc_ppp.c + syncppp.c combo instead, and that there are related bugs
in drivers using syncppp.c alone (not hdlc_ppp) which I have to fix as
well.
Unfortunately I'm unable to do that. Even if I could add another
workaround to hdlc_ppp to make it work with syncppp.c again, I can't
fix the other drivers (if they are indeed broken) because of lack of
hardware, and I can't really make significant changes to syncppp.c
(to make them ...
| Apr 18, 8:58 am 2008 |
| Peter Zijlstra | Re: ACPI lockdep warning on boot, 2.6.25-rc5
I'd suggest to clean up the source of this mess instead; this is quite
horrible.
--
| Apr 18, 3:24 am 2008 |
| Peer Chen | RE: 2.6.24.X: SATA/AHCI related boot delay. - not with 2 ...
Try to use this: http://sourceforge.net/project/showfiles.php?group_id=220929
BRs
Peer Chen
-----Original Message-----
From: Volker Armin Hemmann [mailto:volker.armin.hemmann@tu-clausthal.de]
Sent: Wednesday, April 16, 2008 12:20 AM
To: Peer Chen
Cc: Jeff Garzik; Tejun Heo; linux-kernel@vger.kernel.org; linux-ide@vger.kernel.org; Kuan Luo
Subject: Re: 2.6.24.X: SATA/AHCI related boot delay. - not with 2.6.24.3
Hi,
how do I do that?
Also, I can't see anything resembling this two ...
| Apr 17, 10:51 pm 2008 |
| Michael Kerrisk | Re: [PATCH,TRIVIAL] AF_UNIX, accept() and addrlen
Samuel,
Why did you write sa_family_t here? Dave M already said sizeof(short), which is
the same thing, and I see that in net/unix/af_unix.c::unix_getname() there is:
u = unix_sk(sk);
unix_state_lock(sk);
if (!u->addr) {
sunaddr->sun_family = AF_UNIX;
sunaddr->sun_path[0] = 0;
*uaddr_len = sizeof(short);
Cheers,
Michael
--
Michael Kerrisk
Linux man-pages maintainer; ...
| Apr 18, 9:52 am 2008 |
| David Miller | Re: TG3 network data corruption regression 2.6.24/2.6.23.4
From: "Michael Chan" <mchan@broadcom.com>
That's correct.
--
| Apr 17, 11:20 pm 2008 |
| KOSAKI Motohiro | Re: [PATCH 0/8][for -mm] mem_notify v6
Oh sorry my bad!
I investigated again and found 2 problem in your test program.
1. text segment isn't locked.
if strong memory pressure happned, kernel may drop program text region.
then your test program suddenly slow down.
please use mlockall(MCL_CURRENT) before large buffer allocation.
2. repeat open/close to /proc/meminfo.
in the fact, open(2) system call use a bit memory.
if call open(2) in strong memory pressure, doesn't return until
memory freed enough.
...
| Apr 18, 3:07 am 2008 |
| Michael Kerrisk | RLIMIT_RTTIME documentation for getrlimit.2
Peter,
Below is the draft text that I will add to the getrlimit.2 man page to describe
RLIMIT_RTTIME. Does it look okay to you? (I will add a pointer in
sched_setscheduler.2 to this description in getrlimit.2.)
RLIMIT_RTTIME (Since Linux 2.6.25)
Specifies a limit on the amount of CPU time that a
process scheduled under a real-time scheduling
policy may consume without making a blocking sys-
tem call. For the purpose ...
| Apr 18, 9:52 am 2008 |
| Woodruff, Richard | Higer latency with dynamic tick (need for an io-ondemand ...
Hi,
When capturing some traces with dynamic tick we were noticing the
interrupt latency seems to go up a good amount. If you look at the trace
the gpio IRQ is now offset a good amount. Good news I guess is its
pretty predictable.
* If we couple this with progressively higher latency C-States we see
that IO speed can fall by a good amount, especially for PIO mixes. Now
if QOS is maintained you may or may-not care.
I was wondering what thoughts of optimizing this might be.
One thought ...
| Apr 18, 8:43 am 2008 |
| previous day | today | next day |
|---|---|---|
| April 17, 2008 | April 18, 2008 | April 19, 2008 |
