> > * the consistent.c implementation looks strange. Is any of that code
quoted text
> > even used anywhere? What is it good for, considering that you don't
have
quoted text
> > an mmu?
> 
> We have prepared MMU code. I hope that this code for FDT kernel comes
soon.
quoted text
> This code is written by John Williams. I have never changed it. I see
that this
quoted text
> code solves problems around ucached_shadows stuff.
>
http://developer.petalogix.com/wiki/UserGuide/AdvancedTopics/EnablingUnc
achedShadow
quoted text
> JW. Can you comment this?

It probably makes sense to grab: arch/microblaze/mm/dma-coherent.c from
git.xilinx.com and drop consistent.c.  I believe this is the more
'modern' way to implement this functionality.  I think it's easiest for
you to just grab this file.

quoted text
> > * Your dma_mapping.h does BUG() for almost everything. I suspect you
could
quoted text
> > easily replace it with a trivial implementation, like the x86_32
one.
quoted text
> 
> OK. I'll synchronize this.

This is also in git.xilinx.com.

quoted text
> > * You don't seem to have any code for PCI, so the pci.h and
pci-bridge.h
quoted text
> > files don't make much sense.
> 
> Yes you are right. I don't have any PCI code but I think that this
code for MB
quoted text
> exists. Steve or John: Do you have any code for PCI?

I'd recommend dropping anything having to do with PCI: I don't know that
there is much interest in it on microblaze.

Other comments:

memset/memmove/memcpy are broken under gcc4.  There are fixed versions
of this at git.xilinx.com.  Again, it's probably easiest if you just
grab the files directly.

It would also be good to have irq_of_parse_and_map, which drivers will
need.  I'll send you a patch for this one.

Steve


--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/