[PATCH] Removal of FUTEX_FD (and related code)

Previous thread: core_pattern pipe documentation by Michael Kerrisk on Friday, April 18, 2008 - 12:53 pm. (13 messages)

Next thread: [PATCH][RFC] Add default CPU topology information (try #2) by Ben Hutchings on Friday, April 18, 2008 - 12:11 pm. (1 message)
To: <linux-kernel@...>
Cc: Ingo Molnar <mingo@...>
Date: Friday, April 18, 2008 - 12:07 pm

From: Eric Sesterhenn <snakebyte@gmx.de>
Date: Fri, 25 Jan 2008 10:40:46 +0100

hi,

since FUTEX_FD was scheduled for removal in June 2007 lets remove it.
Google Code search found no users for it and NGPT was abandoned in 2003
according to IBM. futex.h is left untouched to make sure the id does
not get reassigned. Since queue_me() has no users left it is commented
out to avoid a warning, i didnt remove it completely since it is part
of the internal api (matching unqueue_me())

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (removed rest)
---
kernel/futex.c | 176 +--------------------------------------------------------
1 file changed, 6 insertions(+), 170 deletions(-)

diff -r a1496ab2d0e2 kernel/futex.c
--- a/kernel/futex.c Mon Apr 07 15:13:56 2008 +1000
+++ b/kernel/futex.c Mon Apr 07 15:27:30 2008 +1000
@@ -104,10 +104,6 @@ struct futex_q {
/* Key which the futex is hashed on: */
union futex_key key;

- /* For fd, sigio sent using these: */
- int fd;
- struct file *filp;
-
/* Optional priority inheritance state: */
struct futex_pi_state *pi_state;
struct task_struct *task;
@@ -125,9 +121,6 @@ struct futex_hash_bucket {
};

static struct futex_hash_bucket futex_queues[1<<FUTEX_HASHBITS];
-
-/* Futex-fs vfsmount entry: */
-static struct vfsmount *futex_mnt;

/*
* Take mm->mmap_sem, when futex is shared
@@ -610,8 +603,6 @@ static void wake_futex(struct futex_q *q
static void wake_futex(struct futex_q *q)
{
plist_del(&q->list, &q->list.plist);
- if (q->filp)
- send_sigio(&q->filp->f_owner, q->fd, POLL_IN);
/*
* The lock in wake_up_all() is a crucial memory barrier after the
* plist_del() and also before assigning to q->lock_ptr.
@@ -988,13 +979,9 @@ out:
}

/* The key must be already stored in q->key. */
-static inline struct futex_hash_bucket *
-queue_lock(struct futex_q *q, int fd, struct file *filp)
+s...

To: Rusty Russell <rusty@...>
Cc: <linux-kernel@...>, Ingo Molnar <mingo@...>
Date: Sunday, April 27, 2008 - 2:31 pm

Acked-by: Thomas Gleixner <tglx@linutronix.de>
--

To: Rusty Russell <rusty@...>
Cc: <linux-kernel@...>, Ingo Molnar <mingo@...>
Date: Friday, April 18, 2008 - 2:24 pm

Hey Rusty,

[...]

Please CC me on API changes...

Cheers,

Michael
--

To: Michael Kerrisk <mtk.manpages@...>
Cc: <linux-kernel@...>, Ingo Molnar <mingo@...>
Date: Saturday, April 19, 2008 - 10:39 am

Sorry Michael, I didn't think.

Keep up the good work!
Rusty.
--

Previous thread: core_pattern pipe documentation by Michael Kerrisk on Friday, April 18, 2008 - 12:53 pm. (13 messages)

Next thread: [PATCH][RFC] Add default CPU topology information (try #2) by Ben Hutchings on Friday, April 18, 2008 - 12:11 pm. (1 message)