login
Header Space

 
 

Re: [PATCH 2/5] /dev/vring: simple userspace-kernel ringbuffer interface.

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andrew Morton <akpm@...>
Cc: <netdev@...>, Max Krasnyansky <maxk@...>, <virtualization@...>, <linux-kernel@...>
Date: Friday, April 18, 2008 - 10:32 am

On Friday 18 April 2008 21:18:46 Andrew Morton wrote:

Thanks, fixed.


An excellent question, but I thought the modern kernel etiquette was to only 
comment on whitespace and formatting, and call it "review"? :)

Yes, kinda-sorta in that it's a ring buffer.  No, in that it's bidir and 
consumption can be out-of-order (kind of important for I/O buffers).

But the reason I'm not proposing it as a syscall is that I'm not convinced 
it's the One True Solution which everyone should be using.  Time will tell: 
it's clearly not tied to tun and it's been generically useful for virtual 
I/O, but history has not been kind to new userspace interfaces.


Snot from previous version.  Removed.


Yes, except I like the clarity and the BUG_ON.


"#include <copyright-gpl2-plus>" for me, just to add more inclement weather to 
that teacup...

Thanks,
Rusty.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/5] High-speed tun receive and xmit, Rusty Russell, (Fri Apr 18, 12:33 am)
Re: [PATCH 2/5] /dev/vring: simple userspace-kernel ringbuff..., Evgeniy Polyakov, (Sat Apr 19, 12:33 pm)
Re: [PATCH 2/5] /dev/vring: simple userspace-kernel ringbuff..., Rusty Russell, (Fri Apr 18, 10:32 am)
[PATCH 3/5] /dev/vring limit and base ioctls, Rusty Russell, (Fri Apr 18, 12:41 am)
[PATCH 4/5] tun: vringfd receive support., Rusty Russell, (Fri Apr 18, 12:42 am)
[PATCH 5/5] tun: vringfd xmit support., Rusty Russell, (Fri Apr 18, 12:43 am)
Re: [PATCH 5/5] tun: vringfd xmit support., pradeep singh rautela, (Fri Apr 18, 7:46 am)
Re: [PATCH 5/5] tun: vringfd xmit support., Ray Lee, (Fri Apr 18, 10:25 am)
Re: [PATCH 5/5] tun: vringfd xmit support., pradeep singh rautela, (Fri Apr 18, 2:01 pm)
Re: [PATCH 5/5] tun: vringfd xmit support., Andrew Morton, (Fri Apr 18, 7:31 am)
Re: [PATCH 5/5] tun: vringfd xmit support., Rusty Russell, (Fri Apr 18, 11:15 am)
Re: [PATCH 5/5] tun: vringfd xmit support., Andrew Morton, (Fri Apr 18, 9:54 pm)
Re: [PATCH 5/5] tun: vringfd xmit support., Andrew Morton, (Fri Apr 18, 3:06 pm)
Re: [PATCH 5/5] tun: vringfd xmit support., Rusty Russell, (Sat Apr 19, 10:41 am)
Re: [PATCH 5/5] tun: vringfd xmit support., Andrew Morton, (Sat Apr 19, 1:51 pm)
Re: [PATCH 5/5] tun: vringfd xmit support., Ray Lee, (Fri Apr 18, 12:24 pm)
speck-geostationary