Re: 2.6.25-mm1: not looking good

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andrew Morton <akpm@...>
Cc: Thomas Gleixner <tglx@...>, Pekka Enberg <penberg@...>, <linux-usb@...>, <linux-kernel@...>, <linux-mm@...>, James Morris <jmorris@...>, Stephen Smalley <sds@...>, Peter Zijlstra <a.p.zijlstra@...>, <linux-pm@...>, Greg KH <greg@...>, Rafael J. Wysocki <rjw@...>, Pavel Machek <pavel@...>, Jack Steiner <steiner@...>, Mike Travis <travis@...>, Alan Mayer <ajm@...>
Date: Friday, April 18, 2008 - 8:18 am

* Ingo Molnar <mingo@elte.hu> wrote:


that should be the patch below.

	Ingo

------------>
Subject: x86: disable preemption in native_smp_prepare_cpus
From: Ingo Molnar <mingo@elte.hu>
Date: Fri Apr 18 11:07:10 CEST 2008

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/kernel/smpboot.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Index: linux-x86.q/arch/x86/kernel/smpboot.c
===================================================================
--- linux-x86.q.orig/arch/x86/kernel/smpboot.c
+++ linux-x86.q/arch/x86/kernel/smpboot.c
@@ -1181,6 +1181,7 @@ static void __init smp_cpu_index_default
  */
 void __init native_smp_prepare_cpus(unsigned int max_cpus)
 {
+	preempt_disable();
 	nmi_watchdog_default();
 	smp_cpu_index_default();
 	current_cpu_data = boot_cpu_data;
@@ -1197,7 +1198,7 @@ void __init native_smp_prepare_cpus(unsi
 	if (smp_sanity_check(max_cpus) < 0) {
 		printk(KERN_INFO "SMP disabled\n");
 		disable_smp();
-		return;
+		goto out;
 	}
 
 	preempt_disable();
@@ -1237,6 +1238,8 @@ void __init native_smp_prepare_cpus(unsi
 	printk(KERN_INFO "CPU%d: ", 0);
 	print_cpu_info(&cpu_data(0));
 	setup_boot_clock();
+out:
+	preempt_enable();
 }
 /*
  * Early setup to make printk work.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.25-mm1: not looking good, Andrew Morton, (Thu Apr 17, 7:03 pm)
2.6.25-mm1: Failing to probe IDE interface, Mel Gorman, (Mon Apr 28, 12:42 pm)
Re: 2.6.25-mm1: Failing to probe IDE interface, Bartlomiej Zolnierkiewicz..., (Mon Apr 28, 2:44 pm)
Re: 2.6.25-mm1: Failing to probe IDE interface, Mel Gorman, (Tue Apr 29, 5:43 am)
Re: 2.6.25-mm1: Failing to probe IDE interface, Mel Gorman, (Tue Apr 29, 11:49 am)
Re: 2.6.25-mm1: Failing to probe IDE interface, Mel Gorman, (Tue Apr 29, 12:58 pm)
Re: 2.6.25-mm1: Failing to probe IDE interface, Bartlomiej Zolnierkiewicz..., (Tue Apr 29, 5:37 pm)
Re: 2.6.25-mm1: Failing to probe IDE interface, Mel Gorman, (Wed Apr 30, 7:16 am)
Re: 2.6.25-mm1: Failing to probe IDE interface, Andrew Morton, (Mon Apr 28, 12:59 pm)
Re: 2.6.25-mm1: Failing to probe IDE interface, Mel Gorman, (Tue Apr 29, 5:39 am)
Re: 2.6.25-mm1: not looking good, Andrew Morton, (Fri Apr 18, 3:50 am)
Re: 2.6.25-mm1: not looking good, Andrew Morton, (Fri Apr 18, 3:53 am)
Re: 2.6.25-mm1: not looking good, Pavel Machek, (Fri Apr 18, 7:07 am)
Re: 2.6.25-mm1: not looking good, Pavel Machek, (Fri Apr 18, 5:42 am)
Re: 2.6.25-mm1: not looking good, Alan Stern, (Fri Apr 18, 11:22 am)
Re: 2.6.25-mm1: not looking good, Andrew Morton, (Fri Apr 18, 3:57 am)
Re: 2.6.25-mm1: not looking good, Ingo Molnar, (Fri Apr 18, 5:22 am)
Re: 2.6.25-mm1: not looking good, Ingo Molnar, (Fri Apr 18, 8:18 am)
Re: 2.6.25-mm1: not looking good, Ingo Molnar, (Fri Apr 18, 3:09 am)
Re: 2.6.25-mm1: not looking good, Pekka Enberg, (Fri Apr 18, 2:40 am)
Re: 2.6.25-mm1: not looking good, Ingo Molnar, (Fri Apr 18, 3:24 am)
Re: 2.6.25-mm1: not looking good, James Morris, (Fri Apr 18, 6:32 am)
Re: 2.6.25-mm1: not looking good, Pekka Enberg, (Fri Apr 18, 3:25 am)
Re: 2.6.25-mm1: not looking good, Andrew Morton, (Fri Apr 18, 2:56 am)
Re: 2.6.25-mm1: not looking good, Arjan van de Ven, (Fri Apr 18, 1:49 am)
Re: 2.6.25-mm1: not looking good, Andrew Morton, (Fri Apr 18, 2:10 am)
Re: 2.6.25-mm1: not looking good, Ingo Molnar, (Fri Apr 18, 3:19 am)
Re: 2.6.25-mm1: not looking good, Andrew Morton, (Fri Apr 18, 3:28 am)
Re: Stack protector build failure (was Re: 2.6.25-mm1: not l..., Arjan van de Ven, (Fri Apr 18, 12:57 pm)
Re: 2.6.25-mm1: not looking good, Ingo Molnar, (Fri Apr 18, 5:28 am)
Re: 2.6.25-mm1: not looking good, Paul Moore, (Thu Apr 17, 7:55 pm)
Re: 2.6.25-mm1: not looking good, Andrew Morton, (Thu Apr 17, 9:35 pm)
Re: 2.6.25-mm1: not looking good, Paul Moore, (Fri Apr 18, 10:57 am)
Re: 2.6.25-mm1: not looking good, Andrew Morton, (Thu Apr 17, 8:04 pm)
Re: 2.6.25-mm1: not looking good, Paul Moore, (Fri Apr 18, 10:55 am)
Re: 2.6.25-mm1: not looking good, Andrew Morton, (Thu Apr 17, 7:40 pm)
Re: 2.6.25-mm1: not looking good, Andrew Morton, (Thu Apr 17, 8:14 pm)
Re: 2.6.25-mm1: not looking good, Jason Wessel, (Thu Apr 17, 11:05 pm)
Re: 2.6.25-mm1: not looking good, Ingo Molnar, (Fri Apr 18, 3:37 am)
Re: 2.6.25-mm1: not looking good, Jason Wessel, (Fri Apr 18, 5:54 pm)
Re: 2.6.25-mm1: not looking good, Vegard Nossum, (Fri Apr 18, 7:46 am)
Re: 2.6.25-mm1: not looking good, Ingo Molnar, (Fri Apr 18, 8:34 am)
Re: 2.6.25-mm1: not looking good, Vegard Nossum, (Fri Apr 18, 8:41 am)
Re: 2.6.25-mm1: not looking good, Jason Wessel, (Fri Apr 18, 9:02 am)
Re: 2.6.25-mm1: not looking good, Vegard Nossum, (Fri Apr 18, 9:22 am)
Re: 2.6.25-mm1: not looking good, Jason Wessel, (Fri Apr 18, 9:27 am)
Re: 2.6.25-mm1: not looking good, Vegard Nossum, (Fri Apr 18, 10:47 am)
Re: 2.6.25-mm1: not looking good, Vegard Nossum, (Fri Apr 18, 12:02 pm)
Re: 2.6.25-mm1: not looking good, Greg KH, (Thu Apr 17, 7:24 pm)
Re: 2.6.25-mm1: not looking good, Kay Sievers, (Thu Apr 17, 8:48 pm)
Re: 2.6.25-mm1: not looking good, Andrew Morton, (Fri Apr 18, 12:07 am)
Re: 2.6.25-mm1: not looking good, Andrew Morton, (Thu Apr 17, 9:12 pm)
Re: 2.6.25-mm1: not looking good, Dan Williams, (Thu Apr 17, 7:24 pm)