Re: 2.6.25-mm1: not looking good

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Ingo Molnar
Date: Friday, April 18, 2008 - 5:18 am

* Ingo Molnar <mingo@elte.hu> wrote:


that should be the patch below.

	Ingo

------------>
Subject: x86: disable preemption in native_smp_prepare_cpus
From: Ingo Molnar <mingo@elte.hu>
Date: Fri Apr 18 11:07:10 CEST 2008

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/kernel/smpboot.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Index: linux-x86.q/arch/x86/kernel/smpboot.c
===================================================================
--- linux-x86.q.orig/arch/x86/kernel/smpboot.c
+++ linux-x86.q/arch/x86/kernel/smpboot.c
@@ -1181,6 +1181,7 @@ static void __init smp_cpu_index_default
  */
 void __init native_smp_prepare_cpus(unsigned int max_cpus)
 {
+	preempt_disable();
 	nmi_watchdog_default();
 	smp_cpu_index_default();
 	current_cpu_data = boot_cpu_data;
@@ -1197,7 +1198,7 @@ void __init native_smp_prepare_cpus(unsi
 	if (smp_sanity_check(max_cpus) < 0) {
 		printk(KERN_INFO "SMP disabled\n");
 		disable_smp();
-		return;
+		goto out;
 	}
 
 	preempt_disable();
@@ -1237,6 +1238,8 @@ void __init native_smp_prepare_cpus(unsi
 	printk(KERN_INFO "CPU%d: ", 0);
 	print_cpu_info(&cpu_data(0));
 	setup_boot_clock();
+out:
+	preempt_enable();
 }
 /*
  * Early setup to make printk work.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.25-mm1: not looking good, Andrew Morton, (Thu Apr 17, 4:03 pm)
Re: 2.6.25-mm1: not looking good, Greg KH, (Thu Apr 17, 4:24 pm)
Re: 2.6.25-mm1: not looking good, Dan Williams, (Thu Apr 17, 4:24 pm)
Re: 2.6.25-mm1: not looking good, Andrew Morton, (Thu Apr 17, 4:40 pm)
Re: 2.6.25-mm1: not looking good, Paul Moore, (Thu Apr 17, 4:55 pm)
Re: 2.6.25-mm1: not looking good, Andrew Morton, (Thu Apr 17, 5:04 pm)
Re: 2.6.25-mm1: not looking good, Andrew Morton, (Thu Apr 17, 5:14 pm)
Re: 2.6.25-mm1: not looking good, Kay Sievers, (Thu Apr 17, 5:48 pm)
Re: 2.6.25-mm1: not looking good, Andrew Morton, (Thu Apr 17, 6:12 pm)
Re: 2.6.25-mm1: not looking good, Andrew Morton, (Thu Apr 17, 6:35 pm)
Re: 2.6.25-mm1: not looking good, Jason Wessel, (Thu Apr 17, 8:05 pm)
Re: 2.6.25-mm1: not looking good, Andrew Morton, (Thu Apr 17, 9:07 pm)
Re: 2.6.25-mm1: not looking good, Arjan van de Ven, (Thu Apr 17, 10:49 pm)
Re: 2.6.25-mm1: not looking good, Andrew Morton, (Thu Apr 17, 11:10 pm)
Re: 2.6.25-mm1: not looking good, Pekka Enberg, (Thu Apr 17, 11:40 pm)
Re: 2.6.25-mm1: not looking good, Andrew Morton, (Thu Apr 17, 11:56 pm)
Re: 2.6.25-mm1: not looking good, Ingo Molnar, (Fri Apr 18, 12:09 am)
Re: 2.6.25-mm1: not looking good, Ingo Molnar, (Fri Apr 18, 12:19 am)
Re: 2.6.25-mm1: not looking good, Ingo Molnar, (Fri Apr 18, 12:24 am)
Re: 2.6.25-mm1: not looking good, Pekka Enberg, (Fri Apr 18, 12:25 am)
Re: 2.6.25-mm1: not looking good, Andrew Morton, (Fri Apr 18, 12:28 am)
Re: 2.6.25-mm1: not looking good, Ingo Molnar, (Fri Apr 18, 12:37 am)
Re: 2.6.25-mm1: not looking good, Andrew Morton, (Fri Apr 18, 12:50 am)
Re: 2.6.25-mm1: not looking good, Andrew Morton, (Fri Apr 18, 12:53 am)
Re: 2.6.25-mm1: not looking good, Andrew Morton, (Fri Apr 18, 12:57 am)
Re: 2.6.25-mm1: not looking good, Ingo Molnar, (Fri Apr 18, 2:22 am)
Re: 2.6.25-mm1: not looking good, Ingo Molnar, (Fri Apr 18, 2:28 am)
Re: 2.6.25-mm1: not looking good, Pavel Machek, (Fri Apr 18, 2:42 am)
Re: 2.6.25-mm1: not looking good, James Morris, (Fri Apr 18, 3:32 am)
Re: 2.6.25-mm1: not looking good, Pavel Machek, (Fri Apr 18, 4:07 am)
Re: 2.6.25-mm1: not looking good, Vegard Nossum, (Fri Apr 18, 4:46 am)
Re: 2.6.25-mm1: not looking good, Ingo Molnar, (Fri Apr 18, 5:18 am)
Re: 2.6.25-mm1: not looking good, Ingo Molnar, (Fri Apr 18, 5:34 am)
Re: 2.6.25-mm1: not looking good, Vegard Nossum, (Fri Apr 18, 5:41 am)
Re: 2.6.25-mm1: not looking good, Jason Wessel, (Fri Apr 18, 6:02 am)
Re: 2.6.25-mm1: not looking good, Vegard Nossum, (Fri Apr 18, 6:22 am)
Re: 2.6.25-mm1: not looking good, Jason Wessel, (Fri Apr 18, 6:27 am)
Re: 2.6.25-mm1: not looking good, Vegard Nossum, (Fri Apr 18, 7:47 am)
Re: 2.6.25-mm1: not looking good, Paul Moore, (Fri Apr 18, 7:55 am)
Re: 2.6.25-mm1: not looking good, Paul Moore, (Fri Apr 18, 7:57 am)
Re: 2.6.25-mm1: not looking good, Alan Stern, (Fri Apr 18, 8:22 am)
Re: 2.6.25-mm1: not looking good, Vegard Nossum, (Fri Apr 18, 9:02 am)
Re: 2.6.25-mm1: not looking good, Jason Wessel, (Fri Apr 18, 2:54 pm)
2.6.25-mm1: Failing to probe IDE interface, Mel Gorman, (Mon Apr 28, 9:42 am)
Re: 2.6.25-mm1: Failing to probe IDE interface, Andrew Morton, (Mon Apr 28, 9:59 am)
Re: 2.6.25-mm1: Failing to probe IDE interface, Bartlomiej Zolnierki ..., (Mon Apr 28, 11:44 am)
Re: 2.6.25-mm1: Failing to probe IDE interface, Mel Gorman, (Tue Apr 29, 2:39 am)
Re: 2.6.25-mm1: Failing to probe IDE interface, Mel Gorman, (Tue Apr 29, 2:43 am)
Re: 2.6.25-mm1: Failing to probe IDE interface, Mel Gorman, (Tue Apr 29, 8:49 am)
Re: 2.6.25-mm1: Failing to probe IDE interface, Mel Gorman, (Tue Apr 29, 9:58 am)
Re: 2.6.25-mm1: Failing to probe IDE interface, Bartlomiej Zolnierki ..., (Tue Apr 29, 2:37 pm)
Re: 2.6.25-mm1: Failing to probe IDE interface, Mel Gorman, (Wed Apr 30, 4:16 am)