login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
April
»
17
Re: [PATCH]: Factor out PTY index allocation
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Jiri Slaby
Subject:
Re: [PATCH]: Factor out PTY index allocation
Date: Thursday, April 17, 2008 - 2:08 pm
On 04/17/2008 12:17 AM,
sukadev@us.ibm.com
wrote:
quoted text
> We noticed this while working on pts namespaces and believe this might > be an useful change even as we rework our pts/device namespace approach. > > --- > > From: Sukadev Bhattiprolu <sukadev@us.ibm.com> > Subject: [PATCH]: Factor out PTY index allocation > > Factor out the code used to allocate/free a pts index into new interfaces, > devpts_new_index() and devpts_kill_index(). This localizes the external > data structures used in managing the pts indices. > > Signed-off-by: Sukadev Bhattiprolu <sukadev@us.ibm.com> > Signed-off-by: Serge Hallyn<serue@us.ibm.com> > Signed-off-by: Matt Helsley<matthltc@us.ibm.com> > > --- > drivers/char/tty_io.c | 40 ++++++---------------------------------- > fs/devpts/inode.c | 42 +++++++++++++++++++++++++++++++++++++++++- > include/linux/devpts_fs.h | 4 ++++ > 3 files changed, 51 insertions(+), 35 deletions(-)
[...]
quoted text
> Index: 2.6.25-rc8-mm2/drivers/char/tty_io.c > =================================================================== > --- 2.6.25-rc8-mm2.orig/drivers/char/tty_io.c 2008-04-16 09:51:11.000000000 -0700 > +++ 2.6.25-rc8-mm2/drivers/char/tty_io.c 2008-04-16 09:51:15.000000000 -0700 > @@ -137,9 +136,6 @@ EXPORT_SYMBOL(tty_mutex); > > #ifdef CONFIG_UNIX98_PTYS > extern struct tty_driver *ptm_driver; /* Unix98 pty masters; for /dev/ptmx */ > -extern int pty_limit; /* Config limit on Unix98 ptys */ > -static DEFINE_IDR(allocated_ptys); > -static DEFINE_MUTEX(allocated_ptys_lock);
[...]
quoted text
> Index: 2.6.25-rc8-mm2/fs/devpts/inode.c > =================================================================== > --- 2.6.25-rc8-mm2.orig/fs/devpts/inode.c 2008-02-27 15:17:59.000000000 -0800 > +++ 2.6.25-rc8-mm2/fs/devpts/inode.c 2008-04-16 09:51:15.000000000 -0700 > @@ -26,6 +27,10 @@ > > #define DEVPTS_DEFAULT_MODE 0600 > > +extern int pty_limit; /* Config limit on Unix98 ptys */ > +static DEFINE_IDR(allocated_ptys); > +static DECLARE_MUTEX(allocated_ptys_lock);
Ugh, why mutex->semaphore conversion? --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH]: Factor out PTY index allocation
, sukadev
, (Wed Apr 16, 3:17 pm)
Re: [PATCH]: Factor out PTY index allocation
, Serge E. Hallyn
, (Thu Apr 17, 8:42 am)
Re: [PATCH]: Factor out PTY index allocation
, H. Peter Anvin
, (Thu Apr 17, 9:05 am)
Re: [PATCH]: Factor out PTY index allocation
, Jiri Slaby
, (Thu Apr 17, 2:08 pm)
Re: [PATCH]: Factor out PTY index allocation
, Andrew Morton
, (Thu Apr 17, 2:17 pm)
Re: [PATCH]: Factor out PTY index allocation
, Matthew Helsley
, (Thu Apr 17, 4:53 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Rafael J. Wysocki
[Bug #16136] Linux 2.6.34 causes system lockup on Compaq Presario 2200 Laptop
Joerg Roedel
Re: [patch] dma-debug: off by one issue
Pekka Enberg
Re: BUG in free_block (tainted)
Tetsuo Handa
Re: [AppArmor #7 0/13] AppArmor security module
Greg Kroah-Hartman
[PATCH 20/36] Driver core: Call device_pm_add() after bus_add_device() in device_a...
git
:
Christian Stimming
git-gui: Fix broken revert confirmation.
Johannes Schindelin
Re: [PATCH 2/2] git-svn: support fetch with autocrlf on
Mark Burton
Re: [PATCH] builtin-branch: highlight current remote branches with an asterisk
Junio C Hamano
Re: git-svnimport
Junio C Hamano
Re: [PATCH 6/6] Teach core object handling functions about gitlinks
linux-netdev
:
Daniel Lezcano
getsockopt(TCP_DEFER_ACCEPT) value change
David Miller
Re: 2.6.27.18: bnx2/tg3: BUG: "scheduling while atomic" trying to ifenslave a seco...
Amit Kumar Salecha
[PATCH NEXT 10/10] qlcnic: add cksum flag
Patrick McHardy
Re: [PATCH RESEND 1/3] netfilter: xtables: inclusion of xt_condition
Julius Volz
[PATCH] IRDA: Fix genlmsg_put() return value check.
git-commits-head
:
Linux Kernel Mailing List
ath9k_htc: Allocate URBs properly
Linux Kernel Mailing List
ath9k: Added get_survey callback in order to get channel noise
Linux Kernel Mailing List
ALSA: snd-usb-caiaq: Do not expose hardware input mode 0 of A4DJ
Linux Kernel Mailing List
cpumask: make irq_set_affinity() take a const struct cpumask
Linux Kernel Mailing List
V4L/DVB (9041): Add support YUAN High-Tech STK7700D (1164:1f08)
openbsd-misc
:
Conor
Re: RFID Reader
Josh Grosse
ssh/sshd challenge-response seems to have stopped working in -current
Stuart Henderson
Re: SquidGuard problem
Henning Brauer
Re: 3ware hardware raid support?
Ryan McBride
Re: Packets Per Second Limit?
Colocation donated by:
Syndicate