login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
April
»
17
Re: [PATCH]: Factor out PTY index allocation
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Jiri Slaby <jirislaby@...>
To: <sukadev@...>
Cc: Andrew Morton <akpm@...>, <serue@...>, Eric W. Biederman <ebiederm@...>, <hpa@...>, Containers <containers@...>, <linux-kernel@...>
Subject:
Re: [PATCH]: Factor out PTY index allocation
Date: Thursday, April 17, 2008 - 5:08 pm
On 04/17/2008 12:17 AM,
sukadev@us.ibm.com
wrote:
quoted text
> We noticed this while working on pts namespaces and believe this might > be an useful change even as we rework our pts/device namespace approach. > > --- > > From: Sukadev Bhattiprolu <sukadev@us.ibm.com> > Subject: [PATCH]: Factor out PTY index allocation > > Factor out the code used to allocate/free a pts index into new interfaces, > devpts_new_index() and devpts_kill_index(). This localizes the external > data structures used in managing the pts indices. > > Signed-off-by: Sukadev Bhattiprolu <sukadev@us.ibm.com> > Signed-off-by: Serge Hallyn<serue@us.ibm.com> > Signed-off-by: Matt Helsley<matthltc@us.ibm.com> > > --- > drivers/char/tty_io.c | 40 ++++++---------------------------------- > fs/devpts/inode.c | 42 +++++++++++++++++++++++++++++++++++++++++- > include/linux/devpts_fs.h | 4 ++++ > 3 files changed, 51 insertions(+), 35 deletions(-)
[...]
quoted text
> Index: 2.6.25-rc8-mm2/drivers/char/tty_io.c > =================================================================== > --- 2.6.25-rc8-mm2.orig/drivers/char/tty_io.c 2008-04-16 09:51:11.000000000 -0700 > +++ 2.6.25-rc8-mm2/drivers/char/tty_io.c 2008-04-16 09:51:15.000000000 -0700 > @@ -137,9 +136,6 @@ EXPORT_SYMBOL(tty_mutex); > > #ifdef CONFIG_UNIX98_PTYS > extern struct tty_driver *ptm_driver; /* Unix98 pty masters; for /dev/ptmx */ > -extern int pty_limit; /* Config limit on Unix98 ptys */ > -static DEFINE_IDR(allocated_ptys); > -static DEFINE_MUTEX(allocated_ptys_lock);
[...]
quoted text
> Index: 2.6.25-rc8-mm2/fs/devpts/inode.c > =================================================================== > --- 2.6.25-rc8-mm2.orig/fs/devpts/inode.c 2008-02-27 15:17:59.000000000 -0800 > +++ 2.6.25-rc8-mm2/fs/devpts/inode.c 2008-04-16 09:51:15.000000000 -0700 > @@ -26,6 +27,10 @@ > > #define DEVPTS_DEFAULT_MODE 0600 > > +extern int pty_limit; /* Config limit on Unix98 ptys */ > +static DEFINE_IDR(allocated_ptys); > +static DECLARE_MUTEX(allocated_ptys_lock);
Ugh, why mutex->semaphore conversion? --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH]: Factor out PTY index allocation
,
, (Wed Apr 16, 6:17 pm)
Re: [PATCH]: Factor out PTY index allocation
, Andrew Morton
, (Thu Apr 17, 5:17 pm)
Re: [PATCH]: Factor out PTY index allocation
, Matthew Helsley
, (Thu Apr 17, 7:53 pm)
Re: [PATCH]: Factor out PTY index allocation
, Jiri Slaby
, (Thu Apr 17, 5:08 pm)
Re: [PATCH]: Factor out PTY index allocation
, Serge E. Hallyn
, (Thu Apr 17, 11:42 am)
Re: [PATCH]: Factor out PTY index allocation
, H. Peter Anvin
, (Thu Apr 17, 12:05 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Zach Brown
[PATCH 3 of 4] Teach paths to wake a specific void * target instead of a whole tas...
Linus Torvalds
Re: LSM conversion to static interface
Greg Kroah-Hartman
[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
Andrew Morton
-mm merge plans for 2.6.23
git
:
linux-netdev
:
Gregory Haskins
[RFC PATCH 00/17] virtual-bus
David Miller
[GIT]: Networking
Jarek Poplawski
Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker
[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
3 users
and
1021 guests
online.
Online users
Jeremy
cofebarker
vv_ivango
Syndicate