login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
April
»
17
Re: [PATCH] NET: catch signed nla_len() retval in tcf_simp_init()
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From:
Patrick McHardy <kaber@...>
To: <hadi@...>
Cc: David Miller <davem@...>, <12o3l@...>, <netdev@...>, <linux-kernel@...>
Subject:
Re: [PATCH] NET: catch signed nla_len() retval in tcf_simp_init()
Date: Thursday, April 17, 2008 - 9:10 am
jamal wrote:
quoted text
> On Thu, 2008-17-04 at 06:55 +0200, Patrick McHardy wrote: > >> The change is also unnecessary because the attribute was >> already validated and the length can not be less than zero. > > Since act_simple is an academic example: > I think that a better solution is to add TCA_DEF_DATA (which is a > string) to the nla_policy. nla_policy is defined but at the moment it is > not used in the call to nla_parse_nested() - might as well use it.
Basic validity checks are always performed. But I agree, better to provide a good example. --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[PATCH] NET: catch signed nla_len() retval in tcf_simp_init()
, Roel Kluin
, (Wed Apr 16, 11:33 pm)
Re: [PATCH] NET: catch signed nla_len() retval in tcf_simp_i...
, David Miller
, (Thu Apr 17, 12:37 am)
Re: [PATCH] NET: catch signed nla_len() retval in tcf_simp_i...
, Patrick McHardy
, (Thu Apr 17, 12:55 am)
Re: [PATCH] NET: catch signed nla_len() retval in tcf_simp_i...
, David Miller
, (Fri Apr 18, 2:20 am)
Re: [PATCH] NET: catch signed nla_len() retval in tcf_simp_i...
, jamal
, (Thu Apr 17, 8:58 am)
Re: [PATCH] NET: catch signed nla_len() retval in tcf_simp_i...
, Patrick McHardy
, (Thu Apr 17, 9:10 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Trent Piepho
[PATCH] [POWERPC] Improve (in|out)_beXX() asm code
Stoyan Gaydarov
From 2.4 to 2.6 to 2.7?
Andi Kleen
[PATCH] [4/50] x86: add cpu codenames for Kconfig.cpu
Greg Kroah-Hartman
[PATCH 013/196] Documentation: Replace obsolete "driverfs" with "sysfs".
git
:
openbsd-misc
:
linux-netdev
:
Gerrit Renker
[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Jarek Poplawski
Re: HTB accuracy for high speed
Jarek Poplawski
[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller
Re: [GIT]: Networking
Colocation donated by:
Who's online
There are currently
8 users
and
1068 guests
online.
Online users
cargopantsform
yeasty123
tariqalleynepcv
sellingonlineu
ewen32hollr
aspdotnetcompr
tom0009
trafficexchang
Syndicate