login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
April
»
17
Re: [PATCH] NET: catch signed nla_len() retval in tcf_simp_init()
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Patrick McHardy
Subject:
Re: [PATCH] NET: catch signed nla_len() retval in tcf_simp_init()
Date: Thursday, April 17, 2008 - 6:10 am
jamal wrote:
quoted text
> On Thu, 2008-17-04 at 06:55 +0200, Patrick McHardy wrote: > >> The change is also unnecessary because the attribute was >> already validated and the length can not be less than zero. > > Since act_simple is an academic example: > I think that a better solution is to add TCA_DEF_DATA (which is a > string) to the nla_policy. nla_policy is defined but at the moment it is > not used in the call to nla_parse_nested() - might as well use it.
Basic validity checks are always performed. But I agree, better to provide a good example. --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] NET: catch signed nla_len() retval in tcf_simp_init()
, Roel Kluin
, (Wed Apr 16, 8:33 pm)
Re: [PATCH] NET: catch signed nla_len() retval in tcf_simp ...
, David Miller
, (Wed Apr 16, 9:37 pm)
Re: [PATCH] NET: catch signed nla_len() retval in tcf_simp ...
, Patrick McHardy
, (Wed Apr 16, 9:55 pm)
Re: [PATCH] NET: catch signed nla_len() retval in tcf_simp ...
, jamal
, (Thu Apr 17, 5:58 am)
Re: [PATCH] NET: catch signed nla_len() retval in tcf_simp ...
, Patrick McHardy
, (Thu Apr 17, 6:10 am)
Re: [PATCH] NET: catch signed nla_len() retval in tcf_simp ...
, David Miller
, (Thu Apr 17, 11:20 pm)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Ken Chen
[patch] sched: fix inconsistency when redistribute per-cpu tg->cfs_rq shares.
Ingo Molnar
Re: [PATCH v3] x86: merge the simple bitops and move them to bitops.h
Linus Torvalds
Re: [PATCH -v2] rmap: make anon_vma_prepare link in all the anon_vmas of a mergeab...
Matthew Wilcox
Re: Pull request for semaphore include changes
Benjamin Herrenschmidt
Re: [RFC PATCH 03/11] ppc: Create ops to choose between direct window and iommu ba...
git
:
Junio C Hamano
Re: pack operation is thrashing my server
Tay Ray Chuan
Re: [PATCH 02/18] http-push, http-walker: style fixes
Chris Frey
whitespace checking in git-add?
Luben Tuikov
Re: New way of tracking remote branches -- question
Kirill Smelkov
[TopGit PATCH] tg help: <something>: improve readability
git-commits-head
:
Linux Kernel Mailing List
sony-laptop: Add support for extended hotkeys
Linux Kernel Mailing List
rtl8187: use DMA-aware buffers with usb_control_msg
Linux Kernel Mailing List
[ARM] pxa/em-x270: explicitly set .gpio_cs in TDO35S SPI chip data
Linux Kernel Mailing List
epoll: clean up ep_modify
Linux Kernel Mailing List
IB/core: Add support for masked atomic operations
linux-netdev
:
Inaky Perez-Gonzalez
[PATCH 40/40] wimax/i2400m: add CREDITS and MAINTAINERS entries
Karsten Keil
[mISDN PATCH v2 05/19] Reduce stack size in dsp_cmx_send()
Valentine Barshak
[PATCH 1/2] ibm_newemac: PowerPC 440GX EMAC PHY clock workaround
Hannes Eder
[PATCH 06/27] drivers/net/atlx: fix sparse warnings: make symbols static
Gerrit Renker
Re: [PATCH 16/37] dccp: API to query the current TX/RX CCID
freebsd-current
:
Boris Samorodov
Re: twa + dump = sbwait
Kamigishi Rei
Re: HEAD newfs/sysinstall issues
Julian Elischer
Re: reproducible panic in netisr
Bruce Cran
sctp panic in _mtx_lock_sleep when attempting to connect to a remote machine
韓家標 Bill Hacker
Re: ZFS honesty
Colocation donated by:
Syndicate