On Thu, 17 Apr 2008 10:45:59 +0300 "Pekka Enberg" <penberg@cs.helsinki.fi> wrote:

quoted text
> On Thu, Apr 17, 2008 at 10:25 AM, Andrew Morton
> <akpm@linux-foundation.org> wrote:
> >  > Soren Sandmann (1):
> >  >       x86: add the debugfs interface for the sysprof tool
> >
> >  Also, I (and apparently only I) actually reviewed the implementation and
> >  found it to be riddled with bugs and shortcomings.  afacit this was
> >  completely ignored and you propose to merge it anwyay?
> 
> No, I fixed some of those and I think Ingo/Soren did the rest. But it
> needs another round of review on LKML for sure.

afaict none of my review comments have been addressed in the sysprof.c which
is in -mm.  It has the following commits:

    x86, sysprof: merge header to compilation unit
    x86, sysprof: clean up stack frame copying
    x86, sysprof: remove dead code
    sysprof: user pointer verification
    sysprof: minor cleanups
    x86: add the debugfs interface for the sysprof tool

I received no email even acknowledging the review comments.
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/