Home » Mailing list archives » linux-kernel » 2008 » April » 17

[PATCH] mos7840: test and propagate set_uart_reg return value

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Roel Kluin <12o3l@...>
To: Greg KH <greg@...>, <linux-usb@...>, lkml <linux-kernel@...>
Subject: [PATCH] mos7840: test and propagate set_uart_reg return value
Date: Thursday, April 17, 2008 - 12:16 am

The test for an mos7840_set_uart_reg() error return value only works when
status is signed. propagate its error value.

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---

diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
index aeeb9cb..ef1ede2 100644
--- a/drivers/usb/serial/mos7840.c
+++ b/drivers/usb/serial/mos7840.c
@@ -1713,7 +1713,7 @@ static int mos7840_tiocmset(struct usb_serial_port *port, struct file *file,
 {
 	struct moschip_port *mos7840_port;
 	unsigned int mcr;
-	unsigned int status;
+	int status;
 
 	dbg("%s - port %d", __FUNCTION__, port->number);
 
@@ -1739,11 +1739,10 @@ static int mos7840_tiocmset(struct usb_serial_port *port, struct file *file,
 
 	mos7840_port->shadowMCR = mcr;
 
-	status = 0;
 	status = mos7840_set_uart_reg(port, MODEM_CONTROL_REGISTER, mcr);
 	if (status < 0) {
 		dbg("setting MODEM_CONTROL_REGISTER Failed\n");
-		return -1;
+		return status;
 	}
 
 	return 0;
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] mos7840: test and propagate set_uart_reg return value, Roel Kluin, (Thu Apr 17, 12:16 am)
patch usb-mos7840-test-and-propagate-set_uart_reg-return-val..., , (Mon Apr 28, 7:53 pm)
Re: patch usb-mos7840-test-and-propagate-set_uart_reg-return..., SL Baur, (Tue Apr 29, 2:31 am)
Re: patch usb-mos7840-test-and-propagate-set_uart_reg-return..., Greg KH, (Tue Apr 29, 2:51 am)
Re: patch usb-mos7840-test-and-propagate-set_uart_reg-return..., SL Baur, (Tue Apr 29, 3:33 am)
Re: patch usb-mos7840-test-and-propagate-set_uart_reg-return..., Greg KH, (Wed Apr 30, 2:03 am)
Re: patch usb-mos7840-test-and-propagate-set_uart_reg-return..., SL Baur, (Wed Apr 30, 9:56 pm)
Re: [PATCH] mos7840: test and propagate set_uart_reg return ..., SL Baur, (Thu Apr 17, 2:58 am)