Home » Mailing list archives » linux-kernel » 2008 » April » 17

[PATCH] NET: catch signed nla_len() retval in tcf_simp_init()

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Roel Kluin <12o3l@...>
To: <hadi@...>, <netdev@...>, lkml <linux-kernel@...>
Subject: [PATCH] NET: catch signed nla_len() retval in tcf_simp_init()
Date: Wednesday, April 16, 2008 - 11:33 pm

'datalen' is unsigned, use 'ret' instead to catch a negative return value.

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/net/sched/act_simple.c b/net/sched/act_simple.c
index fbde461..b78d015 100644
--- a/net/sched/act_simple.c
+++ b/net/sched/act_simple.c
@@ -114,9 +114,10 @@ static int tcf_simp_init(struct nlattr *nla, struct nlattr *est,
 	if (defdata == NULL)
 		return -EINVAL;
 
-	datalen = nla_len(tb[TCA_DEF_DATA]);
-	if (datalen <= 0)
+	ret = nla_len(tb[TCA_DEF_DATA]);
+	if (ret <= 0)
 		return -EINVAL;
+	datalen = ret;
 
 	pc = tcf_hash_check(parm->index, a, bind, &simp_hash_info);
 	if (!pc) {
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] NET: catch signed nla_len() retval in tcf_simp_init(), Roel Kluin, (Wed Apr 16, 11:33 pm)
Re: [PATCH] NET: catch signed nla_len() retval in tcf_simp_i..., David Miller, (Thu Apr 17, 12:37 am)
Re: [PATCH] NET: catch signed nla_len() retval in tcf_simp_i..., Patrick McHardy, (Thu Apr 17, 12:55 am)
Re: [PATCH] NET: catch signed nla_len() retval in tcf_simp_i..., David Miller, (Fri Apr 18, 2:20 am)
Re: [PATCH] NET: catch signed nla_len() retval in tcf_simp_i..., jamal, (Thu Apr 17, 8:58 am)
Re: [PATCH] NET: catch signed nla_len() retval in tcf_simp_i..., Patrick McHardy, (Thu Apr 17, 9:10 am)