On 4/16/08, Pavel Machek <pavel@ucw.cz> wrote:The struct pci_dev */u64 casting is in init_k8_gatt. If Ingo is happy, then forget my comment. I don't have this kind of system to test the patch on, it was just that as I was looking it over, all the casts kind of made my head swim. The narrowing cast is here: +static inline void enable_gart_translation(struct pci_dev *dev, u64 addr) +{ + u32 tmp, ctl; + + /* address of the mappings table */ + addr >>= 12; + tmp = (u32) addr<<4; Also, putting on my Andrew Morton cap, which I should have done before, that function is too big to be inlined so you should probably drop the explicit `inline' and let the compiler decide. Add a Reviewed-by: SL Baur <steve@xemacs.org> if that's appropriate. I'm satisified that you did a one-for-one code move. -sb --
| jmerkey | [ANNOUNCE] mdb: Merkey's Linux Kernel Debugger 2.6.27-rc4 released |
| Valdis.Kletnieks | Re: [RFC/PATCH] Documentation of kernel messages |
| Greg Kroah-Hartman | [PATCH 004/196] Chinese: add translation of SubmittingPatches |
| Christoph Lameter | [04/14] vcompound: Core piece |
git: | |
| Ken Pratt | pack operation is thrashing my server |
| Peter Stahlir | Git as a filesystem |
| Kyle Moffett | Using GIT to store /etc (Or: How to make GIT store all file permission bits) |
| Francis Moreau | What about git cp ? |
| Richard Stallman | Real men don't attack straw men |
| GVG GVG | ssh_exchange_identification: Connection closed by remote host |
| Girish Venkatachalam | Ethernet jumbo frames? |
| L. V. Lammert | Re: How to find all package files |
| Christoph Hellwig | Re: silent semantic changes with reiser4 |
| Al Boldi | Re: [RFD] Incremental fsck |
| Jens Axboe | Re: [PATCH][RFC] fast file mapping for loop |
| Ian Kent | Re: [PATCH 2/4] autofs4 - track uid and gid of last mount requester |
