linux-kernel mailing list

FromSubjectsort iconDate
Harvey Harrison
[PATCH-mm 5/5] mac80211: tkip.c use struct tkip_ctx in phase...
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> --- net/mac80211/tkip.c | 17 +++++++---------- 1 files changed, 7 insertions(+), 10 deletions(-) diff --git a/net/mac80211/tkip.c b/net/mac80211/tkip.c index 996b1c0..9c03431 100644 --- a/net/mac80211/tkip.c +++ b/net/mac80211/tkip.c @@ -96,10 +96,12 @@ static void tkip_mixing_phase1(struct ieee80211_key *key, const u8 *ta, ctx->initialized = 1; } -static void tkip_mixing_phase2(const u16 *p1k, const u8 *tk, u16 tsc_I...
Apr 16, 7:24 pm 2008
Harvey Harrison
[PATCH-mm 4/5] mac80211: tkip.c use struct tkip_ctx in phase...
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> --- net/mac80211/tkip.c | 28 +++++++++++----------------- 1 files changed, 11 insertions(+), 17 deletions(-) diff --git a/net/mac80211/tkip.c b/net/mac80211/tkip.c index 00a3734..996b1c0 100644 --- a/net/mac80211/tkip.c +++ b/net/mac80211/tkip.c @@ -71,10 +71,12 @@ static inline u16 tkip_S(u16 val) * TSC = TKIP sequence counter (48 bits, only 32 msb bits used) * P1K: 80 bits */ -static void tkip_mixing_phase1(const u8 *...
Apr 16, 7:24 pm 2008
Harvey Harrison
[PATCH-mm 3/5] mac80211: add a struct to hold tkip context
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> --- net/mac80211/cfg.c | 4 +- net/mac80211/debugfs_key.c | 8 +++--- net/mac80211/key.h | 17 +++++++------ net/mac80211/tkip.c | 54 ++++++++++++++++++++++---------------------- net/mac80211/wpa.c | 16 ++++++------ 5 files changed, 50 insertions(+), 49 deletions(-) diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c index 8af576c..88e1904 100644 --- a/net/mac80211/cfg.c +++ b/net/mac...
Apr 16, 7:24 pm 2008
Harvey Harrison
[PATCH-mm 2/5] mac80211: tkip.c remove unused function, remo...
Preparation for move to a tkip context struct. Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> --- net/mac80211/tkip.c | 24 ++++-------------------- net/mac80211/tkip.h | 2 -- 2 files changed, 4 insertions(+), 22 deletions(-) diff --git a/net/mac80211/tkip.c b/net/mac80211/tkip.c index 1c5a46a..f5815ac 100644 --- a/net/mac80211/tkip.c +++ b/net/mac80211/tkip.c @@ -18,15 +18,12 @@ #include "tkip.h" #include "wep.h" - -/* TKIP key mixing functions */ - - #de...
Apr 16, 7:24 pm 2008
Harvey Harrison
[PATCH-mm 1/5] mac80211: add const where possible in michael...
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> --- Andrew, 5 more cleanup patches for -mm on top of the 3 sent earlier today. Setting the stage for a bit more to come later. net/mac80211/michael.c | 4 ++-- net/mac80211/michael.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/mac80211/michael.c b/net/mac80211/michael.c index a9f5323..30b542e 100644 --- a/net/mac80211/michael.c +++ b/net/mac80211/michael.c @@ -27,7 +27,7 @@ static void mic...
Apr 16, 7:24 pm 2008
Karel Zak
[ANNOUNCE] util-linux-ng v2.14-rc1
The first util-linux-ng 2.14 release candidate is available at ftp://ftp.kernel.org/pub/linux/utils/util-linux-ng/v2.14/ Feedback and bug reports, as always, are welcomed. Karel Util-linux-ng 2.14 Release Notes ================================ Release highlights: ------------------ mount(8) supports new "nofail" mount option. mount(8) supports auto-destruction of loop devices. losetup(8) supports new command line option "-j" to show status of all loop devices ...
Apr 16, 7:23 pm 2008
Bartlomiej Zolnierki...
[git patches] IDE fixes
Linus, please pull from: master.kernel.org:/pub/scm/linux/kernel/git/bart/ide-2.6.git/ to receive the following updates: arch/avr32/Kconfig | 1 - arch/mips/au1000/common/platform.c | 2 +- drivers/ide/mips/au1xxx-ide.c | 18 +++++++----------- drivers/ide/pci/it821x.c | 2 +- include/asm-mips/mach-au1x00/au1xxx_ide.h | 18 ------------------ include/asm-mips/mach-db1x00/db1200.h | 4 ++-- include/asm-mips/mach-...
Apr 16, 7:15 pm 2008
Pavel Machek
w35und: remove some more junk and fix divide by zero
Hi! Driver now seems to work a bit better than before... Pavel diff --git a/drivers/net/wireless/winbond/winbondport/mds.c b/drivers/net/wireless/winbond/winbondport/mds.c index 8064deb..b2bd830 100644 --- a/drivers/net/wireless/winbond/winbondport/mds.c +++ b/drivers/net/wireless/winbond/winbondport/mds.c @@ -522,6 +522,8 @@ Mds_DurationSet( PADAPTER Adapter, PDE OffsetSize = pDes->FragmentThreshold + 32 + 3; OffsetSize &= ~0x03; Rate = pDes->TxRate >> 1; + ...
Apr 16, 6:42 pm 2008
Bartlomiej Zolnierki...
[PATCH] ide: remove ->cds field from ide_hwif_t (take 2)
* Use hwif->name instead of cds->name in ide_allocate_dma_engine(). * Use pci_name(dev) instead of cds->name in init_dma_pdc202xx(). * Remove no longer needed ->cds field from ide_hwif_t. v2: * scc_pata.c also needs to be updated now (noticed by Stephen Rothwell). There should be no functional changes caused by this patch. Cc: Kou Ishizaki <kou.ishizaki@toshiba.co.jp> Cc: Akira Iguchi <akira2.iguchi@toshiba.co.jp> Cc: Stephen Rothwell <sfr@canb.auug.org.au&gt...
Apr 16, 6:08 pm 2008
Bartlomiej Zolnierki...
[PATCH] scc_pata: use ide_find_port()
There should be no functional changes caused by this patch. Cc: Kou Ishizaki <kou.ishizaki@toshiba.co.jp> Cc: Akira Iguchi <akira2.iguchi@toshiba.co.jp> Cc: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- goes after "sgiioc4: use ide_find_port()" patch into IDE tree drivers/ide/pci/scc_pata.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) Index: b/drivers/ide/pci/scc_pata.c ================...
Apr 16, 6:03 pm 2008
Bartlomiej Zolnierki...
[PATCH] ide-h8300: add ->{in,out}put_data methods (take 2)
v2: * Update ->{in,out}_data methods to take 'struct request *rq' argument. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- replacement patch for the one in the IDE tree drivers/ide/h8300/ide-h8300.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) Index: b/drivers/ide/h8300/ide-h8300.c =================================================================== --- a/drivers/ide/h8300/ide-h8300.c +...
Apr 16, 6:17 pm 2008
Bartlomiej Zolnierki...
[PATCH] scc_pata: add ->{in,out}put_data methods (take 2)
v2: * Update ->{in,out}_data methods to take 'struct request *rq' argument (thanks to Stephen Rothwell for catching it). There should be no functional changes caused by this patch. Cc: Kou Ishizaki <kou.ishizaki@toshiba.co.jp> Cc: Akira Iguchi <akira2.iguchi@toshiba.co.jp> Cc: Stephen Rothwell <sfr@canb.auug.org.au> Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- replacement patch for the one...
Apr 16, 6:09 pm 2008
Bartlomiej Zolnierki...
[PATCH] au1xxx-ide: add ->{in,out}put_data methods (take 2)
v2: * Update ->{in,out}_data methods to take 'struct request *rq' argument. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- replacement patch for the one in the IDE tree drivers/ide/mips/au1xxx-ide.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) Index: b/drivers/ide/mips/au1xxx-ide.c =================================================================== --- a/drivers/ide/mips/au1xxx-ide.c ++...
Apr 16, 6:14 pm 2008
sukadev
[PATCH]: Factor out PTY index allocation
We noticed this while working on pts namespaces and believe this might be an useful change even as we rework our pts/device namespace approach. --- From: Sukadev Bhattiprolu <sukadev@us.ibm.com> Subject: [PATCH]: Factor out PTY index allocation Factor out the code used to allocate/free a pts index into new interfaces, devpts_new_index() and devpts_kill_index(). This localizes the external data structures used in managing the pts indices. Signed-off-by: Sukadev Bhattiprolu <sukadev@...
Apr 16, 6:17 pm 2008
sukadev
[PATCH]: Propagate error code from devpts_pty_new
From: Sukadev Bhattiprolu <sukadev@us.ibm.com> Subject: [PATCH]: Propagate error code from devpts_pty_new Have ptmx_open() propagate any error code returned by devpts_pty_new() (which returns either 0 or -ENOMEM anyway). Signed-off-by: Sukadev Bhattiprolu <sukadev@us.ibm.com> --- drivers/char/tty_io.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: 2.6.25-rc8-mm2/drivers/char/tty_io.c =================================================================== --- 2.6...
Apr 16, 6:15 pm 2008
devzero
Re: Clock has stopped (time/date looping over 5 seconds), th...
seems so - at least i don`t see LOC (local timer interrupts) increase in /proc/interrupts - the only value increasing there is don`t know - not sure what hrt or no_hz is all about in detail, so please you may tell me what i can check - i will happily deliver all input you need or do any test for you. btw - since i thought that problem was vmware only, i didn`t put it in bugzilla - but we have at least two reports that similar behaviour has also also been seen on real hardware, so i have created a bu...
Apr 16, 6:12 pm 2008
Jesper Juhl
Possible mem leak in copy_process()
Hi Ingo, I was just browsing through Coverity Scan results for the kernel and noticed one thing it spotted that looks valid but which I have no idea how to fix. The code is, as far as I can see, written by you so I thought I'd forward the info from Coverity to you in the hope that perhaps you'd know what to do about it :-) It's a memory leak in copy_process() - this is what coverity reports : 1004 static struct task_struct *copy_process(unsigned long clone_flags, 1005 unsigne...
Apr 16, 5:45 pm 2008
Pavel Machek
w35und: remove ethernet handling, oops magically went away
Remove ethernet handling from mds_TX, and driver started to work again. I can ping without oopsing. --- commit c9835475305cc8e53445fb6245269226309fd5ff tree 5cebb08a98c9f0e2b2c4ac066ef48ff1c00f3942 parent 90a0c62430295f08de972148641283b592a21aa4 author Pavel <pavel@amd.ucw.cz> Wed, 16 Apr 2008 23:52:56 +0200 committer Pavel <pavel@amd.ucw.cz> Wed, 16 Apr 2008 23:52:56 +0200 drivers/net/wireless/winbond/winbondport/mds.c | 180 +----------------------- 1 files changed, 8 insertio...
Apr 16, 5:53 pm 2008
Mathieu Desnoyers
[RFC patch 10/27] Immediate Values - Architecture Independen...
Immediate values are used as read mostly variables that are rarely updated. They use code patching to modify the values inscribed in the instruction stream. It provides a way to save precious cache lines that would otherwise have to be used by these variables. There is a generic _imv_read() version, which uses standard global variables, and optimized per architecture imv_read() implementations, which use a load immediate to remove a data cache hit. When the immediate values functionnality is disabl...
Apr 16, 5:34 pm 2008
Mathieu Desnoyers
[RFC patch 15/27] Immediate Values - Documentation
Changelog: - Remove imv_set_early (removed from API). - Use imv_* instead of immediate_*. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> CC: Rusty Russell <rusty@rustcorp.com.au> CC: Adrian Bunk <bunk@stusta.de> CC: Andi Kleen <andi@firstfloor.org> CC: Christoph Hellwig <hch@infradead.org> CC: mingo@elte.hu CC: akpm@osdl.org --- Documentation/immediate.txt | 221 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 221 insertions(+) I...
Apr 16, 5:34 pm 2008
Mathieu Desnoyers
[RFC patch 13/27] Add text_poke and sync_core to powerpc
- Needed on architectures where we must surround live instruction modification with "WP flag disable". - Turns into a memcpy on powerpc since there is no WP flag activated for instruction pages (yet..). - Add empty sync_core to powerpc so it can be used in architecture independent code. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> CC: Rusty Russell <rusty@rustcorp.com.au> CC: Christoph Hellwig <hch@infradead.org> CC: Paul Mackerras <paulus@samba.org&g...
Apr 16, 5:34 pm 2008
Mathieu Desnoyers
[RFC patch 12/27] Immediate Values - x86 Optimization
x86 optimization of the immediate values which uses a movl with code patching to set/unset the value used to populate the register used as variable source. Note : a movb needs to get its value froma =q constraint. Quoting "H. Peter Anvin" <hpa@zytor.com> Using =r for single-byte values is incorrect for 32-bit code -- that would permit %spl, %bpl, %sil, %dil which are illegal in 32-bit mode. Changelog: - Use text_poke_early with cr0 WP save/restore to patch the bypass. We are doing n...
Apr 16, 5:34 pm 2008
Mathieu Desnoyers
[RFC patch 09/27] Add all cpus option to stop machine run
-allow stop_mahcine_run() to call a function on all cpus. Calling stop_machine_run() with a 'ALL_CPUS' invokes this new behavior. stop_machine_run() proceeds as normal until the calling cpu has invoked 'fn'. Then, we tell all the other cpus to call 'fn'. Signed-off-by: Jason Baron <jbaron@redhat.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> CC: Rusty Russell <rusty@rustcorp.com.au> CC: Adrian Bunk <bunk@stusta.de> CC: Andi Kleen <andi@firstfloo...
Apr 16, 5:34 pm 2008
Mathieu Desnoyers
[RFC patch 14/27] Immediate Values - Powerpc Optimization
PowerPC optimization of the immediate values which uses a li instruction, patched with an immediate value. Changelog: - Put imv_set and _imv_set in the architecture independent header. - Pack the __imv section. Use smallest types required for size (char). - Remove architecture specific update code : now handled by architecture agnostic code. - Use imv_* instead of immediate_*. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> CC: Rusty Russell <rusty@rustcorp.com.au>...
Apr 16, 5:34 pm 2008
Mathieu Desnoyers
[RFC patch 17/27] Scheduler Profiling - Use Immediate Values
Use immediate values with lower d-cache hit in optimized version as a condition for scheduler profiling call. Changelog : - Use imv_* instead of immediate_*. - Follow the white rabbit : kvm_main.c which becomes x86.c. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> CC: Rusty Russell <rusty@rustcorp.com.au> CC: Adrian Bunk <bunk@stusta.de> CC: Andi Kleen <andi@firstfloor.org> CC: Christoph Hellwig <hch@infradead.org> CC: mingo@elte.hu CC: akpm@osdl...
Apr 16, 5:34 pm 2008
Mathieu Desnoyers
[RFC patch 11/27] Immediate Values - Kconfig menu in EMBEDDED
Immediate values provide a way to use dynamic code patching to update variables sitting within the instruction stream. It saves caches lines normally used by static read mostly variables. Enable it by default, but let users disable it through the EMBEDDED menu with the "Disable immediate values" submenu entry. Note: Since I think that I really should let embedded systems developers using RO memory the option to disable the immediate values, I choose to leave this menu option there, in the EMBEDDED m...
Apr 16, 5:34 pm 2008
Mathieu Desnoyers
[RFC patch 22/27] Immediate Values - x86 Optimization NMI an...
x86 optimization of the immediate values which uses a movl with code patching to set/unset the value used to populate the register used as variable source. It uses a breakpoint to bypass the instruction being changed, which lessens the interrupt latency of the operation and protects against NMIs and MCE. - More reentrant immediate value : uses a breakpoint. Needs to know the instruction's first byte. This is why we keep the "instruction size" variable, so we can support the REX prefixed instruct...
Apr 16, 5:34 pm 2008
Mathieu Desnoyers
[RFC patch 02/27] x86 NMI-safe INT3 and Page Fault
Implements an alternative iret with popf and return so trap and exception handlers can return to the NMI handler without issuing iret. iret would cause NMIs to be reenabled prematurely. x86_32 uses popf and far return. x86_64 has to copy the return instruction pointer to the top of the previous stack, issue a popf, loads the previous esp and issue a near return (ret). It allows placing immediate values (and therefore optimized trace_marks) in NMI code since returning from a breakpoint would be valid...
Apr 16, 5:34 pm 2008
Mathieu Desnoyers
[RFC patch 16/27] Immediate Values Support init
Supports placing immediate values in init code We need to put the immediate values in RW data section so we can edit them before init section unload. This code puts NULL pointers in lieu of original pointer referencing init code before the init sections are freed, both in the core kernel and in modules. TODO : support __exit section. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> CC: Rusty Russell <rusty@rustcorp.com.au> CC: "Frank Ch. Eigler" <fche@redhat.com...
Apr 16, 5:34 pm 2008
Mathieu Desnoyers
[RFC patch 06/27] Kprobes - declare kprobe_mutex static
Since it will not be used by other kernel objects, it makes sense to declare it static. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> Acked-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com> Acked-by: Masami Hiramatsu <mhiramat@redhat.com> CC: hch@infradead.org CC: anil.s.keshavamurthy@intel.com CC: davem@davemloft.net --- kernel/kprobes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6-lttng/kernel/kprobes.c ====================...
Apr 16, 5:34 pm 2008
Mathieu Desnoyers
[RFC patch 21/27] Add __discard section to x86
Add a __discard sectionto the linker script. Code produced in this section will not be put in the vmlinux file. This is useful when we have to calculate the size of an instruction before actually declaring it (for alignment purposes for instance). This is used by the immediate values. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> Acked-by: H. Peter Anvin <hpa@zytor.com> CC: Andi Kleen <ak@muc.de> CC: Chuck Ebbert <cebbert@redhat.com> CC: Christoph Hellwig ...
Apr 16, 5:34 pm 2008
Mathieu Desnoyers
[RFC patch 04/27] Kprobes - use a mutex to protect the instr...
Protect the instruction pages list by a specific insn pages mutex, called in get_insn_slot() and free_insn_slot(). It makes sure that architectures that does not need to call arch_remove_kprobe() does not take an unneeded kprobes mutex. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> Acked-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com> Acked-by: Masami Hiramatsu <mhiramat@redhat.com> CC: hch@infradead.org CC: anil.s.keshavamurthy@intel.com CC: davem@davemloft...
Apr 16, 5:34 pm 2008
Mathieu Desnoyers
[RFC patch 08/27] Text Edit Lock - kprobes architecture inde...
Use the mutual exclusion provided by the text edit lock in the kprobes code. It allows coherent manipulation of the kernel code by other subsystems. Changelog: Move the kernel_text_lock/unlock out of the for loops. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> Acked-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com> CC: ananth@in.ibm.com CC: anil.s.keshavamurthy@intel.com CC: davem@davemloft.net CC: Roel Kluin <12o3l@tiscali.nl> --- kernel/kprobes.c | ...
Apr 16, 5:34 pm 2008
Mathieu Desnoyers
[RFC patch 20/27] Immediate Values - Move Kprobes x86 restor...
Since the breakpoint handler is useful both to kprobes and immediate values, it makes sense to make the required restore_interrupt() available through asm-i386/kdebug.h. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> Acked-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com> CC: Christoph Hellwig <hch@infradead.org> CC: anil.s.keshavamurthy@intel.com CC: davem@davemloft.net CC: Thomas Gleixner <tglx@linutronix.de> CC: Ingo Molnar <mingo@redhat.com> CC...
Apr 16, 5:34 pm 2008
Mathieu Desnoyers
[RFC patch 05/27] Kprobes - do not use kprobes mutex in arch...
Remove the kprobes mutex from kprobes.h, since it does not belong there. Also remove all use of this mutex in the architecture specific code, replacing it by a proper mutex lock/unlock in the architecture agnostic code. Changelog : - remove unnecessary kprobe_mutex around arch_remove_kprobe() Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> Acked-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com> Acked-by: Masami Hiramatsu <mhiramat@redhat.com> CC: anil.s.keshava...
Apr 16, 5:34 pm 2008
Mathieu Desnoyers
[RFC patch 01/27] From: Adrian Bunk <bunk@kernel.org>
With the needlessly global marker_debug being static gcc can optimize the unused code away. Signed-off-by: Adrian Bunk &lt;bunk@kernel.org&gt; Acked-by: Mathieu Desnoyers &lt;mathieu.desnoyers@polymtl.ca&gt; Signed-off-by: Andrew Morton &lt;akpm@linux-foundation.org&gt; --- kernel/marker.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN kernel/marker.c~make-marker_debug-static kernel/marker.c --- a/kernel/marker.c~make-marker_debug-static +++ a/kernel/marker.c @@ -28,7 +...
Apr 16, 5:34 pm 2008
Mathieu Desnoyers
[RFC patch 23/27] Immediate Values - Powerpc Optimization NM...
Use an atomic update for immediate values. Signed-off-by: Mathieu Desnoyers &lt;mathieu.desnoyers@polymtl.ca&gt; CC: Rusty Russell &lt;rusty@rustcorp.com.au&gt; CC: Christoph Hellwig &lt;hch@infradead.org&gt; CC: Paul Mackerras &lt;paulus@samba.org&gt; --- arch/powerpc/kernel/Makefile | 1 arch/powerpc/kernel/immediate.c | 73 ++++++++++++++++++++++++++++++++++++++++ include/asm-powerpc/immediate.h | 18 +++++++++ 3 files changed, 92 insertions(+) Index: linux-2.6-lttng/arch/powerp...
Apr 16, 5:34 pm 2008
Paul Mackerras
Re: [RFC patch 23/27] Immediate Values - Powerpc Optimizatio...
What is meant by an "atomic" update in this context? AFAICS you are using memcpy, which is not in any way guaranteed to be atomic. Paul. --
Apr 16, 7:09 pm 2008
Mathieu Desnoyers
Re: [RFC patch 23/27] Immediate Values - Powerpc Optimizatio...
I expect memcpy to perform the copy in one memory access, given I put a .align 2 before the 2 bytes instruction. It makes sure the instruction modified fits in a single, aligned, memory write. Or maybe am I expecting too much from memcpy ? Mathieu -- Mathieu Desnoyers Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 --
Apr 16, 7:33 pm 2008
Mathieu Desnoyers
[RFC patch 18/27] Markers - remove extra format argument
Very good point. I actually thought about dropping it, since it would remove an unnecessary argument from the stack. And actually, since I now have the marker_probe_cb sitting between the marker site and the callbacks, there is no API change required. Thanks :) Mathieu Signed-off-by: Mathieu Desnoyers &lt;mathieu.desnoyers@polymtl.ca&gt; CC: Denys Vlasenko &lt;vda.linux@googlemail.com&gt; --- include/linux/marker.h | 11 +++++------ kernel/marker.c | 30 ++++++++++++++-----------...
Apr 16, 5:34 pm 2008
Mathieu Desnoyers
[RFC patch 19/27] Markers - define non optimized marker
To support the forthcoming "immediate values" marker optimization, we must have a way to declare markers in few code paths that does not use instruction modification based enable. This will be the case of printk(), some traps and eventually lockdep instrumentation. Changelog : - Fix reversed boolean logic of "generic". Signed-off-by: Mathieu Desnoyers &lt;mathieu.desnoyers@polymtl.ca&gt; --- include/linux/marker.h | 29 ++++++++++++++++++++++++----- 1 file changed, 24 insertions(+), 5 deleti...
Apr 16, 5:34 pm 2008
Mathieu Desnoyers
[RFC patch 07/27] Text Edit Lock - Architecture Independent ...
This is an architecture independant synchronization around kernel text modifications through use of a global mutex. A mutex has been chosen so that kprobes, the main user of this, can sleep during memory allocation between the memory read of the instructions it must replace and the memory write of the breakpoint. Other user of this interface: immediate values. Paravirt and alternatives are always done when SMP is inactive, so there is no need to use locks. Signed-off-by: Mathieu Desnoyers &l...
Apr 16, 5:34 pm 2008
Mathieu Desnoyers
[RFC patch 03/27] Check for breakpoint in text_poke to elimi...
It's ok to modify an instruction non-atomically (multiple memory accesses to a large and/or non aligned instruction) *if and only if* we have inserted a breakpoint at the beginning of the instruction. Signed-off-by: Mathieu Desnoyers &lt;mathieu.desnoyers@polymtl.ca&gt; --- arch/x86/kernel/alternative.c | 49 ++++++++++++++++++++++++------------------ 1 file changed, 29 insertions(+), 20 deletions(-) Index: linux-2.6-sched-devel/arch/x86/kernel/alternative.c ==================================...
Apr 16, 5:34 pm 2008
Mathieu Desnoyers
[RFC patch 26/27] Immediate Values - Jump
Adds a new imv_cond() macro to declare a byte read that is meant to be embedded in unlikely(imv_cond(var)), so the kernel can dynamically detect patterns such as mov, test, jne or mov, test, je and patch it with nops and a jump. Signed-off-by: Mathieu Desnoyers &lt;mathieu.desnoyers@polymtl.ca&gt; --- arch/x86/kernel/immediate.c | 381 ++++++++++++++++++++++++++++++++-------- include/asm-powerpc/immediate.h | 2 include/asm-x86/immediate.h | 34 +++ include/linux/immediate.h ...
Apr 16, 5:34 pm 2008
Mathieu Desnoyers
[RFC patch 27/27] Markers use imv jump
Let markers use the heavily optimized imv_cond() version of immediate values. Signed-off-by: Mathieu Desnoyers &lt;mathieu.desnoyers@polymtl.ca&gt; --- include/linux/marker.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6-lttng/include/linux/marker.h =================================================================== --- linux-2.6-lttng.orig/include/linux/marker.h 2008-04-16 00:16:52.000000000 -0400 +++ linux-2.6-lttng/include/linux/marker.h 2008-04-16 00:17:12.000000...
Apr 16, 5:34 pm 2008
Mathieu Desnoyers
[RFC patch 25/27] Linux Kernel Markers - Use Immediate Values
Make markers use immediate values. Changelog : - Use imv_* instead of immediate_*. Signed-off-by: Mathieu Desnoyers &lt;mathieu.desnoyers@polymtl.ca&gt; --- Documentation/markers.txt | 17 +++++++++++++---- include/linux/marker.h | 16 ++++++++++++---- kernel/marker.c | 8 ++++++-- kernel/module.c | 1 + 4 files changed, 32 insertions(+), 10 deletions(-) Index: linux-2.6-sched-devel/include/linux/marker.h ====================================================...
Apr 16, 5:34 pm 2008
Mathieu Desnoyers
[RFC patch 00/27] Jump-based NMI-safe immediate values and m...
Hi Ingo, Here is the patchset you requested. I did not port the marker reintegration to your sched-devel tree though, because many changes happened since you have done the original work. It applies on top of sched-devel.git latest. You will notice that I implemented what we discussed yesterday : using nops and jump for the heavily optimized version of markers. Comments are welcome. Running this with my ~120 LTTng markers on x86_32 detects 97% of the sites. 4 out of 120 did had to fall back on ...
Apr 16, 5:34 pm 2008
Mathieu Desnoyers
[RFC patch 24/27] Immediate Values Use Arch NMI and MCE Supp...
Remove the architecture agnostic code now replaced by architecture specific, atomic instruction updates. Signed-off-by: Mathieu Desnoyers &lt;mathieu.desnoyers@polymtl.ca&gt; --- include/linux/immediate.h | 11 ------ kernel/immediate.c | 73 +--------------------------------------------- 2 files changed, 3 insertions(+), 81 deletions(-) Index: linux-2.6-lttng/kernel/immediate.c =================================================================== --- linux-2.6-lttng.orig/kernel/immed...
Apr 16, 5:34 pm 2008
Jesper Juhl
[PATCH][netlabel] Don't risk NULL ptr deref in netlbl_unlabe...
Hi, dev_get_by_index() may return NULL if nothing is found. In net/netlabel/netlabel_unlabeled.c::netlbl_unlabel_staticlist_gen() the function is called, but the return value is never checked. If it returns NULL then we'll deref a NULL pointer on the very next line. I checked the callers, and I don't think this can actually happen today, but code changes over time and in the future it might happen and it does no harm to be defensive and check for the failure, so that if/when it happens we'll...
Apr 16, 5:08 pm 2008
Paul Moore
Re: [PATCH][netlabel] Don't risk NULL ptr deref in netlbl_un...
I agree we should check for NULL here. I checked the return of dev_get_by_index() in the rest of the file I must have just forgotten to check it here. Thanks for finding this and fixing it. -- paul moore linux @ hp --
Apr 16, 5:21 pm 2008
previous daytodaynext day
April 15, 2008April 16, 2008April 17, 2008