Home » Mailing list archives » linux-kernel » 2008 » April » 16

[PATCH]: Propagate error code from devpts_pty_new

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: <sukadev@...>
To: Andrew Morton <akpm@...>
Cc: <serue@...>, Eric W. Biederman <ebiederm@...>, <hpa@...>, Containers <containers@...>, <linux-kernel@...>
Subject: [PATCH]: Propagate error code from devpts_pty_new
Date: Wednesday, April 16, 2008 - 6:15 pm

From: Sukadev Bhattiprolu <sukadev@us.ibm.com>
Subject: [PATCH]: Propagate error code from devpts_pty_new

Have ptmx_open() propagate any error code returned by devpts_pty_new()
(which returns either 0 or -ENOMEM anyway).

Signed-off-by: Sukadev Bhattiprolu <sukadev@us.ibm.com>
---
 drivers/char/tty_io.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: 2.6.25-rc8-mm2/drivers/char/tty_io.c
===================================================================
--- 2.6.25-rc8-mm2.orig/drivers/char/tty_io.c	2008-04-16 09:38:23.000000000 -0700
+++ 2.6.25-rc8-mm2/drivers/char/tty_io.c	2008-04-16 09:51:11.000000000 -0700
@@ -2835,8 +2835,8 @@ static int ptmx_open(struct inode *inode
 	filp->private_data = tty;
 	file_move(filp, &tty->tty_files);
 
-	retval = -ENOMEM;
-	if (devpts_pty_new(tty->link))
+	retval = devpts_pty_new(tty->link);
+	if (retval)
 		goto out1;
 
 	check_tty_count(tty, "tty_open");
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH]: Propagate error code from devpts_pty_new, , (Wed Apr 16, 6:15 pm)
Re: [PATCH]: Propagate error code from devpts_pty_new, Serge E. Hallyn, (Thu Apr 17, 11:37 am)
Re: [PATCH]: Propagate error code from devpts_pty_new, H. Peter Anvin, (Thu Apr 17, 12:05 pm)