Home » Mailing list archives » linux-kernel » 2008 » April » 16

[PATCH 1/6] MIPS: irixelf: fix test unsigned var < 0

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Roel Kluin <12o3l@...>
To: <ralf@...>
Cc: <linux-mips@...>, lkml <linux-kernel@...>
Subject: [PATCH 1/6] MIPS: irixelf: fix test unsigned var &lt; 0
Date: Tuesday, April 15, 2008 - 9:39 pm

v is unsigned, cast to signed to evaluate the do_brk() return value,
    
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/arch/mips/kernel/irixelf.c b/arch/mips/kernel/irixelf.c
index 290d8e3..fad2a2a 100644
--- a/arch/mips/kernel/irixelf.c
+++ b/arch/mips/kernel/irixelf.c
@@ -583,15 +583,15 @@ static void irix_map_prda_page(void)
 	unsigned long v;
 	struct prda *pp;
 
 	down_write(&current->mm->mmap_sem);
 	v =  do_brk(PRDA_ADDRESS, PAGE_SIZE);
 	up_write(&current->mm->mmap_sem);
 
-	if (v < 0)
+	if ((long) v < 0)
 		return;
 
 	pp = (struct prda *) v;
 	pp->prda_sys.t_pid  = task_pid_vnr(current);
 	pp->prda_sys.t_prid = read_c0_prid();
 	pp->prda_sys.t_rpid = task_pid_vnr(current);
 

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 1/6] MIPS: irixelf: fix test unsigned var < 0, Roel Kluin, (Tue Apr 15, 9:39 pm)
Re: [PATCH 1/6] MIPS: irixelf: fix test unsigned var &lt; 0, Marcin Slusarz, (Wed Apr 16, 3:39 pm)
Re: [PATCH 1/6] MIPS: irixelf: fix test unsigned var &lt; 0, Ralf Baechle, (Wed Apr 16, 2:00 pm)
[PATCH 6/6] sound/drivers/dummy.c: fix negative snd_pcm_form..., Roel Kluin, (Wed Apr 16, 12:20 pm)
Re: [alsa-devel] [PATCH 6/6] sound/drivers/dummy.c: fix nega..., Takashi Iwai, (Wed Apr 16, 12:31 pm)
[PATCH 5/6] NETFILTER: signed tcphoff for ipv6_skip_exthdr()..., Roel Kluin, (Wed Apr 16, 12:00 pm)
Re: [netfilter-core] [PATCH 5/6] NETFILTER: signed tcphoff f..., Patrick McHardy, (Mon Apr 21, 8:24 am)
Re: [PATCH 1/6] MIPS: irixelf: fix test unsigned var &lt; 0, Roel Kluin, (Wed Apr 16, 11:27 am)
[PATCH 4/6] RTC: rtc-ds1374: fix unsigned new_alarm test, Roel Kluin, (Wed Apr 16, 11:32 am)
Re: [PATCH 4/6] RTC: rtc-ds1374: fix unsigned new_alarm test, Alessandro Zummo, (Fri Apr 18, 5:58 pm)