Re: [patch] mm: sparsemem memory_present() memory corruption fix

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Linus Torvalds <torvalds@...>

Cc: Pekka Enberg <penberg@...>, Christoph Lameter <clameter@...>, <linux-kernel@...>, Mel Gorman <mel@...>, Nick Piggin <npiggin@...>, Andrew Morton <akpm@...>, Rafael J. Wysocki <rjw@...>, <Yinghai.Lu@...>, <apw@...>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@...>

Subject: Re: [patch] mm: sparsemem memory_present() memory corruption fix

Date: Tuesday, April 15, 2008 - 8:34 pm

small addendum to the changelog:

quoted text>                 if (!ms->section_mem_map)
>                         ms->section_mem_map = sparse_encode_early_nid(nid) |
+                                            | SECTION_MARKED_PRESENT
quoted text> 
> 'ms' will be out of bounds and we'll corrupt a small amount of memory by
> encoding the node ID. Depending on what that memory is, we might crash, 
> misbehave or just not notice the bug.

the corruption might happen when encoding a non-zero node ID, or due to 
the SECTION_MARKED_PRESENT which is 0x1:

mmzone.h:#define        SECTION_MARKED_PRESENT  (1UL<<0)

	Ingo
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[bug] mm/slab.c boot crash in -git, "kernel BUG at mm/slab.c..., Ingo Molnar, (Fri Apr 11, 3:41 am)

Re: [bug] mm/slab.c boot crash in -git, "kernel BUG at mm/sl..., Pekka Enberg, (Fri Apr 11, 4:21 am)

Re: [bug] mm/slab.c boot crash in -git, "kernel BUG at mm/sl..., Pekka Enberg, (Fri Apr 11, 4:50 am)

Re: [bug] mm/slab.c boot crash in -git, "kernel BUG at mm/sl..., Ingo Molnar, (Fri Apr 11, 4:54 am)

Re: [bug] mm/slab.c boot crash in -git, "kernel BUG at mm/sl..., Pekka Enberg, (Fri Apr 11, 5:05 am)

Re: [bug] mm/slab.c boot crash in -git, "kernel BUG at mm/sl..., Christoph Lameter, (Fri Apr 11, 3:25 pm)

Re: [bug] mm/slab.c boot crash in -git, "kernel BUG at mm/sl..., Ingo Molnar, (Tue Apr 15, 1:49 am)

Re: [bug] mm/slab.c boot crash in -git, "kernel BUG at mm/sl..., Pekka Enberg, (Fri Apr 11, 5:08 am)

Re: [bug] mm/slab.c boot crash in -git, "kernel BUG at mm/sl..., Christoph Lameter, (Fri Apr 11, 3:26 pm)

Re: [bug] mm/slab.c boot crash in -git, "kernel BUG at mm/sl..., Pekka Enberg, (Fri Apr 11, 5:11 am)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 2:25 am)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Linus Torvalds, (Tue Apr 15, 12:02 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 12:15 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 4:23 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Linus Torvalds, (Tue Apr 15, 1:23 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Christoph Lameter, (Tue Apr 15, 3:39 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 3:54 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Christoph Lameter, (Tue Apr 15, 4:03 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 4:17 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Christoph Lameter, (Tue Apr 15, 4:54 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 4:58 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 5:08 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Pekka Enberg, (Tue Apr 15, 4:34 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 4:40 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Linus Torvalds, (Tue Apr 15, 5:06 pm)

[patch] mm: sparsemem memory_present() memory corruption fix, Ingo Molnar, (Tue Apr 15, 8:03 pm)

Re: [patch] mm: sparsemem memory_present() memory corruption..., Ingo Molnar, (Wed Apr 16, 11:03 am)

Re: [patch] mm: sparsemem memory_present() memory corruption..., Mel Gorman, (Wed Apr 16, 10:05 am)

Re: [patch] mm: sparsemem memory_present() memory corruption..., KAMEZAWA Hiroyuki, (Tue Apr 15, 9:48 pm)

Re: [patch] mm: sparsemem memory_present() memory corruption..., Ingo Molnar, (Tue Apr 15, 8:34 pm)

Re: [patch] mm: sparsemem memory_present() memory corruption..., Linus Torvalds, (Tue Apr 15, 10:45 pm)

Re: [patch] mm: sparsemem memory_present() memory corruption..., Ingo Molnar, (Tue Apr 15, 8:40 pm)

Re: [patch] mm: sparsemem memory_present() memory corruption..., Ingo Molnar, (Tue Apr 15, 9:14 pm)

Re: [patch] mm: sparsemem memory_present() memory corruption..., Christoph Lameter, (Tue Apr 15, 8:45 pm)

Re: [patch] mm: sparsemem memory_present() memory corruption..., Ingo Molnar, (Tue Apr 15, 8:52 pm)

Re: [patch] mm: sparsemem memory_present() memory corruption..., Christoph Lameter, (Tue Apr 15, 8:19 pm)

Re: [patch] mm: sparsemem memory_present() memory corruption..., Ingo Molnar, (Tue Apr 15, 8:36 pm)

Re: [patch] mm: sparsemem memory_present() memory corruption..., Yinghai Lu, (Tue Apr 15, 8:33 pm)

Re: [patch] mm: sparsemem memory_present() memory corruption..., Ingo Molnar, (Tue Apr 15, 8:18 pm)

Re: [patch] mm: sparsemem memory_present() memory corruption..., Yinghai Lu, (Tue Apr 15, 8:32 pm)

Re: [patch] mm: sparsemem memory_present() memory corruption..., Ingo Molnar, (Tue Apr 15, 8:44 pm)

Re: [patch] mm: sparsemem memory_present() memory corruption..., Yinghai Lu, (Tue Apr 15, 8:56 pm)

Re: [patch] mm: sparsemem memory_present() memory corruption..., Ingo Molnar, (Tue Apr 15, 9:02 pm)

Re: [patch] mm: sparsemem memory_present() memory corruption..., Yinghai Lu, (Tue Apr 15, 9:17 pm)

Re: [patch] mm: sparsemem memory_present() memory corruption..., Christoph Lameter, (Tue Apr 15, 8:46 pm)

Re: [patch] mm: sparsemem memory_present() memory corruption..., Ingo Molnar, (Tue Apr 15, 8:52 pm)

Re: [patch] mm: sparsemem memory_present() memory corruption..., Ingo Molnar, (Tue Apr 15, 9:17 pm)

Re: [patch] mm: sparsemem memory_present() memory corruption..., Yinghai Lu, (Tue Apr 15, 9:30 pm)

Re: [patch] mm: sparsemem memory_present() memory corruption..., Yinghai Lu, (Tue Apr 15, 10:00 pm)

Re: [patch] mm: sparsemem memory_present() memory corruption..., KAMEZAWA Hiroyuki, (Tue Apr 15, 10:20 pm)

Re: [patch] mm: sparsemem memory_present() memory corruption..., Christoph Lameter, (Tue Apr 15, 8:10 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 5:13 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 5:24 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Christoph Lameter, (Tue Apr 15, 5:42 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 5:55 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Christoph Lameter, (Tue Apr 15, 6:06 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Yinghai Lu, (Tue Apr 15, 7:18 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 6:13 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Christoph Lameter, (Tue Apr 15, 6:27 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Christoph Lameter, (Tue Apr 15, 7:22 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 7:27 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Christoph Lameter, (Tue Apr 15, 8:04 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Christoph Lameter, (Tue Apr 15, 7:32 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 6:32 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 4:28 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 4:34 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 4:42 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Christoph Lameter, (Tue Apr 15, 4:50 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 4:58 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Christoph Lameter, (Tue Apr 15, 5:08 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 5:19 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Mike Travis, (Tue Apr 15, 5:27 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Christoph Lameter, (Tue Apr 15, 5:21 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 5:23 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Christoph Lameter, (Tue Apr 15, 5:24 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 5:28 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 6:07 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Mike Travis, (Tue Apr 15, 5:43 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Christoph Lameter, (Tue Apr 15, 5:33 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Mike Travis, (Tue Apr 15, 5:16 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 3:35 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 3:41 pm)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Pekka Enberg, (Tue Apr 15, 2:41 am)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 3:08 am)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 5:11 am)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Yinghai Lu, (Tue Apr 15, 4:31 am)

Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 4:46 am)

Re: [bug] mm/slab.c boot crash in -git, "kernel BUG at mm/sl..., Ingo Molnar, (Fri Apr 11, 5:24 am)

Re: [bug] mm/slab.c boot crash in -git, "kernel BUG at mm/sl..., Mel Gorman, (Tue Apr 15, 5:36 am)

Re: [bug] mm/slab.c boot crash in -git, "kernel BUG at mm/sl..., Ingo Molnar, (Tue Apr 15, 6:03 am)

Re: [bug] mm/slab.c boot crash in -git, "kernel BUG at mm/sl..., Christoph Lameter, (Fri Apr 11, 3:28 pm)

Re: [bug] mm/slab.c boot crash in -git, "kernel BUG at mm/sl..., Ingo Molnar, (Tue Apr 15, 1:43 am)

Re: [bug] mm/slab.c boot crash in -git, "kernel BUG at mm/sl..., Christoph Lameter, (Sat Apr 12, 6:38 am)

Re: [bug] mm/slab.c boot crash in -git, "kernel BUG at mm/sl..., Yinghai Lu, (Sat Apr 12, 1:22 pm)

Re: [bug] mm/slab.c boot crash in -git, "kernel BUG at mm/sl..., Nick Piggin, (Fri Apr 11, 6:34 am)

Navigation

Popular discussions


linux-kernel:
Andrew Morton	-mm merge plans for 2.6.23
david	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Linus Torvalds	Linux 2.6.27-rc5
Bart Van Assche	Integration of SCST in the mainstream Linux kernel
git:

linux-netdev:
David Miller	Re: [GIT]: Networking
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Lennert Buytenhek	[PATCH 16/39] mv643xx_eth: get rid of ETH_/ethernet_/eth_ prefixes
openbsd-misc:

Colocation donated by:

Online users

Syndicate