login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
April
»
15
Re: [PATCH] tty: fix routine name in ptmx_open()
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Andrew Morton <akpm@...>
To: Hiroshi Shimamoto <h-shimamoto@...>
Cc: <linux-kernel@...>, Alan Cox <alan@...>
Subject:
Re: [PATCH] tty: fix routine name in ptmx_open()
Date: Tuesday, April 15, 2008 - 6:01 pm
On Mon, 14 Apr 2008 17:55:49 -0700 Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> wrote:
quoted text
> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> > > At ptmx_open(), the 2nd parameter for check_tty_count() should > be "ptmx_open". > > Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> > --- > drivers/char/tty_io.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c > index 613ec81..546217d 100644 > --- a/drivers/char/tty_io.c > +++ b/drivers/char/tty_io.c > @@ -2774,7 +2774,7 @@ static int ptmx_open(struct inode *inode, struct file *filp) > if (devpts_pty_new(tty->link)) > goto out1; > > - check_tty_count(tty, "tty_open"); > + check_tty_count(tty, "ptmx_open"); > retval = ptm_driver->open(tty, filp); > if (!retval) { > tty_audit_opening();
Of course, using __func__ prevents this sort of bitrot. Or even #define check_tty_count(tty) __check_tty_count(tty, __func__) --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH] tty: fix routine name in ptmx_open()
, Hiroshi Shimamoto
, (Mon Apr 14, 8:55 pm)
Re: [PATCH] tty: fix routine name in ptmx_open()
, Andrew Morton
, (Tue Apr 15, 6:01 pm)
Re: [PATCH] tty: fix routine name in ptmx_open()
, Alan Cox
, (Tue Apr 15, 5:58 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Al Viro
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg KH
[2.6.22.2 review 05/84] Fix deadlocks in sparc serial console.
Linus Torvalds
Linux 2.6.27-rc8
Greg Kroah-Hartman
[PATCH 006/196] Chinese: add translation of oops-tracing.txt
git
:
linux-netdev
:
Natalie Protasevich
[BUG] New Kernel Bugs
Jarek Poplawski
Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Linus Torvalds
Re: [GIT]: Networking
Gerrit Renker
[PATCH 0/37] dccp: Feature negotiation - last call for comments
netbsd-tech-kern
:
Manuel Bouyer
Re: Interactive performance in -current
YAMAMOTO Takashi
Re: statvfs(2) replacement for statfs(2) patch
Nathan Langford
microkernels
Garrett D'Amore
Re: wsmux inject
Colocation donated by:
Who's online
There are currently
2 users
and
1022 guests
online.
Online users
jamesulner
basika68
Syndicate