login
Header Space

 
 

Re: [PATCH] Replace completions with semaphores

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Linus Torvalds <torvalds@...>
Cc: Peter Zijlstra <peterz@...>, Bart Van Assche <bart.vanassche@...>, Roland Dreier <rdreier@...>, Ingo Molnar <mingo@...>, Matthew Wilcox <matthew@...>, Ingo Oeser <ioe-lkml@...>, Daniel Walker <dwalker@...>, <linux-kernel@...>
Date: Tuesday, April 15, 2008 - 1:15 pm

Linus Torvalds wrote:

For normal locks. But if you have N number of outstanding
events you need to wait for the semaphore is the right primitive.

And it seems there is a not high but non trivial number
of places in the kernel who have a legitimate need for this.


Ok so you just want to rename it.

Fine for me. I always found up() and down() unintuitive anyways
(but it's admittedly better than "P" and "V" which some other systems use)


Because we still "counted completions" for some things and that's the
same code?

Rather i suspect the real problem is not the name, but just not sure
it gets abused. That is largely more a review problem and as far as I
can figure out basically all the usual reviewers take care of that
anyways. But renaming it also probably wouldn't hurt.

[IMHO I always thought we should have a maintained single "list of
things for reviewers to watch out for" list somewhere]

-Andi

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] Replace completions with semaphores, Matthew Wilcox, (Fri Apr 11, 5:00 pm)
Re: [PATCH] Replace completions with semaphores, Peter Zijlstra, (Sat Apr 12, 8:24 am)
Re: [PATCH] Replace completions with semaphores, Ingo Molnar, (Sun Apr 13, 3:05 am)
Re: [PATCH] Replace completions with semaphores, Matthew Wilcox, (Sun Apr 13, 8:52 am)
Re: [PATCH] Replace completions with semaphores, Jens Axboe, (Mon Apr 14, 12:54 pm)
Re: [PATCH] Replace completions with semaphores, Ingo Molnar, (Mon Apr 14, 11:41 am)
Re: [PATCH] Replace completions with semaphores, Matthew Wilcox, (Mon Apr 14, 1:46 pm)
Re: [PATCH] Replace completions with semaphores, Matthew Wilcox, (Sat Apr 12, 1:26 pm)
Re: [PATCH] Replace completions with semaphores, Roland Dreier, (Sat Apr 12, 3:53 pm)
Re: [PATCH] Replace completions with semaphores, Bart Van Assche, (Sun Apr 13, 9:55 am)
Re: [PATCH] Replace completions with semaphores, Matthew Wilcox, (Sun Apr 13, 10:22 am)
Re: [PATCH] Replace completions with semaphores, Matthew Wilcox, (Sat Apr 12, 4:47 pm)
Re: [PATCH] Replace completions with semaphores, Ingo Molnar, (Sun Apr 13, 3:08 am)
Re: [PATCH] Replace completions with semaphores, Bart Van Assche, (Sun Apr 13, 10:55 am)
Re: [PATCH] Replace completions with semaphores, Matthew Wilcox, (Sun Apr 13, 8:57 am)
Re: [PATCH] Replace completions with semaphores, Ingo Molnar, (Mon Apr 14, 11:39 am)
Re: [PATCH] Replace completions with semaphores, Roland Dreier, (Mon Apr 14, 11:58 am)
Re: [PATCH] Replace completions with semaphores, Peter Zijlstra, (Mon Apr 14, 12:32 pm)
Re: [PATCH] Replace completions with semaphores, Andi Kleen, (Mon Apr 14, 1:46 pm)
Re: [PATCH] Replace completions with semaphores, Peter Zijlstra, (Mon Apr 14, 1:54 pm)
Re: [PATCH] Replace completions with semaphores, Alan Cox, (Mon Apr 14, 3:16 pm)
Re: [PATCH] Replace completions with semaphores, Andi Kleen, (Mon Apr 14, 3:16 pm)
Re: [PATCH] Replace completions with semaphores, Bart Van Assche, (Tue Apr 15, 2:18 am)
Re: [PATCH] Replace completions with semaphores, Peter Zijlstra, (Tue Apr 15, 2:46 am)
Re: [PATCH] Replace completions with semaphores, Bart Van Assche, (Tue Apr 15, 3:17 am)
Re: [PATCH] Replace completions with semaphores, Peter Zijlstra, (Tue Apr 15, 4:44 am)
Re: [PATCH] Replace completions with semaphores, Linus Torvalds, (Tue Apr 15, 12:09 pm)
Re: [PATCH] Replace completions with semaphores, Andi Kleen, (Tue Apr 15, 12:27 pm)
Re: [PATCH] Replace completions with semaphores, Linus Torvalds, (Tue Apr 15, 12:57 pm)
Re: [PATCH] Replace completions with semaphores, Andi Kleen, (Tue Apr 15, 1:15 pm)
Re: [PATCH] Replace completions with semaphores, Linus Torvalds, (Tue Apr 15, 1:26 pm)
Re: [PATCH] Replace completions with semaphores, Matthew Wilcox, (Tue Apr 15, 1:41 pm)
Re: [PATCH] Replace completions with semaphores, Linus Torvalds, (Tue Apr 15, 2:14 pm)
Re: [PATCH] Replace completions with semaphores, Ingo Oeser, (Wed Apr 16, 12:07 pm)
Re: [PATCH] Replace completions with semaphores, Matthew Wilcox, (Wed Apr 16, 12:16 pm)
Re: [PATCH] Replace completions with semaphores, Oliver Neukum, (Wed Apr 16, 12:31 pm)
Re: [PATCH] Replace completions with semaphores, Arjan van de Ven, (Wed Apr 16, 12:50 pm)
Re: [PATCH] Replace completions with semaphores, Matthew Wilcox, (Wed Apr 16, 12:58 pm)
Re: [PATCH] Replace completions with semaphores, Arjan van de Ven, (Wed Apr 16, 1:08 pm)
Re: [PATCH] Replace completions with semaphores, Matthew Wilcox, (Wed Apr 16, 2:10 pm)
Re: [PATCH] Replace completions with semaphores, Matthew Wilcox, (Wed Apr 16, 1:12 pm)
Re: [PATCH] Replace completions with semaphores, Matthew Wilcox, (Wed Apr 16, 12:34 pm)
Re: [PATCH] Replace completions with semaphores, Oliver Neukum, (Wed Apr 16, 12:42 pm)
Re: [PATCH] Replace completions with semaphores, Matthew Wilcox, (Wed Apr 16, 12:44 pm)
Re: [PATCH] Replace completions with semaphores, Roland Dreier, (Wed Apr 16, 12:47 pm)
Re: [PATCH] Replace completions with semaphores, Ingo Molnar, (Tue Apr 15, 1:05 pm)
Re: [PATCH] Replace completions with semaphores, Matthew Wilcox, (Tue Apr 15, 2:50 pm)
Re: [PATCH] Replace completions with semaphores, Ingo Molnar, (Wed Apr 16, 8:37 am)
Re: [PATCH] Replace completions with semaphores, Andi Kleen, (Wed Apr 16, 8:50 am)
Killable stat/readdir, Matthew Wilcox, (Wed Apr 16, 8:59 am)
Re: [PATCH] Replace completions with semaphores, Bart Van Assche, (Tue Apr 15, 9:15 am)
Re: [PATCH] Replace completions with semaphores, Daniel Walker, (Mon Apr 14, 2:09 pm)
Re: [PATCH] Replace completions with semaphores, Arjan van de Ven, (Mon Apr 14, 12:56 pm)
Re: [PATCH] Replace completions with semaphores, Matthew Wilcox, (Mon Apr 14, 1:50 pm)
Re: [PATCH] Replace completions with semaphores, Peter Zijlstra, (Sat Apr 12, 2:05 pm)
Re: [PATCH] Replace completions with semaphores, Matthew Wilcox, (Sat Apr 12, 3:04 pm)
Re: [PATCH] Replace completions with semaphores, Peter Zijlstra, (Sat Apr 12, 3:16 pm)
Re: [PATCH] Replace completions with semaphores, Daniel Walker, (Sat Apr 12, 2:01 pm)
Re: [PATCH] Replace completions with semaphores, Daniel Walker, (Sat Apr 12, 2:43 am)
Re: [PATCH] Replace completions with semaphores, Ingo Oeser, (Sat Apr 12, 6:31 am)
speck-geostationary