Re: [patch] checkpatch: relax spacing and line length

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Al Viro <viro@...>
Cc: Andy Whitcroft <apw@...>, Jan Engelhardt <jengelh@...>, Andrew Morton <akpm@...>, Linux Kernel Mailing List <linux-kernel@...>, SL Baur <steve@...>, Randy Dunlap <rdunlap@...>, Richard Knutsson <ricknu-0@...>, Stefan Richter <stefanr@...>
Date: Tuesday, April 15, 2008 - 5:09 am

On Apr. 13, 2008, 18:18 +0300, Al Viro <viro@ZenIV.linux.org.uk> wrote:

Currently checkpatch.pl prints an error if I use 8 or more spaces in the
indentation string and Documentation/CodingStyle says:

"Outside of comments, documentation and except in Kconfig, spaces are never
used for indentation"

Although CodingStyle and checkpatch just provide guidance and the final
word is the maintainer's I consider these recommendations as "disallowing",
or at least "discouraging". So did others that commented on patches I sent
in the past.  If that wasn't the case I wouldn't have come up with this
silly initiative in the first place.


I'm certainly not advocating to prohibit the current indentation style,
just to relax the rules to allow a superset of it.

Basically, I'd like checkpatch to allow /^\+\t* *\S/
and, since Andy says that checkpatch knows "the indent to some degree",
it can warn if the number of leading tabs is smaller than that.


No, I don't mind.

[Though it is a bit of a pain to keep that when automatic wrapping of long
lines is turned off in my mail program so I can easily quote patches or
code snippets.]

Benny

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch] checkpatch: relax spacing and line length, Jan Engelhardt, (Sun Apr 6, 12:54 am)
Re: [patch] checkpatch: relax spacing and line length, Andy Whitcroft, (Tue Apr 8, 1:12 pm)
Re: [patch] checkpatch: relax spacing and line length, Benny Halevy, (Wed Apr 9, 8:19 am)
Re: [patch] checkpatch: relax spacing and line length, Andy Whitcroft, (Wed Apr 9, 9:25 am)
Re: [patch] checkpatch: relax spacing and line length, Benny Halevy, (Wed Apr 9, 1:02 pm)
Re: [patch] checkpatch: relax spacing and line length, Benny Halevy, (Sun Apr 13, 5:53 am)
Re: [patch] checkpatch: relax spacing and line length, Benny Halevy, (Tue Apr 15, 5:09 am)
Re: [patch] checkpatch: relax spacing and line length, Jan Engelhardt, (Fri Apr 11, 12:24 am)
Re: [patch] checkpatch: relax spacing and line length, Andy Whitcroft, (Wed Apr 9, 4:16 pm)
Re: [patch] checkpatch: relax spacing and line length, Stefan Richter, (Wed Apr 9, 1:27 pm)
Re: [patch] checkpatch: relax spacing and line length, Benny Halevy, (Wed Apr 9, 8:10 am)
Re: [patch] checkpatch: relax spacing and line length, Andy Whitcroft, (Wed Apr 9, 4:19 am)
Re: [patch] checkpatch: relax spacing and line length, Andy Whitcroft, (Wed Apr 9, 4:30 am)
Re: [patch] checkpatch: relax spacing and line length, Andy Whitcroft, (Wed Apr 9, 9:14 am)
Re: [patch] checkpatch: relax spacing and line length, Randy Dunlap, (Wed Apr 9, 11:14 am)
Re: [patch] checkpatch: relax spacing and line length, Jan Engelhardt, (Wed Apr 9, 9:18 am)
Re: [patch] checkpatch: relax spacing and line length, Andy Whitcroft, (Wed Apr 9, 9:58 am)
Re: [patch] checkpatch: relax spacing and line length, Andrew Morton, (Wed Apr 9, 12:53 pm)
Re: [patch] checkpatch: relax spacing and line length, Andy Whitcroft, (Wed Apr 9, 4:07 pm)
Re: [patch] checkpatch: relax spacing and line length, Andy Whitcroft, (Fri Apr 11, 11:54 am)
Re: [patch] checkpatch: relax spacing and line length, Sam Ravnborg, (Sun Apr 6, 7:08 am)
Re: [patch] checkpatch: relax spacing and line length, Benny Halevy, (Mon Apr 7, 12:37 pm)
Re: [patch] checkpatch: relax spacing and line length, Andrew Morton, (Sun Apr 6, 1:18 am)
Re: [patch] checkpatch: relax spacing and line length, Benny Halevy, (Sun Apr 6, 7:52 am)
Re: [patch] checkpatch: relax spacing and line length, Boaz Harrosh, (Mon Apr 7, 5:51 am)