Cc: Andy Whitcroft <apw@...>, Jan Engelhardt <jengelh@...>, Andrew Morton <akpm@...>, Linux Kernel Mailing List <linux-kernel@...>, SL Baur <steve@...>, Randy Dunlap <rdunlap@...>, Richard Knutsson <ricknu-0@...>, Stefan Richter <stefanr@...>
On Apr. 13, 2008, 18:18 +0300, Al Viro <viro@ZenIV.linux.org.uk> wrote:
Currently checkpatch.pl prints an error if I use 8 or more spaces in the
indentation string and Documentation/CodingStyle says:
"Outside of comments, documentation and except in Kconfig, spaces are never
used for indentation"
Although CodingStyle and checkpatch just provide guidance and the final
word is the maintainer's I consider these recommendations as "disallowing",
or at least "discouraging". So did others that commented on patches I sent
in the past. If that wasn't the case I wouldn't have come up with this
silly initiative in the first place.
I'm certainly not advocating to prohibit the current indentation style,
just to relax the rules to allow a superset of it.
Basically, I'd like checkpatch to allow /^\+\t* *\S/
and, since Andy says that checkpatch knows "the indent to some degree",
it can warn if the number of leading tabs is smaller than that.
No, I don't mind.
[Though it is a bit of a pain to keep that when automatic wrapping of long
lines is turned off in my mail program so I can easily quote patches or
code snippets.]
Benny
--
