Re: [RESEND][RFC] BFQ I/O Scheduler

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Jens Axboe <jens.axboe@...>
Cc: <linux-kernel@...>, <paolo.valente@...>
Date: Tuesday, April 15, 2008 - 5:11 am

> From: Jens Axboe <jens.axboe@oracle.com>
...

thank you very much :)



of course the hlist_sched_*() functions are much better than what was
in the patch (the idea behind the patch was to not touch at all cfq code).

the ->bfq_ioprio_changed was there to avoid that a process/ioc doing
i/o on multiple devices managed by cfq and bfq would see ioprio
changes only for one of the two schedulers.

cfq_ioc_set_ioprio() (and its bfq counterpart bfq_ioc_set_ioprio())
unconditionally assign 0 to (bfq_)ioprio_changed, so the first
scheduler that sees the ioprio change eats the new priority values.
of course I may be wrong, but I think it (or some better mechanism
to avoid the problem) is necessary.



of course we'll be glad to help in testing in any way you can find useful.

thank you!
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[RESEND][RFC] BFQ I/O Scheduler, Fabio Checconi, (Tue Apr 1, 11:29 am)
Re: [RESEND][RFC] BFQ I/O Scheduler, Pavel Machek, (Wed Apr 16, 2:44 pm)
Re: [RESEND][RFC] BFQ I/O Scheduler, Paolo Valente, (Thu Apr 17, 2:14 am)
Re: [RESEND][RFC] BFQ I/O Scheduler, Jens Axboe, (Thu Apr 17, 3:10 am)
Re: [RESEND][RFC] BFQ I/O Scheduler, Paolo Valente, (Thu Apr 17, 4:26 am)
Re: [RESEND][RFC] BFQ I/O Scheduler, Aaron Carroll, (Thu Apr 17, 6:24 am)
Re: [RESEND][RFC] BFQ I/O Scheduler, Fabio Checconi, (Thu Apr 17, 7:14 am)
Re: [RESEND][RFC] BFQ I/O Scheduler, Aaron Carroll, (Thu Apr 17, 8:14 am)
Re: [RESEND][RFC] BFQ I/O Scheduler, Paolo Valente, (Thu Apr 17, 11:18 am)
Re: [RESEND][RFC] BFQ I/O Scheduler, Jens Axboe, (Thu Apr 17, 9:54 am)
Re: [RESEND][RFC] BFQ I/O Scheduler, Jens Axboe, (Thu Apr 17, 4:30 am)
Re: [RESEND][RFC] BFQ I/O Scheduler, Avi Kivity, (Thu Apr 17, 11:19 am)
Re: [RESEND][RFC] BFQ I/O Scheduler, Aaron Carroll, (Thu Apr 17, 7:44 pm)
Re: [RESEND][RFC] BFQ I/O Scheduler, Paolo Valente, (Thu Apr 17, 11:47 am)
Re: [RESEND][RFC] BFQ I/O Scheduler, Avi Kivity, (Thu Apr 17, 11:51 am)
Re: [RESEND][RFC] BFQ I/O Scheduler, Paolo Valente, (Thu Apr 17, 2:12 pm)
Re: [RESEND][RFC] BFQ I/O Scheduler, Paolo Valente, (Thu Apr 17, 5:24 am)
Re: [RESEND][RFC] BFQ I/O Scheduler, Jens Axboe, (Thu Apr 17, 5:27 am)
Re: [RESEND][RFC] BFQ I/O Scheduler, Fabio Checconi, (Thu Apr 17, 7:30 am)
Re: [RESEND][RFC] BFQ I/O Scheduler, Aaron Carroll, (Thu Apr 17, 6:19 am)
Re: [RESEND][RFC] BFQ I/O Scheduler, Jens Axboe, (Thu Apr 17, 6:21 am)
Re: [RESEND][RFC] BFQ I/O Scheduler, Pavel Machek, (Thu Apr 17, 4:48 am)
Re: [RESEND][RFC] BFQ I/O Scheduler, Jens Axboe, (Thu Apr 17, 4:57 am)
Re: [RESEND][RFC] BFQ I/O Scheduler, Fabio Checconi, (Thu Apr 17, 5:14 am)
Re: [RESEND][RFC] BFQ I/O Scheduler, Jens Axboe, (Tue Apr 15, 4:22 am)
Re: [RESEND][RFC] BFQ I/O Scheduler, Aaron Carroll, (Thu Apr 17, 9:26 pm)
Re: [RESEND][RFC] BFQ I/O Scheduler, Paolo Valente, (Wed Apr 16, 2:48 am)
Re: [RESEND][RFC] BFQ I/O Scheduler, Fabio Checconi, (Tue Apr 15, 5:11 am)
Re: [RESEND][RFC] BFQ I/O Scheduler, Jens Axboe, (Tue Apr 15, 8:42 am)
Re: [RESEND][RFC] BFQ I/O Scheduler, Fabio Checconi, (Tue Apr 15, 2:08 pm)