[PATCH] smb.h: uses struct timespec but didn't include linux/time.h

Previous thread: Re: [PATCH] netconsole: only set CON_PRINTBUFFER if the user specifies a netconsole by David Miller on Tuesday, April 15, 2008 - 12:49 am. (1 message)

Next thread: mm/page_alloc.c: remove hand-coded get_order() by Pavel Machek on Tuesday, April 15, 2008 - 2:23 am. (5 messages)
From: Ilpo Järvinen
Date: Tuesday, April 15, 2008 - 2:04 am

Signed-off-by: Ilpo J
From: Andrew Morton
Date: Tuesday, April 15, 2008 - 2:10 am

Did this actually cause a compilation error?
--

From: Ilpo Järvinen
Date: Tuesday, April 15, 2008 - 2:20 am

No and yes, none I know of in mainline but with my uninlining tool, if 
that counts :-), it did until I work-around the number of compilation 
failures I got if I just include a single header file to a uninlined.c by 
taking an existing compilation unit's list of headers (and hoping for the 
best), which worked most of time (this case include). ...I'm not sure 
should they all be fixed or not (not to speak of how). Finding most of 
them seems relatively easy to automate by include alone + compile.


-- 
 i.
--

From: Adrian Bunk
Date: Tuesday, April 15, 2008 - 4:25 am

Even if it doesn't at the moment it should be fixed - these kind
of issues are why often adding or removing an #include in a header 
suddenly breaks some configuration on some other architecture.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--

From: Ilpo Järvinen
Date: Tuesday, April 15, 2008 - 4:37 am

...I suppose point of Andrew's enquiry was more about determining how 
soon it should be scheduled for inclusion rather than its usefulness.

-- 
 i.
--

Previous thread: Re: [PATCH] netconsole: only set CON_PRINTBUFFER if the user specifies a netconsole by David Miller on Tuesday, April 15, 2008 - 12:49 am. (1 message)

Next thread: mm/page_alloc.c: remove hand-coded get_order() by Pavel Machek on Tuesday, April 15, 2008 - 2:23 am. (5 messages)