login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
April
»
15
Re: [PATCH 1/3] wm97xx-core: Only schedule interrupt handler if not already scheduled
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Mark Brown <broonie@...>
To: Dmitry Torokhov <dmitry.torokhov@...>
Cc: Andrew Morton <akpm@...>, Jiri Kosina <jkosina@...>, <linux-input@...>, <linux-kernel@...>
Subject:
Re: [PATCH 1/3] wm97xx-core: Only schedule interrupt handler if not already scheduled
Date: Tuesday, April 15, 2008 - 4:48 am
On Mon, Apr 14, 2008 at 02:10:02PM -0400, Dmitry Torokhov wrote:
quoted text
> On Mon, Apr 14, 2008 at 06:39:33PM +0100, Mark Brown wrote:
quoted text
> > + if (!work_pending(&wm->pen_event_work)) { > > + wm->mach_ops->irq_enable(wm, 0); > > + queue_work(wm->ts_workq, &wm->pen_event_work); > > + }
quoted text
> Given the fact that work will not be queued if it is pending anyway > why is this change needed?
As well as not queuing the work it ensures that the calls to irq_enable() are balanced which helps with implementing that operation. --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
WM97xx touchscreen updates
, Mark Brown
, (Mon Apr 14, 1:38 pm)
[PATCH 1/3] wm97xx-core: Only schedule interrupt handler if ...
, Mark Brown
, (Mon Apr 14, 1:39 pm)
Re: [PATCH 1/3] wm97xx-core: Only schedule interrupt handler...
, Dmitry Torokhov
, (Mon Apr 14, 2:10 pm)
Re: [PATCH 1/3] wm97xx-core: Only schedule interrupt handler...
, Mark Brown
, (Tue Apr 15, 4:48 am)
Re: [PATCH 1/3] wm97xx-core: Only schedule interrupt handler...
, Dmitry Torokhov
, (Tue Apr 15, 9:02 am)
Re: [PATCH 1/3] wm97xx-core: Only schedule interrupt handler...
, Mark Brown
, (Tue Apr 15, 10:42 am)
[PATCH 2/3] wm97xx-core: Use IRQF_SAMPLE_RANDOM
, Mark Brown
, (Mon Apr 14, 1:39 pm)
[PATCH 3/3] wm97xx-core: Support use as a wakeup source
, Mark Brown
, (Mon Apr 14, 1:39 pm)
Re: [PATCH 3/3] wm97xx-core: Support use as a wakeup source
, Dmitry Torokhov
, (Mon Apr 14, 4:34 pm)
Re: [PATCH 3/3] wm97xx-core: Support use as a wakeup source
, David Brownell
, (Mon Apr 14, 8:29 pm)
Re: [PATCH 3/3] wm97xx-core: Support use as a wakeup source
, Mark Brown
, (Tue Apr 15, 8:18 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Ingo Molnar
Re: containers (was Re: -mm merge plans for 2.6.23)
Greg Kroah-Hartman
[PATCH 009/196] Chinese: add translation of sparse.txt
holzheu
Re: [RFC/PATCH] Documentation of kernel messages
Vladislav Bolkhovitin
Re: Integration of SCST in the mainstream Linux kernel
git
:
linux-netdev
:
Jarek Poplawski
[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker
[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
David Miller
[GIT]: Networking
Antonio Almeida
HTB accuracy for high speed
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
2 users
and
634 guests
online.
Online users
strcmp
pinnglee1
Syndicate