login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
April
»
14
Re: [PATCH 4/8] rfkill: add read-write rfkill switch support
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Ivo van Doorn <ivdoorn@...>
To: Carlos Corbacho <carlos@...>
Cc: Henrique de Moraes Holschuh <hmh@...>, <linux-kernel@...>, John W. Linville <linville@...>, Dmitry Torokhov <dtor@...>
Subject:
Re: [PATCH 4/8] rfkill: add read-write rfkill switch support
Date: Monday, April 14, 2008 - 5:04 pm
On Monday 14 April 2008, Carlos Corbacho wrote:
quoted text
> On Monday 14 April 2008 13:00:41 Ivo van Doorn wrote: > > > > See rt2x00 and b43 in driver-wireless for an example implementation > > > > of pollable input device and rfkill > > > > > > They're broken by design, at least in b43's case. Someone (Carlos, I > > > believe?) posted an example of a ping-pong scenario using b43. > > > > Thats true. But was that a scenario where there were 2 keys for the same > > radio type? Or was that a matter of the driver indicating a key pressed > > event while it has no attached key to it, and only checked the register for > > the key status and the current radio status and saw it was different? > > Two part problem: > > 1) Bug in rfkill; rfkill is toggling all devices in the same state, and not > actually checking the type. > > (I submitted a patch for this on Sunday, although I sent it to linux-wireless > before you sent the MAINTAINERS patch with netdev as the official list; but I > did CC you on it regardless so you should have seen this. If not, let me know > and I'll resend it).
Completely overlooked the patch. I found it in my archives and just acked it. :) Ivo
quoted text
> 2) The cycle-of-doom bug, as described earlier. > > This still applies. > > Yes, b43 can also be fixed not to emit a keycode if it cannot control the > rfkill switch; but that doesn't solve the case of what happens if both the > wireless driver and the platform driver can control the radio. > > I agree wholeheartedly with Henrique here though - wireless drivers should > _not_ be using key press events as a reporting mechanism. > > -Carlos
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[GIT PATCH] rfkill support for r/w and r/o rfkill switches
, Henrique de Moraes Holschuh...
, (Fri Apr 11, 4:37 pm)
Re: [GIT PATCH] rfkill support for r/w and r/o rfkill switches
, John W. Linville
, (Wed Apr 16, 2:37 pm)
Re: [GIT PATCH] rfkill support for r/w and r/o rfkill switches
, Ivo van Doorn
, (Wed Apr 16, 3:26 pm)
Re: [GIT PATCH] rfkill support for r/w and r/o rfkill switches
, John W. Linville
, (Wed Apr 16, 3:58 pm)
Re: [GIT PATCH] rfkill support for r/w and r/o rfkill switches
, Ivo van Doorn
, (Wed Apr 16, 4:40 pm)
Re: [GIT PATCH] rfkill support for r/w and r/o rfkill switches
, David Miller
, (Wed Apr 16, 9:29 pm)
Re: [GIT PATCH] rfkill support for r/w and r/o rfkill switches
, Ivo van Doorn
, (Sat Apr 12, 6:36 am)
[PATCH 6/8] rfkill: add the WWAN radio type
, Henrique de Moraes Holschuh...
, (Fri Apr 11, 4:37 pm)
Re: [PATCH 6/8] rfkill: add the WWAN radio type
, Ivo van Doorn
, (Sat Apr 12, 6:36 am)
Re: [PATCH 6/8] rfkill: add the WWAN radio type
, Henrique de Moraes Holschuh...
, (Sat Apr 12, 8:15 am)
Re: [PATCH 6/8] rfkill: add the WWAN radio type
, Inaky Perez-Gonzalez
, (Sat Apr 12, 7:23 pm)
Re: [PATCH 6/8] rfkill: add the WWAN radio type
, Henrique de Moraes Holschuh...
, (Sun Apr 13, 1:25 pm)
Re: [PATCH 6/8] rfkill: add the WWAN radio type
, Ivo van Doorn
, (Sun Apr 13, 1:37 pm)
Re: [PATCH 6/8] rfkill: add the WWAN radio type
, Henrique de Moraes Holschuh...
, (Sun Apr 13, 2:16 pm)
Re: [PATCH 6/8] rfkill: add the WWAN radio type
, Dmitry Torokhov
, (Mon Apr 14, 12:20 am)
Re: [PATCH 6/8] rfkill: add the WWAN radio type
, Ivo van Doorn
, (Sat Apr 12, 8:28 am)
Re: [PATCH 6/8] rfkill: add the WWAN radio type
, Inaky Perez-Gonzalez
, (Fri Apr 11, 4:44 pm)
Re: [PATCH 6/8] rfkill: add the WWAN radio type
, Henrique de Moraes Holschuh...
, (Fri Apr 11, 4:53 pm)
[PATCH 8/8] rfkill: add parameter to disable radios by default
, Henrique de Moraes Holschuh...
, (Fri Apr 11, 4:37 pm)
Re: [PATCH 8/8] rfkill: add parameter to disable radios by d...
, Ivo van Doorn
, (Sat Apr 12, 6:36 am)
Re: [PATCH 8/8] rfkill: add parameter to disable radios by d...
, Henrique de Moraes Holschuh...
, (Sat Apr 12, 8:56 am)
Re: [PATCH 8/8] rfkill: add parameter to disable radios by d...
, Ivo van Doorn
, (Sat Apr 12, 9:43 am)
Re: [PATCH 8/8] rfkill: add parameter to disable radios by d...
, Henrique de Moraes Holschuh...
, (Sat Apr 12, 10:43 am)
Re: [PATCH 8/8] rfkill: add parameter to disable radios by d...
, Ivo van Doorn
, (Sat Apr 12, 12:24 pm)
Re: [PATCH 8/8] rfkill: add parameter to disable radios by d...
, Henrique de Moraes Holschuh...
, (Sat Apr 12, 2:36 pm)
Re: [PATCH 8/8] rfkill: add parameter to disable radios by d...
, Ivo van Doorn
, (Sat Apr 12, 3:15 pm)
[PATCH 5/8] rfkill: add read-only rfkill switch support
, Henrique de Moraes Holschuh...
, (Fri Apr 11, 4:37 pm)
[PATCH 7/8] rfkill: add an "any radio" switch type and funct...
, Henrique de Moraes Holschuh...
, (Fri Apr 11, 4:37 pm)
Re: [PATCH 7/8] rfkill: add an "any radio" switch type and f...
, Pavel Machek
, (Sat Apr 12, 3:57 pm)
Re: [PATCH 7/8] rfkill: add an "any radio" switch type and f...
, Henrique de Moraes Holschuh...
, (Sun Apr 13, 1:40 pm)
[PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events
, Henrique de Moraes Holschuh...
, (Fri Apr 11, 4:37 pm)
Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events
, Dmitry Torokhov
, (Sat Apr 12, 11:47 am)
Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events
, Henrique de Moraes Holschuh...
, (Sat Apr 12, 2:02 pm)
Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events
, Ivo van Doorn
, (Sat Apr 12, 2:14 pm)
Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events
, Carlos Corbacho
, (Sat Apr 12, 3:09 pm)
Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events
, Henrique de Moraes Holschuh...
, (Sat Apr 12, 4:36 pm)
Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events
, Ivo van Doorn
, (Sat Apr 12, 6:36 am)
Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events
, Henrique de Moraes Holschuh...
, (Sat Apr 12, 8:05 am)
Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events
, Ivo van Doorn
, (Sat Apr 12, 8:23 am)
Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events
, Henrique de Moraes Holschuh...
, (Sat Apr 12, 9:08 am)
Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events
, Ivo van Doorn
, (Sat Apr 12, 9:17 am)
[PATCH 2/8] rfkill: fix minor typo in kernel doc
, Henrique de Moraes Holschuh...
, (Fri Apr 11, 4:37 pm)
[PATCH 4/8] rfkill: add read-write rfkill switch support
, Henrique de Moraes Holschuh...
, (Fri Apr 11, 4:37 pm)
Re: [PATCH 4/8] rfkill: add read-write rfkill switch support
, Ivo van Doorn
, (Sat Apr 12, 6:36 am)
Re: [PATCH 4/8] rfkill: add read-write rfkill switch support
, Henrique de Moraes Holschuh...
, (Sun Apr 13, 9:20 pm)
Re: [PATCH 4/8] rfkill: add read-write rfkill switch support
, Ivo van Doorn
, (Mon Apr 14, 8:00 am)
Re: [PATCH 4/8] rfkill: add read-write rfkill switch support
, Carlos Corbacho
, (Mon Apr 14, 3:06 pm)
Re: [PATCH 4/8] rfkill: add read-write rfkill switch support
, Ivo van Doorn
, (Mon Apr 14, 5:04 pm)
Re: [PATCH 4/8] rfkill: add read-write rfkill switch support
, Henrique de Moraes Holschuh...
, (Mon Apr 14, 5:46 pm)
Re: [PATCH 4/8] rfkill: add read-write rfkill switch support
, Ivo Van Doorn
, (Tue Apr 15, 4:14 am)
Re: [PATCH 4/8] rfkill: add read-write rfkill switch support
, Dmitry Torokhov
, (Mon Apr 14, 4:23 pm)
Re: [PATCH 4/8] rfkill: add read-write rfkill switch support
, Carlos Corbacho
, (Tue Apr 15, 3:27 am)
Re: [PATCH 4/8] rfkill: add read-write rfkill switch support
, Dmitry Torokhov
, (Tue Apr 15, 8:58 am)
Re: [PATCH 4/8] rfkill: add read-write rfkill switch support
, Dmitry Torokhov
, (Mon Apr 14, 10:16 am)
Re: [PATCH 4/8] rfkill: add read-write rfkill switch support
, Henrique de Moraes Holschuh...
, (Mon Apr 14, 10:36 am)
Re: [PATCH 4/8] rfkill: add read-write rfkill switch support
, Dmitry Torokhov
, (Mon Apr 14, 11:19 am)
Re: [PATCH 4/8] rfkill: add read-write rfkill switch support
, Henrique de Moraes Holschuh...
, (Mon Apr 14, 12:33 pm)
Re: [PATCH 4/8] rfkill: add read-write rfkill switch support
, Dmitry Torokhov
, (Mon Apr 14, 2:05 pm)
Re: [PATCH 4/8] rfkill: add read-write rfkill switch support
, Henrique de Moraes Holschuh...
, (Mon Apr 14, 5:41 pm)
[PATCH 1/8] rfkill: clarify meaning of rfkill states
, Henrique de Moraes Holschuh...
, (Fri Apr 11, 4:37 pm)
Re: [PATCH 1/8] rfkill: clarify meaning of rfkill states
, Dmitry Torokhov
, (Mon Apr 14, 12:22 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Theodore Tso
fallocate-implementation-on-i86-x86_64-and-powerpc.patch (was: re: -mm merge plans...
Tarkan Erimer
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg Kroah-Hartman
[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
Greg KH
Re: [RFC/PATCH] Documentation of kernel messages
linux-netdev
:
Gerrit Renker
[PATCH 03/37] dccp: List management for new feature negotiation
Tom Herbert
[PATCH] Software receive packet steering
Jarek Poplawski
Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Wes Chow
Re: Multicast packet loss
git
:
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
6 users
and
981 guests
online.
Online users
strcmp
zeekec
honeyairtuz
bobjones
ppcloophole
Nelson
Syndicate