Home » Mailing list archives » linux-kernel » 2008 » April » 14

[PATCH] x86_64 vDSO: compile with -g

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Roland McGrath <roland@...>
To: Ingo Molnar <mingo@...>, Thomas Gleixner <tglx@...>
Cc: Andrew Morton <akpm@...>, Linus Torvalds <torvalds@...>, <linux-kernel@...>
Subject: [PATCH] x86_64 vDSO: compile with -g
Date: Monday, April 14, 2008 - 3:19 pm

The 64-bit vDSO's sources are compiled with -g0 for no good reason.
Using -g when enabled lets their separate debug files be used at
runtime via build ID matching, same as we can see 32-bit vDSO's
assembly sources.

Signed-off-by: Roland McGrath <roland@redhat.com>
---
 arch/x86/vdso/Makefile |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/x86/vdso/Makefile b/arch/x86/vdso/Makefile
index 0a8f474..e5745a6 100644
--- a/arch/x86/vdso/Makefile
+++ b/arch/x86/vdso/Makefile
@@ -37,7 +37,8 @@ $(obj)/%.so: OBJCOPYFLAGS := -S
 $(obj)/%.so: $(obj)/%.so.dbg FORCE
 	$(call if_changed,objcopy)
 
-CFL := $(PROFILING) -mcmodel=small -fPIC -g0 -O2 -fasynchronous-unwind-tables -m64
+CFL := $(PROFILING) -mcmodel=small -fPIC -O2 -fasynchronous-unwind-tables -m64 \
+       $(filter -g%,$(KBUILD_CFLAGS))
 
 $(vobjs): KBUILD_CFLAGS = $(CFL)
 
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] x86_64 vDSO: compile with -g, Roland McGrath, (Mon Apr 14, 3:19 pm)
Re: [PATCH] x86_64 vDSO: compile with -g, Ingo Molnar, (Wed Apr 16, 8:59 am)
Re: [PATCH] x86_64 vDSO: compile with -g, Sam Ravnborg, (Mon Apr 14, 4:59 pm)