login
Header Space

 
 

[PATCH 1/3] wm97xx-core: Only schedule interrupt handler if not already scheduled

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andrew Morton <akpm@...>, Dmitry Torokhov <dtor@...>, Jiri Kosina <jkosina@...>
Cc: <linux-input@...>, <linux-kernel@...>, Mark Brown <broonie@...>
Date: Monday, April 14, 2008 - 1:39 pm

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 drivers/input/touchscreen/wm97xx-core.c |   14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/input/touchscreen/wm97xx-core.c b/drivers/input/touchscreen/wm97xx-core.c
index 2910999..e27b1e0 100644
--- a/drivers/input/touchscreen/wm97xx-core.c
+++ b/drivers/input/touchscreen/wm97xx-core.c
@@ -328,18 +328,18 @@ static void wm97xx_pen_irq_worker(struct work_struct *work)
  *
  * We have to disable the codec interrupt in the handler because it
  * can take upto 1ms to clear the interrupt source. We schedule a task
- * in a work queue to do the actual interaction with the chip (it
- * doesn't matter if we end up reenqueing it before it is executed
- * since we don't touch the chip until it has run).  The interrupt is
- * then enabled again in the slow handler when the source has been
- * cleared.
+ * in a work queue to do the actual interaction with the chip.  The
+ * interrupt is then enabled again in the slow handler when the source
+ * has been cleared.
  */
 static irqreturn_t wm97xx_pen_interrupt(int irq, void *dev_id)
 {
 	struct wm97xx *wm = dev_id;
 
-	wm->mach_ops->irq_enable(wm, 0);
-	queue_work(wm->ts_workq, &wm->pen_event_work);
+	if (!work_pending(&wm->pen_event_work)) {
+		wm->mach_ops->irq_enable(wm, 0);
+		queue_work(wm->ts_workq, &wm->pen_event_work);
+	}
 
 	return IRQ_HANDLED;
 }
-- 
1.5.5

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
WM97xx touchscreen updates, Mark Brown, (Mon Apr 14, 1:38 pm)
[PATCH 1/3] wm97xx-core: Only schedule interrupt handler if ..., Mark Brown, (Mon Apr 14, 1:39 pm)
[PATCH 2/3] wm97xx-core: Use IRQF_SAMPLE_RANDOM, Mark Brown, (Mon Apr 14, 1:39 pm)
Re: [PATCH 3/3] wm97xx-core: Support use as a wakeup source, Dmitry Torokhov, (Mon Apr 14, 4:34 pm)
speck-geostationary