login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
April
»
14
Re: [RFC][-mm] [2/2] Simple stats for memory resource controller
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Balbir Singh <balbir@...>
To: Andrew Morton <akpm@...>
Cc: Balaji Rao <balajirrao@...>, <linux-kernel@...>, <containers@...>, <menage@...>, <balbir@...>, <dhaval@...>
Subject:
Re: [RFC][-mm] [2/2] Simple stats for memory resource controller
Date: Monday, April 14, 2008 - 10:40 am
Balbir Singh wrote:
quoted text
> Balaji Rao wrote: >> This patch implements trivial statistics for the memory resource controller. >> >> Signed-off-by: Balaji Rao <balajirrao@gmail.com> >> CC: Balbir Singh <balbir@linux.vnet.ibm.com> >> CC: Dhaval Giani <dhaval@linux.vnet.ibm.com> >> >> diff --git a/mm/memcontrol.c b/mm/memcontrol.c >> index a860765..ca98b21 100644 >> --- a/mm/memcontrol.c >> +++ b/mm/memcontrol.c >> @@ -47,6 +47,8 @@ enum mem_cgroup_stat_index { >> */ >> MEM_CGROUP_STAT_CACHE, /* # of pages charged as cache */ >> MEM_CGROUP_STAT_RSS, /* # of pages charged as rss */ >> + MEM_CGROUP_STAT_PGPGIN_COUNT, /* # of pages paged in */ >> + MEM_CGROUP_STAT_PGPGOUT_COUNT, /* # of pages paged out */ >> >> MEM_CGROUP_STAT_NSTATS, >> }; >> @@ -198,6 +200,13 @@ static void mem_cgroup_charge_statistics(struct mem_cgroup *mem, int flags, >> __mem_cgroup_stat_add_safe(stat, MEM_CGROUP_STAT_CACHE, val); >> else >> __mem_cgroup_stat_add_safe(stat, MEM_CGROUP_STAT_RSS, val); >> + >> + if (charge) >> + __mem_cgroup_stat_add_safe(stat, >> + MEM_CGROUP_STAT_PGPGIN_COUNT, 1); >> + else >> + __mem_cgroup_stat_add_safe(stat, >> + MEM_CGROUP_STAT_PGPGOUT_COUNT, 1); >> } >> >> static struct mem_cgroup_per_zone * >> @@ -897,6 +906,8 @@ static const struct mem_cgroup_stat_desc { >> } mem_cgroup_stat_desc[] = { >> [MEM_CGROUP_STAT_CACHE] = { "cache", PAGE_SIZE, }, >> [MEM_CGROUP_STAT_RSS] = { "rss", PAGE_SIZE, }, >> + [MEM_CGROUP_STAT_PGPGIN_COUNT] = {"pgpgin", 1, }, >> + [MEM_CGROUP_STAT_PGPGOUT_COUNT] = {"pgpgout", 1, }, >> }; >> >> static int mem_control_stat_show(struct cgroup *cont, struct cftype *cft, >> > > Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com> > > Hi, Andrew, > > Could you please include these statistics in -mm. > > Balbir > >
Andrew, This should have been addressed to you in the first place. Resending. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[RFC][-mm] [2/2] Simple stats for memory resource controller
, Balaji Rao
, (Sat Apr 5, 2:10 pm)
Re: [RFC][-mm] [2/2] Simple stats for memory resource contro...
, Balbir Singh
, (Mon Apr 14, 10:39 am)
Re: [RFC][-mm] [2/2] Simple stats for memory resource contro...
, Balaji Rao
, (Mon Apr 28, 12:00 pm)
Re: [RFC][-mm] [2/2] Simple stats for memory resource contro...
, Andrew Morton
, (Mon Apr 28, 12:40 pm)
Re: [RFC][-mm] [2/2] Simple stats for memory resource contro...
, Balbir Singh
, (Mon Apr 28, 2:03 pm)
Re: [RFC][-mm] [2/2] Simple stats for memory resource contro...
, KAMEZAWA Hiroyuki
, (Tue Apr 29, 1:42 am)
Re: [RFC][-mm] [2/2] Simple stats for memory resource contro...
, Balbir Singh
, (Mon Apr 14, 10:40 am)
Re: [RFC][-mm] [2/2] Simple stats for memory resource contro...
, Balbir Singh
, (Sun Apr 6, 2:23 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Hiten Pandya
Re: up? (emacs docbook xml ide)
Bart Van Assche
Integration of SCST in the mainstream Linux kernel
Anton Salikhmetov
[PATCH -v8 0/4] Fixing the issue with memory-mapped file times
Greg Kroah-Hartman
[PATCH 002/196] Chinese: rephrase English introduction in HOWTO
git
:
linux-netdev
:
Gerrit Renker
[PATCH 15/37] dccp: Set per-connection CCIDs via socket options
James Bottomley
Re: [BUG] New Kernel Bugs
Jarek Poplawski
[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller
[GIT]: Networking
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
0 users
and
621 guests
online.
Syndicate