Re: [PATCH 13/33 replaces 14/35 and 15/35] W1: w1_slave_read_id multiple short read bug

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: David Fries <david@...>

Cc: <linux-kernel@...>

Subject: Re: [PATCH 13/33 replaces 14/35 and 15/35] W1: w1_slave_read_id multiple short read bug

Date: Monday, April 14, 2008 - 7:40 am

Hi David.

On Sun, Apr 13, 2008 at 06:15:37PM -0500, David Fries (david@fries.net) wrote:
quoted text> This is more to point out the bug in w1_slave_read_id, the next patch
> rewrites the routine.
> 
> w1.c 1.15
... 
quoted text> w1.c 1.16

That is what I talked about. I agree with your analysis of the problem
and I agree with fixes. But I do not agree with how you created them:
why do we ever neen 1.15 version, since immediately after that we have
1.16 which completely rewrite what was done in previous one?
This applies to the whole patchset: there are essentially several bug
fixes and several features, so separate them into several patches, which
do not collide with each other in the above way.

-- 
	Evgeniy Polyakov
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 0/35] W1: w1 core deadlock and oops fixes, ds2490 upd..., David Fries, (Fri Mar 28, 8:23 am)

Re: [PATCH 0/35] W1: w1 core deadlock and oops fixes, ds2490..., Evgeniy Polyakov, (Sun Mar 30, 7:27 am)

Re: [PATCH 0/35] W1: w1 core deadlock and oops fixes, ds2490..., David Fries, (Sun Apr 13, 6:56 pm)

Re: [PATCH 0/35] W1: w1 core deadlock and oops fixes, ds2490..., Evgeniy Polyakov, (Mon Apr 14, 8:30 am)

[PATCH 32/33 replaces 34/35] Documentation/w1/masters/ds2490..., David Fries, (Sun Apr 13, 7:15 pm)

[PATCH 13/33 replaces 14/35 and 15/35] W1: w1_slave_read_id ..., David Fries, (Sun Apr 13, 7:15 pm)

Re: [PATCH 13/33 replaces 14/35 and 15/35] W1: w1_slave_read..., Evgeniy Polyakov, (Mon Apr 14, 7:40 am)

Re: [PATCH 13/33 replaces 14/35 and 15/35] W1: w1_slave_read..., David Fries, (Mon Apr 14, 6:22 pm)

[PATCH 12/33 replaces 13/35] W1: Document add, remove, searc..., David Fries, (Sun Apr 13, 7:15 pm)

[PATCH 11/33 replaces 12/35] W1: new module parameter search..., David Fries, (Sun Apr 13, 7:15 pm)

[PATCH 9/33 replaces 10/35] W1: be able to manually add and ..., David Fries, (Sun Apr 13, 7:14 pm)

[PATCH 8/33 replaces 8/35 and 9/35] W1: feature, w1_therm.c ..., David Fries, (Sun Apr 13, 7:14 pm)

[PATCH 7/33 replaces 7/35] W1: feature, enable hardware stro..., David Fries, (Sun Apr 13, 7:14 pm)


linux-kernel:
Glauber de Oliveira Costa	[PATCH 08/79] [PATCH] use identify_boot_cpu
David Woodhouse	[PATCH v2] Stop pmac_zilog from abusing 8250's device numbers.
Greg Kroah-Hartman	[PATCH 002/196] Chinese: rephrase English introduction in HOWTO
Jeremy Fitzhardinge	[PATCH 30 of 31] xen: no need for domU to worry about MCE/MCA
git:

openbsd-misc:

linux-netdev:
Gerrit Renker	[PATCH 03/37] dccp: List management for new feature negotiation
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller	[GIT]: Networking
Frans Pop	svc: failed to register lockdv1 RPC service (errno 97).

Re: [PATCH 13/33 replaces 14/35 and 15/35] W1: w1_slave_read_id multiple short read bug

Online users