login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
April
»
14
Re: [PATCH] sound/pci/rme9652/hdspm.c: stop inlining largish static functions
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From:
Takashi Iwai <tiwai@...>
To: Denys Vlasenko <vda.linux@...>
Cc: <linux-kernel@...>
Subject:
Re: [PATCH] sound/pci/rme9652/hdspm.c: stop inlining largish static functions
Date: Monday, April 14, 2008 - 6:28 am
At Tue, 1 Apr 2008 04:36:48 +0200, Denys Vlasenko wrote:
quoted text
> > Hi Takashi, > > Can you please take a look at this patch? > > sound/pci/rme9652/hdspm.c has unusually large number > of static inline functions - 22. > > I looked through them and some of them seem to be too big > to warrant inlining. > > This patch removes "inline" from these static functions > (regardless of number of callsites - gcc nowadays auto-inlines > statics with one callsite). > > Size difference on 32bit x86: > text data bss dec hex filename > 20437 2160 516 23113 5a49 linux-2.6-ALLYES/sound/pci/rme9652/hdspm.o > 18036 2160 516 20712 50e8 linux-2.6.inline-ALLYES/sound/pci/rme9652/hdspm.o > > Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com> > -- > vda
Thanks for the patch. I applied it to ALSA tree together with coding style fixes. Takashi --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[PATCH] sound/pci/rme9652/hdspm.c: stop inlining largish sta...
, Denys Vlasenko
, (Mon Mar 31, 10:36 pm)
Re: [PATCH] sound/pci/rme9652/hdspm.c: stop inlining largish...
, Takashi Iwai
, (Mon Apr 14, 6:28 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Greg KH
[GIT PATCH] driver core patches against 2.6.24
Tarkan Erimer
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Bart Van Assche
Integration of SCST in the mainstream Linux kernel
Jeff Garzik
Re: fallocate-implementation-on-i86-x86_64-and-powerpc.patch
git
:
linux-netdev
:
David Miller
Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Arjan van de Ven
Re: [GIT]: Networking
Gerrit Renker
[PATCH 15/37] dccp: Set per-connection CCIDs via socket options
Natalie Protasevich
[BUG] New Kernel Bugs
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
0 users
and
661 guests
online.
Syndicate