login
Header Space

 
 

Re: [PATCH] ptmx: adding handshake support

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <sander@...>
Cc: <linux-kernel@...>
Date: Sunday, April 13, 2008 - 6:35 pm

> + *  Added support for MCR/MSR, used for serial over ethernet

We've been trying to get rid of these long lists in the code and put them
in the git tree (git whatchanged/git blame show the info rather better)


Not needed

  +    /* first time accessing this device, let's create it */

kzalloc will clear it for you...


Why this last assignment ?


Ok - possibly we shouldn't allow people to set undefined bits but I'm not
sure it matters


Why ??


I am curious how this is handled by other Unix systems and if there is an
ioctl we can follow from other systems ?


Looks basically ok, coding style is wrong, some odd extra assignments but
I agree entirely with the idea of adding this functionality to keep
remote serial drivers in user space.

I'll try and find out if other Unixes have similar features we can use to
keep API consistency tidy it up and fold it at some point in the next
couple of weeks.

Alan
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] ptmx: adding handshake support, sander van ginkel, (Tue Mar 11, 4:28 pm)
Re: [PATCH] ptmx: adding handshake support, Alan Cox, (Sun Mar 30, 8:16 am)
Re: [PATCH] ptmx: adding handshake support, sander van ginkel, (Sun Apr 13, 11:42 am)
Re: [PATCH] ptmx: adding handshake support, Alan Cox, (Sun Apr 13, 6:35 pm)
Re: [PATCH] ptmx: adding handshake support, sander van ginkel, (Mon Apr 14, 4:39 pm)
Re: [PATCH] ptmx: adding handshake support, Alan Cox, (Tue Apr 29, 2:01 pm)
Re: [PATCH] ptmx: adding handshake support, Randy Dunlap, (Mon Apr 14, 4:02 pm)
Re: [PATCH] ptmx: adding handshake support, sander van ginkel, (Sun Mar 30, 8:48 am)
speck-geostationary