[2.6 patch] make mmc_wait_for_app_cmd() static

Previous thread: [2.6 patch] mmc/core/sdio_ops.c should #include "sdio_ops.h" by Adrian Bunk on Sunday, April 13, 2008 - 2:15 pm. (2 messages)

Next thread: [patch 2.6.25-rc9] sound: fix platform driver hotplug/coldplug by David Brownell on Sunday, April 13, 2008 - 2:20 pm. (1 message)
To: <drzeus-mmc@...>
Cc: <linux-kernel@...>
Date: Sunday, April 13, 2008 - 2:15 pm

This patch makes the needlessly global mmc_wait_for_app_cmd() static.

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---

drivers/mmc/core/sd_ops.c | 6 ++----
include/linux/mmc/core.h | 2 --
2 files changed, 2 insertions(+), 6 deletions(-)

91b65cb8cda7a2197ebb5c4e4669933a09547057 diff --git a/drivers/mmc/core/sd_ops.c b/drivers/mmc/core/sd_ops.c
index 0d96080..4831a3d 100644
--- a/drivers/mmc/core/sd_ops.c
+++ b/drivers/mmc/core/sd_ops.c
@@ -62,8 +62,8 @@ static int mmc_app_cmd(struct mmc_host *host, struct mmc_card *card)
* that occurred while the command was executing. Do not attempt to
* parse the response.
*/
-int mmc_wait_for_app_cmd(struct mmc_host *host, struct mmc_card *card,
- struct mmc_command *cmd, int retries)
+static int mmc_wait_for_app_cmd(struct mmc_host *host, struct mmc_card *card,
+ struct mmc_command *cmd, int retries)
{
struct mmc_request mrq;

@@ -115,8 +115,6 @@ int mmc_wait_for_app_cmd(struct mmc_host *host, struct mmc_card *card,
return err;
}

-EXPORT_SYMBOL(mmc_wait_for_app_cmd);
-
int mmc_app_set_bus_width(struct mmc_card *card, int width)
{
int err;
diff --git a/include/linux/mmc/core.h b/include/linux/mmc/core.h
index d0c3abe..c8d9a60 100644
--- a/include/linux/mmc/core.h
+++ b/include/linux/mmc/core.h
@@ -131,8 +131,6 @@ struct mmc_card;

extern void mmc_wait_for_req(struct mmc_host *, struct mmc_request *);
extern int mmc_wait_for_cmd(struct mmc_host *, struct mmc_command *, int);
-extern int mmc_wait_for_app_cmd(struct mmc_host *, struct mmc_card *,
- struct mmc_command *, int);

extern void mmc_set_data_timeout(struct mmc_data *, const struct mmc_card *);

--

To: Adrian Bunk <bunk@...>
Cc: <linux-kernel@...>
Date: Wednesday, April 16, 2008 - 1:36 pm

On Sun, 13 Apr 2008 21:15:55 +0300

Now this one I'm going to have to NAK. We've discussed this one before
and I want to keep it around as part of the API so people don't go
doing silly reimplementations. The embedded crowd tends to work a bit
too much outside mainline, so I want to at least try to nudge them in
directions that keeps their code mergeable.

Rgds
--
-- Pierre Ossman

Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org
--

To: Pierre Ossman <drzeus-mmc@...>
Cc: <linux-kernel@...>
Date: Wednesday, April 16, 2008 - 2:01 pm

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

--

Previous thread: [2.6 patch] mmc/core/sdio_ops.c should #include "sdio_ops.h" by Adrian Bunk on Sunday, April 13, 2008 - 2:15 pm. (2 messages)

Next thread: [patch 2.6.25-rc9] sound: fix platform driver hotplug/coldplug by David Brownell on Sunday, April 13, 2008 - 2:20 pm. (1 message)