Home » Mailing list archives » linux-kernel » 2008 » April » 13

Re: [patch] checkpatch: relax spacing and line length

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Al Viro <viro@...>
To: Benny Halevy <bhalevy@...>
Cc: Andy Whitcroft <apw@...>, Jan Engelhardt <jengelh@...>, Andrew Morton <akpm@...>, Linux Kernel Mailing List <linux-kernel@...>, SL Baur <steve@...>, Randy Dunlap <rdunlap@...>, Richard Knutsson <ricknu-0@...>, Stefan Richter <stefanr@...>
Subject: Re: [patch] checkpatch: relax spacing and line length
Date: Sunday, April 13, 2008 - 11:18 am

On Sun, Apr 13, 2008 at 12:53:48PM +0300, Benny Halevy wrote:


Nice turn of a phrase, that.


Oh, for the...


"Allow" is such a nice word, isn't it?  Let's take a closer look:
	* nobody prohibits lines satisfying your constraints ("tabs only for
indent level"), so "allowing" that is meaningless
	* "indentation style" in the above refers to editor settings.
To "allow" that, you advocate prohibiting the lines _NOT_ satisfying your
constraints.  Which, by definition, means extra work for people submitting
patches, no matter how you spin it.

BTW, while we are talking about conventions, would you mind keeping lines
in your mail shorter than 79 columns to avoid wraparounds in quoted text?
Unlike your proposal, that one actually _is_ a common convention...
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch] checkpatch: relax spacing and line length, Jan Engelhardt, (Sun Apr 6, 12:54 am)
Re: [patch] checkpatch: relax spacing and line length, Andy Whitcroft, (Tue Apr 8, 1:12 pm)
Re: [patch] checkpatch: relax spacing and line length, Benny Halevy, (Wed Apr 9, 8:19 am)
Re: [patch] checkpatch: relax spacing and line length, Andy Whitcroft, (Wed Apr 9, 9:25 am)
Re: [patch] checkpatch: relax spacing and line length, Benny Halevy, (Wed Apr 9, 1:02 pm)
Re: [patch] checkpatch: relax spacing and line length, Al Viro, (Fri Apr 11, 8:26 pm)
Re: [patch] checkpatch: relax spacing and line length, Benny Halevy, (Sun Apr 13, 5:53 am)
Re: [patch] checkpatch: relax spacing and line length, Al Viro, (Sun Apr 13, 11:18 am)
Re: [patch] checkpatch: relax spacing and line length, Benny Halevy, (Tue Apr 15, 5:09 am)
Re: [patch] checkpatch: relax spacing and line length, SL Baur, (Thu Apr 10, 7:52 pm)
Re: [patch] checkpatch: relax spacing and line length, Jan Engelhardt, (Fri Apr 11, 12:24 am)
Re: [patch] checkpatch: relax spacing and line length, Andy Whitcroft, (Wed Apr 9, 4:16 pm)
Re: [patch] checkpatch: relax spacing and line length, Stefan Richter, (Wed Apr 9, 1:27 pm)
Re: [patch] checkpatch: relax spacing and line length, Benny Halevy, (Wed Apr 9, 8:10 am)
Re: [patch] checkpatch: relax spacing and line length, Andi Kleen, (Tue Apr 8, 2:01 pm)
Re: [patch] checkpatch: relax spacing and line length, Andy Whitcroft, (Wed Apr 9, 4:19 am)
Re: [patch] checkpatch: relax spacing and line length, Andy Whitcroft, (Wed Apr 9, 4:30 am)
Re: [patch] checkpatch: relax spacing and line length, Andi Kleen, (Wed Apr 9, 4:46 am)
Re: [patch] checkpatch: relax spacing and line length, Andy Whitcroft, (Wed Apr 9, 9:14 am)
Re: [patch] checkpatch: relax spacing and line length, Randy Dunlap, (Wed Apr 9, 11:14 am)
Re: [patch] checkpatch: relax spacing and line length, Jan Engelhardt, (Wed Apr 9, 9:18 am)
Re: [patch] checkpatch: relax spacing and line length, Andy Whitcroft, (Wed Apr 9, 9:58 am)
Re: [patch] checkpatch: relax spacing and line length, Andrew Morton, (Wed Apr 9, 12:53 pm)
Re: [patch] checkpatch: relax spacing and line length, Andy Whitcroft, (Wed Apr 9, 4:07 pm)
Re: [patch] checkpatch: relax spacing and line length, Andy Whitcroft, (Fri Apr 11, 11:54 am)
Re: [patch] checkpatch: relax spacing and line length, Andi Kleen, (Wed Apr 9, 1:43 pm)
Re: [patch] checkpatch: relax spacing and line length, Adrian Bunk, (Sun Apr 6, 6:08 am)
Re: [patch] checkpatch: relax spacing and line length, Sam Ravnborg, (Sun Apr 6, 7:08 am)
Re: [patch] checkpatch: relax spacing and line length, Benny Halevy, (Mon Apr 7, 12:37 pm)
Re: [patch] checkpatch: relax spacing and line length, Andrew Morton, (Sun Apr 6, 1:18 am)
Re: [patch] checkpatch: relax spacing and line length, Benny Halevy, (Sun Apr 6, 7:52 am)
Re: [patch] checkpatch: relax spacing and line length, Joe Perches, (Sun Apr 6, 2:52 pm)
Re: [patch] checkpatch: relax spacing and line length, Boaz Harrosh, (Mon Apr 7, 5:51 am)