login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
April
»
13
Re: [PATCH 2/7] omfs: add inode routines
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From:
Christoph Hellwig <hch@...>
To: Bob Copeland <me@...>
Cc: <linux-kernel@...>, <linux-fsdevel@...>, <akpm@...>
Subject:
Re: [PATCH 2/7] omfs: add inode routines
Date: Sunday, April 13, 2008 - 4:05 am
Looks good. Minor nitpick:
quoted text
> +static void omfs_put_super(struct super_block *sb) > +{ > + struct omfs_sb_info *sbi = OMFS_SB(sb); > + if (sbi) {
This if check is no needed, as your fill_super method never returns success without setting it up. --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[PATCH 2/7] omfs: add inode routines
, Bob Copeland
, (Sat Apr 12, 6:58 pm)
Re: [PATCH 2/7] omfs: add inode routines
, Marcin Slusarz
, (Tue Apr 15, 2:30 pm)
Re: [PATCH 2/7] omfs: add inode routines
, Bob Copeland
, (Tue Apr 15, 7:56 pm)
Re: [PATCH 2/7] omfs: add inode routines
, Marcin Slusarz
, (Wed Apr 16, 2:31 pm)
Re: [PATCH 2/7] omfs: add inode routines
, Miklos Szeredi
, (Tue Apr 15, 2:03 pm)
Re: [PATCH 2/7] omfs: add inode routines
, Bob Copeland
, (Tue Apr 15, 2:33 pm)
Re: [PATCH 2/7] omfs: add inode routines
, Alan Cox
, (Sun Apr 13, 5:17 am)
Re: [PATCH 2/7] omfs: add inode routines
, Christoph Hellwig
, (Sun Apr 13, 4:05 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Andrew Morton
-mm merge plans for 2.6.23
Greg Kroah-Hartman
[PATCH 025/196] paride: Convert from class_device to device for block/paride
Renato S. Yamane
Error -71 on device descriptor read/all
Bart Van Assche
Integration of SCST in the mainstream Linux kernel
git
:
linux-netdev
:
David Miller
Re: [GIT]: Networking
Gerrit Renker
[PATCH 31/37] dccp: Remove manual influence on NDP Count feature
Frans Pop
svc: failed to register lockdv1 RPC service (errno 97).
David Miller
Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
3 users
and
880 guests
online.
Online users
cindy1234
zeekec
lwdumeno
Syndicate