Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Ivo van Doorn <ivdoorn@...>

To: Henrique de Moraes Holschuh <hmh@...>

Cc: <linux-kernel@...>, John W. Linville <linville@...>, Dmitry Torokhov <dtor@...>

Subject: Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events

Date: Saturday, April 12, 2008 - 9:17 am

On Saturday 12 April 2008, Henrique de Moraes Holschuh wrote:
quoted text> On Sat, 12 Apr 2008, Ivo van Doorn wrote:
> > On Saturday 12 April 2008, Henrique de Moraes Holschuh wrote:
> > > On Sat, 12 Apr 2008, Ivo van Doorn wrote:
> > > > On Friday 11 April 2008, Henrique de Moraes Holschuh wrote:
> > > > > The *_RADIO input events are related to all radios in a system.  There are
> > > > > two: KEY_RADIO and SW_RADIO.
> > > > > 
> > > > > Teach rfkill-input how to handle them.  In particular, SW_RADIO is not a
> > > > > toggle, but an absolute enable-or-disable command.
> > > > 
> > > > Not sure what you are trying to achieve here,
> > > > who triggers the SW_RADIO and why?
> > > 
> > > Thinkpad-acpi issues EV_SW SW_RADIO when the user changes a phisical
> > > switch in the unit.  It is a switch, not a button: it has an ON
> > > position, and an OFF position.
> > 
> > Ok, and such a switch is always intended to control all radios?
> > (in other words, it is the expected behavior it controls everything)
> 
> In every device I have seen which had a non-type-specific radio switch?
> Yes.
> 
> If we need type-specific switches (and NOT buttons/hot keys) for, e.g.,
> Bluetooth, the correct thing to do is to add EV_SW SW_BLUETOOTH.  The
> same goes for WWAN, UWB, etc.  But on laptops (which are the devices I
> am dealing with), these switches (when they exist) are meant to block
> *every* builtin radio and thus are not type-specific.
> 
> I can easily see someone designing a gadget with type-specific switches,
> but since nobody asked for such support yet, we don't have anything but
> SW_RADIO defined in the input layer right now.
> 
> So EV_SW SW_RADIO has "every radio" semanthics, just like KEY_RADIO.

Ok, thanks for the explanation.
You can add this patch to my ACK list then. :)

Ivo

--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[GIT PATCH] rfkill support for r/w and r/o rfkill switches, Henrique de Moraes Holschuh..., (Fri Apr 11, 4:37 pm)

Re: [GIT PATCH] rfkill support for r/w and r/o rfkill switches, John W. Linville, (Wed Apr 16, 2:37 pm)

Re: [GIT PATCH] rfkill support for r/w and r/o rfkill switches, Ivo van Doorn, (Wed Apr 16, 3:26 pm)

Re: [GIT PATCH] rfkill support for r/w and r/o rfkill switches, John W. Linville, (Wed Apr 16, 3:58 pm)

Re: [GIT PATCH] rfkill support for r/w and r/o rfkill switches, Ivo van Doorn, (Wed Apr 16, 4:40 pm)

Re: [GIT PATCH] rfkill support for r/w and r/o rfkill switches, David Miller, (Wed Apr 16, 9:29 pm)

Re: [GIT PATCH] rfkill support for r/w and r/o rfkill switches, Ivo van Doorn, (Sat Apr 12, 6:36 am)

[PATCH 6/8] rfkill: add the WWAN radio type, Henrique de Moraes Holschuh..., (Fri Apr 11, 4:37 pm)

Re: [PATCH 6/8] rfkill: add the WWAN radio type, Ivo van Doorn, (Sat Apr 12, 6:36 am)

Re: [PATCH 6/8] rfkill: add the WWAN radio type, Henrique de Moraes Holschuh..., (Sat Apr 12, 8:15 am)

Re: [PATCH 6/8] rfkill: add the WWAN radio type, Inaky Perez-Gonzalez, (Sat Apr 12, 7:23 pm)

Re: [PATCH 6/8] rfkill: add the WWAN radio type, Henrique de Moraes Holschuh..., (Sun Apr 13, 1:25 pm)

Re: [PATCH 6/8] rfkill: add the WWAN radio type, Ivo van Doorn, (Sun Apr 13, 1:37 pm)

Re: [PATCH 6/8] rfkill: add the WWAN radio type, Henrique de Moraes Holschuh..., (Sun Apr 13, 2:16 pm)

Re: [PATCH 6/8] rfkill: add the WWAN radio type, Dmitry Torokhov, (Mon Apr 14, 12:20 am)

Re: [PATCH 6/8] rfkill: add the WWAN radio type, Ivo van Doorn, (Sat Apr 12, 8:28 am)

Re: [PATCH 6/8] rfkill: add the WWAN radio type, Inaky Perez-Gonzalez, (Fri Apr 11, 4:44 pm)

Re: [PATCH 6/8] rfkill: add the WWAN radio type, Henrique de Moraes Holschuh..., (Fri Apr 11, 4:53 pm)

[PATCH 8/8] rfkill: add parameter to disable radios by default, Henrique de Moraes Holschuh..., (Fri Apr 11, 4:37 pm)

Re: [PATCH 8/8] rfkill: add parameter to disable radios by d..., Ivo van Doorn, (Sat Apr 12, 6:36 am)

Re: [PATCH 8/8] rfkill: add parameter to disable radios by d..., Henrique de Moraes Holschuh..., (Sat Apr 12, 8:56 am)

Re: [PATCH 8/8] rfkill: add parameter to disable radios by d..., Ivo van Doorn, (Sat Apr 12, 9:43 am)

Re: [PATCH 8/8] rfkill: add parameter to disable radios by d..., Henrique de Moraes Holschuh..., (Sat Apr 12, 10:43 am)

Re: [PATCH 8/8] rfkill: add parameter to disable radios by d..., Ivo van Doorn, (Sat Apr 12, 12:24 pm)

Re: [PATCH 8/8] rfkill: add parameter to disable radios by d..., Henrique de Moraes Holschuh..., (Sat Apr 12, 2:36 pm)

Re: [PATCH 8/8] rfkill: add parameter to disable radios by d..., Ivo van Doorn, (Sat Apr 12, 3:15 pm)

[PATCH 5/8] rfkill: add read-only rfkill switch support, Henrique de Moraes Holschuh..., (Fri Apr 11, 4:37 pm)

[PATCH 7/8] rfkill: add an "any radio" switch type and funct..., Henrique de Moraes Holschuh..., (Fri Apr 11, 4:37 pm)

Re: [PATCH 7/8] rfkill: add an "any radio" switch type and f..., Pavel Machek, (Sat Apr 12, 3:57 pm)

Re: [PATCH 7/8] rfkill: add an "any radio" switch type and f..., Henrique de Moraes Holschuh..., (Sun Apr 13, 1:40 pm)

[PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events, Henrique de Moraes Holschuh..., (Fri Apr 11, 4:37 pm)

Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events, Dmitry Torokhov, (Sat Apr 12, 11:47 am)

Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events, Henrique de Moraes Holschuh..., (Sat Apr 12, 2:02 pm)

Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events, Ivo van Doorn, (Sat Apr 12, 2:14 pm)

Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events, Carlos Corbacho, (Sat Apr 12, 3:09 pm)

Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events, Henrique de Moraes Holschuh..., (Sat Apr 12, 4:36 pm)

Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events, Ivo van Doorn, (Sat Apr 12, 6:36 am)

Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events, Henrique de Moraes Holschuh..., (Sat Apr 12, 8:05 am)

Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events, Ivo van Doorn, (Sat Apr 12, 8:23 am)

Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events, Henrique de Moraes Holschuh..., (Sat Apr 12, 9:08 am)

Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events, Ivo van Doorn, (Sat Apr 12, 9:17 am)

[PATCH 2/8] rfkill: fix minor typo in kernel doc, Henrique de Moraes Holschuh..., (Fri Apr 11, 4:37 pm)

[PATCH 4/8] rfkill: add read-write rfkill switch support, Henrique de Moraes Holschuh..., (Fri Apr 11, 4:37 pm)

Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Ivo van Doorn, (Sat Apr 12, 6:36 am)

Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Henrique de Moraes Holschuh..., (Sun Apr 13, 9:20 pm)

Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Ivo van Doorn, (Mon Apr 14, 8:00 am)

Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Carlos Corbacho, (Mon Apr 14, 3:06 pm)

Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Ivo van Doorn, (Mon Apr 14, 5:04 pm)

Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Henrique de Moraes Holschuh..., (Mon Apr 14, 5:46 pm)

Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Ivo Van Doorn, (Tue Apr 15, 4:14 am)

Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Dmitry Torokhov, (Mon Apr 14, 4:23 pm)

Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Carlos Corbacho, (Tue Apr 15, 3:27 am)

Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Dmitry Torokhov, (Tue Apr 15, 8:58 am)

Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Dmitry Torokhov, (Mon Apr 14, 10:16 am)

Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Henrique de Moraes Holschuh..., (Mon Apr 14, 10:36 am)

Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Dmitry Torokhov, (Mon Apr 14, 11:19 am)

Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Henrique de Moraes Holschuh..., (Mon Apr 14, 12:33 pm)

Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Dmitry Torokhov, (Mon Apr 14, 2:05 pm)

Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Henrique de Moraes Holschuh..., (Mon Apr 14, 5:41 pm)

[PATCH 1/8] rfkill: clarify meaning of rfkill states, Henrique de Moraes Holschuh..., (Fri Apr 11, 4:37 pm)

Re: [PATCH 1/8] rfkill: clarify meaning of rfkill states, Dmitry Torokhov, (Mon Apr 14, 12:22 am)

Navigation

Popular discussions


linux-kernel:
Linus Torvalds	Linux 2.6.21-rc4
Greg Kroah-Hartman	[PATCH 008/196] Chinese: add translation of volatile-considered-harmful.txt
Andrew Morton	-mm merge plans for 2.6.23
Stephane Eranian	Re: [PATCH] fix up perfmon to build on -mm
git:

linux-netdev:
David Miller	[GIT]: Networking
David Miller	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Natalie Protasevich	[BUG] New Kernel Bugs
linux-fsdevel:
Linus Torvalds	Re: silent semantic changes with reiser4
jim owens	Re: ext4 - getting at birth time (file create time) and getting/setting nanosecond...
Alan Cox	Re: impact of 4k sector size on the IO & FS stack
Peter Zijlstra	Re: + mm-balance_dirty_pages-reduce-calls-to-global_page_state-to-reduce-c ache-re...

Colocation donated by:

Online users

Syndicate