Re: [GIT PATCH] rfkill support for r/w and r/o rfkill switches

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Ivo van Doorn <ivdoorn@...>

To: Henrique de Moraes Holschuh <hmh@...>

Cc: <linux-kernel@...>

Subject: Re: [GIT PATCH] rfkill support for r/w and r/o rfkill switches

Date: Saturday, April 12, 2008 - 6:36 am

Hi,

quoted text> This patch series (based on v2.6.25-rc8-mm2) has several improvements to
> the rfkill class that I need for thinkpad-acpi, plus two fluff and
> documentation fixes.
> 
> I'd appreciate comments, and if the patches are acceptable, that they are
> sent to mainline early during the 2.6.26 merge window.  That way, I could
> try for a thinkpad-acpi rfkill submission for 2.6.26 as well.
> 
> The thinkpad-acpi work that needs these patches is ready, and can be
> looked at on the thinkpad-acpi git tree (devel branch):
> http://repo.or.cz/w/linux-2.6/linux-acpi-2.6/ibm-acpi-2.6.git
> 
> Note: new thinkpads have a read-only "type any" radio switch, plus
> read-write WWAN and Bluetooth radio switches.   The embedded WLAN cards
> have WLAN read-write switches (that should be handled by the ipw* and iwl*
> drivers).  Very old thinkpads had ACPI-based WLAN radio switches, but
> thinkpad-acpi does not support those.

The following patches are fine by me, without any additional comments:
[PATCH 1/8] rfkill: clarify meaning of rfkill states
[PATCH 2/8] rfkill: fix minor typo in kernel doc
[PATCH 5/8] rfkill: add read-only rfkill switch support
[PATCH 7/8] rfkill: add an "any radio" switch type and functionality

The following patches are overall fine, but I have some additional comments:
[PATCH 6/8] rfkill: add the WWAN radio type
[PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events

The following patches are _not_ fine with me:
[PATCH 4/8] rfkill: add read-write rfkill switch support
[PATCH 8/8] rfkill: add parameter to disable radios by default

Ivo
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[GIT PATCH] rfkill support for r/w and r/o rfkill switches, Henrique de Moraes Holschuh..., (Fri Apr 11, 4:37 pm)

Re: [GIT PATCH] rfkill support for r/w and r/o rfkill switches, John W. Linville, (Wed Apr 16, 2:37 pm)

Re: [GIT PATCH] rfkill support for r/w and r/o rfkill switches, Ivo van Doorn, (Wed Apr 16, 3:26 pm)

Re: [GIT PATCH] rfkill support for r/w and r/o rfkill switches, John W. Linville, (Wed Apr 16, 3:58 pm)

Re: [GIT PATCH] rfkill support for r/w and r/o rfkill switches, Ivo van Doorn, (Wed Apr 16, 4:40 pm)

Re: [GIT PATCH] rfkill support for r/w and r/o rfkill switches, David Miller, (Wed Apr 16, 9:29 pm)

Re: [GIT PATCH] rfkill support for r/w and r/o rfkill switches, Ivo van Doorn, (Sat Apr 12, 6:36 am)

[PATCH 6/8] rfkill: add the WWAN radio type, Henrique de Moraes Holschuh..., (Fri Apr 11, 4:37 pm)

Re: [PATCH 6/8] rfkill: add the WWAN radio type, Ivo van Doorn, (Sat Apr 12, 6:36 am)

Re: [PATCH 6/8] rfkill: add the WWAN radio type, Henrique de Moraes Holschuh..., (Sat Apr 12, 8:15 am)

Re: [PATCH 6/8] rfkill: add the WWAN radio type, Inaky Perez-Gonzalez, (Sat Apr 12, 7:23 pm)

Re: [PATCH 6/8] rfkill: add the WWAN radio type, Henrique de Moraes Holschuh..., (Sun Apr 13, 1:25 pm)

Re: [PATCH 6/8] rfkill: add the WWAN radio type, Ivo van Doorn, (Sun Apr 13, 1:37 pm)

Re: [PATCH 6/8] rfkill: add the WWAN radio type, Henrique de Moraes Holschuh..., (Sun Apr 13, 2:16 pm)

Re: [PATCH 6/8] rfkill: add the WWAN radio type, Dmitry Torokhov, (Mon Apr 14, 12:20 am)

Re: [PATCH 6/8] rfkill: add the WWAN radio type, Ivo van Doorn, (Sat Apr 12, 8:28 am)

Re: [PATCH 6/8] rfkill: add the WWAN radio type, Inaky Perez-Gonzalez, (Fri Apr 11, 4:44 pm)

Re: [PATCH 6/8] rfkill: add the WWAN radio type, Henrique de Moraes Holschuh..., (Fri Apr 11, 4:53 pm)

[PATCH 8/8] rfkill: add parameter to disable radios by default, Henrique de Moraes Holschuh..., (Fri Apr 11, 4:37 pm)

Re: [PATCH 8/8] rfkill: add parameter to disable radios by d..., Ivo van Doorn, (Sat Apr 12, 6:36 am)

Re: [PATCH 8/8] rfkill: add parameter to disable radios by d..., Henrique de Moraes Holschuh..., (Sat Apr 12, 8:56 am)

Re: [PATCH 8/8] rfkill: add parameter to disable radios by d..., Ivo van Doorn, (Sat Apr 12, 9:43 am)

Re: [PATCH 8/8] rfkill: add parameter to disable radios by d..., Henrique de Moraes Holschuh..., (Sat Apr 12, 10:43 am)

Re: [PATCH 8/8] rfkill: add parameter to disable radios by d..., Ivo van Doorn, (Sat Apr 12, 12:24 pm)

Re: [PATCH 8/8] rfkill: add parameter to disable radios by d..., Henrique de Moraes Holschuh..., (Sat Apr 12, 2:36 pm)

Re: [PATCH 8/8] rfkill: add parameter to disable radios by d..., Ivo van Doorn, (Sat Apr 12, 3:15 pm)

[PATCH 5/8] rfkill: add read-only rfkill switch support, Henrique de Moraes Holschuh..., (Fri Apr 11, 4:37 pm)

[PATCH 7/8] rfkill: add an "any radio" switch type and funct..., Henrique de Moraes Holschuh..., (Fri Apr 11, 4:37 pm)

Re: [PATCH 7/8] rfkill: add an "any radio" switch type and f..., Pavel Machek, (Sat Apr 12, 3:57 pm)

Re: [PATCH 7/8] rfkill: add an "any radio" switch type and f..., Henrique de Moraes Holschuh..., (Sun Apr 13, 1:40 pm)

[PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events, Henrique de Moraes Holschuh..., (Fri Apr 11, 4:37 pm)

Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events, Dmitry Torokhov, (Sat Apr 12, 11:47 am)

Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events, Henrique de Moraes Holschuh..., (Sat Apr 12, 2:02 pm)

Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events, Ivo van Doorn, (Sat Apr 12, 2:14 pm)

Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events, Carlos Corbacho, (Sat Apr 12, 3:09 pm)

Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events, Henrique de Moraes Holschuh..., (Sat Apr 12, 4:36 pm)

Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events, Ivo van Doorn, (Sat Apr 12, 6:36 am)

Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events, Henrique de Moraes Holschuh..., (Sat Apr 12, 8:05 am)

Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events, Ivo van Doorn, (Sat Apr 12, 8:23 am)

Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events, Henrique de Moraes Holschuh..., (Sat Apr 12, 9:08 am)

Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events, Ivo van Doorn, (Sat Apr 12, 9:17 am)

[PATCH 2/8] rfkill: fix minor typo in kernel doc, Henrique de Moraes Holschuh..., (Fri Apr 11, 4:37 pm)

[PATCH 4/8] rfkill: add read-write rfkill switch support, Henrique de Moraes Holschuh..., (Fri Apr 11, 4:37 pm)

Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Ivo van Doorn, (Sat Apr 12, 6:36 am)

Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Henrique de Moraes Holschuh..., (Sun Apr 13, 9:20 pm)

Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Ivo van Doorn, (Mon Apr 14, 8:00 am)

Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Carlos Corbacho, (Mon Apr 14, 3:06 pm)

Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Ivo van Doorn, (Mon Apr 14, 5:04 pm)

Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Henrique de Moraes Holschuh..., (Mon Apr 14, 5:46 pm)

Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Ivo Van Doorn, (Tue Apr 15, 4:14 am)

Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Dmitry Torokhov, (Mon Apr 14, 4:23 pm)

Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Carlos Corbacho, (Tue Apr 15, 3:27 am)

Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Dmitry Torokhov, (Tue Apr 15, 8:58 am)

Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Dmitry Torokhov, (Mon Apr 14, 10:16 am)

Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Henrique de Moraes Holschuh..., (Mon Apr 14, 10:36 am)

Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Dmitry Torokhov, (Mon Apr 14, 11:19 am)

Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Henrique de Moraes Holschuh..., (Mon Apr 14, 12:33 pm)

Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Dmitry Torokhov, (Mon Apr 14, 2:05 pm)

Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Henrique de Moraes Holschuh..., (Mon Apr 14, 5:41 pm)

[PATCH 1/8] rfkill: clarify meaning of rfkill states, Henrique de Moraes Holschuh..., (Fri Apr 11, 4:37 pm)

Re: [PATCH 1/8] rfkill: clarify meaning of rfkill states, Dmitry Torokhov, (Mon Apr 14, 12:22 am)

Navigation

Popular discussions


linux-kernel:
Parag Warudkar	BUG: soft lockup - CPU#1 stuck for 15s! [swapper:0]
Tarkan Erimer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Bart Van Assche	Integration of SCST in the mainstream Linux kernel
Greg Kroah-Hartman	[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
git:

linux-netdev:
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
David Miller	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Arjan van de Ven	Re: [GIT]: Networking
David Miller	Re: [BUG] New Kernel Bugs
openbsd-misc:

Colocation donated by:

Online users

Syndicate