Yes, that sounds fine too. Although you need to add a
depends on PCI
to the E1000 thing (because the "select" would not honor the dependencies
that E1000E and E1000_PCI have).
However:
I agree we could, but as I tried to explain, I fundamentally don't think
we _should_.
Why should people _ever_ be asked about whether they want "E1000 PCI
support" vs "E1000 PCI-E" support, when it's almost impossible to tell
which kind of card you have?
In other words, I suspect that anybody who selects E1000 support would
actually want the "support both" case, and simply not care. Unless they
were _really_ deeply aware of their hardware.
.. but that said, I think your patch is certainly better than what we have
now (or what Ingo was complaining about for the next merge window). I
certainly could live with it. I would just suggest against ever then
removing that "generic E1000" choice.
Linus
--