On Fri, 11 Apr 2008, Daniel Barkalow wrote:Yes, that sounds fine too. Although you need to add a depends on PCI to the E1000 thing (because the "select" would not honor the dependencies that E1000E and E1000_PCI have). However: I agree we could, but as I tried to explain, I fundamentally don't think we _should_. Why should people _ever_ be asked about whether they want "E1000 PCI support" vs "E1000 PCI-E" support, when it's almost impossible to tell which kind of card you have? In other words, I suspect that anybody who selects E1000 support would actually want the "support both" case, and simply not care. Unless they were _really_ deeply aware of their hardware. .. but that said, I think your patch is certainly better than what we have now (or what Ingo was complaining about for the next merge window). I certainly could live with it. I would just suggest against ever then removing that "generic E1000" choice. Linus --
| Ryan Hope | reiser4 for 2.6.27-rc1 |
| James Bottomley | Re: Integration of SCST in the mainstream Linux kernel |
| majkls | sys_chroot+sys_fchdir Fix |
| Pierre Ossman | Re: [RFC][PATCH] cpuidle: avoid singing capacitors |
git: | |
| Randal L. Schwartz | [BUG] daemon.c blows up on OSX (was Re: What's in git.git (stable), and Announcing... |
| Shawn O. Pearce | Re: Smart fetch via HTTP? |
| Jakub Narebski | Re: VCS comparison table |
| Johannes Schindelin | Re: rc4 - make quick-install-doc is broken |
| Henning Brauer | Re: httpdv6 |
| Edd Barrett | Re: Cold Boot Attacks on Encryption Keys |
| stuartv | Re: Microsoft gets the Most Secure Operating Systems award |
| Sunnz | How do I configure sendmail? |
| Stephen Pierce | SLS |
| Jim Winstead Jr. | Re: Root Disk/Book Disk Compatibility |
| Dave `geek' Gymer | WARNING (was Re: New afio release) |
| Anthony Peacock | Re: ACK! Something's wrong with X! :( |
