[PATCH 1/8] rfkill: clarify meaning of rfkill states

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Henrique de Moraes Holschuh
Date: Friday, April 11, 2008 - 1:37 pm

rfkill really should have been named rfswitch.  As it is, one can get
confused whether RFKILL_STATE_ON means the KILL switch is on (and
therefore, the radio is being *blocked* from operating), or whether it
means the RADIO rf output is on.

Clearly state that RFKILL_STATE_ON means the radio is *unblocked* from
operating (i.e. there is no rf killing going on).

Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Ivo van Doorn <IvDoorn@gmail.com>
Cc: John W. Linville <linville@tuxdriver.com>
Cc: Dmitry Torokhov <dtor@mail.ru>
---
 include/linux/rfkill.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
index e3ab21d..ca89ae1 100644
--- a/include/linux/rfkill.h
+++ b/include/linux/rfkill.h
@@ -44,8 +44,8 @@ enum rfkill_type {
 };
 
 enum rfkill_state {
-	RFKILL_STATE_OFF	= 0,
-	RFKILL_STATE_ON		= 1,
+	RFKILL_STATE_OFF	= 0,	/* Radio output blocked */
+	RFKILL_STATE_ON		= 1,	/* Radio output active */
 };
 
 /**
@@ -53,7 +53,7 @@ enum rfkill_state {
  * @name: Name of the switch.
  * @type: Radio type which the button controls, the value stored
  *	here should be a value from enum rfkill_type.
- * @state: State of the switch (on/off).
+ * @state: State of the switch, "ON" means radio can operate.
  * @user_claim_unsupported: Whether the hardware supports exclusive
  *	RF-kill control by userspace. Set this before registering.
  * @user_claim: Set when the switch is controlled exlusively by userspace.
-- 
1.5.4.4

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[GIT PATCH] rfkill support for r/w and r/o rfkill switches, Henrique de Moraes H ..., (Fri Apr 11, 1:37 pm)
[PATCH 1/8] rfkill: clarify meaning of rfkill states, Henrique de Moraes H ..., (Fri Apr 11, 1:37 pm)
[PATCH 2/8] rfkill: fix minor typo in kernel doc, Henrique de Moraes H ..., (Fri Apr 11, 1:37 pm)
[PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events, Henrique de Moraes H ..., (Fri Apr 11, 1:37 pm)
[PATCH 4/8] rfkill: add read-write rfkill switch support, Henrique de Moraes H ..., (Fri Apr 11, 1:37 pm)
[PATCH 5/8] rfkill: add read-only rfkill switch support, Henrique de Moraes H ..., (Fri Apr 11, 1:37 pm)
[PATCH 6/8] rfkill: add the WWAN radio type, Henrique de Moraes H ..., (Fri Apr 11, 1:37 pm)
[PATCH 7/8] rfkill: add an &quot;any radio&quot; switch type and fun ..., Henrique de Moraes H ..., (Fri Apr 11, 1:37 pm)
[PATCH 8/8] rfkill: add parameter to disable radios by default, Henrique de Moraes H ..., (Fri Apr 11, 1:37 pm)
Re: [PATCH 6/8] rfkill: add the WWAN radio type, Inaky Perez-Gonzalez, (Fri Apr 11, 1:44 pm)
Re: [PATCH 6/8] rfkill: add the WWAN radio type, Henrique de Moraes H ..., (Fri Apr 11, 1:53 pm)
Re: [PATCH 6/8] rfkill: add the WWAN radio type, Ivo van Doorn, (Sat Apr 12, 3:36 am)
Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events, Henrique de Moraes H ..., (Sat Apr 12, 5:05 am)
Re: [PATCH 6/8] rfkill: add the WWAN radio type, Henrique de Moraes H ..., (Sat Apr 12, 5:15 am)
Re: [PATCH 6/8] rfkill: add the WWAN radio type, Ivo van Doorn, (Sat Apr 12, 5:28 am)
Re: [PATCH 8/8] rfkill: add parameter to disable radios by ..., Henrique de Moraes H ..., (Sat Apr 12, 5:56 am)
Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events, Henrique de Moraes H ..., (Sat Apr 12, 6:08 am)
Re: [PATCH 8/8] rfkill: add parameter to disable radios by ..., Henrique de Moraes H ..., (Sat Apr 12, 7:43 am)
Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events, Dmitry Torokhov, (Sat Apr 12, 8:47 am)
Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events, Henrique de Moraes H ..., (Sat Apr 12, 11:02 am)
Re: [PATCH 8/8] rfkill: add parameter to disable radios by ..., Henrique de Moraes H ..., (Sat Apr 12, 11:36 am)
Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events, Carlos Corbacho, (Sat Apr 12, 12:09 pm)
Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events, Henrique de Moraes H ..., (Sat Apr 12, 1:36 pm)
Re: [PATCH 6/8] rfkill: add the WWAN radio type, Inaky Perez-Gonzalez, (Sat Apr 12, 4:23 pm)
Re: [PATCH 6/8] rfkill: add the WWAN radio type, Henrique de Moraes H ..., (Sun Apr 13, 10:25 am)
Re: [PATCH 6/8] rfkill: add the WWAN radio type, Ivo van Doorn, (Sun Apr 13, 10:37 am)
Re: [PATCH 7/8] rfkill: add an &quot;any radio&quot; switch type and ..., Henrique de Moraes H ..., (Sun Apr 13, 10:40 am)
Re: [PATCH 6/8] rfkill: add the WWAN radio type, Henrique de Moraes H ..., (Sun Apr 13, 11:16 am)
Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Henrique de Moraes H ..., (Sun Apr 13, 6:20 pm)
Re: [PATCH 6/8] rfkill: add the WWAN radio type, Dmitry Torokhov, (Sun Apr 13, 9:20 pm)
Re: [PATCH 1/8] rfkill: clarify meaning of rfkill states, Dmitry Torokhov, (Sun Apr 13, 9:22 pm)
Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Dmitry Torokhov, (Mon Apr 14, 7:16 am)
Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Henrique de Moraes H ..., (Mon Apr 14, 7:36 am)
Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Dmitry Torokhov, (Mon Apr 14, 8:19 am)
Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Henrique de Moraes H ..., (Mon Apr 14, 9:33 am)
Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Dmitry Torokhov, (Mon Apr 14, 11:05 am)
Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Carlos Corbacho, (Mon Apr 14, 12:06 pm)
Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Dmitry Torokhov, (Mon Apr 14, 1:23 pm)
Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Henrique de Moraes H ..., (Mon Apr 14, 2:41 pm)
Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Henrique de Moraes H ..., (Mon Apr 14, 2:46 pm)
Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Carlos Corbacho, (Tue Apr 15, 12:27 am)
Re: [PATCH 4/8] rfkill: add read-write rfkill switch support, Dmitry Torokhov, (Tue Apr 15, 5:58 am)
Re: [GIT PATCH] rfkill support for r/w and r/o rfkill switches, John W. Linville, (Wed Apr 16, 11:37 am)
Re: [GIT PATCH] rfkill support for r/w and r/o rfkill switches, John W. Linville, (Wed Apr 16, 12:58 pm)